Commit graph

133486 commits

Author SHA1 Message Date
Laurent Destailleur
0970b23580 Add missing fields in merge of thirdparty 2024-02-06 09:44:22 +01:00
Laurent Destailleur
a8034b226f Better message 2024-02-05 18:51:06 +01:00
Ariel Bentolila
93427ee7a8 QUAL fix lines' title height calculation 2024-02-05 18:50:26 +02:00
Frédéric FRANCE
411df8f216
order tables by relname for pgsql (#28020) 2024-02-05 14:44:03 +01:00
Alexandre SPANGARO
1747a2ff36
NEW Various payment - Use list of account when edit (#27992)
* NEW Various payment - Use list of account when edit

* Fix PHPStan 8.2 undefined variable

* Update CSMSFile.class.php

* Move to getDolGlobalString

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 14:43:21 +01:00
Laurent Destailleur
d3ac91795b Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-05 14:32:40 +01:00
Laurent Destailleur
2b2f540992 Fix doc 2024-02-05 14:32:00 +01:00
MDW
505ca17ba9
Qual: Fix spelling and wording (#27995)
# Qual: Fix spelling and wording

Fix spelling (using beta codespell) and fix some wording
in module README template and ChangeLog.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 14:29:18 +01:00
thibdrev
e987af3995
qual: phpstan - another batch of "getNextValue() should return string but returns int." (#27990)
* Update mod_asset_advanced.php

* Update mod_asset_standard.php

* Update mod_bom_advanced.php

* Update mod_bom_standard.php

* Update mod_chequereceipt_mint.php

* Update mod_chequereceipt_thyme.php

* Update mod_commande_saphir.php

* Update mod_contract_magre.php

* Update mod_contract_serpis.php

* Update mod_delivery_jade.php

* Update mod_delivery_saphir.php

* Update mod_expedition_ribera.php

* Update mod_expedition_safor.php

* Update mod_expensereport_jade.php

* Update mod_expensereport_sand.php

* Update mod_facture_mercure.php

* Update mod_facture_terre.php

* Update mod_arctic.php

* Update mod_holiday_immaculate.php

* Update mod_evaluation_advanced.php

* Update mod_evaluation_standard.php

* Update mod_member_advanced.php

* Update mod_member_simple.php

* Update mod_mo_advanced.php

* Update mod_mo_standard.php

* Update mod_payment_ant.php

* Update mod_payment_cicada.php

* Update mod_codeproduct_elephant.php

* Update mod_lot_advanced.php

* Update mod_lot_standard.php

* Update mod_sn_advanced.php

* Update mod_project_universal.php

* Update mod_task_simple.php

* Update mod_task_universal.php

* Update mod_propale_marbre.php

* Update mod_propale_saphir.php

* Update mod_reception_beryl.php

* Update mod_reception_moonstone.php

* Update mod_codeclient_elephant.php

* Update mod_codeclient_monkey.php

* Update mod_ticket_simple.php

* same as PR #27989

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 14:21:18 +01:00
Frédéric FRANCE
9cac3156f7
Update dbtable.php (#27997)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 14:20:23 +01:00
sonikf
756066e791
Qual fix trans (#28019)
* fix translation

* fix typo

* fix typo

* fix typo
2024-02-05 14:18:34 +01:00
thibdrev
9320c31627
qual:p phspstan for htdocs/compta/facture/list.php (#28016)
htdocs/compta/facture/list.php	451	Property Paiement::$paiementid (int) does not accept array|string.
2024-02-05 13:58:06 +01:00
thibdrev
e67fddd3b6
qual: phpstan : various $xxx (int) does not accept array|string. (#28015)
* qual: phpstan for htdocs/compta/bank/various_payment/card.php

htdocs/compta/bank/various_payment/card.php	267	Property PaymentVarious::$id (int) does not accept null.
htdocs/compta/bank/various_payment/card.php	267	Property PaymentVarious::$ref (string) does not accept null.
htdocs/compta/bank/various_payment/card.php	287	Property PaymentVarious::$sens (int) does not accept array|string.

* qual: phpstan for htdocs/compta/bank/class/paymentvarious.class.php

htdocs/compta/bank/class/paymentvarious.class.php	502	Property PaymentVarious::$ref (string) does not accept int.

* typo

* qual: phpstan for htdocs/compta/paiement.php

htdocs/compta/paiement.php	272	Property Paiement::$fk_account (int) does not accept array|string.

* qual: phpstan for htdocs/fourn/facture/paiement.php

htdocs/fourn/facture/paiement.php	318	Property Paiement::$paiementid (int) does not accept array|string.
htdocs/fourn/facture/paiement.php	321	Property Paiement::$fk_account (int) does not accept array|string.
2024-02-05 13:51:40 +01:00
noec764
130b86de02 FIX: Reduction Input wasn't recovered properly (#28014)
Co-authored-by: Noé <noe@scopen.fr>
2024-02-05 13:49:45 +01:00
noec764
c4a0757619
FIX: Reduction Input wasn't recovered properly (#28014)
Co-authored-by: Noé <noe@scopen.fr>
2024-02-05 13:48:56 +01:00
William Mead
de46046b52
Qual phpstan utils class (#28013)
* Fixed error type. Refactored sendBackup return type. Updated contributor details.

* Update utils.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 13:44:25 +01:00
Lucas Marcouiller
bb347d16f9
Fix email collector add Repy to in ticket description (#28009)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-02-05 13:38:59 +01:00
William Mead
c3f7f8aa2d
Adjusted contract expired services url (#28010) 2024-02-05 13:37:34 +01:00
MDW
72305a9218
Qual: pre-commit: run phpcs on all files in 'main' branches. (#28018)
This change to the workflow will run phpcs on all files in develop,
17.0, 18.0, ... (rule== branch ends in .0).

This ensures that phpcs is run in a github workflow for fast phpcs
issue detection in the develop and other main branches.

Ultimately, this means that the PHPCS action can be disabled
in branches where it is active.  But I propose to verify that
the updated action does the job as expected (tested in a fork
it is ok).
2024-02-05 13:35:20 +01:00
Frédéric FRANCE
2f78b49ca0
usage of else if is discouraged use elseif instead (#28017)
* usage of else if is discouraged use elseif instead

* Update UserRightsToFunction.php
2024-02-05 13:30:18 +01:00
Laurent Destailleur
b1f059de58 Fix user with readonly perm on email template must be able to read. 2024-02-05 12:25:55 +01:00
Laurent Destailleur
3557152515 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-05 01:45:47 +01:00
Laurent Destailleur
f1f92f8922 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-05 01:43:00 +01:00
Laurent Destailleur
b42fd50a7c Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-05 01:42:37 +01:00
Alexandre SPANGARO
b0f999fc5a
FIX Accounting files export - Use th instead of td on all title columns (#28003)
* Remove duplicate lines

* FIX Accounting files export - Use th instead of td on all title columns

* Copyright
2024-02-05 01:40:36 +01:00
thibdrev
b8fd3d54e2
qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)
htdocs/ticket/class/ticketstats.class.php	98	Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
2024-02-05 01:34:50 +01:00
MDW
1289cda460
Qual: Fix spelling/working in datapolicy translations (#28006)
# Qual: Fix spelling/wording in datapolicy translations

Fixed some spelling and wording in datapolicy translations.
2024-02-05 01:33:53 +01:00
Frédéric FRANCE
080d8e0fa4
fix phpstan (#27989)
* fix phpstan

* Update UserRightsToFunction.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 01:33:19 +01:00
MDW
1da1c473ba
Improve wording in README (#27994) 2024-02-05 01:24:41 +01:00
Frédéric FRANCE
866948625b
add model_pdf field in llx_ticket-ticket.sql (#27996)
* add model_pdf field in llx_ticket-ticket.sql

* Update 19.0.0-20.0.0.sql

* Update 19.0.0-20.0.0.sql
2024-02-05 01:22:05 +01:00
Frédéric FRANCE
b53b91d9af
add editorconfig for sql files (#27999)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-05 01:21:41 +01:00
Laurent Destailleur
bcd401d487 Fix phpcs 2024-02-05 01:13:38 +01:00
Frédéric FRANCE
10eaa1d269
fix saved model_pdf after generating odt (#28005) 2024-02-05 01:10:35 +01:00
Laurent Destailleur
539a7666eb Clean code 2024-02-04 18:45:35 +01:00
Laurent Destailleur
73d9795152 Use rector to convert user->rights into user->hasRight 2024-02-04 18:30:53 +01:00
Laurent Destailleur
246fcc639b Use rector to convert user->rights into user->hasRight 2024-02-04 18:21:17 +01:00
Laurent Destailleur
5b36c7c1ba Clean code 2024-02-04 18:21:13 +01:00
Laurent Destailleur
758ccb0c5b Use rector to convert user->rights into user->hasRight 2024-02-04 17:27:57 +01:00
Laurent Destailleur
6dca2e6bf0 Debug v19 2024-02-04 16:29:40 +01:00
Laurent Destailleur
8e6109c897 Clean code 2024-02-04 16:29:10 +01:00
Laurent Destailleur
6b73cdeac7 Debug v19 2024-02-04 16:28:57 +01:00
Laurent Destailleur
24a8c2e66a Fix phpunit 2024-02-04 16:23:09 +01:00
Laurent Destailleur
7c88705f14 Fix template to use v19 dev rules 2024-02-04 16:05:02 +01:00
Laurent Destailleur
52e8d71d65 Fix use v19 dev rules 2024-02-04 16:04:32 +01:00
Laurent Destailleur
334563d282 Fix template to use v19 dev rules 2024-02-04 16:03:59 +01:00
Laurent Destailleur
5f094052b4 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-04 15:52:40 +01:00
Laurent Destailleur
885909a6a3 Enhance rector to fix empty($user->rights->modulex->perm1) 2024-02-04 15:51:05 +01:00
Laurent Destailleur
5b35250b0d Enhance rector to fix empty($user->rights->modulex->perm1) 2024-02-04 15:24:35 +01:00
Laurent Destailleur
5d1874cecb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-04 14:04:31 +01:00
Laurent Destailleur
a4b32baf7a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-04 14:01:04 +01:00