Qual: Fix spelling and wording (#27995)

# Qual: Fix spelling and wording

Fix spelling (using beta codespell) and fix some wording
in module README template and ChangeLog.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
This commit is contained in:
MDW 2024-02-05 14:29:18 +01:00 committed by GitHub
parent e987af3995
commit 505ca17ba9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 62 additions and 60 deletions

View file

@ -124,7 +124,7 @@ NEW: filter on from/to period rather than month/year (#26378)
NEW: FontAwesome - added possibility to select another version
NEW: Get list evaluation with skills details in user fiche (#26510)
NEW: hidden conf to disable use of dns_get_record (which can become unresponsive) (#26339)
NEW: HR: PDF Generation for each Human Resource Evaluations
NEW: HR: PDF Generation for each Human Resource Evaluations
NEW: improved resource data structure
NEW: Interventions: close notification for interventions
NEW: Inventory: include sub warehouse in inventory
@ -254,7 +254,7 @@ NEW: add a $notrigger param to Product::updatePrice() method (#26404)
NEW: add a rule to fix empty($conf->global->...) into !getDolGlobal...
NEW: add column extraparams on societe_rib
NEW: add phpunit for REST API of contacts
NEW: add barcode function to check if EAN13 is valid
NEW: add barcode function to check if EAN13 is valid
WARNING:
@ -271,7 +271,7 @@ The following changes may create regressions for some external modules, but were
* The property ->user_creation to store ID of user of creation has been renamed into ->user_creation_id.
* The property ->user_modification to store ID of user of modification has been renamed into ->user_modification_id.
* The private array ->status_short, ->statuts and ->status_long are now array ->labelStatusShort and ->labelStatus everywhere.
* The duplicate property ->user_creat, ->date_creat, ->date_valid have been removed (use instead user_creation, date_creation, date_validation).
* The duplicate property ->user_creat, ->date_creat, ->date_valid have been removed (use instead user_creation, date_creation, date_validation).
* The method get_substitutionarray_shipment_lines() has been removed. Use the generic get_substitutionarray_lines() instead.
* The method ProductcustomerPrice->fetch_all_log() has been renamed into camel case ->fetchAllLog()
* It was possible to use a variable $soc or $right inside a PHP code condition of some extrafields properties, this is no more true (this 2 variables are no more global variables).
@ -489,7 +489,7 @@ NEW: Accountancy - Quadratus export with attachments in accountancy export
NEW: Accountancy - Can filter on a custom group of accounts. Perf or ledger list.
NEW: Accountancy - Can select the export format during export of journals
NEW: Accountancy - sort of column of custom group of account
NEW: Can upload a file with drag and drop on purchase invoice, vats, salaries and social contributions
NEW: Can upload a file with drag and drop on purchase invoice, vats, salaries and social contributions
NEW: Authentication: #22740 add OpenID Connect impl
NEW: Authentication: add experimental support for Google OAuth2 connection
NEW: Authentication: can now edit service name for OAuth token
@ -677,14 +677,14 @@ WARNING:
Following changes may create regressions for some external modules, but were necessary to make Dolibarr better:
* Minimal PHP version is now PHP 7.1 instead of PHP 7.0
* Sensitive data like keys in setup pages, that need encryption (for example the API keys of users, the CRON security key, the keys into the Stripe module, or
* Sensitive data like keys in setup pages, that need encryption (for example the API keys of users, the CRON security key, the keys into the Stripe module, or
external modules setup pages that store sensitive keys or password), are using the $dolibarr_main_instance_unique_id as part of the key for encryption. So,
if you restore or duplicate the data from another instance dump, you must also
update this parameter in the conf.php file to allow decryption in the new instance, or
update this parameter in the conf.php file to allow decryption in the new instance, or
better, you must reenter the sensitive data into the setup pages of the new instance to resave them correctly.
Note that to find all the parameters that are encrypted into the setup database, you can do a "SELECT * FROM llx_const WHERE value LIKE '%dolcrypt%';"
Note that to find all the parameters that are encrypted into the setup database, you can do a "SELECT * FROM llx_const WHERE value LIKE '%dolcrypt%';"
* The deprecated method "escapeunderscore()" of database handlers has been removed. You must use "escapeforlike()" instead.
* The method "nb_expedition()" has been renamed into "countNbOfShipments()"
* The method "nb_expedition()" has been renamed into "countNbOfShipments()"
* Revert default type of hooks. Default is now 'addreplace' hooks (and exception become 'output' hooks, that become deprecated).
* Deprecated property libelle removed from entrepot class.
* The type 'text' in ->fields property does not accept html content anymore. Use the type 'html' for that.
@ -1086,7 +1086,7 @@ WARNING:
Following changes may create regressions for some external modules, but were necessary to make Dolibarr better:
* Minimal PHP version is now PHP 7.0 instead of PHP 5.6
* Core has introduced a Universal Filter Syntax for search criteria. Example: ((((field1:=:value1) OR (field2:in:1,2,3)) AND ...). In rare case, some filters
could be provided by URL parameters. For such cases (societe/ajax/company.php), use of Universal Filter Syntax become mandatory.
could be provided by URL parameters. For such cases (societe/ajax/company.php), use of Universal Filter Syntax become mandatory.
* The signature of method getNomUrl() of class ProductFournisseur has been modified to match the signature of method Product->getNomUrl()
* Trigger ORDER_SUPPLIER_DISPATCH is removed, use ORDER_SUPPLIER_RECEIVE and/or LINEORDER_SUPPLIER_DISPATCH instead.
* All functions fetch_all() have been set to deprecated for naming consistency, use fetchAll() instead.
@ -1164,7 +1164,7 @@ FIX: #23019 Impossible to add task times to an existing draft invoice
FIX: #23072
FIX: #23075
FIX: #23087
FIX: #23115
FIX: #23115
FIX: #23116
FIX: #23117
FIX: #23281
@ -7551,7 +7551,7 @@ FIX: #4583 Incorrect call of Categories::containing throws a DoliDB error
FIX: #4649 Wrong parameters order
FIX: #4768
FIX: #4785
FIX: Add a test to show bugged module with a bad declaration of dictionaries to avoid to see clean module to be breaked.
FIX: Add a test to show bugged module with a bad declaration of dictionaries to avoid clean modules to be broken.
FIX: add Croatia into list of country in EEC
FIX: add missing global def for ttc column
FIX: ajax error with multicompany module

View file

@ -21,6 +21,7 @@
print '<a class="butAction" href="'.$_SERVER["PHP_SELF"].'?id='.$object->id.'&action=transfert">'.$langs->trans("TransferStock").'</a>';
$action = 'transfert';
$ensemblereponses = $obj->reponses;
$return .= '<br><span class="opacitymedium">'.$langs->trans("Payement").'</span> : <span class="info-box-label">'.$this->type_payment.'</span>';
$sql = 'INSERT INTO '.MAIN_DB_PREFIX.'opensurvey_user_studs (nom, id_sondage, reponses, date_creation)';
$sql = 'INSERT INTO '.MAIN_DB_PREFIX.'opensurvey_user_studs (nom, id_sondage, reponses, ip, date_creation)';
$sql = 'SELECT s.reponses';
@ -61,5 +62,6 @@ $usercandelete = $user->rights->stock->mouvement->creer;
$usercandelete = (($user->rights->stock->mouvement->supprimer));
$usercanread = $user->rights->stock->mouvement->lire;
$usercanread = (($user->rights->stock->mouvement->lire));
* The private array ->status_short, ->statuts and ->status_long are now array ->labelStatusShort and ->labelStatus everywhere.
if (!$user->hasRight('stock', 'mouvement', 'lire')) {
if ($action == "transfert") {

View file

@ -33,7 +33,7 @@ require_once DOL_DOCUMENT_ROOT.'/product/class/html.formproduct.class.php';
// Load translation files required by the page
$langs->loadLangs(array("admin", "stocks"));
// Securit check
// Security check
if (!$user->admin) {
accessforbidden();
}

View file

@ -416,7 +416,7 @@ class Categories extends DolibarrApi
return array(
'success' => array(
'code' => 200,
'message' => 'Objects succefully linked to the category'
'message' => 'Objects successfully linked to the category'
)
);
}
@ -496,7 +496,7 @@ class Categories extends DolibarrApi
return array(
'success' => array(
'code' => 200,
'message' => 'Objects succefully linked to the category'
'message' => 'Objects successfully linked to the category'
)
);
}
@ -574,7 +574,7 @@ class Categories extends DolibarrApi
return array(
'success' => array(
'code' => 200,
'message' => 'Objects succefully unlinked from the category'
'message' => 'Objects successfully unlinked from the category'
)
);
}
@ -652,7 +652,7 @@ class Categories extends DolibarrApi
return array(
'success' => array(
'code' => 200,
'message' => 'Objects succefully unlinked from the category'
'message' => 'Objects successfully unlinked from the category'
)
);
}

View file

@ -651,7 +651,7 @@ if ($result) {
print "</table>";
// Code to adjust value date with plus and less picto using an Ajax call instead of a full reload of page
/* Not yet ready. We must manage inline replacemet of input date field
/* Not yet ready. We must manage inline replacement of input date field
$urlajax = DOL_URL_ROOT.'/core/ajax/bankconciliate.php?token='.currentToken();
print '
<script type="text/javascript">

View file

@ -989,7 +989,7 @@ class FormOther
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Creae an image for color
* Create an image for color
*
* @param string $color Color of image
* @param string $module Name of module

View file

@ -794,7 +794,7 @@ class FormTicket
}
/**
* Return html list of ticket anaytic codes
* Return html list of ticket analytic codes
*
* @param string $selected Id pre-selected category
* @param string $htmlname Name of select component

View file

@ -214,7 +214,7 @@ function check_events() {
} else {
console.log("Cancel check_events() with dolnotif_nb_test_for_page="+dolnotif_nb_test_for_page+". Check is useless because javascript Notification.permission is "+Notification.permission+" (blocked manually or web site is not https).");
result = 2; // We return a positive so the repeated check will done even if authroization is not yet allowed may be after this check)
result = 2; // We return a positive so the repeated check will done even if authorization is not yet allowed may be after this check)
}
if (dolnotif_nb_test_for_page >= 5) {

View file

@ -169,7 +169,7 @@ function length_accounta($accounta)
* Show header of a page used to transfer/dispatch data in accounting
*
* @param string $nom Name of report
* @param string $variante Link for alternate report
* @param string $variant Link for alternate report
* @param string $period Period of report
* @param string $periodlink Link to switch period
* @param string $description Description
@ -180,7 +180,7 @@ function length_accounta($accounta)
* @param string $varlink Add a variable into the address of the page
* @return void
*/
function journalHead($nom, $variante, $period, $periodlink, $description, $builddate, $exportlink = '', $moreparam = array(), $calcmode = '', $varlink = '')
function journalHead($nom, $variant, $period, $periodlink, $description, $builddate, $exportlink = '', $moreparam = array(), $calcmode = '', $varlink = '')
{
global $langs;
@ -218,14 +218,14 @@ function journalHead($nom, $variante, $period, $periodlink, $description, $build
if ($calcmode) {
print '<tr>';
print '<td>'.$langs->trans("CalculationMode").'</td>';
if (!$variante) {
if (!$variant) {
print '<td colspan="3">';
} else {
print '<td>';
}
print $calcmode;
if ($variante) {
print '</td><td colspan="2">'.$variante;
if ($variant) {
print '</td><td colspan="2">'.$variant;
}
print '</td>';
print '</tr>';

View file

@ -1753,7 +1753,7 @@ function form_constantes($tableau, $strictw3c = 0, $helptext = '', $text = 'Valu
if ($const == 'ADHERENT_MAILMAN_URL') {
print '. '.$langs->trans("Example").': <a href="#" id="exampleclick1">'.img_down().'</a><br>';
//print 'http://lists.exampe.com/cgi-bin/mailman/admin/%LISTE%/members?adminpw=%MAILMAN_ADMINPW%&subscribees=%EMAIL%&send_welcome_msg_to_this_batch=1';
//print 'http://lists.example.com/cgi-bin/mailman/admin/%LISTE%/members?adminpw=%MAILMAN_ADMINPW%&subscribees=%EMAIL%&send_welcome_msg_to_this_batch=1';
print '<div id="example1" class="hidden">';
print 'http://lists.example.com/cgi-bin/mailman/admin/%LISTE%/members/add?subscribees_upload=%EMAIL%&amp;adminpw=%MAILMAN_ADMINPW%&amp;subscribe_or_invite=0&amp;send_welcome_msg_to_this_batch=0&amp;notification_to_list_owner=0';
print '</div>';

View file

@ -491,7 +491,7 @@ function pdf_build_address($outputlangs, $sourcecompany, $targetcompany = '', $t
$stringaddress .= ($stringaddress ? "\n" : '').$outputlangs->transnoentities("VATIntraShort").': '.$outputlangs->convToOutputCharset($sourcecompany->tva_intra);
}
}
// Professionnal Ids
// Professional Ids
$reg = array();
if (getDolGlobalString('MAIN_PROFID1_IN_SOURCE_ADDRESS') && !empty($sourcecompany->idprof1)) {
$tmp = $outputlangs->transcountrynoentities("ProfId1", $sourcecompany->country_code);
@ -655,7 +655,7 @@ function pdf_build_address($outputlangs, $sourcecompany, $targetcompany = '', $t
}
}
// Professionnal Ids
// Professional Ids
if (getDolGlobalString('MAIN_PROFID1_IN_ADDRESS') && !empty($targetcompany->idprof1)) {
$tmp = $outputlangs->transcountrynoentities("ProfId1", $targetcompany->country_code);
if (preg_match('/\((.+)\)/', $tmp, $reg)) {

View file

@ -63,7 +63,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
print '<table class="border tableforfield centpercent">'."\n";
$variante = ($periodlink || $exportlink);
$variant = ($periodlink || $exportlink);
// Ligne de titre
print '<tr>';
@ -71,7 +71,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
print '<td>';
print $reportname;
print '</td>';
if ($variante) {
if ($variant) {
print '<td></td>';
}
print '</tr>'."\n";
@ -82,7 +82,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
print '<td width="150">'.$langs->trans("CalculationMode").'</td>';
print '<td>';
print $calcmode;
if ($variante) {
if ($variant) {
print '<td></td>';
}
print '</td>';
@ -96,7 +96,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
if ($period) {
print $period;
}
if ($variante) {
if ($variant) {
print '<td class="nowraponall">'.$periodlink.'</td>';
}
print '</td>';
@ -106,7 +106,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
print '<tr>';
print '<td>'.$langs->trans("ReportDescription").'</td>';
print '<td>'.$description.'</td>';
if ($variante) {
if ($variant) {
print '<td></td>';
}
print '</tr>'."\n";
@ -117,7 +117,7 @@ function report_header($reportname, $notused, $period, $periodlink, $description
print '<td>';
print dol_print_date($builddate, 'dayhour');
print '</td>';
if ($variante) {
if ($variant) {
print '<td>'.($exportlink ? $langs->trans("Export").': '.$exportlink : '').'</td>';
}
print '</tr>'."\n";

View file

@ -399,7 +399,7 @@ class pdf_vinci extends ModelePDFMo
$nexY = $tab_top + 5;
// Use new auto collum system
// Use new auto column system
$this->prepareArrayColumnField($object, $outputlangs, $hidedetails, $hidedesc, $hideref);
// Loop on each lines

View file

@ -473,7 +473,7 @@ class pdf_cornas extends ModelePDFSuppliersOrders
$height_note = 0;
}
// Use new auto collum system
// Use new auto column system
$this->prepareArrayColumnField($object, $outputlangs, $hidedetails, $hidedesc, $hideref);
$nexY = $tab_top + $this->tabTitleHeight;

View file

@ -472,7 +472,7 @@ class pdf_zenith extends ModelePDFSupplierProposal
$height_note = 0;
}
// Use new auto collum system
// Use new auto column system
$this->prepareArrayColumnField($object, $outputlangs, $hidedetails, $hidedesc, $hideref);
$nexY = $tab_top + $this->tabTitleHeight;

View file

@ -299,7 +299,7 @@ if ($action == 'updatelines' && $usercancreate) {
}
}
// If module stock is enabled and the stock decrease is done on edtion of this page
// If module stock is enabled and the stock decrease is done on edition of this page
/*
if (!$error && GETPOST($ent, 'int') > 0 && isModEnabled('stock') && !empty($conf->global->STOCK_CALCULATE_ON_SHIPMENT_DISPATCH_ORDER)) {
$mouv = new MouvementStock($db);

View file

@ -412,7 +412,7 @@ class ProductFournisseur extends Product
$qty = price2num($qty, 'MS');
$unitBuyPrice = price2num($buyprice / $qty, 'MU');
// We can have a puchase ref that need to buy 100 min for a given price and with a packaging of 50.
// We can have a purchase ref that need to buy 100 min for a given price and with a packaging of 50.
//$packaging = price2num(((empty($this->packaging) || $this->packaging < $qty) ? $qty : $this->packaging), 'MS');
$packaging = price2num((empty($this->packaging) ? $qty : $this->packaging), 'MS');

View file

@ -3160,7 +3160,7 @@ function left_menu($menu_array_before, $helppagename = '', $notused = '', $menu_
}
$selected = -1;
if (!getDolGlobalString('MAIN_USE_TOP_MENU_SEARCH_DROPDOWN')) {
// Select into select2 is awfull on smartphone. TODO Is this still true with select2 v4 ?
// Select with select2 is awful on smartphone. TODO Is this still true with select2 v4 ?
if ($conf->browser->layout == 'phone') {
$conf->global->MAIN_USE_OLD_SEARCH_FORM = 1;
}

View file

@ -1,4 +1,4 @@
# MYMODULE FOR [DOLIBARR ERP CRM](https://www.dolibarr.org)
# MYMODULE FOR [DOLIBARR ERP & CRM](https://www.dolibarr.org)
## Features
@ -12,7 +12,7 @@ Other external modules are available on [Dolistore.com](https://www.dolistore.co
## Translations
Translations can be completed manually by editing files into directories *langs*.
Translations can be completed manually by editing files in the module directories under `langs`.
<!--
This module contains also a sample configuration for Transifex, under the hidden directory [.tx](.tx), so it is possible to manage translation using this service.
@ -25,27 +25,27 @@ There is a [Transifex project](https://transifex.com/projects/p/dolibarr-module-
## Installation
Prerequisites: You must have the Dolibarr ERP CRM software installed. You can down it from [Dolistore.org](https://www.dolibarr.org).
You can also get a ready to use instance in the cloud from htts://saas.dolibarr.org
Prerequisites: You must have Dolibarr ERP & CRM software installed. You can download it from [Dolistore.org](https://www.dolibarr.org).
You can also get a ready-to-use instance in the cloud from https://saas.dolibarr.org
### From the ZIP file and GUI interface
If the module is a ready to deploy zip file, so with a name module_xxx-version.zip (like when downloading it from a market place like [Dolistore](https://www.dolistore.com)),
go into menu ```Home - Setup - Modules - Deploy external module``` and upload the zip file.
If the module is a ready-to-deploy zip file, so with a name `module_xxx-version.zip` (e.g., when downloading it from a marketplace like [Dolistore](https://www.dolistore.com)),
go to menu `Home> Setup> Modules> Deploy external module` and upload the zip file.
Note: If this screen tell you that there is no "custom" directory, check that your setup is correct:
Note: If this screen tells you that there is no "custom" directory, check that your setup is correct:
<!--
- In your Dolibarr installation directory, edit the ```htdocs/conf/conf.php``` file and check that following lines are not commented:
- In your Dolibarr installation directory, edit the `htdocs/conf/conf.php` file and check that following lines are not commented:
```php
//$dolibarr_main_url_root_alt ...
//$dolibarr_main_document_root_alt ...
```
- Uncomment them if necessary (delete the leading ```//```) and assign a sensible value according to your Dolibarr installation
- Uncomment them if necessary (delete the leading `//`) and assign the proper value according to your Dolibarr installation
For example :
@ -66,9 +66,9 @@ Note: If this screen tell you that there is no "custom" directory, check that yo
### From a GIT repository
Clone the repository in ```$dolibarr_main_document_root_alt/mymodule```
Clone the repository in `$dolibarr_main_document_root_alt/mymodule`
```sh
```shell
cd ....../custom
git clone git@github.com:gitlogin/mymodule.git mymodule
```
@ -77,10 +77,10 @@ git clone git@github.com:gitlogin/mymodule.git mymodule
### Final steps
From your browser:
Using your browser:
- Log into Dolibarr as a super-administrator
- Go to "Setup" -> "Modules"
- Go to "Setup"> "Modules"
- You should now be able to find and enable the module
@ -93,4 +93,4 @@ GPLv3 or (at your option) any later version. See file COPYING for more informati
### Documentation
All texts and readmes are licensed under GFDL.
All texts and readme's are licensed under [GFDL](https://www.gnu.org/licenses/fdl-1.3.en.html).

View file

@ -372,7 +372,7 @@ class Productbatch extends CommonObject
}
/**
* Find first detail record that match eather eat-by or sell-by or batch within given warehouse
* Find first detailed record that match either eat-by, sell-by or batch within the warehouse
*
* @param int $fk_product_stock id product_stock for object
* @param integer $eatby eat-by date for object - deprecated: a search must be done on batch number

View file

@ -302,7 +302,7 @@ if (empty($reshook)) {
if (empty($packaging)) {
$packaging = 1;
}
/* We can have a puchase ref that need to buy 100 min for a given price and with a packaging of 50.
/* We can have a purchase ref that need to buy 100 min for a given price and with a packaging of 50.
if ($packaging < $quantity) {
$packaging = $quantity;
}*/

View file

@ -23,7 +23,7 @@
/**
* \file public/emailing/mailing-unsubscribe.php
* \ingroup mailing
* \brief Script use to update unsubcribe status of an email
* \brief Script use to update unsubscribe status of an email
* https://myserver/public/emailing/mailing-unsubscribe.php?unsuscrib=1&securitykey=securitykey&tag=abcdefghijklmn
*/

View file

@ -467,7 +467,7 @@ if ($event->type == 'payout.created') {
}
if (!$error && isModEnabled('banque')) {
// Search again the payment to see if it is already linked to a bank payment record (We should always find the payement now we have created before).
// Search again the payment to see if it is already linked to a bank payment record (We should always find the payment that was created before).
$ispaymentdone = 0;
$sql = "SELECT p.rowid, p.fk_bank FROM llx_paiement as p";
$sql .= " WHERE p.ext_payment_id = '".$db->escape($paiement->ext_payment_id)."'";

View file

@ -205,7 +205,7 @@ if ($action == 'updatelines' && $permissiontoreceive) {
$error++;
}
// If module stock is enabled and the stock decrease is done on edtion of this page
// If module stock is enabled and the stock decrease is done on edition of this page
/*
if (!$error && GETPOST($ent, 'int') > 0 && isModEnabled('stock') && !empty($conf->global->STOCK_CALCULATE_ON_SUPPLIER_DISPATCH_ORDER)) {
$mouv = new MouvementStock($db);

View file

@ -4513,7 +4513,7 @@ tr.liste_titre th, tr.liste_titre td, th.liste_titre
{
border-bottom: 1px solid #aaa;
}
/* TODO Once title line is moved under title search, make border bottom of all th black and force to whit when it's first tr */
/* TODO Once the title line is moved under title search, make th border bottoms black and force to white when it's the first tr */
tr:first-child th.liste_titre, tr:first-child th.liste_titre_sel {
border-bottom: 1px solid #FFF ! important;
}