Commit graph

133486 commits

Author SHA1 Message Date
Laurent Destailleur
a639b1a447 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-03 03:37:09 +01:00
Laurent Destailleur
4c2149884c Qual: Introduce getDataToShowPhoto to prepare generic code 2024-02-03 03:35:28 +01:00
Lucas Marcouiller
c01b7e793c
Close #27774 new contact in project (#27947)
* Close  #27774 new contact in project

* add test to not show

* fix as advised

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-02-03 02:06:14 +01:00
Laurent Destailleur
2dfc8df648 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-03 02:02:46 +01:00
Laurent Destailleur
dc8154dd62 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-03 01:57:19 +01:00
Laurent Destailleur
d7524035b3 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-03 01:56:49 +01:00
Laurent Destailleur
eccc60056f Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-03 01:53:10 +01:00
Laurent Destailleur
e5d27ead40 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-03 01:48:16 +01:00
Laurent Destailleur
5dbecd73a0 FIX #27970 #26283 #27970 2024-02-03 01:48:01 +01:00
Laurent Destailleur
428a1758ad Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-03 00:13:07 +01:00
Laurent Destailleur
c7a13ed975 Fix codespell 2024-02-03 00:12:55 +01:00
MDW
ed3bfb152a
Qual: Backport pre-commit to 17.0 (#27948)
Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.
2024-02-03 00:10:49 +01:00
thibdrev
e0f6aca453
qual: phpstan for htdocs/categories/class/categorie.class.php (#27957)
htdocs/categories/class/categorie.class.php	389	Property Categorie::$type (string) does not accept int.
htdocs/categories/class/categorie.class.php	449	Property Categorie::$position (int) does not accept string.
2024-02-03 00:10:07 +01:00
thibdrev
e04ecb95e8
qual: phpstan for htdocs/comm/action/class/api_agendaevents.class.php (#27959)
htdocs/comm/action/class/api_agendaevents.class.php	273	Method AgendaEvents::put() should return int but returns object.

htdocs/comm/action/class/api_agendaevents.class.php	276	Method AgendaEvents::put() should return int but returns false.
2024-02-03 00:07:05 +01:00
thibdrev
3ee455681f
qual: phpstan for htdocs/comm/action/class/cactioncomm.class.php (#27960)
htdocs/comm/action/class/cactioncomm.class.php	360	Method CActionComm::getNomUrl() should return string but returns int.
2024-02-03 00:06:05 +01:00
thibdrev
3acab565aa
qual: phpdoc for htdocs/compta/paiement/class/paiement.class.php (#27962)
* qual: phpdoc for htdocs/compta/paiement/class/paiement.class.php

* phpcs
2024-02-03 00:05:48 +01:00
zeug-it
204a2cdf0c
FIX: Update expedition.class.php to add product width and height in addition to length (#27964)
* Update expedition.class.php to add product width and height

* Fix Lint errors

* Fix typo

* lint errors

* lint
2024-02-03 00:04:54 +01:00
thibdrev
c60c5dce4a
qual: phpstan for htdocs/product/class/productcustomerprice.class.php (#27966)
* qual: phpstan for htdocs/product/class/productcustomerprice.class.php

htdocs/product/class/productcustomerprice.class.php	102	PHPDoc type array of property ProductCustomerPrice::$lines is not covariant with PHPDoc type array of overridden property CommonObject::$lines.
htdocs/product/class/productcustomerprice.class.php	131	Property ProductCustomerPrice::$entity (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	134	Property ProductCustomerPrice::$fk_product (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	137	Property ProductCustomerPrice::$fk_soc (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	170	Property ProductCustomerPrice::$fk_user (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	609	Property ProductCustomerPrice::$entity (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	612	Property ProductCustomerPrice::$fk_product (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	615	Property ProductCustomerPrice::$fk_soc (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	648	Property ProductCustomerPrice::$fk_user (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	1010	Property ProductCustomerPrice::$entity (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	1013	Property ProductCustomerPrice::$fk_product (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	1014	Property ProductCustomerPrice::$fk_soc (int) does not accept string.
htdocs/product/class/productcustomerprice.class.php	1026	Property ProductCustomerPrice::$fk_user (int) does not accept string.

* typo
2024-02-03 00:03:51 +01:00
Laurent Destailleur
8cf72c137b Fix precommit 2024-02-03 00:02:00 +01:00
Laurent Destailleur
e08bf0c567 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-02 23:47:14 +01:00
Laurent Destailleur
1d6cbe1fda Fix GETPOST use should be avoid in classes 2024-02-02 23:46:12 +01:00
Laurent Destailleur
97006d6945 Clean code: Remove code not working (was using hard coded values) 2024-02-02 21:41:40 +01:00
Laurent Destailleur
32e205b5d1 Clean code 2024-02-02 19:50:43 +01:00
thibdrev
d510938b01
qual: phpstan for htdocs/projet/card.php (#27963)
htdocs/projet/card.php	211	Property Project::$fk_project (int) does not accept array|string.
htdocs/projet/card.php	217	Property Project::$budget_amount (float) does not accept string.
2024-02-02 17:46:43 +01:00
kkhelifa-opendsi
dbb8861a98
NEW: Sort variants list by product ref on combinations page (#27969) 2024-02-02 17:45:30 +01:00
JC Prieto
05b824b4d6
FIX: Update loan.class.php (#27971)
Right stauts paid.
2024-02-02 17:44:56 +01:00
Laurent Destailleur
4204127328 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-02 13:56:31 +01:00
Laurent Destailleur
40f18f5577 Try to use a unique id 2024-02-02 13:56:11 +01:00
thibdrev
0d81b5fe0d
qual: phpstan for htdocs/bookmarks/class/bookmark.class.php (#27956)
htdocs/bookmarks/class/bookmark.class.php	189	Property Bookmark::$errno (int) does not accept string.
htdocs/bookmarks/class/bookmark.class.php	195	Property Bookmark::$errno (int) does not accept string.
2024-02-02 13:43:52 +01:00
thibdrev
9e1ec834c2
qual: phpstan for (#27961)
htdocs/compta/bank/card.php	162	Property Account::$fk_accountancy_journal (int) does not accept string.
htdocs/compta/bank/card.php	275	Property Account::$fk_accountancy_journal (int) does not accept string.
2024-02-02 13:43:23 +01:00
thibdrev
dee08cc7c5
qual: phpstan for htdocs/product/stock/card.php (#27965)
htdocs/product/stock/card.php	139	Property Entrepot::$fk_project (int) does not accept array|string.
htdocs/product/stock/card.php	142	Property Entrepot::$statut (int) does not accept array|string.
htdocs/product/stock/card.php	147	Property CommonObject::$country_id (int) does not accept array|string.
2024-02-02 13:43:08 +01:00
MDW
1e412c7a13
Qual: Backport pre-commit into 18.0 (#27949)
* Qual: Backport pre-commit to 17.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.

* Qual: Backport pre-commit to 18.0

# Qual: Backport pre-commit to 18.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.
2024-02-02 13:40:34 +01:00
Laurent Destailleur
9a73612d65 Doc 2024-02-02 13:40:09 +01:00
Laurent Destailleur
0f931ef471 Disable ajax tooltip by default. Still trouble of persistent popup. 2024-02-02 13:29:02 +01:00
Laurent Destailleur
fedbc0f08e Fix use of not existing object 2024-02-02 12:51:11 +01:00
Laurent Destailleur
8fef5b3d5c Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-02 12:47:15 +01:00
Laurent Destailleur
ba95db0175 Fix use of socid 2024-02-02 12:44:47 +01:00
Laurent Destailleur
ff04c99542 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-01 19:34:42 +01:00
Laurent Destailleur
c9823f2b8d Move 401 to 403 2024-02-01 19:34:13 +01:00
Laurent Destailleur
682c42c6f3 Move 401 to 402 2024-02-01 19:16:58 +01:00
thibdrev
cbe1b75332
qual: phpstan for htdocs/adherents/class/adherent_type.class.php (#27946)
htdocs/adherents/class/adherent_type.class.php	130	Property AdherentType::$other (string) does not accept default value of type array.
2024-02-01 17:49:02 +01:00
Vincent Maury
08b9cf2a40
Fix :external user (client for example) can see PMP and accountancy infos (#27952) 2024-02-01 17:43:33 +01:00
MDW
e1a1015f60
Qual: PR to facilitate pre-commit backports (#27951)
* Qual: Backport pre-commit to 17.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.

* Qual: Backport pre-commit to 18.0

# Qual: Backport pre-commit to 18.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.

* Qual: Backport pre-commit to 19.0

# Qual: Backport pre-commit to 19.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.
2024-02-01 17:39:01 +01:00
UT from dolibit
1ffec452a7
Update ChangeLog (#27954) 2024-02-01 17:37:59 +01:00
MDW
4d0fbc657e
Qual: Backport pre-commit to 19.0 (#27950)
* Qual: Backport pre-commit to 17.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.

* Qual: Backport pre-commit to 18.0

# Qual: Backport pre-commit to 18.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.

* Qual: Backport pre-commit to 19.0

# Qual: Backport pre-commit to 19.0

Backport the pre-commit tool to bring extra checks to the older versions
so that they are fixed earlier before merging in upper versions.

Other PRs will be created for backporting to 18.0 and 19.0.
The PRs should be accepted in reverse order:
- develop;
- 19.0:
- 18.0;
- 17.0.

That should avoid merge conflicts and ensure that options (and ignored
messages or steps) are adapted to the version branch.
2024-02-01 17:37:25 +01:00
Mohamed DAOUD
a99e44b6c3
NEW Asset Module - make asset model creation in a single step (#26982)
* make asset model creation in a single step

* fix test unit issue

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-01 16:26:25 +01:00
Mohamed DAOUD
2877a7dd90
New add Messages Tab on Contract View (#26756)
* Messages Tab on Contract View

* Update messaging.php
2024-02-01 16:25:13 +01:00
Lucas Marcouiller
d92a5b79b1
New add new const to pervent sending mail to with autocopy (#26894)
* New add new const to pervent sending mail to with autocopy

* to test

* fix pr to always have the check on $to, $addr_cc and addr_bcc

* remove unwanted code

* fix errors

---------

Co-authored-by: Hystepik <lucas.marcouiller@gmail.com>
Co-authored-by: hystepik <lmarcouiller@nltechno.com>
2024-02-01 15:32:11 +01:00
Laurent Destailleur
a00acaec35 Fix sql syntax error 2024-02-01 14:43:39 +01:00
Laurent Destailleur
5a5c7d5228 Clean code 2024-02-01 14:28:22 +01:00