feat(media): signed POST upload endpoint for MCP flow

This commit is contained in:
Paulo Castellano 2026-05-15 16:10:21 -03:00
parent 5408ca7e27
commit b17026f3a1
4 changed files with 201 additions and 0 deletions

View file

@ -0,0 +1,44 @@
<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api;
use App\Http\Controllers\Controller;
use App\Http\Requests\Api\StoreUploadRequest;
use App\Models\Media;
use App\Models\Workspace;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Facades\Cache;
use Symfony\Component\HttpFoundation\Response;
class UploadController extends Controller
{
public function store(StoreUploadRequest $request, string $token): JsonResponse
{
$expiresAt = (int) $request->query('expires');
$ttl = max(60, $expiresAt - now()->timestamp + 60);
if (! Cache::add("mcp_upload:{$token}", true, $ttl)) {
abort(Response::HTTP_CONFLICT, 'Upload token already used.');
}
if (Media::where('upload_token', $token)->exists()) {
abort(Response::HTTP_CONFLICT, 'Upload token already consumed.');
}
$workspace = Workspace::findOrFail((string) $request->query('ws'));
$media = $workspace->addMedia($request->file('media'), 'assets');
$media->upload_token = $token;
$media->save();
return response()->json([
'upload_token' => $token,
'media_id' => $media->id,
'type' => $media->type,
'mime_type' => $media->mime_type,
'original_filename' => $media->original_filename,
], Response::HTTP_CREATED);
}
}

View file

@ -0,0 +1,33 @@
<?php
declare(strict_types=1);
namespace App\Http\Requests\Api;
use App\Enums\Media\Type as MediaType;
use Illuminate\Foundation\Http\FormRequest;
class StoreUploadRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
public function rules(): array
{
$allowed = implode(',', array_merge(
MediaType::Image->allowedMimeTypes(),
MediaType::Video->allowedMimeTypes(),
));
return [
'media' => [
'required',
'file',
'max:51200',
"mimetypes:{$allowed}",
],
];
}
}

View file

@ -8,9 +8,15 @@
use App\Http\Controllers\Api\PostController;
use App\Http\Controllers\Api\SignatureController;
use App\Http\Controllers\Api\SocialAccountController;
use App\Http\Controllers\Api\UploadController;
use App\Http\Controllers\Api\WorkspaceController;
use Illuminate\Support\Facades\Route;
Route::post('/uploads/{token}', [UploadController::class, 'store'])
->middleware('signed')
->where('token', '[0-9a-f-]{36}')
->name('api.uploads.store');
Route::middleware(['auth:api', 'workspace.token', 'throttle:api'])->group(function () {
// Posts
Route::get('/posts', [PostController::class, 'index'])->name('api.posts.index');

View file

@ -0,0 +1,118 @@
<?php
declare(strict_types=1);
use App\Enums\UserWorkspace\Role;
use App\Models\Media;
use App\Models\User;
use App\Models\Workspace;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\URL;
use Illuminate\Support\Str;
beforeEach(function () {
Storage::fake();
Cache::flush();
$this->user = User::factory()->create();
$this->workspace = Workspace::factory()->create(['user_id' => $this->user->id]);
$this->workspace->members()->attach($this->user->id, ['role' => Role::Member->value]);
});
function signedUploadUrl(Workspace $ws, string $token, ?int $expiresInMinutes = 15): string
{
return URL::temporarySignedRoute(
'api.uploads.store',
now()->addMinutes($expiresInMinutes),
['token' => $token, 'ws' => $ws->id],
);
}
test('valid signed POST stores Media with upload_token', function () {
$token = (string) Str::uuid();
$file = UploadedFile::fake()->image('shot.png', 50, 50);
$response = $this->post(signedUploadUrl($this->workspace, $token), [
'media' => $file,
]);
$response->assertCreated()
->assertJsonStructure(['upload_token', 'media_id', 'type', 'mime_type', 'original_filename']);
$media = Media::where('upload_token', $token)->first();
expect($media)->not->toBeNull();
expect($media->mediable_id)->toBe($this->workspace->id);
expect($media->mediable_type)->toBe('workspace');
});
test('rejects unsigned request', function () {
$token = (string) Str::uuid();
$file = UploadedFile::fake()->image('shot.png', 50, 50);
$response = $this->postJson(route('api.uploads.store', ['token' => $token, 'ws' => $this->workspace->id]), [
'media' => $file,
]);
$response->assertForbidden();
expect(Media::where('upload_token', $token)->exists())->toBeFalse();
});
test('rejects tampered workspace_id', function () {
$other = Workspace::factory()->create();
$token = (string) Str::uuid();
$file = UploadedFile::fake()->image('shot.png', 50, 50);
$url = signedUploadUrl($this->workspace, $token);
$tampered = str_replace("ws={$this->workspace->id}", "ws={$other->id}", $url);
$response = $this->postJson($tampered, ['media' => $file]);
$response->assertForbidden();
});
test('rejects expired URL', function () {
$token = (string) Str::uuid();
$file = UploadedFile::fake()->image('shot.png', 50, 50);
$url = URL::temporarySignedRoute(
'api.uploads.store',
now()->subMinute(),
['token' => $token, 'ws' => $this->workspace->id],
);
$response = $this->postJson($url, ['media' => $file]);
$response->assertForbidden();
});
test('rejects replay of an already-used token', function () {
$token = (string) Str::uuid();
$file1 = UploadedFile::fake()->image('one.png', 50, 50);
$file2 = UploadedFile::fake()->image('two.png', 50, 50);
$this->post(signedUploadUrl($this->workspace, $token), ['media' => $file1])->assertCreated();
$this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file2])->assertStatus(409);
expect(Media::where('upload_token', $token)->count())->toBe(1);
});
test('rejects file larger than 50MB', function () {
$token = (string) Str::uuid();
$file = UploadedFile::fake()->create('huge.mp4', 51 * 1024 + 1, 'video/mp4');
$response = $this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file]);
$response->assertStatus(422);
expect(Media::where('upload_token', $token)->exists())->toBeFalse();
});
test('rejects disallowed mime type', function () {
$token = (string) Str::uuid();
$file = UploadedFile::fake()->create('evil.exe', 10, 'application/octet-stream');
$response = $this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file]);
$response->assertStatus(422);
expect(Media::where('upload_token', $token)->exists())->toBeFalse();
});