From b17026f3a1f25acf14b34a1532a375a44843e196 Mon Sep 17 00:00:00 2001 From: Paulo Castellano Date: Fri, 15 May 2026 16:10:21 -0300 Subject: [PATCH] feat(media): signed POST upload endpoint for MCP flow --- app/Http/Controllers/Api/UploadController.php | 44 +++++++ app/Http/Requests/Api/StoreUploadRequest.php | 33 +++++ routes/api.php | 6 + tests/Feature/Api/UploadControllerTest.php | 118 ++++++++++++++++++ 4 files changed, 201 insertions(+) create mode 100644 app/Http/Controllers/Api/UploadController.php create mode 100644 app/Http/Requests/Api/StoreUploadRequest.php create mode 100644 tests/Feature/Api/UploadControllerTest.php diff --git a/app/Http/Controllers/Api/UploadController.php b/app/Http/Controllers/Api/UploadController.php new file mode 100644 index 00000000..84b122c4 --- /dev/null +++ b/app/Http/Controllers/Api/UploadController.php @@ -0,0 +1,44 @@ +query('expires'); + $ttl = max(60, $expiresAt - now()->timestamp + 60); + + if (! Cache::add("mcp_upload:{$token}", true, $ttl)) { + abort(Response::HTTP_CONFLICT, 'Upload token already used.'); + } + + if (Media::where('upload_token', $token)->exists()) { + abort(Response::HTTP_CONFLICT, 'Upload token already consumed.'); + } + + $workspace = Workspace::findOrFail((string) $request->query('ws')); + + $media = $workspace->addMedia($request->file('media'), 'assets'); + $media->upload_token = $token; + $media->save(); + + return response()->json([ + 'upload_token' => $token, + 'media_id' => $media->id, + 'type' => $media->type, + 'mime_type' => $media->mime_type, + 'original_filename' => $media->original_filename, + ], Response::HTTP_CREATED); + } +} diff --git a/app/Http/Requests/Api/StoreUploadRequest.php b/app/Http/Requests/Api/StoreUploadRequest.php new file mode 100644 index 00000000..f21caf5c --- /dev/null +++ b/app/Http/Requests/Api/StoreUploadRequest.php @@ -0,0 +1,33 @@ +allowedMimeTypes(), + MediaType::Video->allowedMimeTypes(), + )); + + return [ + 'media' => [ + 'required', + 'file', + 'max:51200', + "mimetypes:{$allowed}", + ], + ]; + } +} diff --git a/routes/api.php b/routes/api.php index 3484ae9b..c6f5a67f 100644 --- a/routes/api.php +++ b/routes/api.php @@ -8,9 +8,15 @@ use App\Http\Controllers\Api\PostController; use App\Http\Controllers\Api\SignatureController; use App\Http\Controllers\Api\SocialAccountController; +use App\Http\Controllers\Api\UploadController; use App\Http\Controllers\Api\WorkspaceController; use Illuminate\Support\Facades\Route; +Route::post('/uploads/{token}', [UploadController::class, 'store']) + ->middleware('signed') + ->where('token', '[0-9a-f-]{36}') + ->name('api.uploads.store'); + Route::middleware(['auth:api', 'workspace.token', 'throttle:api'])->group(function () { // Posts Route::get('/posts', [PostController::class, 'index'])->name('api.posts.index'); diff --git a/tests/Feature/Api/UploadControllerTest.php b/tests/Feature/Api/UploadControllerTest.php new file mode 100644 index 00000000..90082581 --- /dev/null +++ b/tests/Feature/Api/UploadControllerTest.php @@ -0,0 +1,118 @@ +user = User::factory()->create(); + $this->workspace = Workspace::factory()->create(['user_id' => $this->user->id]); + $this->workspace->members()->attach($this->user->id, ['role' => Role::Member->value]); +}); + +function signedUploadUrl(Workspace $ws, string $token, ?int $expiresInMinutes = 15): string +{ + return URL::temporarySignedRoute( + 'api.uploads.store', + now()->addMinutes($expiresInMinutes), + ['token' => $token, 'ws' => $ws->id], + ); +} + +test('valid signed POST stores Media with upload_token', function () { + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->image('shot.png', 50, 50); + + $response = $this->post(signedUploadUrl($this->workspace, $token), [ + 'media' => $file, + ]); + + $response->assertCreated() + ->assertJsonStructure(['upload_token', 'media_id', 'type', 'mime_type', 'original_filename']); + + $media = Media::where('upload_token', $token)->first(); + expect($media)->not->toBeNull(); + expect($media->mediable_id)->toBe($this->workspace->id); + expect($media->mediable_type)->toBe('workspace'); +}); + +test('rejects unsigned request', function () { + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->image('shot.png', 50, 50); + + $response = $this->postJson(route('api.uploads.store', ['token' => $token, 'ws' => $this->workspace->id]), [ + 'media' => $file, + ]); + + $response->assertForbidden(); + expect(Media::where('upload_token', $token)->exists())->toBeFalse(); +}); + +test('rejects tampered workspace_id', function () { + $other = Workspace::factory()->create(); + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->image('shot.png', 50, 50); + + $url = signedUploadUrl($this->workspace, $token); + $tampered = str_replace("ws={$this->workspace->id}", "ws={$other->id}", $url); + + $response = $this->postJson($tampered, ['media' => $file]); + + $response->assertForbidden(); +}); + +test('rejects expired URL', function () { + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->image('shot.png', 50, 50); + + $url = URL::temporarySignedRoute( + 'api.uploads.store', + now()->subMinute(), + ['token' => $token, 'ws' => $this->workspace->id], + ); + + $response = $this->postJson($url, ['media' => $file]); + $response->assertForbidden(); +}); + +test('rejects replay of an already-used token', function () { + $token = (string) Str::uuid(); + $file1 = UploadedFile::fake()->image('one.png', 50, 50); + $file2 = UploadedFile::fake()->image('two.png', 50, 50); + + $this->post(signedUploadUrl($this->workspace, $token), ['media' => $file1])->assertCreated(); + $this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file2])->assertStatus(409); + + expect(Media::where('upload_token', $token)->count())->toBe(1); +}); + +test('rejects file larger than 50MB', function () { + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->create('huge.mp4', 51 * 1024 + 1, 'video/mp4'); + + $response = $this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file]); + + $response->assertStatus(422); + expect(Media::where('upload_token', $token)->exists())->toBeFalse(); +}); + +test('rejects disallowed mime type', function () { + $token = (string) Str::uuid(); + $file = UploadedFile::fake()->create('evil.exe', 10, 'application/octet-stream'); + + $response = $this->postJson(signedUploadUrl($this->workspace, $token), ['media' => $file]); + + $response->assertStatus(422); + expect(Media::where('upload_token', $token)->exists())->toBeFalse(); +});