refactor: extract attach-media validation into a FormRequest
Project convention is one FormRequest per endpoint
(Api/Post/StorePostRequest, UpdatePostRequest, etc.) — the inline
$request->validate() in attachMedia was the only outlier in this
controller. Extracted to Api/Post/AttachMediaRequest with the same
rules:
'urls' => ['required', 'array', 'min:1', 'max:10'],
'urls.*' => ['url:http,https', 'active_url'],
Controller signature is now AttachMediaRequest $request — Laravel
binds + validates before the action runs, same pattern as store/update.
This commit is contained in:
parent
4892ee75a5
commit
ac361349da
2 changed files with 29 additions and 7 deletions
|
|
@ -8,6 +8,7 @@
|
|||
use App\Actions\Post\DeletePost;
|
||||
use App\Actions\Post\UpdatePost;
|
||||
use App\Enums\Post\Action as PostAction;
|
||||
use App\Http\Requests\Api\Post\AttachMediaRequest;
|
||||
use App\Http\Requests\Api\Post\StorePostRequest;
|
||||
use App\Http\Requests\Api\Post\UpdatePostRequest;
|
||||
use App\Http\Resources\Api\PostMediaAttachResource;
|
||||
|
|
@ -82,16 +83,11 @@ public function destroy(Request $request, Post $post): JsonResponse
|
|||
return response()->json(null, Response::HTTP_NO_CONTENT);
|
||||
}
|
||||
|
||||
public function attachMedia(Request $request, Post $post): PostMediaAttachResource
|
||||
public function attachMedia(AttachMediaRequest $request, Post $post): PostMediaAttachResource
|
||||
{
|
||||
$this->authorize('update', $post);
|
||||
|
||||
$validated = $request->validate([
|
||||
'urls' => ['required', 'array', 'min:1', 'max:10'],
|
||||
'urls.*' => ['url:http,https', 'active_url'],
|
||||
]);
|
||||
|
||||
$result = app(MediaAttacher::class)->attachFromUrls($post, $validated['urls']);
|
||||
$result = app(MediaAttacher::class)->attachFromUrls($post, $request->validated('urls'));
|
||||
|
||||
$post->refresh()->load(['postPlatforms.socialAccount', 'labels']);
|
||||
|
||||
|
|
|
|||
26
app/Http/Requests/Api/Post/AttachMediaRequest.php
Normal file
26
app/Http/Requests/Api/Post/AttachMediaRequest.php
Normal file
|
|
@ -0,0 +1,26 @@
|
|||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace App\Http\Requests\Api\Post;
|
||||
|
||||
use Illuminate\Foundation\Http\FormRequest;
|
||||
|
||||
class AttachMediaRequest extends FormRequest
|
||||
{
|
||||
public function authorize(): bool
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array<string, array<int, string>>
|
||||
*/
|
||||
public function rules(): array
|
||||
{
|
||||
return [
|
||||
'urls' => ['required', 'array', 'min:1', 'max:10'],
|
||||
'urls.*' => ['url:http,https', 'active_url'],
|
||||
];
|
||||
}
|
||||
}
|
||||
Loading…
Reference in a new issue