From ac361349dad6827e3794f82fc6a439e6ab4fcf18 Mon Sep 17 00:00:00 2001 From: Paulo Castellano Date: Mon, 4 May 2026 14:37:49 -0300 Subject: [PATCH] refactor: extract attach-media validation into a FormRequest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Project convention is one FormRequest per endpoint (Api/Post/StorePostRequest, UpdatePostRequest, etc.) — the inline $request->validate() in attachMedia was the only outlier in this controller. Extracted to Api/Post/AttachMediaRequest with the same rules: 'urls' => ['required', 'array', 'min:1', 'max:10'], 'urls.*' => ['url:http,https', 'active_url'], Controller signature is now AttachMediaRequest $request — Laravel binds + validates before the action runs, same pattern as store/update. --- app/Http/Controllers/Api/PostController.php | 10 +++---- .../Requests/Api/Post/AttachMediaRequest.php | 26 +++++++++++++++++++ 2 files changed, 29 insertions(+), 7 deletions(-) create mode 100644 app/Http/Requests/Api/Post/AttachMediaRequest.php diff --git a/app/Http/Controllers/Api/PostController.php b/app/Http/Controllers/Api/PostController.php index c9df1a24..59f7e9fc 100644 --- a/app/Http/Controllers/Api/PostController.php +++ b/app/Http/Controllers/Api/PostController.php @@ -8,6 +8,7 @@ use App\Actions\Post\DeletePost; use App\Actions\Post\UpdatePost; use App\Enums\Post\Action as PostAction; +use App\Http\Requests\Api\Post\AttachMediaRequest; use App\Http\Requests\Api\Post\StorePostRequest; use App\Http\Requests\Api\Post\UpdatePostRequest; use App\Http\Resources\Api\PostMediaAttachResource; @@ -82,16 +83,11 @@ public function destroy(Request $request, Post $post): JsonResponse return response()->json(null, Response::HTTP_NO_CONTENT); } - public function attachMedia(Request $request, Post $post): PostMediaAttachResource + public function attachMedia(AttachMediaRequest $request, Post $post): PostMediaAttachResource { $this->authorize('update', $post); - $validated = $request->validate([ - 'urls' => ['required', 'array', 'min:1', 'max:10'], - 'urls.*' => ['url:http,https', 'active_url'], - ]); - - $result = app(MediaAttacher::class)->attachFromUrls($post, $validated['urls']); + $result = app(MediaAttacher::class)->attachFromUrls($post, $request->validated('urls')); $post->refresh()->load(['postPlatforms.socialAccount', 'labels']); diff --git a/app/Http/Requests/Api/Post/AttachMediaRequest.php b/app/Http/Requests/Api/Post/AttachMediaRequest.php new file mode 100644 index 00000000..4e2071c5 --- /dev/null +++ b/app/Http/Requests/Api/Post/AttachMediaRequest.php @@ -0,0 +1,26 @@ +> + */ + public function rules(): array + { + return [ + 'urls' => ['required', 'array', 'min:1', 'max:10'], + 'urls.*' => ['url:http,https', 'active_url'], + ]; + } +}