Commit graph

130078 commits

Author SHA1 Message Date
Laurent Destailleur
fc3ea8e8ab Fix apstats 2024-02-17 16:53:24 +01:00
Laurent Destailleur
750e3270ac Enhance apstats 2024-02-17 16:46:06 +01:00
Laurent Destailleur
c0a094974a Clean code 2024-02-17 16:03:24 +01:00
Laurent Destailleur
a3b876e5ca Clean code 2024-02-17 15:50:51 +01:00
Laurent Destailleur
eccff949d6 Mutualize code 2024-02-17 15:34:19 +01:00
Laurent Destailleur
671257e8e3 Clean phpunit tests 2024-02-17 15:19:06 +01:00
Laurent Destailleur
a23addd21e FIX Pb in redirect of a website page in USEDOLIBARRSERVER mode 2024-02-17 15:10:42 +01:00
Laurent Destailleur
713ee984d7 Fix syntax error 2024-02-17 14:40:45 +01:00
Laurent Destailleur
7f49fd355a NEW Add id of last page accessed in website 2024-02-17 14:35:57 +01:00
Laurent Destailleur
4bfbbff447 Remove teardownafter, setup and teardown method in phpunit test 2024-02-17 04:12:42 +01:00
Laurent Destailleur
f9f549ef26 Work on generic filter 2024-02-17 04:07:34 +01:00
Laurent Destailleur
1bd04a04f5 Update doc 2024-02-17 00:15:43 +01:00
Laurent Destailleur
6085fe7e49 Work on custom reports 2024-02-17 00:10:41 +01:00
Laurent Destailleur
c711791197 Work on custom reports 2024-02-16 23:56:07 +01:00
Laurent Destailleur
56b0c29d1f Mutualise code 2024-02-16 23:26:32 +01:00
Laurent Destailleur
a32831bc6f Fix regression 2024-02-16 18:18:30 +01:00
Laurent Destailleur
6e8786241c Fix regression 2024-02-16 18:18:17 +01:00
Laurent Destailleur
38d7e14999 Doc 2024-02-16 13:35:26 +01:00
Laurent Destailleur
8dc8f67c31 Rename status for a better consistency with other modules 2024-02-16 13:32:40 +01:00
evarisk-micka
010257eaa2
FIX #26920 replace fk_statut by status (#27930)
* FIX use status instead of fk_statut

* FIX replace fk_statut by status

* FIX keep old fk_statut field in case it is used by hook or trigger

* FIX select fk_statut as status and fill both with obj->status

* Update list.php

* Update task.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-16 13:23:23 +01:00
Laurent Destailleur
62626a4d53 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-16 13:10:05 +01:00
MDW
f10d06a357
Qual: Clean up (spelling/shellcheck) initdemo/initdata files (#28195)
# Qual: Clean up (spelling/shellcheck) initdemo/initdata files

Cleanup the readme's and the script
2024-02-16 13:09:40 +01:00
Laurent Destailleur
f23fde8a47 Fix typo 2024-02-16 13:09:32 +01:00
HENRY Florian
24b017fbc8
database: add field llx_contract.signed_status (and remane new llx_fichinter.signed to llx_fichinter.signed_status to avoid SQL reserved name use) (#28204) 2024-02-16 13:07:07 +01:00
MDW
844bc42240
FIX: Check valid mail server record correction. (#28197)
# FIX: Check valid mail server record correction.

The test for isValidMXRecord did not pass on Windows platform:

```bash
php -r '$a=getmxrr("yhaoo.com", $mxhosts, $weight);var_dump([$a,$mxhosts]);'

array(2) {
  [0] =>
  bool(true)
  [1] =>
  array(1) {
    [0] =>
    string(1) "."
  }
}

array(2) {
  [0] =>
  bool(true)
  [1] =>
  array(3) {
    [0] =>
    string(21) "mta5.am0.yahoodns.net"
    [1] =>
    string(21) "mta7.am0.yahoodns.net"
    [2] =>
    string(21) "mta6.am0.yahoodns.net"
  }
}

```

So an "invalid" MX record can be returned as a dot '.'.
2024-02-16 13:03:16 +01:00
Frédéric FRANCE
aabe3c528c
fix typo (#28201)
* fix typo

* Update opensurveysondage.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-16 13:01:43 +01:00
Frédéric FRANCE
cdfb72e707
fix wrong test (#28202) 2024-02-16 12:15:57 +01:00
William Mead
423e0d9124
Fixed empty status (#28200) 2024-02-16 12:15:36 +01:00
Frédéric FRANCE
7cb8177de1
fix typos (#28198) 2024-02-16 12:13:25 +01:00
Frédéric FRANCE
647cf21b54
fix warnings in select_resource_list (#28189)
* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list
2024-02-16 02:40:27 +01:00
MDW
ae0f43632e
Fix: Add some initialisations that avoid notices (#28191)
* Fix: Initialize  to avoid incrementing undefined variable.

# Fix: Initialize  to avoid incrementing undefined variable.

Got an error in the Web Interface related to error not being defined and incremented

* Fix: Initialize

# Fix: Initialize

Was not defined during test
2024-02-16 02:32:58 +01:00
thibdrev
f445d1e376
qual: phpstan for various mod_xxx.php (#28190)
* Update mod_contract_magre.php

* Update mod_contract_olive.php

* Update mod_contract_serpis.php

* Update mod_holiday_immaculate.php

* Update mod_holiday_madonna.php

* Update mod_member_advanced.php

* Update mod_member_simple.php

* Update modules_product.class.php

* Update mod_sn_free.php

* phpcs

* phpcs
2024-02-16 02:30:55 +01:00
Frédéric FRANCE
ff29e2e2db
fix movement stock list (#28192)
* fix movement stock list

* fix

* fix
2024-02-16 02:30:06 +01:00
MDW
399f5d6cbe
Qual Improve messages in tests (#28193)
* Fix: Improve error messages for AdminLibTest

# Fix: Improve error messages for AdminLibTest

These changes clarify the messages when the changed assertions fail.

* Qual: Improve error messages for FileLibTest

# Qual: Improve error messages for FileLibTest

Certain tests now have error messages that help identify a failing test.
2024-02-16 02:28:32 +01:00
Laurent Destailleur
77db116447 Debug custom report 2024-02-16 02:11:04 +01:00
Laurent Destailleur
b48455c9d7 Can remove filter entries 2024-02-16 01:50:03 +01:00
Laurent Destailleur
7107b5feb3 Debug custom report filter management 2024-02-16 01:19:53 +01:00
Laurent Destailleur
2677cd9ff7 Update lang 2024-02-15 18:55:46 +01:00
Laurent Destailleur
a549f095b7 Fix custom reports for external modules 2024-02-15 18:40:04 +01:00
Laurent Destailleur
75cdfcbf52 Fix if reffield does not exists 2024-02-15 18:08:38 +01:00
Laurent Destailleur
5d7232f637 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-15 17:07:14 +01:00
Laurent Destailleur
0eee181afd Remove duplicate line 2024-02-15 17:06:54 +01:00
Laurent Destailleur
ce0c4601bb Close #28181 New substitution variables for invoice 2024-02-15 17:05:54 +01:00
William Mead
0a0edcf273
Qual clean dolresource (#27864)
* Updated PHPDoc

* Cleaned code & comments. Typed method parameters.

* Cleaned code

* Force int cast

* Fixed PHP 7.0 compatibility

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-15 16:49:54 +01:00
Frédéric FRANCE
aee0618dd3
fix phpstan salary.class.php (#28164)
* fix phpstan salary.class.php

* Update salary.class.php

* fix

* fix
2024-02-15 16:44:27 +01:00
Frédéric FRANCE
4bf4f587b2
fix phpstan pdf_einstein.modules.php (#28166) 2024-02-15 16:43:25 +01:00
Laurent Destailleur
41fa5758c9 Avoid error 2024-02-15 15:22:33 +01:00
MDW
43967a83a3
SEC: #28168 Correct protocol limitations (PHP7.4/Win) (#28172)
# SEC: #28168 Correct protocol limitations (PHP7.4/Win)

Protocol limitation was not active during test on windows platform.
Moving the application of the limitation just before the curl_exec
instruction made the limitation effective.

Also extended the code to enable allowing ftp and ftps and extended
the code for [CURLOPT_REDIR_PROTOCOLS_STR](https://www.php.net/manual/en/curl.constants.php#constant.curlopt-redir-protocols-str).
2024-02-15 15:20:21 +01:00
Frédéric FRANCE
8830e47c63
phpdoc (#28167)
* phpdoc

* fix
2024-02-15 14:59:43 +01:00
thibdrev
b0658c48f0
qual: phpstan - Property mod_xxxx::$code_modifiable (string) does not accept int. (#28173)
* qual: phpstan for commonnumrefgenerator.class.php

* qual: phpstan for mod_codeproduct_elephant.php

* qual: phpstan for mod_codeproduct_leopard.php

htdocs/core/modules/product/mod_codeproduct_leopard.php	79	Property mod_codeproduct_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_lot_free.php

htdocs/core/modules/product_batch/mod_lot_free.php	76	Property mod_lot_free::$code_modifiable (string) does not accept int.

* Update mod_codeclient_elephant.php

htdocs/core/modules/societe/mod_codeclient_elephant.php	46	PHPDoc type int of property mod_codeclient_elephant::$code_modifiable is not covariant with PHPDoc type string of overridden property ModeleThirdPartyCode::$code_modifiable.

* qual: phpstan for mod_codeclient_leopard.php

htdocs/core/modules/societe/mod_codeclient_leopard.php	76	Property mod_codeclient_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_codeclient_monkey.php

htdocs/core/modules/societe/mod_codeclient_monkey.php	76	Property mod_codeclient_monkey::$code_modifiable (string) does not accept int.

* phpcs

* phpcs

* phpcs

* qual: phpstan for modules_societe.class.php

* Update mod_lot_free.php
2024-02-15 14:59:07 +01:00