Commit graph

130957 commits

Author SHA1 Message Date
Laurent Destailleur
f72b03434b Fix sql sanitization 2024-03-11 13:16:53 +01:00
Laurent Destailleur
4dba1f420e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 12:48:10 +01:00
Laurent Destailleur
1f4e7aedde Avoid to denaturate value when not required. 2024-03-11 12:47:53 +01:00
Lucas Marcouiller
c224f9388e
Fix display in adherents type (#28754)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-03-11 12:39:23 +01:00
MDW
48073b85cb
Fix: 'count' on scalar zip->numFiles (#28756) 2024-03-11 12:39:07 +01:00
Laurent Destailleur
f32bf4b3a7 Fix join -> implode 2024-03-11 12:38:21 +01:00
Laurent Destailleur
af8c45987e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-11 12:30:03 +01:00
Laurent Destailleur
509754fe6b Better fix for #28755 #28752 2024-03-11 12:29:13 +01:00
Lucas Marcouiller
b3c275bcf9
Fix #28752 fix fatal error in societe card (#28755)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-03-11 12:26:47 +01:00
Laurent Destailleur
b3ee7c3853 Fix warning 2024-03-11 12:22:06 +01:00
Laurent Destailleur
e94b9f48c8 Fix warning 2024-03-11 12:18:57 +01:00
Laurent Destailleur
898aebdbf8 Fix missing tooltip 2024-03-11 12:06:57 +01:00
Laurent Destailleur
002a4596df Fix warning 2024-03-11 12:00:39 +01:00
Laurent Destailleur
a327d39062 Fix warning 2024-03-11 11:39:51 +01:00
Laurent Destailleur
ef45783d64 NEW: All fetchAll() method now support the USF syntax. 2024-03-11 11:33:58 +01:00
Laurent Destailleur
09802f76c1 NEW: All fetchAll() method now support the USF syntax. 2024-03-11 11:27:26 +01:00
Laurent Destailleur
0887664888 NEW: All fetchAll() method now support the USF syntax. 2024-03-11 11:23:34 +01:00
Laurent Destailleur
8df2ddc494 Fix sanitize sql 2024-03-11 10:48:46 +01:00
Laurent Destailleur
8d7911f484 Fix compatibility with USF. 2024-03-11 10:32:15 +01:00
Laurent Destailleur
517bffc211 Escape 2024-03-11 10:16:32 +01:00
Laurent Destailleur
0fb4a44563 Fix nb of lines 2024-03-10 22:13:37 +01:00
Laurent Destailleur
c853a4687f Can delete last and criteria into the generic component. 2024-03-10 19:41:31 +01:00
Laurent Destailleur
c03b5dc2ec Fix for phan output 2024-03-10 18:50:02 +01:00
Laurent Destailleur
4140f59335 Fix default value 2024-03-10 17:58:32 +01:00
Laurent Destailleur
ec1b8284c9 Rename files to use an english name 2024-03-10 15:52:29 +01:00
Laurent Destailleur
37775a8e14 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 15:43:07 +01:00
Laurent Destailleur
5a5fa9293f FIX: upload odt files should not start/end with space 2024-03-10 15:42:38 +01:00
MDW
4c442de1a2
Qual: Add phan stub files to phpstan configuration (#28730)
* Qual: Add phan stub files to phpstan configuration

* Provide log as artifact (for debug), improve CACHE_KEY
2024-03-10 02:00:41 +01:00
Laurent Destailleur
e5dc0f97d0 Fix cast 2024-03-10 01:59:42 +01:00
Laurent Destailleur
51807de4ff Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 01:56:45 +01:00
Charles
ce30ccb004
Update ticket.class.php #28721 - Default for Ticket fk_statut in "update" function (#28731)
Correcting the default value for Ticket fk_statut to zero(0) instead of null based on the prescription from the create function.
2024-03-10 01:56:36 +01:00
MDW
6d9e7b8144
Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal (#28732)
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal

* Qual: phan: suppress false positive on ssl_set

* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.

* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing

* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
2024-03-10 01:55:56 +01:00
MDW
d524e97137
Qual: Fix & enable PhanPluginRedundantAssignmentInLoop (#28733)
# Qual: Fix & enable PhanPluginRedundantAssignmentInLoop

Fixes the occurences that generated this notice & enable the report
for PhanPluginRedundantAssignmentInLoop
2024-03-10 01:54:34 +01:00
Laurent Destailleur
429476e293 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 01:53:32 +01:00
MDW
37afba949e
Fix most PhanTypeMismatchDimAssignment notices (#28739)
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice

* Fix: Initialise array for code in somme

* Qual: Update type hint for  argument in _Set_Format

* Qual: Update type hint for childtables

* Qual: Add typing to attributes

* Qual: Add typing for _msgContent

* Qual: Suppress PhanTypeMismatchDimAssignment

* Qual: Add typing for liste

* Qual: Add typing to fields

* Qual: Add typing hint for $objMod

* Qual: Modify assignment of array with bool keys for phan typing

Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
  [1] =>
  string(3) "yes"
  [0] =>
  string(2) "no"
}
```

* Qual: Add typing hint to indicate value is not null

* Force non-null type on $paramname

* Qual: Add typing hint to getCats()

* Update inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-10 01:53:04 +01:00
Laurent Destailleur
28df0ba1ab Fix doc 2024-03-10 01:49:56 +01:00
MDW
c95bab2818
Qual: Add check on addExtraField type argument (#28738)
* Qual: Add check on addExtraField type argument

# Qual: Add check on addExtraField type argument

Added a check on the type argument for addExtraField

* Qual: Update phan ignore with more specific name
2024-03-10 01:46:10 +01:00
Frédéric FRANCE
895aa5ee85
fix phpstan (#28735)
* fix phpstan

* fix phpstan

* fix phpstan
2024-03-10 01:44:08 +01:00
Laurent Destailleur
96ef01c5c7 Fix print $sql 2024-03-10 01:37:27 +01:00
Laurent Destailleur
279de64851 Fix regression 2024-03-10 01:21:50 +01:00
Laurent Destailleur
7e31aedf94 FIX Picto in top menu 2024-03-09 23:46:38 +01:00
Laurent Destailleur
983b22303a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-09 23:20:55 +01:00
Laurent Destailleur
e6a6ec737e Clean code to edit a menu entry 2024-03-09 23:20:43 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values (#28728)
* Qual: Enable PhanUndeclaredVariableDim

# Qual: Enable PhanUndeclaredVariableDim

The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Qual: Add type hint to array to avoid phan notification

* Qual: Add type hint to array to avoid phan notification

* Qual: Enable PhanParamSpecial1 (all resolved)

* Qual: Ignore false PhanTypeArraySuspiciousNullable

* Qual: Improve typing to fix PhanTypeArraySuspicious

* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array

* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Enable phan messages that no longer appear

* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
Laurent Destailleur
ce6958e451 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-09 15:15:03 +01:00
Laurent Destailleur
6ac626c75b Add test on perm and force cast 2024-03-09 15:03:40 +01:00
Frédéric FRANCE
e00a9816f8
fix phpstan (#28727)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-09 14:48:06 +01:00
Laurent Destailleur
38618b405c Clean code 2024-03-09 02:52:09 +01:00
MDW
d116934301
Fix: Initialise array variables before assigning fields (#28725)
* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields

* Fix: Initialise array variables before assigning fields
2024-03-09 02:43:57 +01:00
MDW
53bed0f71d
Fix: cachecontact to cachecontacts (#28724)
# Fix: cachecontact to cachecontacts

Detected as uninitialized array - determined that the variable name must be with s.
2024-03-09 02:31:30 +01:00