Commit graph

155054 commits

Author SHA1 Message Date
Laurent Destailleur
efb693aa1d ci 2026-06-27 01:46:19 +02:00
Laurent Destailleur
0245b4d590 ci 2026-06-27 01:44:56 +02:00
Laurent Destailleur
ac1ac1f50f Try to fix travis 2026-06-27 01:36:01 +02:00
Laurent Destailleur
8c0362f8cf Try to reduce cpu need for travis. Full test on push mode only. 2026-06-27 01:30:31 +02:00
Laurent Destailleur
c9ca147f5c Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-06-27 00:18:09 +02:00
Laurent Destailleur
df24dad116 css 2026-06-27 00:16:43 +02:00
Laurent Destailleur
b687972f86 Look and feel of contact privat emode 2026-06-26 18:13:55 +02:00
Laurent Destailleur
3fa1a2cae6 css 2026-06-26 17:56:12 +02:00
Laurent Destailleur
7fb6093924 Fix MAIN_SHOW_INVALID_EMAIL_IN_LIST option 2026-06-26 17:47:04 +02:00
Laurent Destailleur
38022a1184 Fix MAIN_SHOW_INVALID_EMAIL_IN_LIST option 2026-06-26 17:44:48 +02:00
Laurent Destailleur
a8713b2e7d Fix css 2026-06-26 17:35:35 +02:00
Laurent Destailleur
9679724a4d FIX in list we must not make DNS checks to validate emails 2026-06-26 11:33:43 +02:00
Laurent Destailleur
2a9ad7d24d ci 2026-06-26 11:21:53 +02:00
Laurent Destailleur
b18a83f629 Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-06-26 11:20:52 +02:00
Laurent Destailleur
a6ec579afc Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-06-26 11:08:14 +02:00
Régis Houssin
75fd1f451a
QUAL add MAIN_DISABLE_SHOW_INVALID_EMAIL to avoid slow display (#38992)
* QUAL add MAIN_DISABLE_SHOW_INVALID_EMAIL to avoid slow display

* FIX phpstan error
2026-06-26 11:02:30 +02:00
Laurent Destailleur
301486b730 Missing tooltip 2026-06-26 03:03:59 +02:00
w3houde
09b979e010
Fix #34774 accept YYYYMMDDHHMMSS datep param sent by /societe/agenda.php (#38792)
* Fix #34774 accept YYYYMMDDHHMMSS datep param sent by /societe/agenda.php

htdocs/societe/agenda.php:195 builds the AddAction button URL with
&datep=...dol_print_date(dol_now(), 'dayhourlog')... which expands to
14 digits (YYYYMMDDHHMMSS). htdocs/comm/action/card.php:104 only accepts
the 8-digit YYYYMMDD variant, so the regex misses, $datep stays null
and the date/time pre-fill on the form fails.

Add a leading regex branch that decodes the dayhourlog form and falls
through to the existing 8-digit handler for legacy callers.

Signed-off-by: Dolicraft <contact@dolicraft.com>

* Fix #34774 follow-up: producer-side emit &datep=now per eldy review

PR #38792 was the consumer-side fix (accept 14-digit datep in comm/action/card.php).
Eldy pointed out the cleaner fix is producer-side: send the documented
&datep=now form that the consumer comment at line 104 already recommends
('Try to not use this. Use instead datep=now'). Apply that on the
AddAction URL in /societe/agenda.php.

Kept the consumer-side 14-digit fallback from the previous commit so any
other caller still emitting the old YmdHis form keeps working until they
are migrated too.

Signed-off-by: Dolicraft <contact@dolicraft.com>

* Fix #34774 CI: cast $search_filtert to string for urlencode (phpstan)

Signed-off-by: Dolicraft <contact@dolicraft.com>

---------

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 22:02:03 +02:00
w3houde
e74133c4fe
Fix #37775 do not overwrite POSTed extrafields when creating an invoice from a template (#38814)
htdocs/compta/facture/card.php:1235 calls setOptionalsFromPost() to fill
$object->array_options from the create form, but Facture::create() then
unconditionally overwrites the array with the recurring template values
at line 615. The user-entered extrafields are silently lost.

Only adopt the template's array_options when the caller did not provide
any, so cron-driven recurring invoices keep template values and manual
'generate now' submissions keep what the operator typed in the form.

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 21:46:48 +02:00
w3houde
638c98b2b8
Fix #37357 emailcollector: pick exact source folder before falling back to first match (#38815)
Webklex/PHPIMAP getFolders() in pattern mode treats the second argument
as a sourcedir* glob, so INBOX returns INBOX plus every INBOX.* subfolder.
The collector then took $f[0], which is whichever folder the IMAP server
returned first - often an empty 'INBOX.Traites' archive - so the polling
silently scanned the wrong mailbox and reported no new mail while messages
piled up in INBOX.

Walk the returned list once and prefer the folder whose full_name matches
$tmpsourcedir exactly. Fallback to $f[0] preserves the previous behavior
when no exact match exists (e.g. server-side capitalization quirks).

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 21:42:53 +02:00
w3houde
296b33aa97
Fix #37663 guard SUBTOTALS_SPECIAL_CODE before use in printOriginLine (#38817)
SUBTOTALS_SPECIAL_CODE is only defined by the subtotals module
(htdocs/subtotals/class/commonsubtotal.class.php:24). When a PO line
is printed into a vendor invoice create screen and the subtotals module
is not loaded for the current request, htdocs/core/class/commonobject.class.php
line 5872 fatals with 'Undefined constant SUBTOTALS_SPECIAL_CODE',
hiding every origin line.

Wrap the comparison with defined() to match the existing pattern used in
objectline_view.tpl.php:81, objectline_edit.tpl.php:71 and
originproductline.tpl.php:50.

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 21:35:03 +02:00
w3houde
d6793d9796
Fix #37407 rename main lang key IM to InstantMessaging to free Imperia province code (#38818)
htdocs/core/class/html.formcompany.class.php:339,341,347 picks
$langs->trans($obj->code) for the province dropdown, where $obj->code
is the c_departements code. For Italy that includes IM = Imperia. The
en_US main.lang key 'IM=Instant messaging' was used as fallback and
shadowed the province label.

Rename the lang key to InstantMessaging. No PHP caller references the
old key (grep finds only the .lang files themselves), so this rename
breaks no flow today. Non-en_US locales will resync through Transifex.

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 21:32:54 +02:00
w3houde
08e9766c2a
Fix #37282 dispatch API classes whose name ends with the 'Api' suffix (#38819)
The API discovery loop in htdocs/api/index.php (around line 308) accepts
both Foo and FooApi class names when scanning module directories. The
dispatch loop on the request-handling side (line 422) only checked
class_exists($classname), so a module exposing class MyModuleApi from
api_mymodule.class.php would appear in the API Explorer yet 501 with
'API not found' when the endpoint was actually called.

Probe class_exists($classname.'Api') first to mirror the discovery
behavior. Falls back to the plain class name so existing modules keep
working.

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-06-25 21:32:02 +02:00
Frédéric FRANCE
8b00cb2a61
fix CI (#38858)
* fix CI

* Update get_changed_php.sh

* Update blockedlog.class.php

* Update blockedlog.class.php
2026-06-25 21:27:35 +02:00
Frédéric FRANCE
559599945d
clean code for action specimen (#38865)
* clean code for action specimen

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-25 19:01:16 +02:00
Laurent Destailleur
3b5234d5a7 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-06-25 13:30:27 +02:00
Laurent Destailleur
eed3218153 Fix NaN set into unit price 2026-06-25 13:06:51 +02:00
Laurent Destailleur
e4710357e4 Fix bad test 2026-06-25 12:49:22 +02:00
Nathan
4100121917
fix: remove invalid invoice type check from supplier order stats (#38979) 2026-06-25 12:14:07 +02:00
Laurent Destailleur
65c54a02b8 Doc 2026-06-25 03:35:23 +02:00
Laurent Destailleur
88ab55ee34 Doc 2026-06-25 03:25:11 +02:00
Laurent Destailleur
61ea201b48 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-06-25 02:52:16 +02:00
Laurent Destailleur
f15e53dbae Clean ci scripts 2026-06-25 02:52:04 +02:00
Alexandre SPANGARO
4d9df32d1d
Merge pull request #38986 from frederic34/patch-19
avoid warnings in admin printing
2026-06-24 20:13:54 +02:00
Alexandre SPANGARO
4df5a9429c
Merge pull request #38980 from aspangaro/24_statsinlist
Finish button statistics in list
2026-06-24 20:11:57 +02:00
Frédéric FRANCE
a372e9978b
avoid warnings in admin printing 2026-06-24 17:52:04 +02:00
Alexandre SPANGARO
dc7fd4d39c Add stats in prelevement list 2026-06-24 10:59:50 +02:00
Alexandre SPANGARO
604c7c876a Add stats in salaries list 2026-06-24 10:59:30 +02:00
Alexandre SPANGARO
940ea3d7af Update Eldy Menu 2026-06-24 10:59:04 +02:00
Zakaria Boushaba
35211c6bc7
[FIX] Use date_reception instead of date_delivery in reception linkedobjectblock template (#38964)
Co-authored-by: Zakaria Boushaba <z.boushaba@vold.africa>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-23 20:31:16 +02:00
Nathan
9bdc237e5f
fix: preserve supplier deposit discount currency (#38966)
Co-authored-by: nathnanpixodeo <nathnanpixodeo@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-23 20:29:14 +02:00
MDW
0715c93e68
Qual: Avoid variable scope clash (param $conf vs. global $conf) (#38969)
# Qual: Avoid variable scope clash (param $conf vs. global $conf)

- Renamed parameter `$conf` to `$conf_obj` to avoid targeted name clash with global statement in if clause.
2026-06-23 20:16:24 +02:00
github-actions[bot]
324179f373
PHPStan > Update baseline (#38974)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2026-06-23 20:13:28 +02:00
Laurent Destailleur
452eb31996 Trans 2026-06-23 19:00:28 +02:00
Laurent Destailleur
31e9075989 Merge 2026-06-23 18:52:44 +02:00
Laurent Destailleur
b599407b93 Automated merge from 21.0 to 22.0 by tool pullmerge.sh 2026-06-23 15:54:36 +02:00
Laurent Destailleur
823d4d7ef3 Debug 2026-06-23 14:15:35 +02:00
Laurent Destailleur
0531141e30 Trans 2026-06-23 01:48:22 +02:00
Laurent Destailleur
b2db25bdf0 Trans 2026-06-23 01:41:25 +02:00
MDW
9fde9fae8e
Fix: CI - PHPStan notices, functions.lib.php formatting (#38965)
* Qual: Remove redundant tests

# Qual: Remove redundant tests

Remove redundant tests as reported by PHPStan

* Qual: Fix missing initialisation

# Qual: Fix missing initialisation

In case of catched exception, $hmac_encoded_secret_key was not defined

* Fix: search parameter re-encoding

# Fix: search parameter re-encoding

* Fix: Add new chain initialization in securitycore.lib.php

# Fix: Add new chain initialization in securitycore.lib.php

- Initialize `$newchain` variable before the loop to avoid potential undefined variable issues

* Qual: Fix formatting in functions.lib.php

- Fixed formatting and spacing issues

* Qual: Cast nullable variable to string

# Qual: Cast nullable variable to string

preg_replace requires a string, ensured by casting nullable to string.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-22 23:37:54 +02:00