Commit graph

131069 commits

Author SHA1 Message Date
MDW
dcf25336ba
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:17 +01:00
MDW
1035e92861
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:15 +01:00
MDW
3730dbc31b
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:13 +01:00
MDW
640eb1b75d
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:11 +01:00
MDW
c88a9ea1eb
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:09 +01:00
MDW
fd75753934
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:07 +01:00
MDW
0c0f04f2d5
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:05 +01:00
MDW
88ba7d1bc5
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:03 +01:00
MDW
a8a7d71426
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:01 +01:00
MDW
ec18ec0605
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:59 +01:00
MDW
3f5a3b03ee
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:57 +01:00
MDW
ed703c7241
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:55 +01:00
MDW
4ec7a53e3f
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:52 +01:00
MDW
bc8f023653
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:50 +01:00
MDW
d494def49d
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:48 +01:00
MDW
f4b444cc0f
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:46 +01:00
MDW
622a32b2bb
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:44 +01:00
MDW
4740562141
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:42 +01:00
MDW
67d01e2a9b
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:40 +01:00
MDW
f6920538b6
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:38 +01:00
MDW
1350f4d29e
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:36 +01:00
Laurent Destailleur
cf617547b5 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 16:39:58 +01:00
Laurent Destailleur
404d594f24 Removed not used file 2024-03-11 16:39:44 +01:00
Laurent Destailleur
01c3808478
Merge pull request #28618 from solution-libre/fix-cloned-supplier-order-creation-date
FIX cloned supplier order creation date as now
2024-03-11 16:34:35 +01:00
Laurent Destailleur
b963a9ab36 Fix phpunit 2024-03-11 16:30:33 +01:00
Laurent Destailleur
2cbeca6d4f
Merge pull request #28668 from atm-john/fix_element_type_part_04
NEW : Factoring and Fix external module elementType limit - Part 04
2024-03-11 16:29:34 +01:00
Laurent Destailleur
553587b660
Update DoliDB.class.php 2024-03-11 16:27:46 +01:00
Laurent Destailleur
5b921d0dc4
Update DoliDB.class.php 2024-03-11 16:26:17 +01:00
Laurent Destailleur
93638f3980
Merge pull request #28667 from atm-john/fix_element_type_part_03
NEW : Factoring and Fix external module elementType limit - Part 03
2024-03-11 16:19:00 +01:00
Laurent Destailleur
38e67851bf
Merge pull request #28747 from mdeweerd/test/security_dol_eval_ob_cleanup_on_exception
Fix: Ob buffer cleanup on exception
2024-03-11 16:17:14 +01:00
Laurent Destailleur
ba019a8936
Merge pull request #28764 from lamrani002/addInEmailingAi
NEW layout and prompt ai on create emailing
2024-03-11 16:16:25 +01:00
Laurent Destailleur
688e5ae9b6
Merge pull request #28757 from mdeweerd/fix/getChildrenOfLine/array_merge
Fix: getChildrenOfLine's use of includealltree as array
2024-03-11 16:14:37 +01:00
Laurent Destailleur
769b682fd3
Update commonobject.class.php 2024-03-11 16:13:11 +01:00
Laurent Destailleur
464b1246f0
Merge pull request #28736 from JonBendtsen/cheque_number
attempt at fixing #28645 - API bankaccounts/transfer POST missing the cheque_number
2024-03-11 15:37:47 +01:00
Laurent Destailleur
f7024b61ee
Update api_bankaccounts.class.php 2024-03-11 15:37:16 +01:00
terhoy
a8a2f0ff73
FIX: online signature partly fails if commercial proposal numbering contains a mask that’s includes a space (#28608) (#28742)
* FIX: online signature (#28608) Update signature.lib.php

If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in signature.lib.php line 77, will remove any existing space in the Commercial proposal numbering. The result is that the online signature form will miss data in field “Third-party” and “Amount”.

* FIX: online signature (#28608) Update payments.lib.php

If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in core/lib/payments.lib.ph, will remove any existing space in the Commercial proposal numbering.
2024-03-11 15:33:10 +01:00
MDW
bb64871b35
Qual: Precise typing for Societeaccount's fields property (#28758)
# Qual: Precise typing for Societeaccount's fields property

Better typing helps static analysis and fixes the message:
PhanTypeMismatchArgumentInternal Argument 2 ($array) is $object->fields['site']['arrayofkeyval'] of type null but \array_key_exists() takes array
2024-03-11 15:23:43 +01:00
Lamrani Abdel
5e2a06a177 Add layout and prompt ai on create emmailing 2024-03-11 15:23:26 +01:00
Laurent Destailleur
1178b858d8
Merge branch 'develop' into fix/getChildrenOfLine/array_merge 2024-03-11 15:22:44 +01:00
Laurent Destailleur
39ea68ace4 Try fix phan 2024-03-11 15:20:56 +01:00
Laurent Destailleur
41078a9a46
Merge branch 'develop' into test/security_dol_eval_ob_cleanup_on_exception 2024-03-11 14:57:33 +01:00
Laurent Destailleur
66c40264d1 sql syntax 2024-03-11 14:56:36 +01:00
Laurent Destailleur
4d8e5bb2a7 Fix phpunit 2024-03-11 14:50:35 +01:00
Laurent Destailleur
be403024ed Try a fix for #28734 2024-03-11 14:40:36 +01:00
Laurent Destailleur
c192b8fccd Import menu before export 2024-03-11 14:33:02 +01:00
Laurent Destailleur
61d328093c Fix warnings 2024-03-11 14:28:55 +01:00
MDW
ec0fd31386
Fix phpstan workflow file (#28741)
* Fix phpstan workflow file

# Fix phpstan workflow file

Line was split in two, joined

* qual: set memory limit to 'unlimited' (-1)

* Remove some stubs to check impact

* Fix: Verify execution time limit

* Remove stub files to reuse cache

* Qual: Rename distribution phpstan.neon to phpstan.neon.dist

# Qual: Rename distribution phpstan.neon to phpstan.neon.dist

This allows the developer to override some settings locally

Also update the .gitignore file with phpstan.neon and some other other
ignores (cache, local log files, temporary edit files).

* Enable debug on phpstan

* Re-enable stubs

* Fix: Change parallel settings to defaults, remove buffer

'buffer' is not a documented parameter, removing it.
Removing some configuration settings as the defaults are higher and
should adapt better to the target machine
2024-03-11 14:04:02 +01:00
MDW
b72cf193c4
Fix some cases of PhanTypeSuspiciousStringExpression (#28751)
* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-11 14:01:28 +01:00
Laurent Destailleur
0f2121e3ba Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 13:46:08 +01:00
Florent Poinsaut
674e668b78 FIX cloned supplier order creation date as now 2024-03-11 12:42:16 +00:00