Commit graph

155439 commits

Author SHA1 Message Date
MDW
cbf8748dd2
Fix CI #39247: Fix phan notices by reorganising code (#39264)
* Fix #39247: Fix phan notices by reorganising code

# Fix #39247: Fix phan notices by reorganising code

Phan typing analysis was disturbed by conditional assignment to array fields of array items.

This reorganises the the code and uses a foreach and a loop item by reference.
The result array is filtered after the initial loop to find matching ECM items.

Not that this does not fix an unreported issue when paging is applied for filtered items
(paging is applied on the full list, not the filtered items and may result in small(er)
or empty pages).

* Qual: Fix Phan notices

# Qual: Fix Phan notices

- The page_count value was simply ceil(...) which is typed float, now casting to int.
- Add missing properties share and agenda_id to EcmFilesLine
2026-07-23 16:09:22 +02:00
Laurent Destailleur
68297cad59 FIX #39265 2026-07-23 16:02:34 +02:00
Laurent Destailleur
4746f6573a Fix Regresion: restore creation of key/functions/data at install/upgrade 2026-07-23 15:05:52 +02:00
Laurent Destailleur
ad98f29d68 Debug v24 2026-07-23 12:19:30 +02:00
Laurent Destailleur
ada3e7c748 Removed deprecated file 2026-07-23 12:18:33 +02:00
Laurent Destailleur
729c2da70a Code comment 2026-07-23 11:44:05 +02:00
Laurent Destailleur
c7bc056aba Fix error when https not available 2026-07-23 11:43:10 +02:00
Laurent Destailleur
87644de46e CI 2026-07-21 03:55:58 +02:00
Laurent Destailleur
4ba970312d Fix phan 2026-07-21 01:28:22 +02:00
Laurent Destailleur
b0e8f0aa14 Doc 2026-07-20 18:08:57 +02:00
Laurent Destailleur
89e3c8bec7 Doc 2026-07-20 18:08:15 +02:00
Laurent Destailleur
51d43a28c9 clean code 2026-07-20 17:42:20 +02:00
Laurent Destailleur
a4605fcac3 Restrict access on permission for editing notification on thirdparty 2026-07-20 17:26:15 +02:00
Laurent Destailleur
2ec0cdb508 doc 2026-07-20 16:08:57 +02:00
Laurent Destailleur
2e31195201 Fix edit of notification need write permission on users. 2026-07-20 15:49:39 +02:00
Laurent Destailleur
3813c1ad59 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-07-20 15:36:40 +02:00
Laurent Destailleur
ef6e4bc7b8 Doc 2026-07-20 15:36:29 +02:00
MDW
d3725ac73a
Qual: Fix 'SqlInjection' notices (#39230)
* Fix(ci): Add exceptions for 'mouvement' (codespell)

* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 15:28:26 +02:00
MDW
21ae10b566
Qual: Fix 'SqlInjection' notices (#39231)
* Fix(ci): Add exceptions for 'mouvement' (codespell)

* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 15:28:15 +02:00
MDW
63c88427f3
Fix(ci): Add exceptions for 'mouvement' (codespell) (#39227) 2026-07-20 15:27:25 +02:00
MDW
1f30bd1d7d
Qual: Fix 'SqlInjection' notices (#39229)
* Fix(ci): Add exceptions for 'mouvement' (codespell)

* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 15:26:43 +02:00
MDW
a801fb5229
Qual: Fix 'SqlInjection' notices (#39228)
* Fix(ci): Add exceptions for 'mouvement' (codespell)

* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 15:26:30 +02:00
Laurent Destailleur
63a2b0fe49 CI 2026-07-20 15:22:16 +02:00
Laurent Destailleur
b3d342393c Clean code 2026-07-20 14:58:04 +02:00
Laurent Destailleur
7335438ee1 Fix rewrite api /documents to solve duplicate and missing security check
at object-level
2026-07-20 14:57:23 +02:00
Laurent Destailleur
dd1c124349 Debug v24 2026-07-20 12:38:35 +02:00
Laurent Destailleur
b12734dd36 Fix missing object-level control on api to reopen or billed an order -
reported by Phan Long
2026-07-20 12:03:14 +02:00
Laurent Destailleur
7dc44c9665 CSS 2026-07-20 11:50:24 +02:00
Laurent Destailleur
6b607bc21e Debug v24 2026-07-20 11:41:52 +02:00
Laurent Destailleur
3d1eeb35af Fix sanitize urlfrom like backtopage - reported by codex 2026-07-20 11:09:58 +02:00
Laurent Destailleur
5130a49591 Fix test on permissions 2026-07-20 10:52:14 +02:00
Laurent Destailleur
0dd9e6acc2 Fix missing test on external user id - reported by Codex 2026-07-20 10:12:24 +02:00
Laurent Destailleur
11aec08ff4 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-07-20 09:46:23 +02:00
Laurent Destailleur
f7e3af214d Better test 2026-07-20 09:45:24 +02:00
MDW
352b0ac6b4
Qual: Fix 'SqlInjection' notices (#39225)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:52:07 +02:00
MDW
6196491e1b
Qual: Fix 'SqlInjection' notices (#39224)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:51:54 +02:00
MDW
b51b38ef64
Qual: Fix 'SqlInjection' notices (#39223)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:51:42 +02:00
MDW
1df0531b43
Qual: Fix 'SqlInjection' notices (#39222)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:51:25 +02:00
MDW
7cc8ae1efb
Qual: Fix 'SqlInjection' notices (#39221)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:51:11 +02:00
MDW
1a8825d759
Qual: Fix 'SqlInjection' notices (#39220)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:51:00 +02:00
MDW
1dcd497c69
Qual: Fix 'SqlInjection' notices (#39219)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-20 02:50:44 +02:00
Ushindi Gedeon
2fb564d438
FIX accounting export: enhance file metadata return and secure access checks (#39218)
Co-authored-by: gedeonts <gedeontshobowa1@gmail.com>
2026-07-20 02:50:31 +02:00
Camile
fa5fe7ebf8
FIX|Fix #34947 PDF top margin breaks layout in multiple templates (#35919)
* Fix pdf top margin break layout

* Fix others pdf theme's top margin
2026-07-20 00:09:32 +02:00
マルコメ
db8babd39c
FIX #35786 Allow situation credit notes regardless of payment (#39207)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-07-19 17:36:10 +02:00
MDW
679c6eaf29
Qual: Fix SqlInjection notices in scripts (#39214) 2026-07-19 17:32:57 +02:00
MDW
5db08a3151
Qual: Fix 'SqlInjection' notices (#39213)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-19 17:32:14 +02:00
w3houde
cbe0335455
Fix #39143 store computed extrafields with object context (#39172)
When MAIN_STORE_COMPUTED_EXTRAFIELDS is enabled, insertExtraFields() and
updateExtraField() evaluated the computed formula without setting the global
$objectoffield to the current object, so formulas relying on
$objectoffield->array_options returned a wrong value (often 0) when stored,
unlike fetch_optionals() which already sets it.

The list template also always recomputed computed extrafields, but the raw
row available in a list has no object context, giving wrong display and wrong
totals. When MAIN_STORE_COMPUTED_EXTRAFIELDS is enabled the value stored in
database is now used instead.

Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
2026-07-19 16:22:57 +02:00
github-actions[bot]
f495b92d1f
PHPStan > Update baseline (#39193)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2026-07-19 16:17:31 +02:00
bomuux
4c903ef62a
FIX #37381 Cancelling shipping shouldn't remove its linked objects association (#39212)
* FIX #37381

* Fix #37381

Cancelling shipping shouldn't remove its linked objects association #37381
2026-07-19 15:58:14 +02:00
MDW
6dac0c7263
Qual: Fix 'SqlInjection' notices (#39203)
# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices
2026-07-19 15:53:14 +02:00