Commit graph

125721 commits

Author SHA1 Message Date
MDW
acea5c17dd
each is deprecated in PHP7.2 and removed in PHP8.0 (#26317)
See https://www.php.net/manual/en/function.each.php
2023-10-23 19:20:55 +02:00
PriteshJadhav132
ef1ccdf6b1
remove typo (#26316) 2023-10-23 19:19:36 +02:00
MDW
e036e32caa
qual Annotation/initialisation fixes (#26318) 2023-10-23 19:19:10 +02:00
sonikf
19012cad47
fix typo (#26321) 2023-10-23 19:17:34 +02:00
sonikf
99ee3523b0
fix errors in /fourn/facture/list.php (#26324) 2023-10-23 19:16:59 +02:00
Alexandre SPANGARO
ce28ab6b35
NEW #26312 Manage intermediate BIC - SQL Part (#26325) 2023-10-23 19:13:02 +02:00
William Mead
e9fda9653d
New perf & qual sections for PR template (#26328)
* NEW performance & code quality enhancements template sections

* Reordered commit keyword categories to match pull request template

* Adjusted instructions

---------

Co-authored-by: William Mead <william.mead@manchenumerique.fr>
2023-10-23 19:00:03 +02:00
William Mead
08f17dab0b
Qual logevents action switch (#26330)
* QUAL use switch case instead of if elseif statements for actions

* Deleted unnecessary action comments

* Added default case

* Added contributor details

---------

Co-authored-by: William Mead <william.mead@manchenumerique.fr>
2023-10-23 18:58:57 +02:00
Laurent Destailleur
551e3f5994 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-23 18:54:36 +02:00
Laurent Destailleur
b7de0baedd Fix phpunit 2023-10-23 18:54:16 +02:00
gdsoftdev
2d303b7c95
fix account code binding for supplier invoice (#26333) 2023-10-23 18:30:27 +02:00
atm-gauthier
f46482a72a
NEW Can switch product batch management to no management. (#21691)
* NEW : When an user unset the batch management of products, transformation of each batch stock mouvement in global stock mouvement

* FIX : Alert on deserialize product

* FIX : Correction of the trad

* Fixing style errors.

* FIX : PR returns

* FIX : using llx_product_batch table

* FIX : langs

* Fixing style errors.

* FIX : $value must be an absolute value

* FIX : init $inventorycode before while loop

* Fixing style errors.

* FIX : "Yes (unique serial number required)" choice must not be available on product edit if its current status batch is "Yes (lot required)"

* Fixing style errors.

* FIX : Just display a message when we change from batch to serial

* Fixing style errors.

* Update card.php

* Update card.php

* Update product.class.php

* Update product.class.php

---------

Co-authored-by: Adrien Raze <adrien.raze@atm-consulting.fr>
Co-authored-by: stickler-ci <support@stickler-ci.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-10-23 18:05:21 +02:00
Laurent Destailleur
5d6cf7cd51 dolPrintHTMLForAttribute remove \n 2023-10-23 13:15:01 +02:00
Laurent Destailleur
d8d3faa50f dolPrintHTMLForAttribute remove \n 2023-10-23 13:14:59 +02:00
Laurent Destailleur
0b11668660 FIX better management of <br> for dolGetFirstLine 2023-10-23 12:26:23 +02:00
Laurent Destailleur
f2e29d12de Fix travis 2023-10-21 18:11:07 +02:00
Laurent Destailleur
326bd356f5 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-21 18:03:40 +02:00
Laurent Destailleur
53adeb9be2 Try to fix travis 2023-10-21 18:01:32 +02:00
Laurent Destailleur
9275684ed1 Clean code 2023-10-21 17:58:31 +02:00
Alexandre SPANGARO
e6986446cb
NEW #22531 Expense report - Add two fields into export : Qty & Unit price (excl.) (#26309) 2023-10-21 16:29:37 +02:00
Alexandre Janniaux
9fe9eee18a
FIX|Fix some minor issues on Reception and add a new test for it (#26310)
* reception: reOpen: mirror $this->statut in $this->status

$this->statut is the deprecated variable, $this->status should also get
the correct value.

* reception: setDraft: mirror $this->statut in $this->status

$this->statut is the deprecated variable, $this->status should also get
the correct value.

* reception: add missing $weight field

Fix warning:

    Undefined property: Reception::$weight

* societe: add country_id field

* reception: use getDolGlobalInt when suitable

Using empty() implies that the value actually exists on the stdClass at
$conf->global, but it's not always the case. getDolGlobalInt will handle
this smoothly by checking first, which solves warnings like those:

    Undefined property: stdClass::$STOCK_CALCULATE_ON_RECEPTION

* ReceptionTest: add new test

The test checks the usual workflow of the Reception class, with, on the
one hand, the common CRUD operations:
 - create
 - fetch
 - update
 - delete

And on the other hand, the status handling for Reception:
 - valid: STATUS_DRAFT -> STATUS_VALID
 - setClosed: STATUS_VALID -> STATUS_CLOSED
 - reOpen: STATUS_CLOSED -> STATUS_VALID
 - setDraft: STATUS_VALID -> STATUS_DRAFT

The stocks lines are not tested yet, and the error cases, like any other
transition not described above, are not tested either. The permissions
for some of the operations are hardcoded for the test and there is no
failure check when the permission is not set yet.
2023-10-21 16:28:30 +02:00
MDW
24f8488b48
QUAL Force subclass MINVERSION (#26314)
* Define DoliDB::VERSIONMIN as mandatory constant in subclass

See https://stackoverflow.com/a/43134924/6378634

This also helps static tool checks

* fixup! Define DoliDB::VERSIONMIN as mandatory constant in subclass
2023-10-21 16:27:52 +02:00
Laurent Destailleur
25ace1d042 Debug v19 2023-10-21 16:23:58 +02:00
Laurent Destailleur
4b214b4100 Fix #yogosha18281 2023-10-21 02:39:27 +02:00
Laurent Destailleur
62c1baaa61 Clean param 2023-10-20 21:01:59 +02:00
Laurent Destailleur
777c6bffa5 Debug v19 2023-10-20 20:33:19 +02:00
Laurent Destailleur
b23dc8478c php 8.2 2023-10-20 17:46:26 +02:00
Laurent Destailleur
fad21985da Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-20 16:36:53 +02:00
Laurent Destailleur
cad186aed5 css 2023-10-20 16:36:28 +02:00
William Mead
a4dd36d967
NEW resource improvements - data structure (#26285)
* NEW improved resource data structure

* Added data structure v18-v19 migration

* Added null as default

* Revert "Added null as default"

This reverts commit c17d144800bc0bd740db77490db8790fc4996f56.

* Added null as default

* Added contributor details

* Renamed user_places to max_users

* Update llx_resource.sql

---------

Co-authored-by: William Mead <william.mead@manchenumerique.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-10-20 14:59:04 +02:00
Laurent Destailleur
ece2d0267f Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-20 14:57:25 +02:00
mc2contributor
60fa585a7f
CLOSE #23331 Add support for parent projects (#24856) 2023-10-20 14:33:39 +02:00
V-Py
9361b1269b
FIX #25143 Using default_values for extrafields by replacing GETPOSTISSET by GETPOST (#25233)
* FIX #25143 Using default_values for extrafields

* Update extrafields.class.php

correct the indentation error
2023-10-20 14:28:52 +02:00
MDW
19b1dd5a11
Fix misspelled @throw -> @throws (#26297)
Identified using phan, see #26262
2023-10-20 14:12:42 +02:00
Laurent Destailleur
ba04ba4f0e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-20 13:08:51 +02:00
William Mead
b0a7332e8f
FIX intervention closed agenda action message (#26294)
Co-authored-by: William Mead <william.mead@manchenumerique.fr>
2023-10-20 12:59:48 +02:00
Laurent Destailleur
65f78b6e86 Close #26293 manually to avoid duplicate menu statistics 2023-10-20 12:59:12 +02:00
Laurent Destailleur
455fb4417a Look and feel v19 2023-10-20 12:57:58 +02:00
Pascal Hubrecht
0628dd057d
FIX #26291 (#26292) 2023-10-20 12:53:03 +02:00
AmazingBeu
bc528fed67
fix SQL syntax error introduced in 9861b50 (#26289) 2023-10-20 12:52:36 +02:00
Rikard Bosnjakovic
cebd3f831c
Update list.php (#26287)
* Update list.php

Add the Description column in the list of possible columns to select from when vieweing Products.

* Update list.php

Spaces -> tabs
2023-10-20 12:51:05 +02:00
Laurent Destailleur
3a5f36cc4a Removed dead code 2023-10-20 11:34:36 +02:00
Laurent Destailleur
466c72c80f Fix warning 2023-10-20 11:30:05 +02:00
Laurent Destailleur
8ef60a311e Fix missing property 2023-10-20 11:25:10 +02:00
Laurent Destailleur
76c00767ad Fix typo class name 2023-10-20 11:22:36 +02:00
MDW
706d0f6053
Fix __METHOD__ usage outside class-method (#26286) 2023-10-20 11:20:02 +02:00
MDW
6077ad2130
Fix Supplier_Proposal->SupplierProposal (detected with Phan) (#26282) 2023-10-20 10:55:15 +02:00
Florent Poinsaut
82fdfb03ca
Use fetch_project method in email (#26284) 2023-10-20 10:53:14 +02:00
Rémi Champlon
654d9ac635
FIX : export separator config with multientity (#26253)
* fix export separator condig with multi entity

* Revert "fix export separator condig with multi entity"

This reverts commit 69042260ee525b68a226d82cca1cfc1009b6ac53.

* update dolibarr_set_const

---------

Co-authored-by: Rémi Champlon <remi.champlon@vold.lu>
2023-10-20 10:51:23 +02:00
Laurent Destailleur
e1bf377f20 QUAL: Removed deprecated field remise, remise_percent, remise_absolute 2023-10-20 10:47:08 +02:00