Commit graph

130866 commits

Author SHA1 Message Date
MDW
79adb60cf5
Qual: Add instanceof tests to help static typing analysis (#28696)
# Qual: Add instanceof tests to help static typing analysis

Added instanceof tests to help identify that properties exist.
2024-03-07 23:09:25 +01:00
Anthony Berton
ff03f86a50
NEW - See the documents of my subordinates (#28318)
* NEW - See the documents of my subordinates

* cop

* Rewriting

* up

* ok

* FIX - Restriction on sale representative

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 22:47:29 +01:00
Frédéric FRANCE
3035a7bc7f
fix phpstan (#28695)
* fix phpstan

* fix typo

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-07 22:13:09 +01:00
Laurent Destailleur
7f277e9578 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 22:09:31 +01:00
Laurent Destailleur
ca297a751f Clean internal pahn warnings 2024-03-07 22:08:58 +01:00
Laurent Destailleur
970545b218 Doc 2024-03-07 21:49:45 +01:00
Frédéric FRANCE
c2379bfdf5
fix phpstan (#28694)
* fix phpstan

* fix typo

* fix phpstan
2024-03-07 21:39:29 +01:00
John BOTELLA
7b5982de5b
NEW : Factoring and Fix external module elementType limit - Part 02 (#28666)
* Fix element type size

* Factoring getElementType

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:32:41 +01:00
John BOTELLA
0dd7aad04b
Fix element type size (#28664) 2024-03-07 20:27:51 +01:00
Rikard Bosnjakovic
901fd65ad9
Fix #20209 (#28692)
When using multiple languages Dolibarr sometimes switches languages depending on settings. By not loading the "main" file, the proper date formats will not be used and this leads to inconsistency.
2024-03-07 20:24:37 +01:00
thibdrev
e2026a1c14
qual: phan for functions.lib.php (#28654)
6 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 5 ($objcon) is null of type null but \show_actions_messaging() takes \Contact|string (no real type) defined at htdocs/core/lib/functions.lib.php:13081
2024-03-07 20:23:45 +01:00
thibdrev
07b2850c27
qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28689)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array of property Paiement::$multicurrency_tx is not covariant with PHPDoc type array|float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array of property Paiement::$multicurrency_code is not covariant with PHPDoc type array|string of overridden property CommonObject::$multicurrency_code.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:22:51 +01:00
thibdrev
4b47868cea
qual: phpstan for htdocs/accountancy/class/accountingjournal.class.php (#28690)
htdocs/accountancy/class/accountingjournal.class.php	82	PHPDoc type array of property AccountingJournal::$lines is not covariant with PHPDoc type array of overridden property CommonObject::$lines.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:17:51 +01:00
MDW
63b2fff4a7
Qual: Ignore false positive for suspicious param positions (#28693)
* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
2024-03-07 20:16:48 +01:00
Frédéric FRANCE
eb12fe6545
fix create from order (#28660) 2024-03-07 19:11:43 +01:00
Laurent Destailleur
b4b83c10b4 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 19:10:53 +01:00
Laurent Destailleur
6e2f1d350a Fix position of parameter 2024-03-07 19:10:27 +01:00
Laurent Destailleur
a63d7e0802 Fix regression 2024-03-07 19:06:08 +01:00
Jon Bendtsen
b55804841f
using note_public since note_private is not working (#28675)
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2024-03-07 19:01:38 +01:00
thibdrev
d79b3ba8ec
qual: phpstan for htdocs/expedition/class/expedition.class.php (#28686)
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (CommonObject|string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (CommonObject|string) does not accept null.
2024-03-07 18:57:38 +01:00
MDW
c6333c7782
Fix: Missing parameter (#28691)
# Fix: Missing parameter

dol_print_error was missing db parameter
2024-03-07 18:57:18 +01:00
Laurent Destailleur
a72e1f08c1 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

Conflicts:
	htdocs/fourn/class/fournisseur.commande.class.php
2024-03-07 18:54:59 +01:00
Laurent Destailleur
f396bf1218 Fix compatibility 2024-03-07 18:53:21 +01:00
Laurent Destailleur
5f7192f475 Fix signature of delete method 2024-03-07 18:51:20 +01:00
Frédéric FRANCE
9b59445e39
fix unknown $user (#28687)
* fix unknown $user

* fix @param

* fix @param

* fix @param

* fix @param
2024-03-07 18:48:50 +01:00
Laurent Destailleur
61e69b352b Doc 2024-03-07 18:44:55 +01:00
thibdrev
c66f7d6345
qual: phpstan for htdocs/comm/action/class/ical.class.php (#28685)
htdocs/comm/action/class/ical.class.php	146	Property ICal::$file_text (string) does not accept null.
htdocs/comm/action/class/ical.class.php	171	Property ICal::$file_text (string) does not accept array|false.
2024-03-07 18:20:18 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
William Mead
f1c7b5729f
Fix resource list (#28661)
* Move sql SELECT request to list

* Refactored list. Added mass actions. Added contributor details.

* Added dolresource delete

* Cleaned code
2024-03-07 17:01:36 +01:00
Sylvain Legrand
27f88b3ad5
Fix error using MAIN_FILL_SERVICE_DATES_FROM_LAST_SERVICE_LINE (#28662)
With PHP 8.1 an error occurs when editing the first line of a document
2024-03-07 16:57:53 +01:00
Frédéric FRANCE
14ffa142aa
fix precommit and clean code (#28651)
* fix precommit

* fix precommit

* fix missing include

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* clean code

* clean code
2024-03-07 16:57:29 +01:00
thibdrev
b9c843c086
qual: phan for functions.lib.php (#28653)
* qual: phan for functions.lib.php

54 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 3 ($exclude) is null of type null but \getCommonSubstitutionArray() takes array (no real type) defined at htdocs/core/lib/functions.lib.php:8285

* phpcs
2024-03-07 16:55:12 +01:00
thibdrev
5659ba8de3
qual: phan for accountingaccount.class.php (#28669)
htdocs/accountancy/admin/productaccount.php	196	TypeError PhanTypeMismatchArgumentProbablyReal Argument 2 ($account_number) is null of type null but \AccountingAccount::fetch() takes string (no real type) defined at htdocs/accountancy/class/accountingaccount.class.php:182 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:50:42 +01:00
HENRY Florian
4fcbdf15ab
fix: better inner join than comma for hook printFieldListFrom after (#28681)
* better inner jion than comme for hook after

* better inner jion than comme for hook after

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:49:41 +01:00
Rikard Bosnjakovic
1aa0f8227f
Update card.php (#28679)
Fix #25130

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:43:04 +01:00
thibdrev
af9704acdc
qual: phpdoc for htdocs/core/lib/pdf.lib.php (#28671) 2024-03-07 16:41:39 +01:00
Laurent Destailleur
56a8c752cf Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 16:38:55 +01:00
Laurent Destailleur
5e9dfc8090 Fix phan 2024-03-07 16:38:02 +01:00
MDW
38e69184d1
Fix typing hints (#28676) 2024-03-07 16:04:39 +01:00
thibdrev
fcfc70e02a
qual: phpstan for htdocs/loan/class/loan.class.php (#28673)
htdocs/loan/class/loan.class.php	113	PHPDoc type int of property Loan::$totalpaid is not covariant with PHPDoc type float of overridden property CommonObject::$totalpaid.
2024-03-07 16:02:57 +01:00
thibdrev
18cc09fae6
qual: phan for htdocs/core/lib/ajax.lib.php (#28672)
29 entries for:

Argument 3 ($entity) is null of type null but \ajax_constantonoff() takes int (no real type) defined at htdocs/core/lib/ajax.lib.php:645
2024-03-07 16:02:14 +01:00
Laurent Destailleur
f00d3ff6dd Fix route not complete 2024-03-07 14:57:41 +01:00
Laurent Destailleur
21ef877772 Remove not used email layout 2024-03-07 11:07:28 +01:00
Laurent Destailleur
8bc7027ced Fix help on status of menu condition 2024-03-06 17:17:24 +01:00
Laurent Destailleur
c0ee90aa7d Exclude require, include into dol_eval 2024-03-06 17:13:05 +01:00
Laurent Destailleur
7866ee472b QUAL Clean code around dol_eval use 2024-03-06 17:07:24 +01:00
Laurent Destailleur
f9a2c8ec5d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-06 15:08:21 +01:00
Laurent Destailleur
f1aa29507a Fix sec more complete list of forbidden function 2024-03-06 15:01:25 +01:00
Laurent Destailleur
1a9fa740a5 Fix quote 2024-03-06 13:32:15 +01:00
Laurent Destailleur
8a2578d742 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-06 01:58:54 +01:00