Commit graph

133486 commits

Author SHA1 Message Date
thibdrev
c0d8da34d4
qual: phpdoc for htdocs/core/class/utils.class.php 2024-01-29 22:36:23 +01:00
thibdrev
3da8970a09
qual: phpdoc for htdocs/core/class/cstate.class.php 2024-01-29 22:20:18 +01:00
thibdrev
60a2c30f87
qual: phpdoc for htdocs/core/class/cregion.class.php 2024-01-29 22:05:05 +01:00
thibdrev
b4ad9045da
qual: phpstan for htdocs/societe/paymentmodes.php
htdocs/societe/paymentmodes.php	170	Property Account::$courant (int) does not accept array|string.
htdocs/societe/paymentmodes.php	171	Property Account::$clos (int) does not accept array|string.
htdocs/societe/paymentmodes.php	300	Property Account::$courant (int) does not accept array|string.
htdocs/societe/paymentmodes.php	301	Property Account::$clos (int) does not accept array|string.
2024-01-29 21:22:28 +01:00
thibdrev
0d21087e47
qual: phpstan for htdocs/public/members/new.php
htdocs/public/members/new.php	294	Property CommonObject::$country_id (int) does not accept string.
htdocs/public/members/new.php	295	Property CommonObject::$state_id (int) does not accept array|string.
htdocs/public/members/new.php	296	Property Adherent::$typeid (int) does not accept string.
2024-01-29 19:16:18 +01:00
thibdrev
b8314209ce
qual: phspstan for htdocs/public/eventorganization/attendee_new.php
htdocs/public/eventorganization/attendee_new.php	468	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/eventorganization/attendee_new.php	469	Property CommonObject::$state_id (int) does not accept array|string.
2024-01-29 19:13:04 +01:00
thibdrev
473980a022
qual: phpstan for htdocs/public/company/new.php
htdocs/public/company/new.php	222	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/company/new.php	232	Property Societe::$code_client (string) does not accept int.
2024-01-29 19:12:02 +01:00
thibdrev
8e1dc0e450
qual: phpstan for htdocs/public/bookcal/index.php
htdocs/public/bookcal/index.php	239	Property ActionComm::$datep (int) does not accept array|string.
htdocs/public/bookcal/index.php	243	Property ActionComm::$fk_bookcal_calendar (int) does not accept array|string.
2024-01-29 19:09:34 +01:00
thibdrev
9862210681
qual: phpstan for htdocs/projet/tasks/task.php
htdocs/projet/tasks/task.php	114	Property Task::$budget_amount (float) does not accept string.
2024-01-29 19:06:19 +01:00
thibdrev
70b9a06986
qual: phpstan for htdocs/projet/tasks/stats/index.php
htdocs/projet/tasks/stats/index.php	83	Property Stats::$year (int) does not accept array|string.
htdocs/projet/tasks/stats/index.php	125	Property Stats::$year (int) does not accept array|string.
2024-01-29 19:04:06 +01:00
thibdrev
b19d230a18
qual: phpstan for htdocs/projet/tasks.php
htdocs/projet/tasks.php	345	Property CommonObject::$fk_project (int) does not accept array|string.
htdocs/projet/tasks.php	356	Property Task::$budget_amount (float) does not accept array|string.
2024-01-29 19:01:18 +01:00
MDW
044d342956 Fix: LABEL is required on the db classes.
# Fix: LABEL is required on the db classes.

Define const in parent type so that it is required in the subclasses.
2024-01-29 18:56:17 +01:00
MDW
f0cb078378 Qual: Fix typing in files.lib
Fix several typing hints in files.lib .
Fixed some initialisers.
Simplified some expressions.
Cast some `return $result` statements  (could be null).
2024-01-29 18:34:28 +01:00
thibdrev
2fe5347d66
qual: phpstan for htdocs/core/lib/functions.lib.php
htdocs/core/lib/functions.lib.php	128	Function getMultidirOutput() should return string|void but returns null.
htdocs/core/lib/functions.lib.php	9889	Function getLanguageCodeFromCountryCode() should return string but returns null.
htdocs/core/lib/functions.lib.php	10105	Function getLanguageCodeFromCountryCode() should return string but returns null.
htdocs/core/lib/functions.lib.php	11372	Function roundUpToNextMultiple() should return int but returns float.
2024-01-29 18:22:54 +01:00
thibdrev
b53c7b5eb5
qual: phpstan for htdocs/expedition/dispatch.php
htdocs/expedition/dispatch.php	216	Property ExpeditionLigne::$qty (float) does not accept string.
htdocs/expedition/dispatch.php	217	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/dispatch.php	274	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/dispatch.php	275	Property ExpeditionLigne::$fk_origin_line (int) does not accept array|string.
htdocs/expedition/dispatch.php	276	Property ExpeditionLigne::$qty (float) does not accept string.
2024-01-29 17:43:40 +01:00
thibdrev
d13d931e2a
qual: phpstan for htdocs/expedition/card.php
htdocs/expedition/card.php	614	Property CommonObjectLine::$id (int) does not accept array|string.
htdocs/expedition/card.php	760	Property CommonObjectLine::$id (int) does not accept array|string.
htdocs/expedition/card.php	761	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/card.php	762	Property ExpeditionLigne::$qty (float) does not accept array|string.
htdocs/expedition/card.php	773	Property CommonObjectLine::$id (int) does not accept array|string.
htdocs/expedition/card.php	774	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/card.php	775	Property ExpeditionLigne::$qty (float) does not accept array|string.
htdocs/expedition/card.php	791	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/card.php	792	Property ExpeditionLigne::$qty (float) does not accept array|string.
htdocs/expedition/card.php	806	Property CommonObjectLine::$id (int) does not accept array|string.
htdocs/expedition/card.php	807	Property ExpeditionLigne::$qty (float) does not accept array|string.
htdocs/expedition/card.php	820	Property CommonObjectLine::$id (int) does not accept array|string.
htdocs/expedition/card.php	821	Property ExpeditionLigne::$qty (float) does not accept array|string.
2024-01-29 17:39:19 +01:00
Lamrani Abdel
586230adbe add image for boxes 2024-01-29 17:31:23 +01:00
Laurent Destailleur
22b42d8b81
Merge pull request #27853 from thibdrev/patch-4
qual: phpstan for htdocs/accountancy/class/bookkeeping.class.php
2024-01-29 16:41:35 +01:00
William Mead
d800444f50
Merge branch 'develop' into qual-societe-phpstan-lvl3 2024-01-29 16:36:27 +01:00
William Mead
e206a9da40
Merge branch 'develop' into new-export-order-client-code 2024-01-29 16:36:19 +01:00
Lamrani Abdel
c92b8709f2 add script for generate email template 2024-01-29 16:17:49 +01:00
Lamrani Abdel
fc9e833318 add script for generate email template 2024-01-29 16:17:42 +01:00
Lamrani Abdel
17ce61b82f fix name in input message 2024-01-29 16:03:11 +01:00
Lamrani Abdel
3cc15d4163 New display for template email in boxes 2024-01-29 15:38:13 +01:00
Laurent Destailleur
f0392a0caf Fix link with entity 2024-01-29 15:03:46 +01:00
MDW
49b21b9cbe Fix: Typing hint for hasRights parameter.
# Fix: Typing hint for hasRights parameter.

Correct typing hint for static tools
2024-01-29 14:05:25 +01:00
Laurent Destailleur
1b58a37cf5 Fix label of prospect 2024-01-29 13:41:51 +01:00
Laurent Destailleur
c934340580 Doc 2024-01-29 13:12:06 +01:00
Laurent Destailleur
40794458d2 Comment 2024-01-29 13:00:33 +01:00
Laurent Destailleur
2f4d00f58c Log 2024-01-29 11:44:47 +01:00
Laurent Destailleur
fd0495e1c7 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-29 11:41:22 +01:00
Laurent Destailleur
0815df6bdf Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-29 11:40:57 +01:00
Laurent Destailleur
2840a88e6d Fix warnings 2024-01-29 11:37:17 +01:00
MDW
ea9f9c5bee Qual: Make phpcs messages in pre-commit extractable.
# Qual: Make phpcs messages in pre-commit extractable.

To make messages extractable for annotation when phpcs is run in pre-commit,
change the report style to emacs.
Also had to update logToCs.py.

Using checkstyle directly as an option would not make the output readable
when pre-commit is run from the CLI, on commit.
2024-01-29 11:33:28 +01:00
Laurent Destailleur
eab0093750 Fix var not defined 2024-01-29 11:24:37 +01:00
Laurent Destailleur
a4e2d6ea42 Fix doc 2024-01-29 11:06:03 +01:00
Laurent Destailleur
60da05679b Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-29 10:30:19 +01:00
Laurent Destailleur
70ab796c23 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-29 10:30:01 +01:00
Laurent Destailleur
6b5aba1960 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-01-29 10:29:40 +01:00
William Mead
a615672525 Added client code to order export 2024-01-29 09:23:11 +01:00
William Mead
b800316f7e
Merge branch 'develop' into qual-societe-phpstan-lvl3 2024-01-29 09:00:27 +01:00
thibdrev
eda4b0cd85
qual: phpstan for htdocs/accountancy/class/bookkeeping.class.php
htdocs/accountancy/class/bookkeeping.class.php	1833	Method BookKeeping::getNextNumMvt() should return int but returns string.
htdocs/accountancy/class/bookkeeping.class.php	2268	Method BookKeeping::getCanModifyBookkeepingSQL() should return string but returns null.
htdocs/accountancy/class/bookkeeping.class.php	2624	Method BookKeeping::accountingResult() should return string but returns (float|int).
htdocs/accountancy/class/bookkeeping.class.php	2764	Property BookKeeping::$date_lim_reglement (int) does not accept string.
htdocs/accountancy/class/bookkeeping.class.php	2811	Property BookKeeping::$date_lim_reglement (int) does not accept string.
2024-01-29 08:55:26 +01:00
Laurent Destailleur
6313c57ea1
Merge pull request #27839 from thibdrev/patch-8
qual: phpstan for htdocs/holiday/card_group.php
2024-01-29 02:01:24 +01:00
Laurent Destailleur
c3430646c8
Merge branch 'develop' into patch-8 2024-01-29 02:00:59 +01:00
vmaury
f033cc455f Fix : random bug when attaching file to email : no file attached 2024-01-29 01:58:07 +01:00
Laurent Destailleur
c57e16dd05
Merge pull request #27845 from vmaury/Fix_random_bug_when_attach_file_to_a_mail
Fix : random bug when attaching file to email : no file attached
2024-01-29 01:57:28 +01:00
Laurent Destailleur
a6e4ce0a1b Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-29 01:53:35 +01:00
Laurent Destailleur
ee810d65da Close #27842 2024-01-29 01:52:43 +01:00
Laurent Destailleur
df9349a866 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-29 01:27:25 +01:00
Laurent Destailleur
ecbfeaddc5 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-29 01:26:55 +01:00