Commit graph

133486 commits

Author SHA1 Message Date
Laurent Destailleur
a48a399b31 FIX Add a limit in nb of element in view event/message 2024-01-31 02:47:49 +01:00
Laurent Destailleur
280a7a24e4 Rename page 2024-01-31 01:56:24 +01:00
MDW
485dec120f Fix: Always return value as suggested
# Fix: Always return value as suggested

Always return a value in doAction (as per PHPDoc type hint).
2024-01-31 01:42:15 +01:00
MDW
d8784f1294 Fix: Always return value in get_element_list
# Fix: Always return value in get_element_list

get_element_list did not always return a value.  Fixed.
2024-01-31 01:28:25 +01:00
MDW
5655eb387c Qual: Fix annotation
# Qual: Fix annotation

The typing hint was incorrect, corrected.
2024-01-31 00:41:06 +01:00
Laurent Destailleur
bb7e68dbaa
Merge pull request #27901 from thibdrev/patch-4
qual: phpstan - Property CommonDict::$active (int) does not accept string.
2024-01-30 23:48:35 +01:00
Laurent Destailleur
d6fea0c040
Merge pull request #27905 from thibdrev/patch-1
qual: phpstan for htdocs/ecm/class/ecmfiles.class.php
2024-01-30 23:48:04 +01:00
Laurent Destailleur
356bb80676
Merge pull request #27903 from rycks/14.0_fix_datehour_to_datetime_comment
fix comment about datehour -> datetime
2024-01-30 23:47:44 +01:00
Laurent Destailleur
0b7ef8812a
Merge pull request #27909 from thibdrev/patch-5
qual: phpstan for htdocs/expedition/card.php
2024-01-30 23:40:16 +01:00
Laurent Destailleur
cf472303be
Merge pull request #27913 from thibdrev/patch-9
qual: phpstan for htdocs/cron/class/cronjob.class.php
2024-01-30 23:39:41 +01:00
Frédéric FRANCE
25557e3dc2
fix phpstan 2024-01-30 23:03:43 +01:00
thibdrev
3df2d3543f
qual: phpstan for htdocs/cron/class/cronjob.class.php
htdocs/cron/class/cronjob.class.php	266	Property Cronjob::$frequency (int) does not accept string.
htdocs/cron/class/cronjob.class.php	269	Property Cronjob::$status (int) does not accept string.
htdocs/cron/class/cronjob.class.php	713	Property Cronjob::$frequency (int) does not accept string.
htdocs/cron/class/cronjob.class.php	716	Property Cronjob::$status (int) does not accept string.
htdocs/cron/class/cronjob.class.php	722	Property Cronjob::$nbrun (int) does not accept string.
htdocs/cron/class/cronjob.class.php	948	Property CommonObject::$ref (string) does not accept int.
htdocs/cron/class/cronjob.class.php	970	Property Cronjob::$frequency (int) does not accept string.
htdocs/cron/class/cronjob.class.php	978	Property Cronjob::$nbrun (int) does not accept string.
htdocs/cron/class/cronjob.class.php	1232	Property Cronjob::$lastresult (string) does not accept int.
htdocs/cron/class/cronjob.class.php	1248	Property Cronjob::$lastresult (string) does not accept int.
htdocs/cron/class/cronjob.class.php	1260	Property Cronjob::$lastresult (string) does not accept int.
htdocs/cron/class/cronjob.class.php	1268	Property Cronjob::$lastresult (string) does not accept int.
htdocs/cron/class/cronjob.class.php	1283	Property Cronjob::$lastresult (string) does not accept int.
2024-01-30 22:49:39 +01:00
thibdrev
3e023bffe9
qual: phpstan for htdocs/expensereport/class/paymentexpensereport.class.php
htdocs/expensereport/class/paymentexpensereport.class.php	137	Property PaymentExpenseReport::$fk_expensereport (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	143	Property PaymentExpenseReport::$fk_typepayment (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	293	Property PaymentExpenseReport::$fk_expensereport (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	299	Property PaymentExpenseReport::$fk_typepayment (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	308	Property PaymentExpenseReport::$fk_bank (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	311	Property PaymentExpenseReport::$fk_user_creat (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	314	Property PaymentExpenseReport::$fk_user_modif (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	503	Property PaymentExpenseReport::$fk_expensereport (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	508	Property PaymentExpenseReport::$fk_typepayment (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	511	Property PaymentExpenseReport::$fk_bank (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	512	Property PaymentExpenseReport::$fk_user_creat (int) does not accept string.
htdocs/expensereport/class/paymentexpensereport.class.php	513	Property PaymentExpenseReport::$fk_user_modif (int) does not accept string.
2024-01-30 22:36:41 +01:00
MDW
e8ed4d4507 Qual: Ignore phpcs warnings (pre-commit)
# Qual: Ignore php-cs warnings (pre-commit)

I fixed the pre-commit hook for pre-commit so that
phpcs warnings are ignored
2024-01-30 22:31:50 +01:00
thibdrev
250b3fb6c8
qual: phpstan for htdocs/expensereport/class/expensereportstats.class.php
htdocs/expensereport/class/expensereportstats.class.php	113	Parameter #1 $year (string) of method ExpenseReportStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
2024-01-30 22:31:45 +01:00
thibdrev
c10edc2396
qual: phpstan for htdocs/expensereport/class/expensereport.class.php
htdocs/expensereport/class/expensereport.class.php	502	Property ExpenseReport::$fk_user_valid (int) does not accept string.
htdocs/expensereport/class/expensereport.class.php	1692	Method ExpenseReport::getNextNumRef() should return string but returns int.
htdocs/expensereport/class/expensereport.class.php	1696	Method ExpenseReport::getNextNumRef() should return string but returns int.
2024-01-30 22:24:24 +01:00
Laurent Destailleur
423837a750 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-30 22:20:43 +01:00
thibdrev
e3ef3996db
qual: phpstan for htdocs/expedition/card.php
htdocs/expedition/card.php	761	Property ExpeditionLigne::$entrepot_id (int) does not accept array|string.
htdocs/expedition/card.php	762	Property ExpeditionLigne::$qty (float) does not accept array|string.
2024-01-30 22:19:43 +01:00
Laurent Destailleur
79d9cab115 Include instruction to fix character set of a column 2024-01-30 22:19:41 +01:00
Marc de Lima Lucio
0d2d607c48 FIX: force https: infinite redirection in case the access is already secure 2024-01-30 22:16:38 +01:00
thibdrev
cc94913b65
typo 2024-01-30 22:16:27 +01:00
thibdrev
038bd00eaf
qual: phpstan for htdocs/emailcollector/lib/emailcollector.lib.php
htdocs/emailcollector/lib/emailcollector.lib.php	178	Function saveAttachment() should return string but returns int.
2024-01-30 22:12:35 +01:00
thibdrev
f1462d85b7
qual: phpstan for htdocs/emailcollector/class/emailcollector.class.php
htdocs/emailcollector/class/emailcollector.class.php	844	Method EmailCollector::getEncodedUtf7() should return string but returns false.
htdocs/emailcollector/class/emailcollector.class.php	2896	Property Project::$date_end (int) does not accept string.
2024-01-30 22:09:08 +01:00
thibdrev
009ab57586
qual: phpstan for htdocs/ecm/class/ecmfiles.class.php
htdocs/ecm/class/ecmfiles.class.php	665	Property EcmFiles::$entity (int) does not accept string.
htdocs/ecm/class/ecmfiles.class.php	693	Property EcmFiles::$fk_user_m (int) does not accept string.
htdocs/ecm/class/ecmfiles.class.php	982	Property EcmFiles::$fk_user_m (int) does not accept string.
2024-01-30 22:05:15 +01:00
Eric Seigne
1f21e1a945 fix #27883 : zero could be a value stored 2024-01-30 21:42:57 +01:00
Eric Seigne
8d9ddf4a51 fix comment about datehour -> datetime 2024-01-30 21:35:19 +01:00
thibdrev
3d5fd010b4
Update cgenericdic.class.php
htdocs/core/class/cgenericdic.class.php	100	Property CGenericDic::$active (int) does not accept string.
htdocs/core/class/cgenericdic.class.php	324	Property CGenericDic::$active (int) does not accept string.
2024-01-30 21:25:01 +01:00
thibdrev
7546063a8e
Update ccountry.class.php
htdocs/core/class/ccountry.class.php	76	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/ccountry.class.php	198	Property CommonDict::$active (int) does not accept string.
2024-01-30 21:22:21 +01:00
Laurent Destailleur
ebf5fd261b
Merge pull request #27900 from thibdrev/patch-3
qual: phpstan for htdocs/compta/tva/class/tva.class.php
2024-01-30 21:15:48 +01:00
thibdrev
83e90c65c2
qual: phpstan for htdocs/compta/tva/class/tva.class.php
htdocs/compta/tva/class/tva.class.php	88	PHPDoc type int|string of property Tva::$totalpaid is not covariant with PHPDoc type float of overridden property CommonObject::$totalpaid.
htdocs/compta/tva/class/tva.class.php	429	Property Tva::$fk_bank (int) does not accept string.
htdocs/compta/tva/class/tva.class.php	430	Property Tva::$fk_user_creat (int) does not accept string.
htdocs/compta/tva/class/tva.class.php	431	Property Tva::$fk_user_modif (int) does not accept string.
htdocs/compta/tva/class/tva.class.php	579	Property Tva::$datec (DateTime) does not accept int.
2024-01-30 21:12:19 +01:00
Laurent Destailleur
eafe3deeb3
Merge pull request #27899 from thibdrev/patch-2
qual: phpstan - Property CommonDict::$active (int) does not accept string.
2024-01-30 21:05:25 +01:00
Laurent Destailleur
8d68091d3a
Merge pull request #27895 from thibdrev/patch-1
qual: roundUpToNextMultiple()
2024-01-30 21:04:28 +01:00
thibdrev
0d395aa082
Update cunits.class.php
htdocs/core/class/cunits.class.php	88	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/cunits.class.php	91	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/cunits.class.php	321	Property CommonDict::$active (int) does not accept string.
2024-01-30 20:31:05 +01:00
thibdrev
fa21289257
Update ctyperesource.class.php
htdocs/core/class/ctyperesource.class.php	83	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/ctyperesource.class.php	280	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/ctyperesource.class.php	436	Property CommonDict::$active (int) does not accept string.
2024-01-30 20:27:07 +01:00
thibdrev
aa3085d7ad
Update ctypent.class.php
htdocs/core/class/ctypent.class.php	67	Property CommonDict::$id (int) does not accept string.
htdocs/core/class/ctypent.class.php	76	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/ctypent.class.php	196	Property CommonDict::$activ
2024-01-30 20:25:46 +01:00
thibdrev
5df55a0c34
Update cstate.class.php
htdocs/core/class/cstate.class.php	87	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/cstate.class.php	197	Property CommonDict::$active (int) does not accept string.
2024-01-30 20:22:55 +01:00
thibdrev
84e0909310
Update cregion.class.php
htdocs/core/class/cregion.class.php	97	Property CommonDict::$active (int) does not accept string.
htdocs/core/class/cregion.class.php	227	Property CommonDict::$active (int) does not accept string.
2024-01-30 20:20:52 +01:00
Laurent Destailleur
919eb2fcf7
Merge pull request #27802 from W1W1-M/qual-societe-phpstan-lvl3
Qual phpstan societe class
2024-01-30 18:44:56 +01:00
Laurent Destailleur
3e40f74463
Merge pull request #27897 from thibdrev/patch-2
qual: Update website.class.php - function replaceLineUsingNum()
2024-01-30 18:11:04 +01:00
Laurent Destailleur
bd1d7141e2
Merge pull request #27893 from thibdrev/patch-14
qual: phpdoc for htdocs/core/class/utils.class.php
2024-01-30 18:09:24 +01:00
Laurent Destailleur
4c5ac44621
Merge pull request #27896 from altairisfr/takeprice
FIX : [TAKEPOS] display prices with or without taxes depending on setup (TAKEPOS_CHANGE_PRICE_HT)
2024-01-30 18:08:54 +01:00
thibdrev
f83e18f53b
qual: Update website.class.php - function replaceLineUsingNum()
function_exists('posix_getpwuid') is checked twice but not function_exists('posix_geteuid')
2024-01-30 18:06:11 +01:00
Laurent Destailleur
b8b60ac896
Merge pull request #27888 from lamrani002/setTemplateForEachModel
NEW get html template exemple for each model
2024-01-30 18:00:42 +01:00
Laurent Destailleur
68471a1c7e
Merge pull request #27894 from thibdrev/patch-6
qual: phpstan for htdocs/projet/tasks/task.php
2024-01-30 17:58:34 +01:00
Christophe Battarel
fa104b6613 automatic fixes 2024-01-30 17:55:13 +01:00
thibdrev
bb2ca75c46
qual: Update FunctionsLibTest.php - add unit test for roundUpToNextMultiple()
see remarks from PR 27865
2024-01-30 17:49:58 +01:00
thibdrev
5ebc760e04
qual Update functions.lib.php - clearer return for roundUpToNextMultiple() 2024-01-30 17:36:55 +01:00
thibdrev
df60be8abc
phpcs 2024-01-30 17:34:40 +01:00
thibdrev
206f359c53
Merge branch 'Dolibarr:develop' into patch-6 2024-01-30 17:31:06 +01:00
thibdrev
91bc9dc057
Merge branch 'Dolibarr:develop' into patch-14 2024-01-30 17:29:40 +01:00