Commit graph

133486 commits

Author SHA1 Message Date
Frédéric FRANCE
f4f96de45b
fix address on several lines (#28227) 2024-02-18 15:26:14 +01:00
Frédéric FRANCE
9abd079625
add missing parameter for tooltip user.class.php (#28231) 2024-02-18 15:25:46 +01:00
Frédéric FRANCE
887351b0d8
fix typo (#28230)
* fix typo

* Update README.md
2024-02-18 15:25:19 +01:00
Frédéric FRANCE
0114f6fc99
Fix warnings in checkVatPopup.php (#28232) 2024-02-18 15:25:07 +01:00
Frédéric FRANCE
144ed48fcb
fix warning in list_print_total.tpl.php (#28233)
* fix warning in list_print_total.tpl.php

* Update list.php
2024-02-18 15:24:14 +01:00
Frédéric FRANCE
c2eeeabb4a
fix field too short (#28238) 2024-02-18 15:17:02 +01:00
Laurent Destailleur
f48ab54513 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 15:16:22 +01:00
Laurent Destailleur
9b4d53638f Fix html 2024-02-18 15:15:10 +01:00
Laurent Destailleur
44f718232c Doc 2024-02-18 15:13:56 +01:00
MDW
9387616e7f
Qual: Improve rendering of phpstan technical debt table in apstats. (#28236)
* Qual: Improve rendering of phpstan technical debt table in apstats.

# Qual: Improve rendering of phpstan technical debt table in apstats.

Apply the DataTable rendering to the phpstan technical debt (same as applied to phan).

* Fix spelling

* Qual: Harden apstats output.

# Qual: Harden apstats output.

Escaping output for phpstan, and more escaping for phan.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:13:43 +01:00
MDW
f5dd7d7c93
FIX: Fix unneeded access outside open_basedir when looking for modules (#28237)
* FIX: Fix unneeded access outside open_basedir when looking for modules

# FIX: Fix unneeded access outside open_basedir when looking for modules

Change the order in which the if conditions are tested so that an is_dir("dir/..") is avoided
by first testing if the subpath starts with a dot.

Also changed uppercased the first 3 letters of the file before comparing to CVS.

Finally, improved the typing hint and documentation.

The PHPUNIT test failed like this:

```
35) ExportTest::testExportModulesDatasets
is_dir(): open_basedir restriction in effect. File(D:\a\dolibarr\dolibarr\htdocs/..) is not within the allowed path(s): (D:\a\dolibarr\dolibarr\htdocs;D:\a\dolibarr\dolibarr\documents;D:\a\dolibarr\dolibarr\test;D:\a\dolibarr\dolibarr\dev\initdemo;c:\tools\php)

D:\a\dolibarr\dolibarr\htdocs\core\lib\functions2.lib.php:100
D:\a\dolibarr\dolibarr\htdocs\exports\class\export.class.php:119
D:\a\dolibarr\dolibarr\test\phpunit\ExportTest.php:463
```

* Fix spelling
2024-02-18 15:09:01 +01:00
thibdrev
bf13b040d7
qual: phpstan for htdocs/comm/mailing/class/mailing.class.php (#28240)
htdocs/comm/mailing/class/mailing.class.php	464	Property CommonObject::$user_validation_id (int|null) does not accept string.

htdocs/comm/mailing/class/mailing.class.php	466	Property Mailing::$date_envoi (int) does not accept null.
2024-02-18 15:05:58 +01:00
thibdrev
5acad21cbe
qual: phpstan for htdocs/adherents/class/adherent.class.php (#28241)
htdocs/adherents/class/adherent.class.php	1868	Property Paiement::$amounts (array) does not accept array.
2024-02-18 15:05:32 +01:00
Mohamed DAOUD
0fed96d702
New Add alias field to socpeople table (#28253)
* add alias field to socpeople table

* change name of the field
2024-02-18 15:05:17 +01:00
thibdrev
56ddeadd07
qual: phpstan for htdocs/compta/bank/class/account.class.php (#28242)
* qual: phpstan for htdocs/compta/bank/class/account.class.php

htdocs/compta/bank/class/account.class.php	206	PHPDoc type array of property Account::$status is not covariant with PHPDoc type int of overridden property CommonObject::$status.

htdocs/compta/bank/class/account.class.php	799	Property AccountLine::$amount (float) does not accept string.

* Update commonobject.class.php

* phpcs
2024-02-18 15:04:44 +01:00
thibdrev
538dbb509e
qual: phpstan for htdocs/compta/facture/class/facture.class.php (#28243)
* qual: phpstan for htdocs/compta/facture/class/facture.class.php

htdocs/compta/facture/class/facture.class.php	1253	Property CommonObject::$fk_project (int) does not accept string.

htdocs/compta/facture/class/facture.class.php	1254	Property CommonObject::$fk_delivery_address (int) does not accept string.

htdocs/compta/facture/class/facture.class.php	4474	Property Facture::$remise_percent (int) does not accept float.

* Update commoninvoice.class.php

* Update facture.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:04:18 +01:00
thibdrev
e9eccb7ad2
qual: phpstan for htdocs/core/modules/barcode/modules_barcode.class.php (#28244)
* qual: phpstan for htdocs/core/modules/barcode/modules_barcode.class.php

htdocs/core/modules/barcode/modules_barcode.class.php	59	PHPDoc type int of property ModeleNumRefBarCode::$code_null is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_null.

htdocs/core/modules/barcode/modules_barcode.class.php	64	PHPDoc type int of property ModeleNumRefBarCode::$code_auto is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_auto.

* Update modules_barcode.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:02:20 +01:00
Laurent Destailleur
a4bcfb1282 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 15:01:32 +01:00
Laurent Destailleur
fb61fa4c4d Close #28245 2024-02-18 15:01:19 +01:00
thibdrev
424f3cb002
qual: phpstan for htdocs/cron/class/cronjob.class.php (#28246)
htdocs/cron/class/cronjob.class.php	944	Property CommonObject::$tms (int) does not accept string.
2024-02-18 14:56:47 +01:00
thibdrev
f7f9dfd77c
qual: phpstan - Property CommonObject::$tms (int) does not accept string. (#28247)
* Update paymentdonation.class.php

* Update paymentexpensereport.class.php

* Update productbatch.class.php

* Update propalmergepdfproduct.class.php

* Update productstockentrepot.class.php

* Update stocktransfer.class.php

* Update dolresource.class.php

* Update paymentsalary.class.php

* Update salary.class.php
2024-02-18 14:56:31 +01:00
I. Antunes
a417b4eda9
FIX 28251 Fixing subpermission name on api_multicurrencies.class.php (#28252) 2024-02-18 14:48:01 +01:00
Marcelo Araujo
d9abb3ccb1
Update api_products.class.php (#28250)
You need to change this to float. In our business we use fractions of a unit of a product, and I think the majority works like that.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 14:42:01 +01:00
Laurent Destailleur
d707a1d668 Fix errors 2024-02-18 14:36:45 +01:00
Laurent Destailleur
42243d141a Test pre-commit 2024-02-18 14:28:24 +01:00
Laurent Destailleur
a59fa7eca0 Test 2024-02-18 14:27:15 +01:00
Laurent Destailleur
ead53cf4f5 Avoid beautysh error 2024-02-18 14:09:02 +01:00
Laurent Destailleur
ba8c7d14c9 Test 2024-02-18 13:44:48 +01:00
Laurent Destailleur
7662df7672 Test 2024-02-18 13:43:04 +01:00
Laurent Destailleur
ce367eb389 Update precommit 2024-02-18 13:40:33 +01:00
Laurent Destailleur
fb54306a1e Update precommit 2024-02-18 13:39:25 +01:00
Laurent Destailleur
a72077731f FIX Bad CRLF when sending text only content. Fix dol_htmlwithnojs() 2024-02-18 02:23:04 +01:00
Laurent Destailleur
56bd7be836 Add log 2024-02-18 02:12:34 +01:00
Laurent Destailleur
4b6347e7e7 FIX Bad CRLF when sending text only content. Fix dol_htmlwithnojs() 2024-02-18 02:11:15 +01:00
Laurent Destailleur
3de240823b NEW Add link to export ICS file of an event. 2024-02-18 01:46:44 +01:00
Laurent Destailleur
72298b8954 FIX bad timzeone for the start/end date of an event 2024-02-18 01:34:45 +01:00
Laurent Destailleur
2f57173574 Fix timezone for event 2024-02-18 01:33:21 +01:00
Laurent Destailleur
e50fdeec2c Fix timezone for event 2024-02-18 01:31:37 +01:00
Laurent Destailleur
e846721dc9 NEW Add link to export ICS file of an event. 2024-02-18 00:25:00 +01:00
Laurent Destailleur
de210ce277 css 2024-02-17 23:47:47 +01:00
Laurent Destailleur
66615477ae Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-17 20:58:40 +01:00
Laurent Destailleur
3f99cce347 Fix #yogosha20850 2024-02-17 20:53:56 +01:00
Laurent Destailleur
044d14ce2e Add dol_escape_htmltag 2024-02-17 19:56:45 +01:00
Laurent Destailleur
85be2aa98e Add dol_escape_htmltag 2024-02-17 19:48:30 +01:00
Laurent Destailleur
f4c9d683f5 Fix log message 2024-02-17 19:36:33 +01:00
Laurent Destailleur
17c3f6003e Fix pb letting think a user with no perm can change prospect status 2024-02-17 19:30:42 +01:00
Laurent Destailleur
8abe663d6f Add phpunit to test the rename/move into a corrupted pdf file. 2024-02-17 18:59:57 +01:00
Laurent Destailleur
fb283fdfe9 Clean code after yogosha reports 2024-02-17 18:39:26 +01:00
Laurent Destailleur
bb06e674ad Add dol_escape_htmltag 2024-02-17 18:05:31 +01:00
Laurent Destailleur
3d98b7b1ac Fix phpunit 2024-02-17 17:38:10 +01:00