* Qual: Improve rendering of phpstan technical debt table in apstats.
# Qual: Improve rendering of phpstan technical debt table in apstats.
Apply the DataTable rendering to the phpstan technical debt (same as applied to phan).
* Fix spelling
* Qual: Harden apstats output.
# Qual: Harden apstats output.
Escaping output for phpstan, and more escaping for phan.
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FIX: Fix unneeded access outside open_basedir when looking for modules
# FIX: Fix unneeded access outside open_basedir when looking for modules
Change the order in which the if conditions are tested so that an is_dir("dir/..") is avoided
by first testing if the subpath starts with a dot.
Also changed uppercased the first 3 letters of the file before comparing to CVS.
Finally, improved the typing hint and documentation.
The PHPUNIT test failed like this:
```
35) ExportTest::testExportModulesDatasets
is_dir(): open_basedir restriction in effect. File(D:\a\dolibarr\dolibarr\htdocs/..) is not within the allowed path(s): (D:\a\dolibarr\dolibarr\htdocs;D:\a\dolibarr\dolibarr\documents;D:\a\dolibarr\dolibarr\test;D:\a\dolibarr\dolibarr\dev\initdemo;c:\tools\php)
D:\a\dolibarr\dolibarr\htdocs\core\lib\functions2.lib.php:100
D:\a\dolibarr\dolibarr\htdocs\exports\class\export.class.php:119
D:\a\dolibarr\dolibarr\test\phpunit\ExportTest.php:463
```
* Fix spelling
htdocs/comm/mailing/class/mailing.class.php 464 Property CommonObject::$user_validation_id (int|null) does not accept string.
htdocs/comm/mailing/class/mailing.class.php 466 Property Mailing::$date_envoi (int) does not accept null.
* qual: phpstan for htdocs/compta/bank/class/account.class.php
htdocs/compta/bank/class/account.class.php 206 PHPDoc type array of property Account::$status is not covariant with PHPDoc type int of overridden property CommonObject::$status.
htdocs/compta/bank/class/account.class.php 799 Property AccountLine::$amount (float) does not accept string.
* Update commonobject.class.php
* phpcs
* qual: phpstan for htdocs/core/modules/barcode/modules_barcode.class.php
htdocs/core/modules/barcode/modules_barcode.class.php 59 PHPDoc type int of property ModeleNumRefBarCode::$code_null is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_null.
htdocs/core/modules/barcode/modules_barcode.class.php 64 PHPDoc type int of property ModeleNumRefBarCode::$code_auto is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_auto.
* Update modules_barcode.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
You need to change this to float. In our business we use fractions of a unit of a product, and I think the majority works like that.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>