MDW
536e35d2e8
Fix tabcond field type ( #30666 )
2024-08-18 22:02:25 +02:00
Laurent Destailleur
83be399ab5
Doc
2024-08-18 18:28:24 +02:00
Laurent Destailleur
9b08c48455
Fix warning
2024-08-18 18:17:04 +02:00
MDW
b0087aaf61
Qual: Enable phan on modulebuilder ( #30652 )
...
* Allow null for buyer, and force '' for in printObjectLine(s)
* Allow null for Contact in show_actions_done
* Qual: Enable phan on modulebuilder
# Qual: Enable phan on modulebuilder
Most files of the modulebuilder template can be checked as regular files.
It will help improve the template
* Update baseline (enable modulebuilder notices)
* Add properties that are expected to exist on modules_boxes
* Qual: Ignore false positive (phan)
* Set phpdoc type to include null on formAddObjectLine
* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)
* Fix phpcs for intracom
* Make ModeleBoxes:showBox() signature match child class's
* Fix *box::showBox() phpdoc types
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 18:16:08 +02:00
ptibogxiv
4e2842ca27
Update api_knowledgemanagement.class.php with pagination ( #30664 )
2024-08-18 16:20:45 +02:00
ptibogxiv
c9151a235e
Update api_tickets.class.php with pagination ( #30663 )
2024-08-18 16:20:22 +02:00
Oliver Lippert
0a41d5eb2c
tell about delivery objecttype tabs ( #30662 )
2024-08-18 16:18:49 +02:00
Jon Bendtsen
76b8327b40
NEW: API close proposal now supports both private and public note ( #30659 )
...
* NEW: API close proposal now supports both private and public note
* build errors
* build errors v2
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 16:16:47 +02:00
Laurent Destailleur
599923b04f
Fix phan
2024-08-18 00:39:47 +02:00
Laurent Destailleur
be1ef19d3a
Fix phan warning
2024-08-18 00:26:04 +02:00
Laurent Destailleur
72b37a2369
Fix phan
2024-08-18 00:01:45 +02:00
Laurent Destailleur
7ea04ab0af
Clean code
2024-08-17 23:59:08 +02:00
Laurent Destailleur
3114d1d13e
Clean code
2024-08-17 23:46:16 +02:00
Laurent Destailleur
30a8bd6bd5
Add entry in ignore
2024-08-17 23:40:08 +02:00
Laurent Destailleur
4f93bc7d09
Try to fix fatal PHP error
2024-08-17 22:47:59 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
52fdd19d0f
Doc
2024-08-17 19:28:17 +02:00
Laurent Destailleur
13d61527c9
Debug module intracommreport
2024-08-17 19:18:00 +02:00
Laurent Destailleur
31112fa467
Debug module intracommreport
2024-08-17 18:55:29 +02:00
Laurent Destailleur
ccba11a198
Fix phan warning for #30563
2024-08-17 17:47:27 +02:00
Laurent Destailleur
3f73447489
Fix warning on scandir for #30563
2024-08-17 17:28:18 +02:00
Laurent Destailleur
3b147a2776
Fix typo
2024-08-17 17:00:36 +02:00
Laurent Destailleur
0355153757
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 16:42:29 +02:00
Laurent Destailleur
fdb209ca41
Add a check to allow setPassword from apis
2024-08-17 16:41:30 +02:00
Laurent Destailleur
58dfd89256
Look and feel
2024-08-17 16:31:34 +02:00
Laurent Destailleur
2f643b8f99
Fix API_DISABLE_LOGIN_API
2024-08-17 16:30:47 +02:00
Laurent Destailleur
03bc26dcbb
Fix API_DISABLE_LOGIN_API
2024-08-17 16:29:52 +02:00
Laurent Destailleur
52c8b669c9
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 16:20:17 +02:00
Laurent Destailleur
c481be58f7
Clean code
2024-08-17 16:20:06 +02:00
Jon Bendtsen
5c6594b4ce
NEW API call to re-generate a users password. ( #30590 )
...
* NEW API call to re-generate a users password.
* fixing job:pre-commit that gave an error saying it was missing here
* adding the variable
* trying to load global user variable based on this comment https://github.com/Dolibarr/dolibarr/pull/30589#issuecomment-2276631147
* first attempt didnt work, but I found that global $conf at the top of the function
* adjust http error code to 500
* removing some comments and pre commit fix
* making send password a bool + using ->useraccount as pr. @eldy request
* lower case false
* Update api_users.class.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-17 16:19:55 +02:00
Frédéric FRANCE
34404b4e58
fix phpstan ( #30660 )
...
* fix phpstan
* Update reddithandler.class.php
2024-08-17 15:59:14 +02:00
Laurent Destailleur
84699b64fe
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 15:56:30 +02:00
Laurent Destailleur
8f1ef39976
Fix duplicate column name
2024-08-17 15:49:33 +02:00
Laurent Destailleur
25cd547a44
Fix duplicate column name
2024-08-17 15:48:49 +02:00
Laurent Destailleur
b436ffeaae
Fix link image
2024-08-17 14:10:10 +02:00
Laurent Destailleur
8dafdf4522
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-08-17 13:12:53 +02:00
Laurent Destailleur
5a8b5565f7
FIX message after recordig an internal transfer was not visible
2024-08-17 13:12:28 +02:00
Laurent Destailleur
8606175b4e
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 12:22:45 +02:00
Laurent Destailleur
fde4c38657
Close #30623 Close #30640
2024-08-17 12:22:18 +02:00
Laurent Destailleur
223f87a78b
Debug v20
2024-08-17 02:02:32 +02:00
Laurent Destailleur
ec5d9ff0cc
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-08-17 01:41:06 +02:00
Laurent Destailleur
6d7e6a0f8f
Look and feel
2024-08-17 01:40:44 +02:00
lamrani abdelwadoud
e8c9fa1945
New configuration for mastodonHandler ( #30632 )
...
* New configuration for mastodonHandler
* Fix error CTI
* Fix phpStan errors
* add getters for private attributes
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-16 22:41:38 +02:00
Laurent Destailleur
6249268e98
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-16 22:28:43 +02:00
Laurent Destailleur
ad7201c368
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-08-16 22:27:53 +02:00
Oliver Lippert
9757e18960
FIX: Fatal error on create loan schedule ( #30656 )
...
* don't set `$echeances->lines` to null to prevent fatal error
also replace wrong variable `$echeance` with `$new_echeance`
#30655
* replace "step1" with a more speaking error message
#30655
---------
Co-authored-by: Oliver Lippert <oliver@lipperts-web.de>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-16 22:25:59 +02:00
Laurent Destailleur
77ea24c812
Try fix codespell
2024-08-16 22:23:52 +02:00
Laurent Destailleur
ab2bfae576
Fix precommit
2024-08-16 22:20:44 +02:00
Laurent Destailleur
025f71d6be
Fix typo
2024-08-16 22:19:09 +02:00
Laurent Destailleur
dcedc39887
Comment
2024-08-16 22:15:23 +02:00
