Commit graph

130061 commits

Author SHA1 Message Date
Laurent Destailleur
38d7e14999 Doc 2024-02-16 13:35:26 +01:00
Laurent Destailleur
8dc8f67c31 Rename status for a better consistency with other modules 2024-02-16 13:32:40 +01:00
evarisk-micka
010257eaa2
FIX #26920 replace fk_statut by status (#27930)
* FIX use status instead of fk_statut

* FIX replace fk_statut by status

* FIX keep old fk_statut field in case it is used by hook or trigger

* FIX select fk_statut as status and fill both with obj->status

* Update list.php

* Update task.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-16 13:23:23 +01:00
Laurent Destailleur
62626a4d53 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-16 13:10:05 +01:00
MDW
f10d06a357
Qual: Clean up (spelling/shellcheck) initdemo/initdata files (#28195)
# Qual: Clean up (spelling/shellcheck) initdemo/initdata files

Cleanup the readme's and the script
2024-02-16 13:09:40 +01:00
Laurent Destailleur
f23fde8a47 Fix typo 2024-02-16 13:09:32 +01:00
HENRY Florian
24b017fbc8
database: add field llx_contract.signed_status (and remane new llx_fichinter.signed to llx_fichinter.signed_status to avoid SQL reserved name use) (#28204) 2024-02-16 13:07:07 +01:00
MDW
844bc42240
FIX: Check valid mail server record correction. (#28197)
# FIX: Check valid mail server record correction.

The test for isValidMXRecord did not pass on Windows platform:

```bash
php -r '$a=getmxrr("yhaoo.com", $mxhosts, $weight);var_dump([$a,$mxhosts]);'

array(2) {
  [0] =>
  bool(true)
  [1] =>
  array(1) {
    [0] =>
    string(1) "."
  }
}

array(2) {
  [0] =>
  bool(true)
  [1] =>
  array(3) {
    [0] =>
    string(21) "mta5.am0.yahoodns.net"
    [1] =>
    string(21) "mta7.am0.yahoodns.net"
    [2] =>
    string(21) "mta6.am0.yahoodns.net"
  }
}

```

So an "invalid" MX record can be returned as a dot '.'.
2024-02-16 13:03:16 +01:00
Frédéric FRANCE
aabe3c528c
fix typo (#28201)
* fix typo

* Update opensurveysondage.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-16 13:01:43 +01:00
Frédéric FRANCE
cdfb72e707
fix wrong test (#28202) 2024-02-16 12:15:57 +01:00
William Mead
423e0d9124
Fixed empty status (#28200) 2024-02-16 12:15:36 +01:00
Frédéric FRANCE
7cb8177de1
fix typos (#28198) 2024-02-16 12:13:25 +01:00
Frédéric FRANCE
647cf21b54
fix warnings in select_resource_list (#28189)
* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list
2024-02-16 02:40:27 +01:00
MDW
ae0f43632e
Fix: Add some initialisations that avoid notices (#28191)
* Fix: Initialize  to avoid incrementing undefined variable.

# Fix: Initialize  to avoid incrementing undefined variable.

Got an error in the Web Interface related to error not being defined and incremented

* Fix: Initialize

# Fix: Initialize

Was not defined during test
2024-02-16 02:32:58 +01:00
thibdrev
f445d1e376
qual: phpstan for various mod_xxx.php (#28190)
* Update mod_contract_magre.php

* Update mod_contract_olive.php

* Update mod_contract_serpis.php

* Update mod_holiday_immaculate.php

* Update mod_holiday_madonna.php

* Update mod_member_advanced.php

* Update mod_member_simple.php

* Update modules_product.class.php

* Update mod_sn_free.php

* phpcs

* phpcs
2024-02-16 02:30:55 +01:00
Frédéric FRANCE
ff29e2e2db
fix movement stock list (#28192)
* fix movement stock list

* fix

* fix
2024-02-16 02:30:06 +01:00
MDW
399f5d6cbe
Qual Improve messages in tests (#28193)
* Fix: Improve error messages for AdminLibTest

# Fix: Improve error messages for AdminLibTest

These changes clarify the messages when the changed assertions fail.

* Qual: Improve error messages for FileLibTest

# Qual: Improve error messages for FileLibTest

Certain tests now have error messages that help identify a failing test.
2024-02-16 02:28:32 +01:00
Laurent Destailleur
77db116447 Debug custom report 2024-02-16 02:11:04 +01:00
Laurent Destailleur
b48455c9d7 Can remove filter entries 2024-02-16 01:50:03 +01:00
Laurent Destailleur
7107b5feb3 Debug custom report filter management 2024-02-16 01:19:53 +01:00
Laurent Destailleur
2677cd9ff7 Update lang 2024-02-15 18:55:46 +01:00
Laurent Destailleur
a549f095b7 Fix custom reports for external modules 2024-02-15 18:40:04 +01:00
Laurent Destailleur
75cdfcbf52 Fix if reffield does not exists 2024-02-15 18:08:38 +01:00
Laurent Destailleur
5d7232f637 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-15 17:07:14 +01:00
Laurent Destailleur
0eee181afd Remove duplicate line 2024-02-15 17:06:54 +01:00
Laurent Destailleur
ce0c4601bb Close #28181 New substitution variables for invoice 2024-02-15 17:05:54 +01:00
William Mead
0a0edcf273
Qual clean dolresource (#27864)
* Updated PHPDoc

* Cleaned code & comments. Typed method parameters.

* Cleaned code

* Force int cast

* Fixed PHP 7.0 compatibility

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-15 16:49:54 +01:00
Frédéric FRANCE
aee0618dd3
fix phpstan salary.class.php (#28164)
* fix phpstan salary.class.php

* Update salary.class.php

* fix

* fix
2024-02-15 16:44:27 +01:00
Frédéric FRANCE
4bf4f587b2
fix phpstan pdf_einstein.modules.php (#28166) 2024-02-15 16:43:25 +01:00
Laurent Destailleur
41fa5758c9 Avoid error 2024-02-15 15:22:33 +01:00
MDW
43967a83a3
SEC: #28168 Correct protocol limitations (PHP7.4/Win) (#28172)
# SEC: #28168 Correct protocol limitations (PHP7.4/Win)

Protocol limitation was not active during test on windows platform.
Moving the application of the limitation just before the curl_exec
instruction made the limitation effective.

Also extended the code to enable allowing ftp and ftps and extended
the code for [CURLOPT_REDIR_PROTOCOLS_STR](https://www.php.net/manual/en/curl.constants.php#constant.curlopt-redir-protocols-str).
2024-02-15 15:20:21 +01:00
Frédéric FRANCE
8830e47c63
phpdoc (#28167)
* phpdoc

* fix
2024-02-15 14:59:43 +01:00
thibdrev
b0658c48f0
qual: phpstan - Property mod_xxxx::$code_modifiable (string) does not accept int. (#28173)
* qual: phpstan for commonnumrefgenerator.class.php

* qual: phpstan for mod_codeproduct_elephant.php

* qual: phpstan for mod_codeproduct_leopard.php

htdocs/core/modules/product/mod_codeproduct_leopard.php	79	Property mod_codeproduct_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_lot_free.php

htdocs/core/modules/product_batch/mod_lot_free.php	76	Property mod_lot_free::$code_modifiable (string) does not accept int.

* Update mod_codeclient_elephant.php

htdocs/core/modules/societe/mod_codeclient_elephant.php	46	PHPDoc type int of property mod_codeclient_elephant::$code_modifiable is not covariant with PHPDoc type string of overridden property ModeleThirdPartyCode::$code_modifiable.

* qual: phpstan for mod_codeclient_leopard.php

htdocs/core/modules/societe/mod_codeclient_leopard.php	76	Property mod_codeclient_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_codeclient_monkey.php

htdocs/core/modules/societe/mod_codeclient_monkey.php	76	Property mod_codeclient_monkey::$code_modifiable (string) does not accept int.

* phpcs

* phpcs

* phpcs

* qual: phpstan for modules_societe.class.php

* Update mod_lot_free.php
2024-02-15 14:59:07 +01:00
Niels Scheunemann
5315b609cd
FIX: Shipment closing action has wrong value (#28174)
Change the value of the action parameter from "close" to "classifyclosed" to make the button work again.
2024-02-15 14:53:12 +01:00
MDW
e5423d5c59
Qual: Add exceptions for codespell (#28186)
* Dev: Add setup scripts for phpunit/database

# Dev: Add setup scripts for phpunit/database

Some scripts that helped to setup some unit testing.

* NEW Add Windows ci workflow

# NEW Add Windows ci workflow

This adds a workflow to execute ci on a windows platform

* Disable open_basedir for now, to test effect

* Qual: Exclude documents directory from codespell

# Qual: Exclude documents directory from codespell

Documents directory may be present during development (unit tests).
Do not check spelling there

* Qual: Add codespell exceptions

# Qual: Add codespell exceptions

Add new exceptions to codespell (var identified as misspelling).
2024-02-15 14:49:09 +01:00
Frédéric FRANCE
306e594b8e
fix warning (#28175)
* fix warning

* Update index.php
2024-02-15 14:45:19 +01:00
Laurent Destailleur
c65870c026 QUAL: Properties ->date_update and ->date_modification were merged into
date_modification.
2024-02-15 14:08:08 +01:00
Frédéric FRANCE
5f1c679142
fix warning (#28177)
* fix warning

* clean properties

* clean properties
2024-02-15 13:59:19 +01:00
Frédéric FRANCE
69a766b300
use browser cache for pictures (#28179)
* use browser cache for pictures

* test

* Update phpstan.yml

* Update phpstan.yml
2024-02-15 13:58:07 +01:00
MDW
a68f6ed0d1
Qual: Improve caching for phpstan (#28180)
# Qual: Improve caching for phpstan

The phpstan step does not seem to always choose the best cache.
This configuration update adds the target branch to the restore
feature.
Maybe it is more selective and better.
2024-02-15 13:55:54 +01:00
William Mead
d612e32c06
NEW resource phone, email & maxusers (#28185)
* Added resource phone, email & max_users

* Cleaned code

* Added phone, email & max_users

* Cleaned code. Removed fields shown in header.

* Cleaned code

* Fixed resource create

* Add MaxUsers localization
2024-02-15 13:44:29 +01:00
Laurent Destailleur
67c9916a79 Add README file for module 2024-02-15 13:26:31 +01:00
Laurent Destailleur
c8777a94b0 Fix table for export profile in modulebuilder 2024-02-15 13:13:24 +01:00
Laurent Destailleur
7bb21e7ff6 Fix picto 2024-02-15 13:10:28 +01:00
Laurent Destailleur
248119fc8c Move setup files 2024-02-15 11:50:38 +01:00
Laurent Destailleur
983845bb32 FIX Bad condition on button back to draft on recruitment job. 2024-02-14 15:07:49 +01:00
Laurent Destailleur
864d753b04 NEW Module bookcal is now experimental 2024-02-14 12:39:24 +01:00
Laurent Destailleur
06e93aeb0e Debug module bookcal 2024-02-14 04:46:59 +01:00
Laurent Destailleur
21098dae23 FIX ajaxtooltip must return content with no html header/footer even for
error message
2024-02-14 03:38:17 +01:00
Laurent Destailleur
a6ef430ca1 Clean code 2024-02-14 01:42:38 +01:00