* FIX use status instead of fk_statut
* FIX replace fk_statut by status
* FIX keep old fk_statut field in case it is used by hook or trigger
* FIX select fk_statut as status and fill both with obj->status
* Update list.php
* Update task.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
# FIX: Check valid mail server record correction.
The test for isValidMXRecord did not pass on Windows platform:
```bash
php -r '$a=getmxrr("yhaoo.com", $mxhosts, $weight);var_dump([$a,$mxhosts]);'
array(2) {
[0] =>
bool(true)
[1] =>
array(1) {
[0] =>
string(1) "."
}
}
array(2) {
[0] =>
bool(true)
[1] =>
array(3) {
[0] =>
string(21) "mta5.am0.yahoodns.net"
[1] =>
string(21) "mta7.am0.yahoodns.net"
[2] =>
string(21) "mta6.am0.yahoodns.net"
}
}
```
So an "invalid" MX record can be returned as a dot '.'.
* fix warnings in select_resource_list
* fix warnings in select_resource_list
* fix warnings in select_resource_list
* fix warnings in select_resource_list
* Fix: Initialize to avoid incrementing undefined variable.
# Fix: Initialize to avoid incrementing undefined variable.
Got an error in the Web Interface related to error not being defined and incremented
* Fix: Initialize
# Fix: Initialize
Was not defined during test
* Fix: Improve error messages for AdminLibTest
# Fix: Improve error messages for AdminLibTest
These changes clarify the messages when the changed assertions fail.
* Qual: Improve error messages for FileLibTest
# Qual: Improve error messages for FileLibTest
Certain tests now have error messages that help identify a failing test.
# SEC: #28168 Correct protocol limitations (PHP7.4/Win)
Protocol limitation was not active during test on windows platform.
Moving the application of the limitation just before the curl_exec
instruction made the limitation effective.
Also extended the code to enable allowing ftp and ftps and extended
the code for [CURLOPT_REDIR_PROTOCOLS_STR](https://www.php.net/manual/en/curl.constants.php#constant.curlopt-redir-protocols-str).
* qual: phpstan for commonnumrefgenerator.class.php
* qual: phpstan for mod_codeproduct_elephant.php
* qual: phpstan for mod_codeproduct_leopard.php
htdocs/core/modules/product/mod_codeproduct_leopard.php 79 Property mod_codeproduct_leopard::$code_modifiable (string) does not accept int.
* qual: phpstan for mod_lot_free.php
htdocs/core/modules/product_batch/mod_lot_free.php 76 Property mod_lot_free::$code_modifiable (string) does not accept int.
* Update mod_codeclient_elephant.php
htdocs/core/modules/societe/mod_codeclient_elephant.php 46 PHPDoc type int of property mod_codeclient_elephant::$code_modifiable is not covariant with PHPDoc type string of overridden property ModeleThirdPartyCode::$code_modifiable.
* qual: phpstan for mod_codeclient_leopard.php
htdocs/core/modules/societe/mod_codeclient_leopard.php 76 Property mod_codeclient_leopard::$code_modifiable (string) does not accept int.
* qual: phpstan for mod_codeclient_monkey.php
htdocs/core/modules/societe/mod_codeclient_monkey.php 76 Property mod_codeclient_monkey::$code_modifiable (string) does not accept int.
* phpcs
* phpcs
* phpcs
* qual: phpstan for modules_societe.class.php
* Update mod_lot_free.php
* Dev: Add setup scripts for phpunit/database
# Dev: Add setup scripts for phpunit/database
Some scripts that helped to setup some unit testing.
* NEW Add Windows ci workflow
# NEW Add Windows ci workflow
This adds a workflow to execute ci on a windows platform
* Disable open_basedir for now, to test effect
* Qual: Exclude documents directory from codespell
# Qual: Exclude documents directory from codespell
Documents directory may be present during development (unit tests).
Do not check spelling there
* Qual: Add codespell exceptions
# Qual: Add codespell exceptions
Add new exceptions to codespell (var identified as misspelling).
# Qual: Improve caching for phpstan
The phpstan step does not seem to always choose the best cache.
This configuration update adds the target branch to the restore
feature.
Maybe it is more selective and better.