* Improve UXUI on public ticket interface
* Use the style method to remove the border in border to preserve the edit pencil
* Switching back to 2 column layout
* reduce changes
* Identical look'n'feel between just viewing the list and editing a new response
* Attempt at fixing phan
---------
Co-authored-by: Jon Bendtsen <jonbendtsen@jonb.dk>
* Qual: Update GETPOST calls to handle hint array type
# Qual: Update GETPOST calls to handle hint array type
- Updated GETPOST calls for 'amounts' and 'multicurrency_amounts' to explicitly handle array inputs by adding the 'array' type parameter
This fixes PHPStan notices where expressions expect an array.
* Qual: Set type for status label mapping in LignePrelevement (PHPStan)
# Qual: Set type for status label mapping in LignePrelevement (PHPStan)
Added type hint to property `$labelStatus`
* Qual: Add type hints to datec and datep properties in PaymentSocialContribution
# Qual: Add type hints to datec and datep properties in PaymentSocialContribution
Added type hints to datec and datep properties.
* Qual: Add type hint to MIME mapping for image file extensions
# Qual: Add type hint to MIME mapping for image file extensions
Added type hint to `$image_types`
* Qual: Better type hint for getAllItemsLinkedByObjectID method
# Qual: Better type hint for getAllItemsLinkedByObjectID method
The return type annotation for the getAllItemsLinkedByObjectID method has been updated from 'array|int' to 'string[]|int'.
* Qual: Better type hint for fetchAll return value
# Qual: Better type hint for fetchAll return value
Suggest thet fetchAll returns list of objects
* Qual: Remove array from return value hint
* Qual: Add missing type hints to Notify
* Qual: Cast resource IDs to integers in getAllResourcesOfWorkstation
# Qual: Cast resource IDs to integers in getAllResourcesOfWorkstation
Ensure returned value is list of ints as parent::getAllItemsLinkedByObjectID does not ensure value type.
* Qual: Ensure correct return type for getAllGroupsOfWorkstation
* Qual: Improve typing hints
* Qual: Improve typing hints, ignore some notices
* Qual: Fix argument type
* Qual: Improve type hints
* Qual: Improve typing hints
* Qual: Add missing type hint
* Qual: Update Phan baseline
* Qual: Remove redundant exit (PHPStan, Phan)
* NEW massaction for invoice list which contains a given product
* This sends 1 email when tested with 1 selection, will have to cleanup
* cleaning up my various debug messages and comments
* fix pre-commit hook errors
* PHPstan fixes
* typecasting invoice id due to PHAN complaint
* Redefine how selectedfields variable is defined
* fix PHPstan and phan using advice from mdeweerd
* directly, not saved as string
* fix pre-commit fail
* put in a string
---------
Co-authored-by: Jon Bendtsen <jonbendtsen@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: CI notices after changes to fields type
# Qual: CI notices after changes to fields type
The phpstan regexes to ignore notices no longer matched because of the type change.
Update the code to fix the notices.
* Qual: Ignore false positive (Phan)
* Qual: Fix phpstan notice with cast
* Qual: Fix initialiser (phpstan) and narrow some types
* Qual: Fix typing for object->type field (phpstan)
* Qual: Update preg_quote usage in step2.php
# Qual: Ignore false phpstan positive for preg_match
Add comment to ignore phpstan warning for preg_match argument
* Qual: Extend accepted types for arrayoptions (phpstan)
* Qual: Fix type hint typo
* Qual: Fix type for contact_id assignment
* Qual: Add menuonly as allowed reloadmode
* Qual: Add PHPStan ignore comments for argument.type
* Qual: Ignore unused parameter in constructors (PHPStan)
* Qual: Add type hint for $TMsg (PHPStan)
* Qual: Cast array values to match expected type (PHPStan)
* Qual: Cast $remise_percent_ligne to float (PHPStan)
* Qual: Add array specifier to GETPOST for correct type (PHPStan)
* Qual: Update sumSituation() argument types
* Qual: Cast value to string for printStdColumnContent (PHPStan)
* Qual: Ignore PHPStan notice for autoload function return value
* Qual: Fix type of argument to Menubase::recur (PHPStan)
* Qual: Fix return type hint (PHPStan)
* Qual: Add $dolibarr_main_db_type as default global
* Qual: Update Phan baseline (due to PHPStan fix)
