Commit graph

136941 commits

Author SHA1 Message Date
HENRY Florian
07c9dea71e
Qual: add fields array property into categorie class (#30450)
* new: add fields array into categorie class

* reveiw php stan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 23:23:30 +02:00
Laurent Destailleur
69bc79b9a9 Fix test on securiy page 2024-08-20 15:02:33 +02:00
Laurent Destailleur
91ef884859 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-20 12:36:53 +02:00
MDW
16e72b4602
Qual: Fix phan notices for fournisseur.facture.class.php (#30680)
# Qual: Fix phan notices for fournisseur.facture.class.php

Fix phan notices in one of the popular classes to improve future detection.
2024-08-20 12:29:16 +02:00
Laurent Destailleur
eee66bff8b Doc 2024-08-20 12:28:41 +02:00
kkhelifa-opendsi
5b8a3a10a4
NEW: Add auto generate document when reception is created (#30688)
* NEW: Add auto generate document when reception is created

* Corrections

* Corrections

* Corrections
2024-08-20 12:08:58 +02:00
Laurent Destailleur
0830af9f11 Fix label-picto of extrafields 2024-08-20 11:45:15 +02:00
Laurent Destailleur
99924d4432 Trans 2024-08-20 11:05:32 +02:00
Laurent Destailleur
02084292c6 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-20 11:03:11 +02:00
Laurent Destailleur
23c91578f0 NEW Add pîcto on list of notification email templates 2024-08-20 11:02:47 +02:00
ptibogxiv
f613752bd3
Update api_contracts.class.php with pagination (#30681)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 10:18:15 +02:00
ptibogxiv
465b7dc2c6
Update api_contacts.class.php with pagination (#30679)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 10:18:06 +02:00
Laurent Destailleur
fdff749ab0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-20 10:11:31 +02:00
Laurent Destailleur
a90b6d8779 Fix warning and option MAIN_AUTOFILL_DATE 2024-08-20 10:10:13 +02:00
Frédéric Bagnol
0166b6c0e9
# FIX truncate mail server error message to fit to database (mailling module) (#30534)
* truncate mail server error message  to fit to database

* fix typo

* substr under DB->escape

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 09:51:27 +02:00
Frédéric FRANCE
5ed0d017e0
fix phpdoc (#30685) 2024-08-20 09:46:59 +02:00
Aloïs Micard
3b2207ca2f
Add docker installation instructions (#30684) 2024-08-20 09:46:42 +02:00
ptibogxiv
42a79c3dc0
Update api_recruitments.class.php with pagination (#30677)
* Update api_recruitments.class.php with pagination

* Update api_recruitments.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 09:44:07 +02:00
Laurent Destailleur
a83fb60074 Merge branch 'develop' of github.com:Dolibarr/dolibarr into develop 2024-08-20 04:19:17 +02:00
Laurent Destailleur
0340f0db8d Fix phpstan 2024-08-20 04:18:02 +02:00
Frédéric FRANCE
fce1c6f328
NEW add hook dolibarrDelConst (#30672) 2024-08-20 03:31:02 +02:00
Frédéric FRANCE
7298e42769
fix phpdoc (#30668)
* fix phpdoc

* Update utils_diff.class.php
2024-08-20 03:19:13 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
Laurent Destailleur
009e93a4c2 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-19 01:22:36 +02:00
Laurent Destailleur
a675b47f43 Doc 2024-08-19 01:21:52 +02:00
ptibogxiv
0ba084a8b2
Update api_donations.class.php with pagination (#30665)
* Update api_donations.class.php with pagination

* Update api_donations.class.php
2024-08-18 23:12:07 +02:00
MDW
536e35d2e8
Fix tabcond field type (#30666) 2024-08-18 22:02:25 +02:00
Laurent Destailleur
83be399ab5 Doc 2024-08-18 18:28:24 +02:00
Laurent Destailleur
9b08c48455 Fix warning 2024-08-18 18:17:04 +02:00
MDW
b0087aaf61
Qual: Enable phan on modulebuilder (#30652)
* Allow null for buyer, and force '' for  in printObjectLine(s)

* Allow null for Contact in show_actions_done

* Qual: Enable phan on modulebuilder

# Qual: Enable phan on modulebuilder

Most files of the modulebuilder template can be checked as regular files.
It will help improve the template

* Update baseline (enable modulebuilder notices)

* Add properties that are expected to exist on modules_boxes

* Qual: Ignore false positive (phan)

* Set phpdoc type to include null on formAddObjectLine

* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)

* Fix phpcs for intracom

* Make ModeleBoxes:showBox() signature match child class's

* Fix *box::showBox() phpdoc types

* Update index.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 18:16:08 +02:00
ptibogxiv
4e2842ca27
Update api_knowledgemanagement.class.php with pagination (#30664) 2024-08-18 16:20:45 +02:00
ptibogxiv
c9151a235e
Update api_tickets.class.php with pagination (#30663) 2024-08-18 16:20:22 +02:00
Oliver Lippert
0a41d5eb2c
tell about delivery objecttype tabs (#30662) 2024-08-18 16:18:49 +02:00
Jon Bendtsen
76b8327b40
NEW: API close proposal now supports both private and public note (#30659)
* NEW: API close proposal now supports both private and public note

* build errors

* build errors v2

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 16:16:47 +02:00
Laurent Destailleur
599923b04f Fix phan 2024-08-18 00:39:47 +02:00
Laurent Destailleur
be1ef19d3a Fix phan warning 2024-08-18 00:26:04 +02:00
Laurent Destailleur
72b37a2369 Fix phan 2024-08-18 00:01:45 +02:00
Laurent Destailleur
7ea04ab0af Clean code 2024-08-17 23:59:08 +02:00
Laurent Destailleur
3114d1d13e Clean code 2024-08-17 23:46:16 +02:00
Laurent Destailleur
30a8bd6bd5 Add entry in ignore 2024-08-17 23:40:08 +02:00
Laurent Destailleur
4f93bc7d09 Try to fix fatal PHP error 2024-08-17 22:47:59 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") (#30563)
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add typing hint to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add typing hint in phan config to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjectBlock

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjectBlock

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjects

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Fix: MemberNumRefNumbers getExample does not take any arguments

Found thanks to adding the typing for phan!

* Qual: Correct forced type for $module

* Qual: Ignore phan false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Ignore false positive

* Qual: phan/Ignore false positive, replace depr.prop with method

* Qual: Fix typing for count by adding is_array check

* Qual: replace depr.prop `nom` with method

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Fix depr.prop with getter and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: Improve typing for mymodule template

* Make info method arguments match calls

* Make PrintingDriver abstract class because we added abstract methods

* Add phpdoc typing for phan

* Update getExample function signature for compatibility

* Update getExample function signature for compatibility

* Update getExample function signature for compatibility

* Update header wit correct information

* Update getExample method signature

* Update getExample method signature

* Correct reference to class in comment

* Force php phan typing for numbering modules

* Correct $_GLOBALS to $GLOBALS

* Add phpdoc to indicat type of properties

* Correct default to null

* Improve getNextValue typehint

* Improve getNextValue typehint

* Qual: Improve ModeleNumRefTakepos typing

* Qual: Improve ModeleNumRefRecruitmentJobPosition typing

* Fix default for $langs

* Do not use non-existing ModeleNumRefTakepos::nom

* Allow getNextValue argument to be null

* Correct $_GLOBAL into $GLOBALS

* Improve typing for ldap functions

* Allow null for outputlangs argument

* Improve typing for printOriginLine

* Improve typing for linkedObject access

* Fix PhanTypeMismatchArgumentNullableInternal and optimize

* Fix PhanPossiblyUndeclaredVariable by setting default value

* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4

* getToolTip does not accept null, changed to ''

* Improve getNextValue typing

* Change PrintingDriver back to normal class (instantiated)

And add errors for functions that should be overloaded

* Adjust pringOriginLine typing to match parent

* Fix phpdoc for getNextValue

* Fix phan typing

* Add/Improve phpdoc typing hints

* Qual: Adjustments to match typing

* Update typing for unit, use GETPOSTINT

* ModeleNumRefTask needs Project

* Fix several notices appearing after update from develop

* Index for choices is int, use GETPOSTINT

* Qual: Ignore empty foreach

* Force BOMLine on object line

* phan typing to indicate that linked objects are BOM

* Type the correct variable name (phan)

* Add typing for $langs

* Type to CommonNumRefGenerator (no class for availabilities)

* Resolve several phan notices after update from dev branch

* Extra typing fixes

* Move common attributes to parent class (phan)

* Add typing to Calendar class

* Improve typing hints

* Add typing to pdf_eagle_proforma

* Qual: Add typing for token in generic_oauthcallback.php

* Add typing for objMod

* Correct getNextValue function signature (phpstan)

* Fix typing (phpstan)

* Update version declarations (fix phpstan)

* Fix phpstan typing issues

* Adjust typing (phpstan)

* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
52fdd19d0f Doc 2024-08-17 19:28:17 +02:00
Laurent Destailleur
13d61527c9 Debug module intracommreport 2024-08-17 19:18:00 +02:00
Laurent Destailleur
31112fa467 Debug module intracommreport 2024-08-17 18:55:29 +02:00
Laurent Destailleur
ccba11a198 Fix phan warning for #30563 2024-08-17 17:47:27 +02:00
Laurent Destailleur
3f73447489 Fix warning on scandir for #30563 2024-08-17 17:28:18 +02:00
Laurent Destailleur
3b147a2776 Fix typo 2024-08-17 17:00:36 +02:00
Laurent Destailleur
0355153757 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-17 16:42:29 +02:00
Laurent Destailleur
fdb209ca41 Add a check to allow setPassword from apis 2024-08-17 16:41:30 +02:00