Commit graph

307 commits

Author SHA1 Message Date
Nathan
95bcefbb9e
FIX: #39068 Ignore warning text in product search (#39071) 2026-07-10 17:46:28 +02:00
Florian Charlaix
029a1fbc1b
NEW #37727 phone input with country code (#37728)
* New phone input with country code

* CI fixes

* Assure AJAX CSRF check

* Fix SQL migration typo

* Remove unnecessary CSRFCHECK_WITH_TOKEN in getphonecode.php AJAX endpoint
2026-04-21 16:15:38 +02:00
MDW
36b940974a
Qual: Fix CI (PHPStan) (#37945)
* Qual: Fix CI (PHPStan)

# Qual: Fix CI (PHPStan)

Fix two PHPStan messages

* Update html.formticket.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-04-20 18:39:58 +02:00
MDW
1743565a50
Qual: Fix PHPStan notices (#37933)
* Qual: Fix phpstan notice with cast

* Qual: Fix initialiser (phpstan) and narrow some types

* Qual: Fix typing for object->type field (phpstan)

* Qual: Update preg_quote usage in step2.php

# Qual: Ignore false phpstan positive for preg_match

Add comment to ignore phpstan warning for preg_match argument

* Qual: Extend accepted types for arrayoptions (phpstan)

* Qual: Fix type hint typo

* Qual: Fix type for contact_id assignment

* Qual: Add menuonly as allowed reloadmode

* Qual: Add PHPStan ignore comments for argument.type

* Qual: Ignore unused parameter in constructors (PHPStan)

* Qual: Add type hint for $TMsg (PHPStan)

* Qual: Cast array values to match expected type (PHPStan)

* Qual: Cast $remise_percent_ligne to float (PHPStan)

* Qual: Add array specifier to GETPOST for correct type (PHPStan)

* Qual: Update sumSituation() argument types

* Qual: Cast value to string for printStdColumnContent (PHPStan)

* Qual: Ignore PHPStan notice for autoload function return value

* Qual: Fix type of argument to Menubase::recur (PHPStan)

* Qual: Fix return type hint (PHPStan)

* Qual: Add $dolibarr_main_db_type as default global

* Qual: Update Phan baseline (due to PHPStan fix)
2026-04-20 12:36:21 +02:00
MDW
e23059184f
Qual: Phan/fix for notices seen in #37875 & ci (#37876)
* Qual: Fix phan notice

Fix PhanTypeMismatchArgumentNullable: Argument 1 ($stringtosanitize) is $origin of type ?\CommonObject|?\CommonTrigger|?\DolDeprecationHandler|?array{}|?non-empty-array&lt;mixed,mixed&gt;|?non-empty-string|?string but \DoliDB::sanitize() takes string defined at htdocs/core/db/DoliDB.class.php:187 (expected type to be non-nullable)

* Qual: Fix PhanPluginSuspiciousParamPosition

# Qual: Fix PhanPluginSuspiciousParamPosition

Fix notices by using intermediate variable name that matches the parameter of the called function
where the original parameter name matches the name of a parameter in another position

* Qual: Fix PhanTypeMismatchArgument

# Qual: Fix PhanTypeMismatchArgument

Fix PhanTypeMismatchArgument: Argument 1 ($stringtosanitize) is $local of type int but \DoliDB::sanitize() takes string
in get_localtax_by_third($local) where local is an int already.
So use cast to (int) instead.
Also limit typehint of local to 1 and 2 which are the only allowed values

* Qual: Fix PhanTypeMismatchArgument in cloneCategories()

# Qual: Fix PhanTypeMismatchArgument in cloneCategories()

The argument $toId which is already an integer was passed to DoliDB::sanitize() which expects a string.
So casting to (int) instead to fix this.

* Qual: Ignore complex PhanUndeclaredStaticProperty

# Qual: Ignore complex PhanUndeclaredStaticProperty

Accessing static property provided by a trait on some classes - ignore the phan notice

* Qual: Phan ignore PhanUndeclaredMethod for getPossibleLevels

* Qual: Add typing hints for phan

* Qual: Add typehint for phan

* Qual: Remove redundant semicolon in objectonoff.php

# Qual: Remove redundant semicolon in objectonoff.php

Removed an unnecessary semicolon in the error handling loop of objectonoff.php.

* Qual: Fix PhanPossiblyUndeclaredGlobalVariable

* Qual: Ignore PhanPossiblyUndeclaredGlobalVariable
2026-04-15 17:59:06 +02:00
Laurent Destailleur
9a3b0d4922 Fix replace js alert with Dolibarr.tools.setEventMessage 2026-04-15 13:50:20 +02:00
Laurent Destailleur
584b25a6c8 Automated merge from 22.0 to 23.0 by tool pullmerge.sh 2026-03-25 14:00:51 +01:00
Laurent Destailleur
60353bd182 Automated merge from 21.0 to 22.0 by tool pullmerge.sh 2026-03-25 14:00:48 +01:00
atm-lucas
fd93c50c19
fix: add null check before setting _renderItem on jQuery UI autocomplete widget (#37597)
* fix: add null check before setting _renderItem on jQuery UI autocomplete widget

* const
2026-03-25 01:14:37 +01:00
Laurent Destailleur
c8be6609a2 Fix pb with ajaxonoff 2026-03-24 20:49:49 +01:00
ldestailleur
06a5b4947d Fix CI 2025-06-18 15:59:28 +02:00
ldestailleur
75d0f2ea6c FIX #33547 2025-04-07 15:58:06 +02:00
ldestailleur
0c09be61a2 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-03-25 14:01:28 +01:00
Jyhere
ad5102e5da
FIX: products with a single price by qty may have empty price when adding it in a commercial piece (#33509)
* FIX: products with a single price by qty may have empty price when adding it in a commercial piece

* FIX: products with a single price by qty may have empty price when adding it in a commercial piece
2025-03-24 23:34:02 +01:00
MDW
a0f71fbe76
Qual: Fix phan notices (core/lib) (#33379)
* Qual: Fix PhanMismatchType

* Finalize rename of $attrV into $value

* Correct getGlobalString into getGlobalInt

* Do not require some fields in the 'title' definition of $cols

* Qual: Fix phan notices (core/lib)
2025-03-11 01:43:54 +01:00
MDW
f66e9553d5
Qual: Fix phan notices
# Qual: Fix phan notices

Fix phan notices in fourn/commande (+form class)
2025-02-03 16:05:55 +01:00
Laurent Destailleur (aka Eldy)
a233abdcc5 Fix sql error 2025-01-16 15:33:00 +01:00
Laurent Destailleur (aka Eldy)
5e7ed6ba6d Try better fix for js warning 2025-01-16 15:32:08 +01:00
Laurent Destailleur (aka Eldy)
70a476a830 Fix js warning 2025-01-16 15:24:09 +01:00
Laurent Destailleur
cd0b8ceab5 Debug v23 2026-01-27 16:21:35 +01:00
Laurent Destailleur
2686238fe9 Clean code. select2 component need less code in html page 2025-10-30 22:21:12 +01:00
Laurent Destailleur
a1b4d1a06e WIP LNE 2025-10-28 13:07:19 +01:00
Frédéric FRANCE
f89cc919b8
clean code (#35894)
* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-23 14:05:59 +02:00
Laurent Destailleur
412a224d90 Fix CI 2025-10-22 22:28:55 +02:00
Laurent Destailleur
c465a5c8da Fix CI 2025-10-22 18:28:00 +02:00
Laurent Destailleur
33e27947ca WIP LNE 2025-10-22 16:31:47 +02:00
Laurent Destailleur
be351614e2 NEW DEV Can set color of the on/off button. 2025-10-22 11:05:59 +02:00
ldestailleur
f729d33dcc Clean setup of antivirus 2025-08-30 17:14:57 +02:00
Laurent Destailleur
2619ee7696 FIX #35105 2025-08-28 03:22:17 +02:00
Frédéric FRANCE
cd5df0bd68
try to fix doc (#35036)
* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc

* try to fix doc
2025-08-21 23:13:00 +02:00
atm-lucas
cfd64ff70a
FIX - Removal of accents in searches via comboxbox (#34933)
* accents and lower case on combobox

* Fix type

* adding conf

* remove comment

---------

Co-authored-by: ldestailleur <eldy@destailleur.fr>
2025-08-19 11:50:44 +02:00
Frédéric FRANCE
ee54d1c372
fix CI (#32089)
* fix CI

* fix CI

* fix CI

* fix CI
2024-11-25 18:57:57 +01:00
Laurent Destailleur
fb3c464555 Debug v21 2024-11-24 13:00:08 +01:00
Laurent Destailleur
4bc1eebcb5 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-11-21 12:47:48 +01:00
Laurent Destailleur
d9d97c4eb3 Add a lega linformation on online signature 2024-11-18 12:52:49 +01:00
Laurent Destailleur
07c3690bb7 FIX the style not visible in combo using autocomplete 2024-11-12 01:26:08 +01:00
MDW
e7539f2e19
Qual: Fix notices in .lib.php files (#31672)
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
Laurent Destailleur
c8c4bd4e7f Debug v21 2024-10-30 02:38:59 +01:00
Laurent Destailleur
318148354b Enhance setup of virtual card 2024-10-30 00:08:43 +01:00
Frédéric FRANCE
a185fb4296
fix phpstan (#31479)
* fix phpstan

* fix phpstan
2024-10-20 10:13:40 +02:00
Frédéric FRANCE
a94cff63a7
fix phpstan (#31102)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-25 22:21:31 +02:00
MDW
506454b10a
Qual: Resolve ~200 phan notices/~100 phpstan notices (#30879)
* bookkeeping\card.php, productaccount

* Fix bookkeeping/listbyaccount

* Typing for accountancycategory

* Fix typing accountancyimport

* Typing accountingaccount

* Typing api_accountancy

* bookkeeping typing

* Fix typing lettering

* Typing for accountancy/customer/list

* Typing accountancy/journal/bankjournal

* typing accountancy/journal/variousjournal

* Typing accountancy/supplier/list

* Initialisations in accountancy/journal/expensereportsjournal

* Initialisations in accountancy/journal/purchasesjournal

* Initialisations in accountancy/journal/sellsjournal

* Update baseline
2024-09-10 02:11:53 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
0feb44cd9e Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-26 21:09:21 +02:00
Laurent Destailleur
7778bc4b01 Fix switch page status. Fix clone page. 2024-08-26 20:51:42 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
Laurent Destailleur
bd57bcf617 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-15 19:52:31 +02:00
Laurent Destailleur
fcd2aeb026 Debug v20 2024-07-15 18:00:45 +02:00
Laurent Destailleur
9af159cdd8 Replace "! empty($conf->global->$" with "getDolGlobalString($" 2024-07-03 20:05:29 +02:00
Laurent Destailleur
ca2313bdcc Code comment 2024-06-29 19:24:16 +02:00