From 505ca17ba9debb5aee65812ea0fafffe81039928 Mon Sep 17 00:00:00 2001 From: MDW Date: Mon, 5 Feb 2024 14:29:18 +0100 Subject: [PATCH] Qual: Fix spelling and wording (#27995) # Qual: Fix spelling and wording Fix spelling (using beta codespell) and fix some wording in module README template and ChangeLog. Co-authored-by: Laurent Destailleur --- ChangeLog | 22 +++++++-------- .../codespell/codespell-lines-ignore.txt | 2 ++ htdocs/admin/stock.php | 2 +- .../categories/class/api_categories.class.php | 8 +++--- htdocs/compta/bank/line.php | 2 +- htdocs/core/class/html.formother.class.php | 2 +- htdocs/core/class/html.formticket.class.php | 2 +- htdocs/core/js/lib_notification.js.php | 2 +- htdocs/core/lib/accounting.lib.php | 10 +++---- htdocs/core/lib/admin.lib.php | 2 +- htdocs/core/lib/pdf.lib.php | 4 +-- htdocs/core/lib/report.lib.php | 12 ++++---- .../modules/mrp/doc/pdf_vinci.modules.php | 2 +- .../supplier_order/doc/pdf_cornas.modules.php | 2 +- .../doc/pdf_zenith.modules.php | 2 +- htdocs/expedition/dispatch.php | 2 +- .../fourn/class/fournisseur.product.class.php | 2 +- htdocs/main.inc.php | 2 +- htdocs/modulebuilder/template/README.md | 28 +++++++++---------- htdocs/product/class/productbatch.class.php | 2 +- htdocs/product/fournisseurs.php | 2 +- .../public/emailing/mailing-unsubscribe.php | 2 +- htdocs/public/stripe/ipn.php | 2 +- htdocs/reception/dispatch.php | 2 +- htdocs/theme/md/style.css.php | 2 +- 25 files changed, 62 insertions(+), 60 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0cfaa1ca3ad..bda30ca8caa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -124,7 +124,7 @@ NEW: filter on from/to period rather than month/year (#26378) NEW: FontAwesome - added possibility to select another version NEW: Get list evaluation with skills details in user fiche (#26510) NEW: hidden conf to disable use of dns_get_record (which can become unresponsive) (#26339) -NEW: HR: PDF Generation for each Human Resource Evaluations +NEW: HR: PDF Generation for each Human Resource Evaluations NEW: improved resource data structure NEW: Interventions: close notification for interventions NEW: Inventory: include sub warehouse in inventory @@ -254,7 +254,7 @@ NEW: add a $notrigger param to Product::updatePrice() method (#26404) NEW: add a rule to fix empty($conf->global->...) into !getDolGlobal... NEW: add column extraparams on societe_rib NEW: add phpunit for REST API of contacts -NEW: add barcode function to check if EAN13 is valid +NEW: add barcode function to check if EAN13 is valid WARNING: @@ -271,7 +271,7 @@ The following changes may create regressions for some external modules, but were * The property ->user_creation to store ID of user of creation has been renamed into ->user_creation_id. * The property ->user_modification to store ID of user of modification has been renamed into ->user_modification_id. * The private array ->status_short, ->statuts and ->status_long are now array ->labelStatusShort and ->labelStatus everywhere. -* The duplicate property ->user_creat, ->date_creat, ->date_valid have been removed (use instead user_creation, date_creation, date_validation). +* The duplicate property ->user_creat, ->date_creat, ->date_valid have been removed (use instead user_creation, date_creation, date_validation). * The method get_substitutionarray_shipment_lines() has been removed. Use the generic get_substitutionarray_lines() instead. * The method ProductcustomerPrice->fetch_all_log() has been renamed into camel case ->fetchAllLog() * It was possible to use a variable $soc or $right inside a PHP code condition of some extrafields properties, this is no more true (this 2 variables are no more global variables). @@ -489,7 +489,7 @@ NEW: Accountancy - Quadratus export with attachments in accountancy export NEW: Accountancy - Can filter on a custom group of accounts. Perf or ledger list. NEW: Accountancy - Can select the export format during export of journals NEW: Accountancy - sort of column of custom group of account -NEW: Can upload a file with drag and drop on purchase invoice, vats, salaries and social contributions +NEW: Can upload a file with drag and drop on purchase invoice, vats, salaries and social contributions NEW: Authentication: #22740 add OpenID Connect impl NEW: Authentication: add experimental support for Google OAuth2 connection NEW: Authentication: can now edit service name for OAuth token @@ -677,14 +677,14 @@ WARNING: Following changes may create regressions for some external modules, but were necessary to make Dolibarr better: * Minimal PHP version is now PHP 7.1 instead of PHP 7.0 -* Sensitive data like keys in setup pages, that need encryption (for example the API keys of users, the CRON security key, the keys into the Stripe module, or +* Sensitive data like keys in setup pages, that need encryption (for example the API keys of users, the CRON security key, the keys into the Stripe module, or external modules setup pages that store sensitive keys or password), are using the $dolibarr_main_instance_unique_id as part of the key for encryption. So, if you restore or duplicate the data from another instance dump, you must also -update this parameter in the conf.php file to allow decryption in the new instance, or +update this parameter in the conf.php file to allow decryption in the new instance, or better, you must reenter the sensitive data into the setup pages of the new instance to resave them correctly. -Note that to find all the parameters that are encrypted into the setup database, you can do a "SELECT * FROM llx_const WHERE value LIKE '%dolcrypt%';" +Note that to find all the parameters that are encrypted into the setup database, you can do a "SELECT * FROM llx_const WHERE value LIKE '%dolcrypt%';" * The deprecated method "escapeunderscore()" of database handlers has been removed. You must use "escapeforlike()" instead. -* The method "nb_expedition()" has been renamed into "countNbOfShipments()" +* The method "nb_expedition()" has been renamed into "countNbOfShipments()" * Revert default type of hooks. Default is now 'addreplace' hooks (and exception become 'output' hooks, that become deprecated). * Deprecated property libelle removed from entrepot class. * The type 'text' in ->fields property does not accept html content anymore. Use the type 'html' for that. @@ -1086,7 +1086,7 @@ WARNING: Following changes may create regressions for some external modules, but were necessary to make Dolibarr better: * Minimal PHP version is now PHP 7.0 instead of PHP 5.6 * Core has introduced a Universal Filter Syntax for search criteria. Example: ((((field1:=:value1) OR (field2:in:1,2,3)) AND ...). In rare case, some filters - could be provided by URL parameters. For such cases (societe/ajax/company.php), use of Universal Filter Syntax become mandatory. + could be provided by URL parameters. For such cases (societe/ajax/company.php), use of Universal Filter Syntax become mandatory. * The signature of method getNomUrl() of class ProductFournisseur has been modified to match the signature of method Product->getNomUrl() * Trigger ORDER_SUPPLIER_DISPATCH is removed, use ORDER_SUPPLIER_RECEIVE and/or LINEORDER_SUPPLIER_DISPATCH instead. * All functions fetch_all() have been set to deprecated for naming consistency, use fetchAll() instead. @@ -1164,7 +1164,7 @@ FIX: #23019 Impossible to add task times to an existing draft invoice FIX: #23072 FIX: #23075 FIX: #23087 -FIX: #23115 +FIX: #23115 FIX: #23116 FIX: #23117 FIX: #23281 @@ -7551,7 +7551,7 @@ FIX: #4583 Incorrect call of Categories::containing throws a DoliDB error FIX: #4649 Wrong parameters order FIX: #4768 FIX: #4785 -FIX: Add a test to show bugged module with a bad declaration of dictionaries to avoid to see clean module to be breaked. +FIX: Add a test to show bugged module with a bad declaration of dictionaries to avoid clean modules to be broken. FIX: add Croatia into list of country in EEC FIX: add missing global def for ttc column FIX: ajax error with multicompany module diff --git a/dev/tools/codespell/codespell-lines-ignore.txt b/dev/tools/codespell/codespell-lines-ignore.txt index 0d4e979d84a..fe245f74b46 100644 --- a/dev/tools/codespell/codespell-lines-ignore.txt +++ b/dev/tools/codespell/codespell-lines-ignore.txt @@ -21,6 +21,7 @@ print ''.$langs->trans("TransferStock").''; $action = 'transfert'; $ensemblereponses = $obj->reponses; + $return .= '
'.$langs->trans("Payement").' : '.$this->type_payment.''; $sql = 'INSERT INTO '.MAIN_DB_PREFIX.'opensurvey_user_studs (nom, id_sondage, reponses, date_creation)'; $sql = 'INSERT INTO '.MAIN_DB_PREFIX.'opensurvey_user_studs (nom, id_sondage, reponses, ip, date_creation)'; $sql = 'SELECT s.reponses'; @@ -61,5 +62,6 @@ $usercandelete = $user->rights->stock->mouvement->creer; $usercandelete = (($user->rights->stock->mouvement->supprimer)); $usercanread = $user->rights->stock->mouvement->lire; $usercanread = (($user->rights->stock->mouvement->lire)); +* The private array ->status_short, ->statuts and ->status_long are now array ->labelStatusShort and ->labelStatus everywhere. if (!$user->hasRight('stock', 'mouvement', 'lire')) { if ($action == "transfert") { diff --git a/htdocs/admin/stock.php b/htdocs/admin/stock.php index 2e28b567e41..9b088c7e660 100644 --- a/htdocs/admin/stock.php +++ b/htdocs/admin/stock.php @@ -33,7 +33,7 @@ require_once DOL_DOCUMENT_ROOT.'/product/class/html.formproduct.class.php'; // Load translation files required by the page $langs->loadLangs(array("admin", "stocks")); -// Securit check +// Security check if (!$user->admin) { accessforbidden(); } diff --git a/htdocs/categories/class/api_categories.class.php b/htdocs/categories/class/api_categories.class.php index e15571e5481..b938298f2c1 100644 --- a/htdocs/categories/class/api_categories.class.php +++ b/htdocs/categories/class/api_categories.class.php @@ -416,7 +416,7 @@ class Categories extends DolibarrApi return array( 'success' => array( 'code' => 200, - 'message' => 'Objects succefully linked to the category' + 'message' => 'Objects successfully linked to the category' ) ); } @@ -496,7 +496,7 @@ class Categories extends DolibarrApi return array( 'success' => array( 'code' => 200, - 'message' => 'Objects succefully linked to the category' + 'message' => 'Objects successfully linked to the category' ) ); } @@ -574,7 +574,7 @@ class Categories extends DolibarrApi return array( 'success' => array( 'code' => 200, - 'message' => 'Objects succefully unlinked from the category' + 'message' => 'Objects successfully unlinked from the category' ) ); } @@ -652,7 +652,7 @@ class Categories extends DolibarrApi return array( 'success' => array( 'code' => 200, - 'message' => 'Objects succefully unlinked from the category' + 'message' => 'Objects successfully unlinked from the category' ) ); } diff --git a/htdocs/compta/bank/line.php b/htdocs/compta/bank/line.php index f62fbd1af75..0679b01951c 100644 --- a/htdocs/compta/bank/line.php +++ b/htdocs/compta/bank/line.php @@ -651,7 +651,7 @@ if ($result) { print ""; // Code to adjust value date with plus and less picto using an Ajax call instead of a full reload of page - /* Not yet ready. We must manage inline replacemet of input date field + /* Not yet ready. We must manage inline replacement of input date field $urlajax = DOL_URL_ROOT.'/core/ajax/bankconciliate.php?token='.currentToken(); print '