trypost/tests/Feature/Mcp/McpRoleAuthorizationTest.php
Paulo Castellano eb2b345163
feat: Asset Library list, preview, and attach via API and MCP (#282)
* feat: list, preview, and attach Asset Library media via API and MCP

Let API and MCP clients reuse workspace assets instead of re-uploading, sharing the same scoped query, signed preview, and idempotent attach path.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Align Asset Library API and MCP with main media patterns.

Drop the signed-preview stack, return Storage URLs and PostResource like existing attach flows, and query medias by morph owner instead of getMedia().

Co-authored-by: Cursor <cursoragent@cursor.com>

* Paginate workspace assets with the app default page size.

Keep list pagination in the action via config('app.pagination.default') instead of a hardcoded API page size.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Move asset API and MCP input rules into FormRequests.

Keep controllers and tools free of inline field validation; MCP tools reuse the request rule definitions.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Document asset MCP tools with explicit parameters and constraints.

Spell out workspace scope, return fields, sibling tools, and rejection cases so agents can call list/get/attach without guessing.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden asset attach against races and keep library metadata on the post.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Relock the library asset on attach so a deleted file cannot land on the post.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Document that omitting alt on attach keeps the library alt text.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-16 17:08:20 -03:00

222 lines
8.7 KiB
PHP

<?php
declare(strict_types=1);
use App\Enums\SocialAccount\Platform;
use App\Enums\UserWorkspace\Role;
use App\Mcp\Servers\TryPostServer;
use App\Mcp\Tools\Asset\AttachExistingAssetTool;
use App\Mcp\Tools\Asset\GetAssetTool;
use App\Mcp\Tools\Asset\ListAssetsTool;
use App\Mcp\Tools\Label\CreateLabelTool;
use App\Mcp\Tools\Label\DeleteLabelTool;
use App\Mcp\Tools\Label\ListLabelsTool;
use App\Mcp\Tools\Label\UpdateLabelTool;
use App\Mcp\Tools\Post\AttachMediaFromUploadTool;
use App\Mcp\Tools\Post\AttachMediaFromUrlTool;
use App\Mcp\Tools\Post\PublishPostTool;
use App\Mcp\Tools\Post\RequestMediaUploadTool;
use App\Mcp\Tools\Signature\CreateSignatureTool;
use App\Mcp\Tools\Signature\DeleteSignatureTool;
use App\Mcp\Tools\Signature\ListSignaturesTool;
use App\Mcp\Tools\Signature\UpdateSignatureTool;
use App\Mcp\Tools\SocialAccount\ListDiscordChannelsTool;
use App\Mcp\Tools\SocialAccount\ListPinterestBoardsTool;
use App\Mcp\Tools\SocialAccount\ListSocialAccountsTool;
use App\Mcp\Tools\SocialAccount\ToggleSocialAccountTool;
use App\Models\Media;
use App\Models\Post;
use App\Models\SocialAccount;
use App\Models\User;
use App\Models\Workspace;
use App\Models\WorkspaceLabel;
use App\Models\WorkspaceSignature;
use Illuminate\Support\Str;
use Illuminate\Testing\Fluent\AssertableJson;
beforeEach(function () {
$this->owner = User::factory()->create();
$this->workspace = Workspace::factory()->create(['user_id' => $this->owner->id]);
$this->workspace->members()->attach($this->owner->id, ['role' => Role::Admin->value]);
$this->owner->update(['current_workspace_id' => $this->workspace->id]);
$this->viewer = User::factory()->create(['account_id' => $this->owner->account_id]);
$this->workspace->members()->attach($this->viewer->id, ['role' => Role::Viewer->value]);
$this->viewer->update(['current_workspace_id' => $this->workspace->id]);
$this->member = User::factory()->create(['account_id' => $this->owner->account_id]);
$this->workspace->members()->attach($this->member->id, ['role' => Role::Member->value]);
$this->member->update(['current_workspace_id' => $this->workspace->id]);
$this->post = Post::factory()->create([
'workspace_id' => $this->workspace->id,
'user_id' => $this->owner->id,
]);
});
test('viewers can list labels signatures and social accounts via mcp', function () {
WorkspaceLabel::factory()->create(['workspace_id' => $this->workspace->id]);
WorkspaceSignature::factory()->create(['workspace_id' => $this->workspace->id]);
SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
'platform' => Platform::LinkedIn,
]);
TryPostServer::actingAs($this->viewer)
->tool(ListLabelsTool::class, [])
->assertOk()
->assertStructuredContent(fn (AssertableJson $json) => $json->has('labels', 1)->etc());
TryPostServer::actingAs($this->viewer)
->tool(ListSignaturesTool::class, [])
->assertOk()
->assertStructuredContent(fn (AssertableJson $json) => $json->has('signatures', 1)->etc());
TryPostServer::actingAs($this->viewer)
->tool(ListSocialAccountsTool::class, [])
->assertOk()
->assertStructuredContent(fn (AssertableJson $json) => $json->has('social_accounts', 1)->etc());
});
test('viewers cannot publish attach media or request uploads via mcp', function () {
$uploadToken = (string) Str::uuid();
Media::factory()->create([
'mediable_type' => (new Workspace)->getMorphClass(),
'mediable_id' => $this->workspace->id,
'collection' => 'assets',
'upload_token' => $uploadToken,
]);
TryPostServer::actingAs($this->viewer)
->tool(PublishPostTool::class, ['post_id' => $this->post->id])
->assertHasErrors(['Not authorized to publish this post.']);
TryPostServer::actingAs($this->viewer)
->tool(AttachMediaFromUrlTool::class, [
'post_id' => $this->post->id,
'urls' => [['url' => 'https://example.com/photo.jpg']],
])
->assertHasErrors(['Not authorized to update this post.']);
TryPostServer::actingAs($this->viewer)
->tool(AttachMediaFromUploadTool::class, [
'post_id' => $this->post->id,
'upload_token' => $uploadToken,
])
->assertHasErrors(['Not authorized to update this post.']);
TryPostServer::actingAs($this->viewer)
->tool(RequestMediaUploadTool::class, [])
->assertHasErrors(['Not authorized to upload media.']);
TryPostServer::actingAs($this->viewer)
->tool(ListAssetsTool::class, [])
->assertHasErrors(['Not authorized to view assets.']);
TryPostServer::actingAs($this->viewer)
->tool(GetAssetTool::class, ['asset_id' => (string) Str::uuid()])
->assertHasErrors(['Not authorized to view assets.']);
TryPostServer::actingAs($this->viewer)
->tool(AttachExistingAssetTool::class, [
'post_id' => $this->post->id,
'asset_id' => (string) Str::uuid(),
])
->assertHasErrors(['Not authorized to update this post.']);
});
test('viewers cannot manage labels or signatures via mcp', function () {
$label = WorkspaceLabel::factory()->create(['workspace_id' => $this->workspace->id]);
$signature = WorkspaceSignature::factory()->create(['workspace_id' => $this->workspace->id]);
TryPostServer::actingAs($this->viewer)
->tool(CreateLabelTool::class, ['name' => 'Nope', 'color' => '#112233'])
->assertHasErrors(['Not authorized to manage labels.']);
TryPostServer::actingAs($this->viewer)
->tool(UpdateLabelTool::class, [
'label_id' => $label->id,
'name' => 'Nope',
'color' => '#112233',
])
->assertHasErrors(['Not authorized to manage labels.']);
TryPostServer::actingAs($this->viewer)
->tool(DeleteLabelTool::class, ['label_id' => $label->id])
->assertHasErrors(['Not authorized to manage labels.']);
TryPostServer::actingAs($this->viewer)
->tool(CreateSignatureTool::class, ['name' => 'Nope', 'content' => 'x'])
->assertHasErrors(['Not authorized to manage signatures.']);
TryPostServer::actingAs($this->viewer)
->tool(UpdateSignatureTool::class, [
'signature_id' => $signature->id,
'name' => 'Nope',
'content' => 'x',
])
->assertHasErrors(['Not authorized to manage signatures.']);
TryPostServer::actingAs($this->viewer)
->tool(DeleteSignatureTool::class, ['signature_id' => $signature->id])
->assertHasErrors(['Not authorized to manage signatures.']);
expect($label->fresh())->not->toBeNull()
->and($signature->fresh())->not->toBeNull();
});
test('viewers cannot toggle social accounts or list compose helpers via mcp', function () {
$linkedin = SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
'platform' => Platform::LinkedIn,
'is_active' => true,
]);
$discord = SocialAccount::factory()->discord()->create([
'workspace_id' => $this->workspace->id,
]);
$pinterest = SocialAccount::factory()->pinterest()->create([
'workspace_id' => $this->workspace->id,
]);
TryPostServer::actingAs($this->viewer)
->tool(ToggleSocialAccountTool::class, ['account_id' => $linkedin->id])
->assertHasErrors(['Not authorized to manage social accounts.']);
TryPostServer::actingAs($this->viewer)
->tool(ListDiscordChannelsTool::class, ['account_id' => $discord->id])
->assertHasErrors(['Not authorized to manage posts.']);
TryPostServer::actingAs($this->viewer)
->tool(ListPinterestBoardsTool::class, ['account_id' => $pinterest->id])
->assertHasErrors(['Not authorized to manage posts.']);
expect($linkedin->fresh()->is_active)->toBeTrue();
});
test('members cannot toggle social accounts via mcp', function () {
$account = SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
'platform' => Platform::LinkedIn,
'is_active' => true,
]);
TryPostServer::actingAs($this->member)
->tool(ToggleSocialAccountTool::class, ['account_id' => $account->id])
->assertHasErrors(['Not authorized to manage social accounts.']);
expect($account->fresh()->is_active)->toBeTrue();
});
test('admins can toggle social accounts via mcp', function () {
$account = SocialAccount::factory()->create([
'workspace_id' => $this->workspace->id,
'platform' => Platform::LinkedIn,
'is_active' => true,
]);
TryPostServer::actingAs($this->owner)
->tool(ToggleSocialAccountTool::class, ['account_id' => $account->id])
->assertOk();
expect($account->fresh()->is_active)->toBeFalse();
});