The previous suite asserted happy paths and a couple of basic field omissions but didn't probe the rules themselves. Adds 26 tests across 5 files: REST API (tests/Feature/Api/PostApiTest.php) — 9 new: - content_type not in the enum - content_type mismatched with the social account's platform - label_id from another workspace - platforms[].id from another post on update (cross-post leak) - content_type mismatched with the post_platform on update - status=scheduled requires future scheduled_at - status=draft works with no scheduled_at - past scheduled_at on store MCP create-post-tool (tests/Feature/Mcp/PostToolTest.php) — 5 new: - inactive social account - content_type not in the enum - content_type mismatched with the social account's platform - label_id from another workspace - already had: scheduled_at past MCP update-post-tool (tests/Feature/Mcp/PostPublishToolTest.php) — 2 new: - platforms[].id from another post (regression for the new Rule::exists scoping) - content_type mismatched with the post_platform MCP attach-media-from-url-tool (tests/Feature/Mcp/AttachMediaFromUrlToolTest.php) — 3 new: - non-http(s) scheme (ftp://...) - malformed url string - more than 10 URLs per call Custom rules unit tests — 2 new files: - ContentTypeMatchesPlatformTest covers happy path, cross-platform mismatch, the Instagram + InstagramFacebook compatibility bridge, and the no-op cases (missing account_id, unknown content_type — those are caught by Rule::in elsewhere). - ContentTypeMatchesPostPlatformTest covers the equivalent shape for the update flow that pivots through post_platform.id.
451 lines
15 KiB
PHP
451 lines
15 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Enums\Post\Status as PostStatus;
|
|
use App\Enums\PostPlatform\ContentType;
|
|
use App\Enums\SocialAccount\Platform;
|
|
use App\Models\Post;
|
|
use App\Models\PostPlatform;
|
|
use App\Models\SocialAccount;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceLabel;
|
|
|
|
beforeEach(function () {
|
|
$result = createApiTestToken();
|
|
$this->user = $result['user'];
|
|
$this->workspace = $result['workspace'];
|
|
$this->plainToken = $result['plain_token'];
|
|
|
|
$this->socialAccount = SocialAccount::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform' => Platform::LinkedIn,
|
|
]);
|
|
});
|
|
|
|
it('lists posts', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->getJson(route('api.posts.index'))
|
|
->assertOk()
|
|
->assertJsonCount(1, 'data');
|
|
});
|
|
|
|
it('shows a post', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->getJson(route('api.posts.show', $post))
|
|
->assertOk()
|
|
->assertJsonPath('id', $post->id);
|
|
});
|
|
|
|
it('cannot show post from another workspace', function () {
|
|
$otherWorkspace = Workspace::factory()->create();
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $otherWorkspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->getJson(route('api.posts.show', $post))
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('creates a post', function () {
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
[
|
|
'social_account_id' => $this->socialAccount->id,
|
|
'content_type' => 'linkedin_post',
|
|
],
|
|
],
|
|
])
|
|
->assertCreated()
|
|
->assertJsonPath('status', PostStatus::Draft->value);
|
|
|
|
expect(Post::where('workspace_id', $this->workspace->id)->count())->toBe(1);
|
|
});
|
|
|
|
it('creates a post with content, media, and labels', function () {
|
|
$label = WorkspaceLabel::factory()->create(['workspace_id' => $this->workspace->id]);
|
|
|
|
$payload = [
|
|
'content' => 'Hello from the API',
|
|
'media' => [['id' => 'media-1', 'path' => 'media/foo.jpg', 'url' => 'https://example.com/foo.jpg', 'type' => 'image']],
|
|
'platforms' => [
|
|
['social_account_id' => $this->socialAccount->id, 'content_type' => 'linkedin_post'],
|
|
],
|
|
'label_ids' => [$label->id],
|
|
];
|
|
|
|
$response = $this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), $payload)
|
|
->assertCreated();
|
|
|
|
$post = Post::where('workspace_id', $this->workspace->id)->first();
|
|
|
|
expect($post->content)->toBe('Hello from the API');
|
|
expect($post->media)->toHaveCount(1);
|
|
expect($post->labels()->pluck('workspace_labels.id')->all())->toContain($label->id);
|
|
|
|
$response->assertJsonPath('content', 'Hello from the API');
|
|
});
|
|
|
|
it('rejects creating a post with an inactive social account', function () {
|
|
$inactive = SocialAccount::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'platform' => Platform::LinkedIn,
|
|
'is_active' => false,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['social_account_id' => $inactive->id, 'content_type' => 'linkedin_post'],
|
|
],
|
|
])
|
|
->assertJsonValidationErrors(['platforms.0.social_account_id']);
|
|
});
|
|
|
|
it('deletes a post', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->deleteJson(route('api.posts.destroy', $post))
|
|
->assertNoContent();
|
|
|
|
expect(Post::find($post->id))->toBeNull();
|
|
});
|
|
|
|
it('cannot delete post from another workspace', function () {
|
|
$otherWorkspace = Workspace::factory()->create();
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $otherWorkspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->deleteJson(route('api.posts.destroy', $post))
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('updates a post', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
]);
|
|
|
|
$postPlatform = PostPlatform::factory()->linkedin()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->socialAccount->id,
|
|
'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'draft',
|
|
'platforms' => [
|
|
[
|
|
'id' => $postPlatform->id,
|
|
'content_type' => ContentType::LinkedInPost->value,
|
|
],
|
|
],
|
|
])
|
|
->assertOk();
|
|
});
|
|
|
|
it('cannot update post from another workspace', function () {
|
|
$otherWorkspace = Workspace::factory()->create();
|
|
$otherSocialAccount = SocialAccount::factory()->create([
|
|
'workspace_id' => $otherWorkspace->id,
|
|
'platform' => Platform::LinkedIn,
|
|
]);
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $otherWorkspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
$postPlatform = PostPlatform::factory()->linkedin()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $otherSocialAccount->id,
|
|
'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'draft',
|
|
'platforms' => [
|
|
[
|
|
'id' => $postPlatform->id,
|
|
'content_type' => ContentType::LinkedInPost->value,
|
|
],
|
|
],
|
|
])
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('cannot update published post', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Published,
|
|
]);
|
|
|
|
$postPlatform = PostPlatform::factory()->linkedin()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->socialAccount->id,
|
|
'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'draft',
|
|
'platforms' => [
|
|
[
|
|
'id' => $postPlatform->id,
|
|
'content_type' => ContentType::LinkedInPost->value,
|
|
],
|
|
],
|
|
])
|
|
->assertUnprocessable();
|
|
});
|
|
|
|
it('validates post update fields', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'platforms' => [
|
|
['content' => 'missing id'],
|
|
],
|
|
])
|
|
->assertUnprocessable();
|
|
});
|
|
|
|
it('validates post creation requires platforms', function () {
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms']);
|
|
});
|
|
|
|
it('validates post creation platform fields', function () {
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['content' => 'missing social_account_id and content_type'],
|
|
],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['platforms.0.social_account_id', 'platforms.0.content_type']);
|
|
});
|
|
|
|
it('validates post update invalid status', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'invalid_status',
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['status']);
|
|
});
|
|
|
|
it('validates post update scheduled_at must be date', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'scheduled_at' => 'not-a-date',
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['scheduled_at']);
|
|
});
|
|
|
|
it('validates post update label_ids must be uuids', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'label_ids' => ['not-a-uuid'],
|
|
])
|
|
->assertUnprocessable()
|
|
->assertJsonValidationErrors(['label_ids.0']);
|
|
});
|
|
|
|
it('rejects creating a post with content_type not in the enum', function () {
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['social_account_id' => $this->socialAccount->id, 'content_type' => 'made_up_type'],
|
|
],
|
|
])
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('rejects creating a post when content_type does not match the social account platform', function () {
|
|
// x_post on a LinkedIn account — ContentTypeMatchesPlatform should reject.
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['social_account_id' => $this->socialAccount->id, 'content_type' => 'x_post'],
|
|
],
|
|
])
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('rejects creating a post with a label from another workspace', function () {
|
|
$otherWorkspace = Workspace::factory()->create();
|
|
$foreignLabel = WorkspaceLabel::factory()->create(['workspace_id' => $otherWorkspace->id]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['social_account_id' => $this->socialAccount->id, 'content_type' => 'linkedin_post'],
|
|
],
|
|
'label_ids' => [$foreignLabel->id],
|
|
])
|
|
->assertJsonValidationErrors(['label_ids.0']);
|
|
});
|
|
|
|
it('rejects updating a post with a platforms[].id that belongs to another post', function () {
|
|
$myPost = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
]);
|
|
|
|
$otherPost = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
]);
|
|
$foreignPlatform = PostPlatform::factory()->linkedin()->create([
|
|
'post_id' => $otherPost->id,
|
|
'social_account_id' => $this->socialAccount->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $myPost), [
|
|
'status' => 'draft',
|
|
'platforms' => [
|
|
['id' => $foreignPlatform->id, 'content_type' => ContentType::LinkedInPost->value],
|
|
],
|
|
])
|
|
->assertJsonValidationErrors(['platforms.0.id']);
|
|
});
|
|
|
|
it('rejects updating a post when content_type does not match the post_platform', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
]);
|
|
$postPlatform = PostPlatform::factory()->linkedin()->create([
|
|
'post_id' => $post->id,
|
|
'social_account_id' => $this->socialAccount->id,
|
|
'enabled' => true,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'draft',
|
|
'platforms' => [
|
|
['id' => $postPlatform->id, 'content_type' => 'x_post'],
|
|
],
|
|
])
|
|
->assertJsonValidationErrors(['platforms.0.content_type']);
|
|
});
|
|
|
|
it('rejects scheduled status without a future scheduled_at', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
'scheduled_at' => now()->subDay(),
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'scheduled',
|
|
'scheduled_at' => now()->subHour()->toIso8601String(),
|
|
])
|
|
->assertJsonValidationErrors(['scheduled_at']);
|
|
});
|
|
|
|
it('accepts draft status with no scheduled_at', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
'status' => PostStatus::Draft,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->putJson(route('api.posts.update', $post), [
|
|
'status' => 'draft',
|
|
])
|
|
->assertOk();
|
|
});
|
|
|
|
it('rejects creating a post with a past scheduled_at', function () {
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->postJson(route('api.posts.store'), [
|
|
'platforms' => [
|
|
['social_account_id' => $this->socialAccount->id, 'content_type' => 'linkedin_post'],
|
|
],
|
|
'scheduled_at' => now()->subDay()->toIso8601String(),
|
|
])
|
|
->assertJsonValidationErrors(['scheduled_at']);
|
|
});
|
|
|
|
it('list posts returns correct structure', function () {
|
|
Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->getJson(route('api.posts.index'))
|
|
->assertOk()
|
|
->assertJsonStructure([
|
|
'data' => [
|
|
'*' => ['id', 'status', 'scheduled_at', 'published_at', 'created_at', 'updated_at'],
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('show post returns correct structure', function () {
|
|
$post = Post::factory()->create([
|
|
'workspace_id' => $this->workspace->id,
|
|
'user_id' => $this->user->id,
|
|
]);
|
|
|
|
$this->withHeaders(['Authorization' => 'Bearer '.$this->plainToken])
|
|
->getJson(route('api.posts.show', $post))
|
|
->assertOk()
|
|
->assertJsonStructure(['id', 'status', 'scheduled_at', 'published_at']);
|
|
});
|