332513e360
Two regex pieces in StoreChunkedAssetRequest, both replaced by more
fitting tools:
1. Parsing 'Content-Range' header — preg_match with capturing groups
and $matches[1..3] indexing replaced by sscanf, which is
purpose-built for parsing structured strings with a known format:
$parsed = sscanf($header, 'bytes %d-%d/%d') ?: [];
$start = $parsed[0] ?? null;
No regex, no $matches array, no manual int casts (sscanf returns ints
for %d).
2. Validating filename suffix — regex:/\.(jpe?g|png|gif|webp|mp4)$/i
replaced by Laravel's built-in 'ends_with' rule, with extensions
derived from the MediaType enum:
$allowedSuffixes = collect([Image, Video])
->flatMap(fn (MediaType $t) => $t->extensions())
->map(fn ($ext) => '.'.$ext)
->all();
For the case-insensitive part, normalize the filename to lowercase
in prepareForValidation so 'IMG_1234.JPG' matches '.jpg' naturally.
Added MediaType::extensions() — single source of truth for filename
suffixes (jpg/jpeg/png/gif/webp + mp4/mov/webm). Mirrors
allowedMimeTypes() for callers that validate by name instead of MIME.
68 lines
2.3 KiB
PHP
68 lines
2.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Http\Requests\App\Asset;
|
|
|
|
use App\Enums\Media\Type as MediaType;
|
|
use Illuminate\Foundation\Http\FormRequest;
|
|
|
|
/**
|
|
* Validates a chunked upload request. The chunk metadata (offset / total
|
|
* size / filename) is encoded in the `Content-Range` and `X-File-Name`
|
|
* headers, not in the body, so we lift it into the request bag via
|
|
* `prepareForValidation` and then run standard rules against it.
|
|
*/
|
|
class StoreChunkedAssetRequest extends FormRequest
|
|
{
|
|
public function authorize(): bool
|
|
{
|
|
return true;
|
|
}
|
|
|
|
protected function prepareForValidation(): void
|
|
{
|
|
$parsed = sscanf((string) $this->header('Content-Range'), 'bytes %d-%d/%d') ?: [];
|
|
|
|
$this->merge([
|
|
'range_start' => $parsed[0] ?? null,
|
|
'range_end' => $parsed[1] ?? null,
|
|
'total_size' => $parsed[2] ?? null,
|
|
// Lowercase the name so `ends_with` validation is effectively
|
|
// case-insensitive (IMG_1234.JPG vs img_1234.jpg).
|
|
'file_name' => strtolower((string) $this->header('X-File-Name', 'upload')),
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* @return array<string, array<int, string>>
|
|
*/
|
|
public function rules(): array
|
|
{
|
|
$allowedSuffixes = collect([MediaType::Image, MediaType::Video])
|
|
->flatMap(fn (MediaType $type) => $type->extensions())
|
|
->map(fn (string $ext) => '.'.$ext)
|
|
->all();
|
|
|
|
return [
|
|
'range_start' => ['required', 'integer', 'min:0'],
|
|
'range_end' => ['required', 'integer', 'gte:range_start'],
|
|
'total_size' => ['required', 'integer', 'min:1', 'max:'.MediaType::Video->maxSizeInBytes()],
|
|
'file_name' => ['required', 'string', 'ends_with:'.implode(',', $allowedSuffixes)],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array<string, string>
|
|
*/
|
|
public function messages(): array
|
|
{
|
|
return [
|
|
'range_start.required' => 'Invalid Content-Range header',
|
|
'range_end.required' => 'Invalid Content-Range header',
|
|
'total_size.required' => 'Invalid Content-Range header',
|
|
'total_size.max' => 'File size exceeds the maximum allowed ('.MediaType::Video->maxSizeInMb().' MB).',
|
|
'file_name.ends_with' => 'File type not supported.',
|
|
];
|
|
}
|
|
}
|