83ba72ddc6
TokenRefreshClient classified every non-5xx/429 refresh failure as a dead token. Meta returns rate-limit (code 4/17) and transient (code 1/2) errors as HTTP 4xx with type OAuthException, so a throttled proactive refresh was disconnecting still-valid Instagram/Threads tokens — and the wider 24h/15-min refresh cadence raised the odds of hitting it. Classification now keys on error code 190 (the signal the publish exceptions already use): only a genuine 190 disconnects; every other Meta 4xx is treated as transient (PlatformUnavailable) and retried next cycle. The same over-broad type-based check in verifyInstagram/verifyFacebook/verifyThreads is replaced with the shared Meta\GraphError helper so verify and refresh agree.
90 lines
3.3 KiB
PHP
90 lines
3.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Services\Social;
|
|
|
|
use App\Enums\SocialAccount\Platform;
|
|
use App\Exceptions\PlatformUnavailableException;
|
|
use App\Exceptions\TokenExpiredException;
|
|
use Closure;
|
|
use Illuminate\Http\Client\ConnectionException;
|
|
use Illuminate\Http\Client\Response;
|
|
use Illuminate\Support\Facades\Log;
|
|
|
|
/**
|
|
* Normalizes the failure modes of an OAuth token-refresh request:
|
|
*
|
|
* - ConnectionException (timeout / DNS / refused) → PlatformUnavailableException
|
|
* - HTTP 5xx or 429 → PlatformUnavailableException
|
|
* - other HTTP 4xx → TokenExpiredException
|
|
*
|
|
* Providers that return rate-limit or transient errors as an ordinary 4xx
|
|
* (Meta: Instagram/Threads) can pass an `$isTokenInvalid` classifier to
|
|
* `send()`; only a genuinely dead token then disconnects, while every other
|
|
* 4xx is treated as transient (PlatformUnavailableException).
|
|
*
|
|
* Callers configure the actual HTTP call through the closure passed to
|
|
* `send()`, so platform-specific quirks (form vs JSON body, auth headers,
|
|
* basic auth, etc.) stay where they belong — in the per-platform refresh
|
|
* method.
|
|
*/
|
|
class TokenRefreshClient
|
|
{
|
|
public function __construct(public readonly Platform $platform) {}
|
|
|
|
public static function for(Platform $platform): self
|
|
{
|
|
return new self($platform);
|
|
}
|
|
|
|
/**
|
|
* @param Closure():Response $request
|
|
* @param (Closure(array<string, mixed>|null):bool)|null $isTokenInvalid Given the parsed
|
|
* response body, returns whether a non-5xx/429 failure means the token itself is dead.
|
|
* When it returns false, the failure is treated as transient (PlatformUnavailableException).
|
|
*
|
|
* @throws PlatformUnavailableException
|
|
* @throws TokenExpiredException
|
|
*/
|
|
public function send(Closure $request, ?Closure $isTokenInvalid = null): Response
|
|
{
|
|
$name = $this->platform->label();
|
|
|
|
try {
|
|
$response = $request();
|
|
} catch (ConnectionException $e) {
|
|
throw new PlatformUnavailableException("{$name} API unreachable: {$e->getMessage()}");
|
|
}
|
|
|
|
if ($response->serverError() || $response->status() === 429) {
|
|
throw new PlatformUnavailableException(
|
|
"{$name} API returned {$response->status()} during token refresh",
|
|
$response->status(),
|
|
);
|
|
}
|
|
|
|
if ($response->failed()) {
|
|
Log::error("TokenRefreshClient: {$name} token refresh failed", [
|
|
'body' => TokenRedactor::redact($response->body()),
|
|
]);
|
|
|
|
$body = $response->json();
|
|
|
|
if ($isTokenInvalid !== null && ! $isTokenInvalid($body)) {
|
|
throw new PlatformUnavailableException(
|
|
"{$name} API returned {$response->status()} during token refresh",
|
|
$response->status(),
|
|
);
|
|
}
|
|
|
|
$message = data_get($body, 'error_description')
|
|
?? data_get($body, 'error.message')
|
|
?? "Failed to refresh {$name} token";
|
|
|
|
throw new TokenExpiredException($message, platformErrorCode: (string) $response->status());
|
|
}
|
|
|
|
return $response;
|
|
}
|
|
}
|