trypost/app/Http/Controllers/Api/PostController.php
Paulo Castellano 8d7dcdf6eb refactor(social): trim verbose comments + harden X chunked upload from review
Cold-review follow-ups on the PR:
- Trim the oversized docblocks/inline comments added across the API controller,
  MediaAttacher, Post, the publish job, and the X publisher to one line (keeping
  the @param/@return array-shape annotations).
- XPublisher::chunkedUpload now accepts ?string $mediaCategory and only sends
  media_category when present — getMediaCategory() can return null, so the strict
  string param was a latent TypeError (unreachable on X today, removed anyway).
- Fix MediaAttacher docblocks: the file imports Type as MediaType, so the
  @param array<Type> annotations didn't resolve — now array<MediaType>.
- Tests: cover the failed() job hook genericizing a raw error, and X failing
  cleanly (XPublishException) when media can't be downloaded.
2026-06-28 20:37:04 -03:00

200 lines
6.2 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api;
use App\Actions\Post\CreatePost;
use App\Actions\Post\DeletePost;
use App\Actions\Post\UpdatePost;
use App\Enums\Media\Type as MediaType;
use App\Enums\Post\Action as PostAction;
use App\Http\Requests\Api\Post\AttachMediaFromUrlRequest;
use App\Http\Requests\Api\Post\StoreMediaRequest;
use App\Http\Requests\Api\Post\StorePostRequest;
use App\Http\Requests\Api\Post\UpdatePostRequest;
use App\Http\Resources\Api\PostMediaAttachResource;
use App\Http\Resources\Api\PostMetricsResource;
use App\Http\Resources\Api\PostPreviewResource;
use App\Http\Resources\Api\PostResource;
use App\Models\Post;
use App\Models\Workspace;
use App\Services\Post\MediaAttacher;
use App\Support\PostStatusRules;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Illuminate\Validation\ValidationException;
use Symfony\Component\HttpFoundation\Response;
class PostController extends Controller
{
public function index(Request $request): AnonymousResourceCollection
{
$posts = $request->user()->currentWorkspace->posts()
->with(['postPlatforms.socialAccount', 'user', 'labels'])
->latest('scheduled_at')
->paginate(15);
return PostResource::collection($posts);
}
public function show(Request $request, Post $post): PostResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount', 'user', 'labels']);
return new PostResource($post);
}
public function store(StorePostRequest $request): JsonResponse
{
$workspace = $request->user()->currentWorkspace;
$data = $request->validated();
if (array_key_exists('media', $data)) {
$data['media'] = $this->hostInlineMedia(
$workspace,
Post::allowedMediaTypesFor($request->selectedPlatforms()),
$data['media'],
);
}
$post = CreatePost::execute($workspace, $workspace->owner, $data);
$post->load(['postPlatforms.socialAccount']);
return (new PostResource($post))
->response()
->setStatusCode(Response::HTTP_CREATED);
}
public function update(UpdatePostRequest $request, Post $post): PostResource|JsonResponse
{
$this->authorize('update', $post);
$data = $request->validated();
if (array_key_exists('media', $data)) {
$data['media'] = $this->hostInlineMedia(
$request->user()->currentWorkspace,
$post->allowedMediaTypes(),
$data['media'],
);
}
$result = UpdatePost::execute($request->user()->currentWorkspace, $post, $data);
if (data_get($result, 'action') === PostAction::Finalized) {
return response()->json(
['message' => PostStatusRules::editBlockedMessage()],
Response::HTTP_UNPROCESSABLE_ENTITY
);
}
$updated = data_get($result, 'post');
$updated->load(['postPlatforms.socialAccount']);
return new PostResource($updated);
}
/**
* Download and host external media URLs; reject (422) if one can't be fetched.
*
* @param array<MediaType> $allowedTypes
* @param array<int, array<string, mixed>> $media
* @return array<int, array<string, mixed>>
*
* @throws ValidationException
*/
private function hostInlineMedia(Workspace $workspace, array $allowedTypes, array $media): array
{
if ($media === []) {
return $media;
}
$result = app(MediaAttacher::class)->resolveInlineMedia($workspace, $allowedTypes, $media);
if ($result['failed'] !== []) {
throw ValidationException::withMessages([
'media' => ['Could not fetch media from URL: '.implode(', ', $result['failed'])],
]);
}
return $result['media'];
}
public function destroy(Request $request, Post $post): JsonResponse
{
$this->authorize('delete', $post);
DeletePost::execute($post);
return response()->json(null, Response::HTTP_NO_CONTENT);
}
public function storeMedia(StoreMediaRequest $request, Post $post): PostResource
{
$this->authorize('update', $post);
$file = $request->file('media');
$type = MediaType::fromMime((string) $file->getMimeType());
if ($type === null || ! in_array($type, $post->allowedMediaTypes(), true)) {
throw ValidationException::withMessages([
'media' => 'This file type is not supported by the platforms enabled on the post.',
]);
}
if ($file->getSize() > $type->maxSizeInBytes()) {
throw ValidationException::withMessages([
'media' => 'File size exceeds the maximum allowed for this media type.',
]);
}
$media = $post->workspace->addMedia($file, 'assets');
$post->appendMedia([[
'id' => $media->id,
'path' => $media->path,
'url' => $media->url,
'type' => $media->type,
'mime_type' => $media->mime_type,
'original_filename' => $media->original_filename,
]]);
$post->refresh()->load(['postPlatforms.socialAccount', 'labels']);
return new PostResource($post);
}
public function attachMediaFromUrl(AttachMediaFromUrlRequest $request, Post $post): PostMediaAttachResource
{
$this->authorize('update', $post);
$result = app(MediaAttacher::class)->attachFromUrls($post, $request->validated('urls'));
$post->refresh()->load(['postPlatforms.socialAccount', 'labels']);
return new PostMediaAttachResource($post, $result);
}
public function metrics(Request $request, Post $post): PostMetricsResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount']);
return new PostMetricsResource($post);
}
public function preview(Request $request, Post $post): PostPreviewResource
{
$this->authorize('view', $post);
$post->load(['postPlatforms.socialAccount']);
return new PostPreviewResource($post);
}
}