31b6544c57
Wrap the webhook HTTP send in a try/catch so a connection error returns a clean failed result (reason: request_failed) instead of bubbling up as a job failure — matching the HTTP request node. Add tests for the gaps in node-run coverage: - HTTP request: basic auth, PUT/PATCH/DELETE, non-2xx responses, connection exceptions, and an items_path that doesn't resolve to a list. - Webhook: every HTTP method, header expression resolution, and the new connection-failure path. - Fetch RSS: non-2xx feed responses, malformed XML, items without a publish date (skipped), and the link fallback when an item has no guid. - Delay: unknown unit throws. - Publish: dry runs don't publish or queue.
341 lines
15 KiB
PHP
341 lines
15 KiB
PHP
<?php
|
||
|
||
declare(strict_types=1);
|
||
|
||
use App\Actions\Automation\Node\RunFetchRssNode;
|
||
use App\Enums\Automation\NodeRun\Status as NodeRunStatus;
|
||
use App\Jobs\Automation\ProcessAutomationNode;
|
||
use App\Models\Automation;
|
||
use App\Models\AutomationNodeState;
|
||
use App\Models\AutomationRun;
|
||
use Carbon\CarbonImmutable;
|
||
use Illuminate\Support\Carbon;
|
||
use Illuminate\Support\Facades\Bus;
|
||
use Illuminate\Support\Facades\Http;
|
||
|
||
afterEach(fn () => Carbon::setTestNow());
|
||
|
||
const FETCH_RSS_OLD = <<<'XML'
|
||
<?xml version="1.0" encoding="UTF-8"?>
|
||
<rss version="2.0"><channel>
|
||
<item><title>Ancient</title><link>https://1.1.1.1/1</link><guid>1</guid><pubDate>Mon, 01 Jan 2024 12:00:00 +0000</pubDate></item>
|
||
<item><title>Old</title><link>https://1.1.1.1/2</link><guid>2</guid><pubDate>Sat, 01 Feb 2025 12:00:00 +0000</pubDate></item>
|
||
</channel></rss>
|
||
XML;
|
||
|
||
const FETCH_RSS_MIXED = <<<'XML'
|
||
<?xml version="1.0" encoding="UTF-8"?>
|
||
<rss version="2.0"><channel>
|
||
<item><title>Older</title><link>https://1.1.1.1/a</link><guid>a</guid><pubDate>Sat, 01 Feb 2025 12:00:00 +0000</pubDate></item>
|
||
<item><title>Newer1</title><link>https://1.1.1.1/b</link><guid>b</guid><pubDate>Sun, 01 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
<item><title>Newer2</title><link>https://1.1.1.1/c</link><guid>c</guid><pubDate>Mon, 15 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
</channel></rss>
|
||
XML;
|
||
|
||
const FETCH_RSS_THREE_NEW = <<<'XML'
|
||
<?xml version="1.0" encoding="UTF-8"?>
|
||
<rss version="2.0"><channel>
|
||
<item><title>New1</title><link>https://1.1.1.1/x</link><guid>x</guid><pubDate>Sun, 01 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
<item><title>New2</title><link>https://1.1.1.1/y</link><guid>y</guid><pubDate>Mon, 02 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
<item><title>New3</title><link>https://1.1.1.1/z</link><guid>z</guid><pubDate>Tue, 03 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
</channel></rss>
|
||
XML;
|
||
|
||
beforeEach(fn () => Bus::fake());
|
||
|
||
it('first execution dispatches nothing and stores watermark from newest item', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_OLD, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'end_1', 'type' => 'end', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'target' => 'end_1'],
|
||
],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
expect($result->status)->toBe(NodeRunStatus::Completed);
|
||
expect($result->nextHandle)->toBe('no_items');
|
||
|
||
$state = AutomationNodeState::where('automation_id', $automation->id)->where('node_id', 'fetch_1')->first();
|
||
expect($state)->not->toBeNull();
|
||
expect(CarbonImmutable::parse($state->data['last_item_date'])->toIso8601String())
|
||
->toBe(CarbonImmutable::parse('2025-02-01 12:00:00')->toIso8601String());
|
||
});
|
||
|
||
it('processes the first new item on the current run and spawns siblings for the rest', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_MIXED, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'end_1', 'type' => 'end', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'target' => 'end_1'],
|
||
],
|
||
]);
|
||
|
||
// Pre-seed watermark so 'Older' is below it; 'Newer1' and 'Newer2' should pass.
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-02-01T12:00:00+00:00'],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
expect($result->status)->toBe(NodeRunStatus::Completed);
|
||
expect($result->output['fetched']['key'])->toBe('b'); // oldest of the new items
|
||
expect($result->output['fetch']['count'])->toBe(2);
|
||
expect($result->output['fetch']['spawned'])->toBe(1);
|
||
|
||
// One sibling run created + dispatched at end_1
|
||
expect(AutomationRun::where('automation_id', $automation->id)->count())->toBe(2);
|
||
Bus::assertDispatchedTimes(ProcessAutomationNode::class, 1);
|
||
});
|
||
|
||
it('spawns sibling runs down the item edge for each remaining new item', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_THREE_NEW, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'generate_1', 'type' => 'generate', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'source_handle' => 'default', 'target' => 'generate_1'],
|
||
],
|
||
]);
|
||
|
||
// Watermark predates all three items, so every item is "new".
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-01-01T00:00:00+00:00'],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
// Current run handles item #1 (oldest); siblings handle #2 and #3.
|
||
expect($result->status)->toBe(NodeRunStatus::Completed);
|
||
expect($result->output['fetched']['key'])->toBe('x');
|
||
expect($result->output['fetch']['count'])->toBe(3);
|
||
expect($result->output['fetch']['spawned'])->toBe(2);
|
||
|
||
Bus::assertDispatchedTimes(ProcessAutomationNode::class, 2);
|
||
Bus::assertDispatched(
|
||
ProcessAutomationNode::class,
|
||
fn (ProcessAutomationNode $job) => $job->nodeId === 'generate_1',
|
||
);
|
||
});
|
||
|
||
it('fans every spawned item out across all branches wired to the fetch node', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_THREE_NEW, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'generate_1', 'type' => 'generate', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
['id' => 'webhook_1', 'type' => 'webhook', 'position' => ['x' => 400, 'y' => 200], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'source_handle' => 'default', 'target' => 'generate_1'],
|
||
['id' => 'e3', 'source' => 'fetch_1', 'source_handle' => 'default', 'target' => 'webhook_1'],
|
||
],
|
||
]);
|
||
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-01-01T00:00:00+00:00'],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
// 2 spawned items × 2 branches = 4 dispatches; both branches reached.
|
||
Bus::assertDispatchedTimes(ProcessAutomationNode::class, 4);
|
||
Bus::assertDispatched(ProcessAutomationNode::class, fn ($job) => $job->nodeId === 'generate_1');
|
||
Bus::assertDispatched(ProcessAutomationNode::class, fn ($job) => $job->nodeId === 'webhook_1');
|
||
});
|
||
|
||
it('does not persist the production watermark on a manual real-data test', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_MIXED, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'end_1', 'type' => 'end', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'target' => 'end_1'],
|
||
],
|
||
]);
|
||
|
||
// Watermark in the FUTURE: a production run would see zero new items here.
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2030-01-01T00:00:00+00:00'],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create([
|
||
'current_node_id' => 'fetch_1',
|
||
'is_manual' => true,
|
||
'is_dry_run' => false,
|
||
]);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
// A manual test IGNORES the watermark, so it always surfaces real data even
|
||
// when production would have already consumed every item.
|
||
expect($result->status)->toBe(NodeRunStatus::Completed);
|
||
expect($result->output['fetch']['count'])->toBeGreaterThan(0);
|
||
|
||
// ...and never advances the persisted watermark.
|
||
$state = AutomationNodeState::for($automation->id, 'fetch_1');
|
||
expect($state->data['last_item_date'])->toBe('2030-01-01T00:00:00+00:00');
|
||
});
|
||
|
||
it('advances the production watermark on a non-manual real-data run', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
Http::fake(['1.1.1.1/*' => Http::response(FETCH_RSS_MIXED, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create([
|
||
'nodes' => [
|
||
['id' => 'trigger_1', 'type' => 'trigger', 'position' => ['x' => 0, 'y' => 0], 'data' => ['trigger_type' => 'schedule']],
|
||
['id' => 'fetch_1', 'type' => 'fetch_rss', 'position' => ['x' => 200, 'y' => 0], 'data' => ['feed_url' => 'https://1.1.1.1/feed']],
|
||
['id' => 'end_1', 'type' => 'end', 'position' => ['x' => 400, 'y' => 0], 'data' => []],
|
||
],
|
||
'connections' => [
|
||
['id' => 'e1', 'source' => 'trigger_1', 'target' => 'fetch_1'],
|
||
['id' => 'e2', 'source' => 'fetch_1', 'target' => 'end_1'],
|
||
],
|
||
]);
|
||
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-01-01T00:00:00+00:00'],
|
||
]);
|
||
|
||
$run = AutomationRun::factory()->for($automation)->create([
|
||
'current_node_id' => 'fetch_1',
|
||
'is_manual' => false,
|
||
'is_dry_run' => false,
|
||
]);
|
||
|
||
app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
$state = AutomationNodeState::for($automation->id, 'fetch_1');
|
||
expect(CarbonImmutable::parse($state->data['last_item_date'])->toIso8601String())
|
||
->toBe(CarbonImmutable::parse('Mon, 15 Jun 2025 12:00:00 +0000')->toIso8601String());
|
||
});
|
||
|
||
it('fails when feed_url is missing', function () {
|
||
$automation = Automation::factory()->active()->create();
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, []);
|
||
|
||
expect($result->status)->toBe(NodeRunStatus::Failed);
|
||
});
|
||
|
||
it('fails when the feed request returns a non-2xx status', function () {
|
||
Http::fake(['1.1.1.1/*' => Http::response('upstream down', 500)]);
|
||
|
||
$automation = Automation::factory()->active()->create();
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed.xml']);
|
||
|
||
expect($result->status)->toBe(NodeRunStatus::Failed);
|
||
expect($result->error['status'])->toBe(500);
|
||
});
|
||
|
||
it('fails on a malformed RSS feed', function () {
|
||
Http::fake(['1.1.1.1/*' => Http::response('this is not xml at all', 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create();
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed.xml']);
|
||
|
||
expect($result->status)->toBe(NodeRunStatus::Failed);
|
||
});
|
||
|
||
it('skips items without a publish date', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
$feed = <<<'XML'
|
||
<?xml version="1.0" encoding="UTF-8"?>
|
||
<rss version="2.0"><channel>
|
||
<item><title>Dated</title><link>https://1.1.1.1/d</link><guid>d</guid><pubDate>Sun, 01 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
<item><title>NoDate</title><link>https://1.1.1.1/n</link><guid>n</guid></item>
|
||
</channel></rss>
|
||
XML;
|
||
Http::fake(['1.1.1.1/*' => Http::response($feed, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create();
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-02-01T12:00:00+00:00'],
|
||
]);
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
// Only the dated item passes; the dateless one is ignored.
|
||
expect($result->output['fetch']['count'])->toBe(1);
|
||
expect($result->output['fetched']['key'])->toBe('d');
|
||
});
|
||
|
||
it('falls back to the link as the dedup key when an item has no guid', function () {
|
||
Carbon::setTestNow('2026-01-15 10:00:00');
|
||
$feed = <<<'XML'
|
||
<?xml version="1.0" encoding="UTF-8"?>
|
||
<rss version="2.0"><channel>
|
||
<item><title>LinkKey</title><link>https://1.1.1.1/only-link</link><pubDate>Sun, 01 Jun 2025 12:00:00 +0000</pubDate></item>
|
||
</channel></rss>
|
||
XML;
|
||
Http::fake(['1.1.1.1/*' => Http::response($feed, 200)]);
|
||
|
||
$automation = Automation::factory()->active()->create();
|
||
AutomationNodeState::create([
|
||
'automation_id' => $automation->id,
|
||
'node_id' => 'fetch_1',
|
||
'data' => ['last_item_date' => '2025-02-01T12:00:00+00:00'],
|
||
]);
|
||
$run = AutomationRun::factory()->for($automation)->create(['current_node_id' => 'fetch_1']);
|
||
|
||
$result = app(RunFetchRssNode::class)($run, ['feed_url' => 'https://1.1.1.1/feed']);
|
||
|
||
expect($result->output['fetched']['key'])->toBe('https://1.1.1.1/only-link');
|
||
});
|