vignesh/trypost
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Pinterest video try/finally, LinkedIn/Mastodon stream uploads, close file handles

Browse source
This commit is contained in:
Paulo Castellano 2026-03-31 22:18:05 -03:00
parent 307b496bad
commit e90a24fc31
4 changed files with 45 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/Services/Social/LinkedInPagePublisher.php
View file

@ -274,15 +274,19 @@ private function uploadImage($mediaItem, string $ownerUrn): ?string
$tempFile = $optimizedPath;
}
$imageContent = file_get_contents($tempFile);
$stream = fopen($tempFile, 'r');
$uploadResponse = Http::withToken($this->accessToken)
->withHeaders([
'Content-Type' => 'application/octet-stream',
])
->withBody($imageContent, 'application/octet-stream')
->withBody($stream, 'application/octet-stream')
->put($uploadUrl);
if (is_resource($stream)) {
fclose($stream);
}
if ($uploadResponse->failed()) {
Log::error('LinkedIn Page image upload failed', ['body' => $uploadResponse->body()]);
$this->handleApiError($uploadResponse);

8
app/Services/Social/LinkedInPublisher.php
View file

@ -255,15 +255,19 @@ private function uploadImage($mediaItem, string $ownerUrn): ?string
$tempFile = $optimizedPath;
}
$imageContent = file_get_contents($tempFile);
$stream = fopen($tempFile, 'r');
$uploadResponse = Http::withToken($this->accessToken)
->withHeaders([
'Content-Type' => 'application/octet-stream',
])
->withBody($imageContent, 'application/octet-stream')
->withBody($stream, 'application/octet-stream')
->put($uploadUrl);
if (is_resource($stream)) {
fclose($stream);
}
if ($uploadResponse->failed()) {
Log::error('LinkedIn image upload failed', ['body' => $uploadResponse->body()]);
$this->handleApiError($uploadResponse);

8
app/Services/Social/MastodonPublisher.php
View file

@ -87,10 +87,16 @@ private function uploadMedia(SocialAccount $account, string $instance, string $u
$name = 'media';
}
$stream = fopen($tempFile, 'r');
$response = Http::withToken($account->access_token)
->attach('file', fopen($tempFile, 'r'), $name)
->attach('file', $stream, $name)
->post("{$instance}/api/v1/media");
if (is_resource($stream)) {
fclose($stream);
}
if ($response->failed()) {
Log::error('Mastodon media upload failed', [
'status' => $response->status(),

53
app/Services/Social/PinterestPublisher.php
View file

@ -161,36 +161,35 @@ private function publishVideoPin(PostPlatform $postPlatform): array
// Download video to temp file (memory-safe)
$tempFile = tempnam(sys_get_temp_dir(), 'pin_video_');
Http::withOptions(['sink' => $tempFile])->timeout(600)->get($media->url);
$videoStream = null;
$videoContent = fopen($tempFile, 'r');
try {
Http::withOptions(['sink' => $tempFile])->timeout(600)->get($media->url);
if ($videoContent === false) {
$videoStream = fopen($tempFile, 'r');
if ($videoStream === false) {
throw new \Exception('Failed to read video file');
}
$multipart[] = [
'name' => 'file',
'contents' => $videoStream,
'filename' => basename($media->url),
];
$uploadResponse = Http::asMultipart()
->timeout(600)
->post($uploadUrl, $multipart);
if ($uploadResponse->failed()) {
$this->handleApiError($uploadResponse);
}
} finally {
if ($videoStream !== null && is_resource($videoStream)) {
fclose($videoStream);
}
@unlink($tempFile);
throw new \Exception('Failed to read video file');
}
$multipart[] = [
'name' => 'file',
'contents' => $videoContent,
'filename' => basename($media->url),
];
$uploadResponse = Http::asMultipart()
->timeout(600)
->post($uploadUrl, $multipart);
if (is_resource($videoContent)) {
fclose($videoContent);
}
@unlink($tempFile);
if ($uploadResponse->failed()) {
Log::error('Pinterest video upload failed', [
'status' => $uploadResponse->status(),
'body' => $uploadResponse->body(),
]);
throw new \Exception('Pinterest video upload failed');
}
// Step 3: Wait for processing