From 9864ea96b64b4f0c843ee8aca0faf447b784ab9c Mon Sep 17 00:00:00 2001
From: Paulo Castellano <paulo@castellanos.llc>
Date: Sat, 13 Jun 2026 20:30:41 -0300
Subject: [PATCH] Cover handle-resolution errors and configured web-app host

Add a test that a network error during handle resolution degrades the mention
to plain text instead of failing the post (exercises the resolveHandleToDid
try/catch), and a test asserting the post URL is built from the configured
web_app host (a revert to a hardcoded host would now fail).
---
 .../Services/Social/BlueskyPublisherTest.php  | 47 +++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/tests/Feature/Services/Social/BlueskyPublisherTest.php b/tests/Feature/Services/Social/BlueskyPublisherTest.php
index 136c7b75..76c648ad 100644
--- a/tests/Feature/Services/Social/BlueskyPublisherTest.php
+++ b/tests/Feature/Services/Social/BlueskyPublisherTest.php
@@ -12,6 +12,7 @@
 use App\Models\Workspace;
 use App\Services\Media\MediaOptimizer;
 use App\Services\Social\BlueskyPublisher;
+use Illuminate\Http\Client\ConnectionException;
 use Illuminate\Support\Facades\Http;
 
 beforeEach(function () {
@@ -236,6 +237,52 @@
     });
 });
 
+test('bluesky publisher publishes as plain text when handle resolution errors', function () {
+    $this->post->update(['content' => 'hi @friend.bsky.social']);
+
+    Http::fake(function ($request) {
+        if (str_contains($request->url(), 'resolveHandle')) {
+            throw new ConnectionException('connection refused');
+        }
+
+        return Http::response([
+            'uri' => 'at://did:plc:testuser123/app.bsky.feed.post/3abc123xyz',
+            'cid' => 'bafyreiabc123',
+        ], 200);
+    });
+
+    // A network error resolving the handle must degrade to plain text, not fail the post.
+    $result = $this->publisher->publish($this->postPlatform);
+
+    expect($result['id'])->toBe('3abc123xyz');
+
+    Http::assertSent(function ($request) {
+        if (! str_contains($request->url(), 'createRecord')) {
+            return false;
+        }
+
+        $hasMention = collect($request['record']['facets'] ?? [])
+            ->contains(fn ($facet) => $facet['features'][0]['$type'] === 'app.bsky.richtext.facet#mention');
+
+        return str_contains($request['record']['text'], '@friend.bsky.social') && ! $hasMention;
+    });
+});
+
+test('bluesky publisher builds the post url from the configured web app host', function () {
+    config(['trypost.platforms.bluesky.web_app' => 'https://custom.bsky.example']);
+
+    Http::fake([
+        config('trypost.platforms.bluesky.default_service').'/xrpc/com.atproto.repo.createRecord' => Http::response([
+            'uri' => 'at://did:plc:testuser123/app.bsky.feed.post/3abc123xyz',
+            'cid' => 'bafyreiabc123',
+        ], 200),
+    ]);
+
+    $result = $this->publisher->publish($this->postPlatform);
+
+    expect($result['url'])->toBe('https://custom.bsky.example/profile/testuser.bsky.social/post/3abc123xyz');
+});
+
 test('bluesky publisher resolves some mentions and skips the unresolvable ones', function () {
     $this->post->update(['content' => 'cc @good.bsky.social and @bad.bsky.social']);