* fix: resolve React Doctor errors and restore its PR baseline
The React Doctor check on PR #9160 reported 266 issues across 130 files.
Most of that is a reporting artifact: the workflow's `actions/checkout`
step used the default shallow clone, so React Doctor had no merge base to
diff against and fell back to listing every pre-existing issue in every
changed file rather than only what the PR introduced. Add `fetch-depth: 0`
so the comparison works. Also point the `push` trigger at `preview` — the
repo's default branch — instead of `main`, which does not exist here, so
the health-score trend never ran.
Fix the 7 genuine errors it surfaced:
- use-keypress: `callback` sat in the effect deps while every one of the
10 call sites passes an inline arrow, so the document listener was torn
down and re-added on every render. Latch the callback in a ref and key
the subscription on `key` alone. This clears `no-effect-with-fresh-deps`
at create-root.tsx:102 and create-project-modal.tsx:64 at the source.
- estimates/points/preview: the dblclick listener was added with no
cleanup, so listeners accumulated on every toggle. Add the matching
removeEventListener.
- issues/header, calendar/issue-block, pages/editor/editor-body: guard
`window` reads that run during render with `typeof window !== "undefined"`,
matching the pattern already used elsewhere in web and admin. The editor
case previously relied on the surrounding try/catch swallowing a
ReferenceError on the server.
Also clears the five pre-existing oxlint warnings in calendar/issue-block
that the repo's `--deny-warnings` pre-commit gate blocks on once the file
is touched: rename a shadowed `issue` parameter, and mark two presentational
wrapper divs with `role="presentation"` — CustomMenu already wraps the
first in a real <button>, and the second exists only to stop click
propagation to the surrounding ControlLink.
Verified: `turbo run check:types --filter=web` passes (11/11 tasks),
`oxlint --deny-warnings` reports 0 warnings and 0 errors on the changed files.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
* fix: import EditorAIMenu directly instead of through the ai barrel
The only issue React Doctor reports against this branch. `./ai` re-exports
both menu.tsx and ask-pi-menu.tsx, so importing through it pulls the
ask-pi menu into the page editor bundle for a symbol that lives in
menu.tsx. Pre-existing on preview rather than introduced here, but it is
a one-line fix in a file this branch already touches.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
* fix: address CodeRabbit review on the React Doctor branch
- react-doctor.yml: set persist-credentials: false on checkout. The token
otherwise stays in .git/config for the third-party millionco/react-doctor
step that runs next. fetch-depth: 0 has already fetched every ref the
merge-base diff needs, and the action authenticates to the API through
its own credentials, so nothing depends on the persisted git credential.
- calendar/issue-block: pass workspaceSlug?.toString() to handleRedirection.
The param is typed string | undefined and line 89 of the same file already
optional-chains it; this call site would have thrown on a missing route
param. Pre-existing, but it is on a line this branch already touches.
Declined the two SSR/hydration findings: apps/web sets ssr: false in
react-router.config.ts and ships a client-only bundle, so there is no
server render to diverge from. The typeof window guards satisfy the
React Doctor rule but are defensive only.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
7564480cf7