* fix: resolve React Doctor errors and restore its PR baseline The React Doctor check on PR #9160 reported 266 issues across 130 files. Most of that is a reporting artifact: the workflow's `actions/checkout` step used the default shallow clone, so React Doctor had no merge base to diff against and fell back to listing every pre-existing issue in every changed file rather than only what the PR introduced. Add `fetch-depth: 0` so the comparison works. Also point the `push` trigger at `preview` — the repo's default branch — instead of `main`, which does not exist here, so the health-score trend never ran. Fix the 7 genuine errors it surfaced: - use-keypress: `callback` sat in the effect deps while every one of the 10 call sites passes an inline arrow, so the document listener was torn down and re-added on every render. Latch the callback in a ref and key the subscription on `key` alone. This clears `no-effect-with-fresh-deps` at create-root.tsx:102 and create-project-modal.tsx:64 at the source. - estimates/points/preview: the dblclick listener was added with no cleanup, so listeners accumulated on every toggle. Add the matching removeEventListener. - issues/header, calendar/issue-block, pages/editor/editor-body: guard `window` reads that run during render with `typeof window !== "undefined"`, matching the pattern already used elsewhere in web and admin. The editor case previously relied on the surrounding try/catch swallowing a ReferenceError on the server. Also clears the five pre-existing oxlint warnings in calendar/issue-block that the repo's `--deny-warnings` pre-commit gate blocks on once the file is touched: rename a shadowed `issue` parameter, and mark two presentational wrapper divs with `role="presentation"` — CustomMenu already wraps the first in a real <button>, and the second exists only to stop click propagation to the surrounding ControlLink. Verified: `turbo run check:types --filter=web` passes (11/11 tasks), `oxlint --deny-warnings` reports 0 warnings and 0 errors on the changed files. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT * fix: import EditorAIMenu directly instead of through the ai barrel The only issue React Doctor reports against this branch. `./ai` re-exports both menu.tsx and ask-pi-menu.tsx, so importing through it pulls the ask-pi menu into the page editor bundle for a symbol that lives in menu.tsx. Pre-existing on preview rather than introduced here, but it is a one-line fix in a file this branch already touches. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT * fix: address CodeRabbit review on the React Doctor branch - react-doctor.yml: set persist-credentials: false on checkout. The token otherwise stays in .git/config for the third-party millionco/react-doctor step that runs next. fetch-depth: 0 has already fetched every ref the merge-base diff needs, and the action authenticates to the API through its own credentials, so nothing depends on the persisted git credential. - calendar/issue-block: pass workspaceSlug?.toString() to handleRedirection. The param is typed string | undefined and line 89 of the same file already optional-chains it; this call site would have thrown on a missing route param. Pre-existing, but it is on a line this branch already touches. Declined the two SSR/hydration findings: apps/web sets ssr: false in react-router.config.ts and ships a client-only bundle, so there is no server render to diverge from. The typeof window guards satisfy the React Doctor rule but are defensive only. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
137 lines
4.9 KiB
TypeScript
137 lines
4.9 KiB
TypeScript
/**
|
|
* Copyright (c) 2023-present Plane Software, Inc. and contributors
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
* See the LICENSE file for details.
|
|
*/
|
|
|
|
import { observer } from "mobx-react";
|
|
import { useParams } from "next/navigation";
|
|
// icons
|
|
import { Circle } from "lucide-react";
|
|
// plane imports
|
|
import {
|
|
EUserPermissions,
|
|
EUserPermissionsLevel,
|
|
SPACE_BASE_PATH,
|
|
SPACE_BASE_URL,
|
|
WORK_ITEM_TRACKER_ELEMENTS,
|
|
} from "@plane/constants";
|
|
import { useTranslation } from "@plane/i18n";
|
|
import { Button } from "@plane/propel/button";
|
|
import { NewTabIcon, WorkItemsIcon } from "@plane/propel/icons";
|
|
import { Tooltip } from "@plane/propel/tooltip";
|
|
import { EIssuesStoreType } from "@plane/types";
|
|
import { Breadcrumbs, Header } from "@plane/ui";
|
|
// components
|
|
import { BreadcrumbLink } from "@/components/common/breadcrumb-link";
|
|
import { CountChip } from "@/components/common/count-chip";
|
|
// constants
|
|
import { HeaderFilters } from "@/components/issues/filters";
|
|
// helpers
|
|
// hooks
|
|
import { useCommandPalette } from "@/hooks/store/use-command-palette";
|
|
import { useIssues } from "@/hooks/store/use-issues";
|
|
import { useProject } from "@/hooks/store/use-project";
|
|
import { useUserPermissions } from "@/hooks/store/user";
|
|
import { useAppRouter } from "@/hooks/use-app-router";
|
|
import { usePlatformOS } from "@/hooks/use-platform-os";
|
|
// plane web imports
|
|
import { CommonProjectBreadcrumbs } from "@/components/breadcrumbs/common";
|
|
|
|
export const IssuesHeader = observer(function IssuesHeader() {
|
|
// router
|
|
const router = useAppRouter();
|
|
const { workspaceSlug, projectId } = useParams();
|
|
// store hooks
|
|
const {
|
|
issues: { getGroupIssueCount },
|
|
} = useIssues(EIssuesStoreType.PROJECT);
|
|
// i18n
|
|
const { t } = useTranslation();
|
|
|
|
const { currentProjectDetails, loader } = useProject();
|
|
|
|
const { toggleCreateIssueModal } = useCommandPalette();
|
|
const { allowPermissions } = useUserPermissions();
|
|
const { isMobile } = usePlatformOS();
|
|
|
|
const SPACE_APP_URL =
|
|
(SPACE_BASE_URL.trim() === "" && typeof window !== "undefined" ? window.location.origin : SPACE_BASE_URL) +
|
|
SPACE_BASE_PATH;
|
|
const publishedURL = `${SPACE_APP_URL}/issues/${currentProjectDetails?.anchor}`;
|
|
|
|
const issuesCount = getGroupIssueCount(undefined, undefined, false);
|
|
const canUserCreateIssue = allowPermissions(
|
|
[EUserPermissions.ADMIN, EUserPermissions.MEMBER],
|
|
EUserPermissionsLevel.PROJECT
|
|
);
|
|
|
|
return (
|
|
<Header>
|
|
<Header.LeftItem>
|
|
<div className="flex items-center gap-2.5">
|
|
<Breadcrumbs onBack={() => router.back()} isLoading={loader === "init-loader"} className="flex-grow-0">
|
|
<CommonProjectBreadcrumbs workspaceSlug={workspaceSlug?.toString()} projectId={projectId?.toString()} />
|
|
<Breadcrumbs.Item
|
|
component={
|
|
<BreadcrumbLink
|
|
label="Work Items"
|
|
href={`/${workspaceSlug}/projects/${projectId}/issues/`}
|
|
icon={<WorkItemsIcon className="h-4 w-4 text-tertiary" />}
|
|
isLast
|
|
/>
|
|
}
|
|
isLast
|
|
/>
|
|
</Breadcrumbs>
|
|
{issuesCount && issuesCount > 0 ? (
|
|
<Tooltip
|
|
isMobile={isMobile}
|
|
tooltipContent={`There are ${issuesCount} ${issuesCount > 1 ? "work items" : "work item"} in this project`}
|
|
position="bottom"
|
|
>
|
|
<CountChip count={issuesCount} />
|
|
</Tooltip>
|
|
) : null}
|
|
</div>
|
|
{currentProjectDetails?.anchor ? (
|
|
<a
|
|
href={publishedURL}
|
|
className="group flex items-center gap-1.5 rounded-sm bg-accent-primary/10 px-2.5 py-1 text-11 font-medium text-accent-primary"
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
>
|
|
<Circle className="h-1.5 w-1.5 fill-accent-primary" strokeWidth={2} />
|
|
{t("workspace_projects.network.public.title")}
|
|
<NewTabIcon className="hidden h-3 w-3 group-hover:block" strokeWidth={2} />
|
|
</a>
|
|
) : (
|
|
<></>
|
|
)}
|
|
</Header.LeftItem>
|
|
<Header.RightItem>
|
|
<div className="hidden gap-2 md:flex">
|
|
<HeaderFilters
|
|
projectId={projectId}
|
|
currentProjectDetails={currentProjectDetails}
|
|
workspaceSlug={workspaceSlug}
|
|
canUserCreateIssue={canUserCreateIssue}
|
|
/>
|
|
</div>
|
|
{canUserCreateIssue && (
|
|
<Button
|
|
variant="primary"
|
|
size="lg"
|
|
onClick={() => {
|
|
toggleCreateIssueModal(true, EIssuesStoreType.PROJECT);
|
|
}}
|
|
data-ph-element={WORK_ITEM_TRACKER_ELEMENTS.HEADER_ADD_BUTTON.WORK_ITEMS}
|
|
>
|
|
<div className="block sm:hidden">{t("issue.label", { count: 1 })}</div>
|
|
<div className="hidden sm:block">{t("issue.add.label")}</div>
|
|
</Button>
|
|
)}
|
|
</Header.RightItem>
|
|
</Header>
|
|
);
|
|
});
|