dolibarr/htdocs
MDW f142240083
Qual: Fix phan notices (#37837)
* Qual: Ignore PhanUndeclaredProperty for specific lines

* Fix: Update payment mode reference in PDF generation

# Fix: Update payment mode reference in PDF generation

The payment mode reference in the PDF generation was incorrectly using `type_payment_code`, an unknown property in Salary.
It has been updated to use `type_code` as used elsewhere for the same purpose.

* Qual: Typing of several DDLUpdateField field_desc items made optional

# Qual: Typing of several DDLUpdateField field_desc items made optional

Not all fields are required for updateing the DB typing, and ExtraFields was not providing all of them.

* Qual: Update typing for phan notices

# Qual: Update typing for phan notices

Fix typing mismatches

* Qual: Fix extrafields typing in objectline_create.tpl.php

# Qual: Fix extrafields typing in objectline_create.tpl.php

- Update typing for phan

* Qual: Fix typing for Phan & re-use encrypted password when requested

# Qual: Fix typing for Phan & re-use encrypted password when requested

- Added a cast to string for the crypted password to hint phan that it returns the string version (not the array)
- Added a check to ensure the password is not already crypted before generating a new password.
- Updated the type hints for parameters `$changelater`, `$notrigger`, `$nosyncmember`, and `$passwordalreadycrypted` to include the range of possible values.
- Updated the return type hint for the `setPassword` method to include the range of possible error values.

* Qual: Fix file argument to showPreview() calls

# Qual: Fix file argument to showPreview() calls

Fix argument type mismatches by adjusting '$file' arguments in showPreview calls.

* Qual: Update login_c type to string

# Qual: Update login_c type to string

login_c is username from db.

* Qual: Update type hints in treeview.lib.php

# Qual: Update type hints in treeview.lib.php

Update type hints for static analysis.

* Qual: Add null check for objecttmp in selectForFormsList

# Qual: Add null check for objecttmp in selectForFormsList

Add null check for objecttmp before calling selectForFormsList to ensure static analysis

* Qual: Fix phan through null check on object argument

# Qual: Fix phan through null check on object argument

- Do null check to avoid null parameter (fix phan);
- Set more specific type for argument.

* Qual: Change type hint of $remise_percent parameter to float

# Qual: Change type hint of $remise_percent parameter to float

DB type is float, so correct arg type to fix phan notice.

* Qual: Ignore some phan notices

The descriptions for the linkedObjectsFullLoaded and oldcopy properties have been updated to avoid modification by code formatting tools

* Qual: Update phan baseline

* Qual: Cast remise_percent to float to match typing requirements

* Qual: Cast label to string to help static analysis

* Qual: Update date_cancel property type and assignment

To fix phan notices:

- The date_cancel property type was changed from 'int|string' to 'int|""' to match return type from jdate().
- Additionally, the assignment of date_cancel was updated to use dol_now() instead of $this->db->idate(dol_now()).

* Qual: Provide the expected user_id instead of the User object

Changed the user fetch logic from using `user_author` to `user_creation_id`

* Qual: Correct bool argument from 0 to false ($fill)

* Qual/Fix: Correct date converted to dol_print_date

* Qual: Fix argument type for addline()

* Qual: Update Phan baseline.txt
2026-04-13 12:50:23 +02:00
..
accountancy Using counter when cloning bookkeeping transactions. (#37809) 2026-04-11 18:07:39 +02:00
adherents NEW We can now link membership contributions to invoices, orders, proposals (#37712) 2026-04-09 02:09:47 +02:00
admin Try CI fix 2026-04-12 13:07:40 +02:00
ai CI 2026-04-08 01:27:04 +02:00
api Automated merge from 20.0 to 21.0 by tool pullmerge.sh 2026-04-10 16:24:19 +02:00
asset CI 2026-04-11 16:32:03 +02:00
asterisk
barcode
blockedlog clean code and fix phpstan (#37831) 2026-04-12 11:59:56 +02:00
bom CI 2026-04-11 17:43:22 +02:00
bookcal Doc 2026-04-07 01:35:32 +02:00
bookmarks
categories
collab
comm Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
commande Merge the dir bank and banque into bank. 2026-04-12 15:20:51 +02:00
compta Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
conf Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-03-29 21:32:22 +02:00
contact
contrat Clean code. Must use USF everywhere. 2026-04-03 21:20:59 +02:00
core Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
cron Clean coe 2026-03-30 11:38:39 +02:00
custom
datapolicy
dav
debugbar Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
delivery
don
ecm Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
emailcollector
eventorganization Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-07 03:44:29 +02:00
expedition Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-08 21:47:37 +02:00
expensereport Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
exports
fichinter interventional clone feature clean signed_status too (#37681) 2026-04-03 03:22:12 +02:00
fourn Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
ftp
holiday Clean code 2026-04-08 21:09:31 +02:00
hrm
imports Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
includes FIX TCPDI: honor K_TCPDF_THROW_EXCEPTION_ERROR and enable exceptions by default (#37827) 2026-04-11 18:01:59 +02:00
install Add legal forms for New Caledonia (#37840) 2026-04-13 12:47:45 +02:00
intracommreport
knowledgemanagement
langs Trans 2026-04-12 16:17:04 +02:00
loan
mailmanspip/class
margin
modulebuilder Add link to module index file in module description (#37803) 2026-04-10 11:28:27 +02:00
mrp
multicurrency
opensurvey
partnership
paybox Removed old option PAYMENT_SECURITY_TOKEN_UNIQUE has been removed 2026-04-10 15:21:37 +02:00
paypal Removed old option PAYMENT_SECURITY_TOKEN_UNIQUE has been removed 2026-04-10 15:21:37 +02:00
printing
product Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-08 21:47:37 +02:00
projet NEW Add mass mailing tab - with counts to project tabs (#37703) 2026-04-07 05:09:02 +02:00
public Doc 2026-04-12 15:34:23 +02:00
reception Clean code. Must use USF everywhere. 2026-04-03 21:20:59 +02:00
recruitment
resource
salaries Fix in list of array 2026-04-08 21:48:15 +02:00
societe Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-07 13:27:44 +02:00
stripe Now use a default salt for online signature securekey. Old links may be 2026-04-10 16:15:38 +02:00
subtotals
supplier_invoice/admin QUAL - Supplier modules - Separate - admin supplier invoice head (#37779) 2026-04-07 20:46:58 +02:00
supplier_order/admin QUAL - Supplier modules - Separate - admin supplier order head (#37780) 2026-04-07 20:47:16 +02:00
supplier_proposal Clean code 2026-04-10 10:37:12 +02:00
takepos Clean deprecated code 2026-04-09 02:35:25 +02:00
theme css 2026-04-09 13:02:56 +02:00
ticket CI 2026-04-12 13:03:53 +02:00
user Qual: Fix phan notices (#37837) 2026-04-13 12:50:23 +02:00
variants
webhook Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 2026-04-03 22:54:53 +02:00
webportal Try ci fix 2026-04-12 13:52:10 +02:00
webservices
website
workstation
zapier
.gitignore
document.php Automated merge from 20.0 to 21.0 by tool pullmerge.sh 2026-04-10 16:24:19 +02:00
favicon.ico
filefunc.inc.php
index.php Merge the dir bank and banque into bank. 2026-04-12 15:20:51 +02:00
main.inc.php Automated merge from 21.0 to 22.0 by tool pullmerge.sh 2026-04-10 17:47:11 +02:00
master.inc.php
robots.txt
security.txt
version.inc.php Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-04 11:57:18 +02:00
viewimage.php
waf.inc.php