vignesh/dolibarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
dolibarr/htdocs
History
MDW cbf8748dd2
Fix CI #39247: Fix phan notices by reorganising code (#39264) 
* Fix #39247: Fix phan notices by reorganising code

# Fix #39247: Fix phan notices by reorganising code

Phan typing analysis was disturbed by conditional assignment to array fields of array items.

This reorganises the the code and uses a foreach and a loop item by reference.
The result array is filtered after the initial loop to find matching ECM items.

Not that this does not fix an unreported issue when paging is applied for filtered items
(paging is applied on the full list, not the filtered items and may result in small(er)
or empty pages).

* Qual: Fix Phan notices

# Qual: Fix Phan notices

- The page_count value was simply ceil(...) which is typed float, now casting to int.
- Add missing properties share and agenda_id to EcmFilesLine
2026-07-23 16:09:22 +02:00
..
accountancy Qual: Fix 'SqlInjection' notices (#39231) 2026-07-20 15:28:15 +02:00
adherents Qual: Fix 'SqlInjection' notices (#39225) 2026-07-20 02:52:07 +02:00
admin Qual: Fix 'SqlInjection' notices (#39231) 2026-07-20 15:28:15 +02:00
ai Qual: Fix 'SqlInjection' notices (#39231) 2026-07-20 15:28:15 +02:00
api Fix CI #39247: Fix phan notices by reorganising code (#39264) 2026-07-23 16:09:22 +02:00
asset Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
asterisk
barcode
blockedlog Qual: Fix 'SqlInjection' notices (#39203) 2026-07-19 15:53:14 +02:00
bom Qual: Fix 'SqlInjection' notices (#39219) 2026-07-20 02:50:44 +02:00
bookcal Qual: Fix 'SqlInjection' notices (#39224) 2026-07-20 02:51:54 +02:00
bookmarks Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
categories Qual: Fix 'SqlInjection' notices (#39213) 2026-07-19 17:32:14 +02:00
collab
comm Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
commande Fix missing object-level control on api to reopen or billed an order - 2026-07-20 12:03:14 +02:00
compta Qual: Fix 'SqlInjection' notices (#39231) 2026-07-20 15:28:15 +02:00
conf Automated merge from 23.0 to develop 2026-06-19 03:59:57 +02:00
contact CSS 2026-07-20 11:50:24 +02:00
contrat Qual: Fix 'SqlInjection' notices (#39219) 2026-07-20 02:50:44 +02:00
core FIX #39265 2026-07-23 16:02:34 +02:00
cron Qual: Fix 'SqlInjection' notices (#39221) 2026-07-20 02:51:11 +02:00
custom
datapolicy Qual: Fix 'SqlInjection' notices (#39213) 2026-07-19 17:32:14 +02:00
dav clean deprecated (#38897) 2026-06-22 02:18:10 +02:00
debugbar
delivery Qual: Fix 'SqlInjection' notices (#39219) 2026-07-20 02:50:44 +02:00
don Qual: Fix 'SqlInjection' notices (#39225) 2026-07-20 02:52:07 +02:00
ecm Fix CI #39247: Fix phan notices by reorganising code (#39264) 2026-07-23 16:09:22 +02:00
emailcollector Qual: Fix 'SqlInjection' notices (#39203) 2026-07-19 15:53:14 +02:00
eventorganization Qual: Fix 'SqlInjection' notices (#39230) 2026-07-20 15:28:26 +02:00
expedition Qual: Fix 'SqlInjection' notices (#39224) 2026-07-20 02:51:54 +02:00
expensereport Qual: Fix 'SqlInjection' notices (#39224) 2026-07-20 02:51:54 +02:00
exports Qual: Fix 'SqlInjection' notices (#39222) 2026-07-20 02:51:25 +02:00
fichinter Qual: Fix 'SqlInjection' notices (#39220) 2026-07-20 02:51:00 +02:00
fourn doc 2026-07-20 16:08:57 +02:00
ftp Qual: Fix french comments and improve detector (#39026) 2026-07-01 12:26:51 +02:00
holiday FIX: Translate French code comments to English in holiday, hrm and salaries modules 2026-06-28 09:30:50 +02:00
hrm Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
imports Automated merge from 23.0 to develop 2026-07-15 02:06:09 +02:00
includes Automated merge from 23.0 to develop 2026-07-15 02:06:09 +02:00
install Qual: Fix 'SqlInjection' notices (#39220) 2026-07-20 02:51:00 +02:00
intracommreport Qual: Fix french comments and improve detector (#39026) 2026-07-01 12:26:51 +02:00
knowledgemanagement Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
langs Trans 2026-07-16 01:42:19 +02:00
loan Qual: Fix 'SqlInjection' notices (#39225) 2026-07-20 02:52:07 +02:00
mailmanspip/class
margin Qual: Fix 'SqlInjection' notices (#39222) 2026-07-20 02:51:25 +02:00
modulebuilder Qual: Fix 'SqlInjection' notices (#39225) 2026-07-20 02:52:07 +02:00
mrp Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-07-18 16:17:03 +02:00
multicurrency Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2026-07-13 16:33:26 +02:00
opensurvey Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
partnership Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
paypal FIX: PayPal API calls set CURLOPT_SSL_VERIFYHOST to a bool instead of 2 (#39155) 2026-07-16 02:23:26 +02:00
printing avoid warnings in admin printing 2026-06-24 17:52:04 +02:00
product Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
projet Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
public Fix error when https not available 2026-07-23 11:43:10 +02:00
quickmemo Qual: Fix 'SqlInjection' notices (#39222) 2026-07-20 02:51:25 +02:00
reception Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
recruitment Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
resource Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
salaries Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
societe Restrict access on permission for editing notification on thirdparty 2026-07-20 17:26:15 +02:00
stripe fix(stripe): use automatic_payment_methods when STRIPE_USE_INTENT_WITH_AUTOMATIC_CONFIRMATION=2 (#38578) 2026-06-09 03:22:39 +02:00
subtotals FIX #37658 Compute total of price from unit price (including tax) on proposal (#38755) 2026-06-13 02:34:51 +02:00
supplier_invoice/admin clean code for action specimen (#38865) 2026-06-25 19:01:16 +02:00
supplier_order/admin
supplier_proposal Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
takepos Qual: Fix 'SqlInjection' notices (#39225) 2026-07-20 02:52:07 +02:00
theme Clean code 2026-07-20 14:58:04 +02:00
ticket Qual: Fix 'SqlInjection' notices (#39203) 2026-07-19 15:53:14 +02:00
user Fix edit of notification need write permission on users. 2026-07-20 15:49:39 +02:00
variants Qual: Fix 'SqlInjection' notices (#39223) 2026-07-20 02:51:42 +02:00
webhook Fix link 2026-06-20 03:59:39 +02:00
webportal Qual: Fix 'SqlInjection' notices (#39221) 2026-07-20 02:51:11 +02:00
webservices Qual: Fix 'SqlInjection' notices (#39229) 2026-07-20 15:26:43 +02:00
website Qual: Fix 'SqlInjection' notices (#39213) 2026-07-19 17:32:14 +02:00
workstation clean code (#38745) 2026-06-13 02:36:03 +02:00
zapier
document.php Qual: Fix PHPStan always true/false errors breaking develop CI (#39114) 2026-07-13 16:11:51 +02:00
favicon.ico
filefunc.inc.php Move file securitycore.lib.php into blockedlog directory. 2026-06-19 22:07:57 +02:00
index.php
main.inc.php Debug v24 2026-07-23 12:19:30 +02:00
master.inc.php
robots.txt
security.txt
version.inc.php
viewimage.php Doc and clean code (viewimage and document must follow same rules) 2026-07-10 14:22:08 +02:00
waf.inc.php