* FIX: Resolve possibly-undefined-variable cases flagged by PHPStan Fixes several cases of the variable.undefined PHPStan rule instead of just excluding them via the baseline: a wrong variable used to build a delete link (dir_add_card.php), an uninitialized $result across a try/catch (CMailFile), missing GETPOST reads ($mode, $fk_project/$date reset via unset() creating cross-branch ambiguity), a missing $r contract check (commonfieldsinimport.inc.php), missing @var/global annotations for $conf/$langs/$bc, dead extrafields-display code guarded by the wrong condition (expedition/card.php), and an undefined $soc passed to formAddObjectLine() where objects have no buyer thirdparty (replaced with null). Corresponding entries removed from dev/build/phpstan/phpstan-baseline.neon. * FIX: Resolve more possibly-undefined-variable cases flagged by PHPStan Second batch of variable.undefined fixes removed from the baseline: - Complex conditional flows PHPStan can't prove exhaustive (Stripe key selection in commoninvoice.class.php, a situation-invoice loop var in pdf_sponge.modules.php, a product loop var in stock/movement_list.php) fixed by adding a definite initialization before the ambiguous branch. - A commented-out $linkback assignment restored in expensereport/payment/info.php. - Missing GETPOST reads added (holiday/list.php update-date filters, product/stock/info.php $action/$socid, projet/comment.php $mode). - A dead-code $mesg call to dol_htmloutput_mesg() removed from admin_hrm.php (messages are already shown via setEventMessages()). - Redundant isset() checks removed in product/reassort.php and reassortlot.php where $type is unconditionally set earlier in the same file, so the isset()-false branch was unreachable dead code. - $user documented as always available in public/bookcal/index.php (NOREQUIREUSER is not defined on that page). - A genuinely missing $tmpcode initialization fixed in attendee_new.php, suggestbooth.php and suggestconference.php: when an existing thirdparty is reused (or SOCIETE_CODECLIENT_ADDON has no auto-numbering), $tmpcode was never set before being assigned to code_client/code_fournisseur. * add phan fix * add phan fix * fix * fix * fix
107 lines
2.9 KiB
PHP
107 lines
2.9 KiB
PHP
<?php
|
|
/* Copyright (C) 2004 Rodolphe Quiedeville <rodolphe@quiedeville.org>
|
|
* Copyright (C) 2004-2009 Laurent Destailleur <eldy@users.sourceforge.net>
|
|
* Copyright (C) 2013 Marcos García <marcosgdf@gmail.com>
|
|
* Copyright (C) 2015 Alexandre Spangaro <aspangaro@open-dsi.fr>
|
|
* Copyright (C) 2024-2026 Frédéric France <frederic.france@free.fr>
|
|
* Copyright (C) 2025 MDW <mdeweerd@users.noreply.github.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
/**
|
|
* \file htdocs/expensereport/payment/info.php
|
|
* \ingroup Expense report
|
|
* \brief Tab payment info
|
|
*/
|
|
|
|
// Load Dolibarr environment
|
|
require '../../main.inc.php';
|
|
/**
|
|
* @var Conf $conf
|
|
* @var DoliDB $db
|
|
* @var HookManager $hookmanager
|
|
* @var Translate $langs
|
|
* @var User $user
|
|
*/
|
|
require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
|
|
require_once DOL_DOCUMENT_ROOT.'/expensereport/class/paymentexpensereport.class.php';
|
|
require_once DOL_DOCUMENT_ROOT.'/core/lib/expensereport.lib.php';
|
|
|
|
// Load translation files required by the page
|
|
$langs->loadLangs(array('bills', 'trips'));
|
|
|
|
$id = GETPOSTINT('id');
|
|
$ref = GETPOST('ref', 'alpha');
|
|
$action = GETPOST('action', 'aZ09');
|
|
$confirm = GETPOST('confirm', 'alpha');
|
|
|
|
$object = new PaymentExpenseReport($db);
|
|
|
|
if ($id > 0) {
|
|
$result = $object->fetch($id);
|
|
if (!$result) {
|
|
dol_print_error($db, 'Failed to get payment id '.$id);
|
|
}
|
|
}
|
|
|
|
// Security check
|
|
if ($user->isExternalUser()) {
|
|
$socid = $user->isExternalUser();
|
|
}
|
|
|
|
$result = restrictedArea($user, 'expensereport', $object->fk_expensereport, 'expensereport');
|
|
|
|
|
|
/*
|
|
* Actions
|
|
*/
|
|
|
|
// None
|
|
|
|
|
|
/*
|
|
* View
|
|
*/
|
|
|
|
llxHeader('', $langs->trans("Payment"));
|
|
|
|
$object->info($object->id);
|
|
|
|
$head = payment_expensereport_prepare_head($object);
|
|
|
|
print dol_get_fiche_head($head, 'info', $langs->trans("ExpenseReportPayment"), -1, 'payment');
|
|
|
|
|
|
$linkback = '<a href="' . DOL_URL_ROOT . '/expensereport/payment/list.php">' . $langs->trans("BackToList") . '</a>';
|
|
|
|
dol_banner_tab($object, 'ref', $linkback, 1, 'ref', 'ref', '');
|
|
|
|
|
|
print '<div class="fichecenter">';
|
|
print '<div class="underbanner clearboth"></div>';
|
|
|
|
print '<br>';
|
|
|
|
print '<table width="100%"><tr><td>';
|
|
dol_print_object_info($object);
|
|
print '</td></tr></table>';
|
|
|
|
print '</div>';
|
|
|
|
print dol_get_fiche_end();
|
|
|
|
// End of page
|
|
llxFooter();
|
|
$db->close();
|