dolibarr/htdocs/core/ajax/objectonoff.php
MDW e23059184f
Qual: Phan/fix for notices seen in #37875 & ci (#37876)
* Qual: Fix phan notice

Fix PhanTypeMismatchArgumentNullable: Argument 1 ($stringtosanitize) is $origin of type ?\CommonObject|?\CommonTrigger|?\DolDeprecationHandler|?array{}|?non-empty-array<mixed,mixed>|?non-empty-string|?string but \DoliDB::sanitize() takes string defined at htdocs/core/db/DoliDB.class.php:187 (expected type to be non-nullable)

* Qual: Fix PhanPluginSuspiciousParamPosition

# Qual: Fix PhanPluginSuspiciousParamPosition

Fix notices by using intermediate variable name that matches the parameter of the called function
where the original parameter name matches the name of a parameter in another position

* Qual: Fix PhanTypeMismatchArgument

# Qual: Fix PhanTypeMismatchArgument

Fix PhanTypeMismatchArgument: Argument 1 ($stringtosanitize) is $local of type int but \DoliDB::sanitize() takes string
in get_localtax_by_third($local) where local is an int already.
So use cast to (int) instead.
Also limit typehint of local to 1 and 2 which are the only allowed values

* Qual: Fix PhanTypeMismatchArgument in cloneCategories()

# Qual: Fix PhanTypeMismatchArgument in cloneCategories()

The argument $toId which is already an integer was passed to DoliDB::sanitize() which expects a string.
So casting to (int) instead to fix this.

* Qual: Ignore complex PhanUndeclaredStaticProperty

# Qual: Ignore complex PhanUndeclaredStaticProperty

Accessing static property provided by a trait on some classes - ignore the phan notice

* Qual: Phan ignore PhanUndeclaredMethod for getPossibleLevels

* Qual: Add typing hints for phan

* Qual: Add typehint for phan

* Qual: Remove redundant semicolon in objectonoff.php

# Qual: Remove redundant semicolon in objectonoff.php

Removed an unnecessary semicolon in the error handling loop of objectonoff.php.

* Qual: Fix PhanPossiblyUndeclaredGlobalVariable

* Qual: Ignore PhanPossiblyUndeclaredGlobalVariable
2026-04-15 17:59:06 +02:00

148 lines
4.9 KiB
PHP

<?php
/* Copyright (C) 2015-2023 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2024-2026 MDW <mdeweerd@users.noreply.github.com>
* Copyright (C) 2024 Frédéric France <frederic.france@free.fr>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
/**
* \file htdocs/core/ajax/objectonoff.php
* \brief File to set status for an object. Called when ajax_object_onoff() is used.
* This Ajax service is often called when option MAIN_DIRECT_STATUS_UPDATE is set.
* TODO Rename into updatestatus.php
*/
if (!defined('NOTOKENRENEWAL')) {
define('NOTOKENRENEWAL', '1'); // Disables token renewal
}
if (!defined('NOREQUIREMENU')) {
define('NOREQUIREMENU', '1');
}
if (!defined('NOREQUIREHTML')) {
define('NOREQUIREHTML', '1');
}
if (!defined('NOREQUIREAJAX')) {
define('NOREQUIREAJAX', '1');
}
if (!defined('NOREQUIRESOC')) {
define('NOREQUIRESOC', '1');
}
// Load Dolibarr environment
require '../../main.inc.php';
/**
* @var Conf $conf
* @var DoliDB $db
* @var HookManager $hookmanager
* @var Translate $langs
* @var User $user
*/
require_once DOL_DOCUMENT_ROOT.'/core/class/genericobject.class.php';
$action = GETPOST('action', 'aZ09');
$backtopage = GETPOST('backtopage');
$id = GETPOSTINT('id');
$element = GETPOST('element', 'alpha'); // 'myobject' (myobject=mymodule) or 'myobject@mymodule' or 'myobject_mysubobject' (myobject=mymodule)
$field = GETPOST('field', 'alpha');
$value = GETPOSTINT('value');
$format = 'int';
// Load object according to $id and $element
$object = fetchObjectByElement($id, $element);
if (!is_object($object)) {
httponly_accessforbidden("Bad value for combination of parameters element/field: Object not found."); // This includes the exit.
}
'@phan-var-force CommonObject $object';
$object->fields[$field] = array('type' => $format, 'enabled' => 1);
$module = $object->module;
$element = $object->element;
$usesublevelpermission = ($module != $element ? $element : '');
if ($usesublevelpermission && !$user->hasRight($module, $element)) { // There is no permission on object defined, we will check permission on module directly
$usesublevelpermission = '';
}
//print $object->id.' - '.$object->module.' - '.$object->element.' - '.$object->table_element.' - '.$usesublevelpermission."\n";
// Security check
if (!empty($user->socid)) {
$socid = $user->socid;
if (!empty($object->socid) && $socid != $object->socid) { // @phan-suppress-current-line PhanUndeclaredProperty
httponly_accessforbidden("Access on object not allowed for this external user."); // This includes the exit.
}
}
// We check permission.
// Check is done on $user->rights->element->create or $user->rights->element->subelement->create (because $action = 'set')
if (preg_match('/stat[u][st]$/', $field) || ($field == 'evenunsubscribe' && $object->table_element == 'mailing')) {
restrictedArea($user, $object->module, $object, $object->table_element, $usesublevelpermission);
} elseif ($element == 'product' && in_array($field, array('status', 'status_buy', 'status_batch', 'tosell', 'tobuy', 'tobatch'))) { // Special case for products
restrictedArea($user, 'produit|service', $object, 'product&product', '', '', 'rowid');
} else {
httponly_accessforbidden("Bad value for combination of parameters element/field: Field not supported."); // This includes the exit.
}
/*
* Actions
*/
// None
/*
* View
*/
top_httphead();
//print '<!-- Ajax page called with url '.dol_escape_htmltag($_SERVER["PHP_SELF"]).'?'.dol_escape_htmltag($_SERVER["QUERY_STRING"]).' -->'."\n";
// Registering new values
if (($action == 'set') && !empty($id)) { // Test on permission already done in header according to object and field.
$triggerkey = strtoupper(($module != $element ? $module.'_' : '').$element).'_UPDATE';
// Special case
if ($triggerkey == 'SOCIETE_UPDATE') {
$triggerkey = 'COMPANY_MODIFY';
}
if ($triggerkey == 'PRODUCT_UPDATE') {
$triggerkey = 'PRODUCT_MODIFY';
}
$result = $object->setValueFrom($field, $value, $object->table_element, $id, $format, '', $user, $triggerkey);
if ($result < 0) {
print $object->error."\n";
foreach ($object->errors as $msg) {
print $msg."\n";
}
$db->close();
http_response_code(500);
exit;
}
if ($backtopage) {
$db->close();
header('Location: '.$backtopage);
exit;
}
}
$db->close();