Commit graph

133486 commits

Author SHA1 Message Date
Laurent Destailleur
b4174e7a01
Merge pull request #27688 from libremaster/develop
CRON: fetchAll will return list of Cronjob object instead of Cronjobline
2024-01-21 16:05:38 +01:00
Laurent Destailleur
1c0fd5f4d0
Merge pull request #27702 from mdeweerd/qual/spelling
Qual: Fix spelling.
2024-01-21 16:00:33 +01:00
Laurent Destailleur
6ccea73912
Merge pull request #27704 from mdeweerd/flow/limit-cache-storage
Qual: Store phpstan cache only if not loaded or successful run
2024-01-21 16:00:04 +01:00
MDW
19ac1e4b02 Qual: Store phpstan cache only if not loaded or successful run
The PHPStan steps run a long time for the latest runs and I suspect that
this may be because of a bad cache, possibly includeing:
```
Result cache was not saved because of non-ignorable exception: Syntax error, unexpected } on line 378
``` .

This change should only save the cache if the run was successful or if no cache
was loaded.  The possibly preserves a cache that still reduces the run time.

For instance, the following got an empty cache, saved at 2024-01-19T21:28:22.18Z.
- https://github.com/Dolibarr/dolibarr/actions/runs/7589384926
That was an aborted run:
- https://github.com/Dolibarr/dolibarr/actions/runs/7589372703/job/20673878193

So I added `cancelled()` to avoid overwriting valid cache and phpstan cache
will only be written if the outcome was success or if the cache could not
be loaded before.

I also updated the version for the cache action.
2024-01-21 15:05:47 +01:00
MDW
ef95c56ecd Qual: Fix spelling.
# Qual: Fix some spelling
2024-01-21 13:37:53 +01:00
Alexandre SPANGARO
85fb65ad7e phpcs 2024-01-21 08:09:34 +01:00
Alexandre SPANGARO
c161a825f1 NEW Accountancy - Show accounting result on balance 2024-01-21 08:00:34 +01:00
thibdrev
b4bb255f04
qual:phpstan
htdocs/product/class/product.class.php	666	Property Product::$price_ttc (float) does not accept string.
htdocs/product/class/product.class.php	667	Property Product::$price (float) does not accept string.
htdocs/product/class/product.class.php	668	Property Product::$price_min_ttc (float) does not accept string.
htdocs/product/class/product.class.php	669	Property Product::$price_min (float) does not accept string.
htdocs/product/class/product.class.php	2404	Property Product::$price (float) does not accept string.
htdocs/product/class/product.class.php	2405	Property Product::$price_ttc (float) does not accept string.
htdocs/product/class/product.class.php	2863	Property Product::$price_ttc (float) does not accept string.
2024-01-20 22:00:38 +01:00
thibdrev
8e69be7f8d
qual: phpstan
htdocs/product/card.php	578	Property CommonObject::$barcode_type (int) does not accept array|string.
htdocs/product/card.php	820	Property CommonObject::$barcode_type (int) does not accept array|string.
2024-01-20 21:55:24 +01:00
thibdrev
70ae0186c5
qual: phpstan 2024-01-20 21:53:57 +01:00
thibdrev
87fa8103b1
qual: phpstan
htdocs/multicurrency/multicurrency_rate.php	149	Property CurrencyRate::$rate (float) does not accept string.
htdocs/multicurrency/multicurrency_rate.php	150	Property CurrencyRate::$rate_indirect (float) does not accept string.
htdocs/multicurrency/multicurrency_rate.php	170	Property CurrencyRate::$rate (float) does not accept string.
2024-01-20 21:50:32 +01:00
thibdrev
2ea1254c6b
qual: phpstn
htdocs/loan/card.php	135	Property Loan::$fk_bank (int) does not accept array|string.
htdocs/loan/card.php	143	Property Loan::$fk_project (int) does not accept array|string.
2024-01-20 21:46:38 +01:00
thibdrev
54adf6a285
qual: phpstan
htdocs/holiday/card_group.php	310	Property Holiday::$fk_validator (int) does not accept array|string.
2024-01-20 21:43:27 +01:00
thibdrev
747820da7c
qual: phpstan
htdocs/fourn/facture/card-rec.php	197	Property FactureFournisseurRec::$fk_project (int) does not accept array|string.
htdocs/fourn/facture/card-rec.php	389	Property CommonObjectLine::$id (int) does not accept array|string.
2024-01-20 21:29:46 +01:00
thibdrev
02da32736e
qual: phpstan
htdocs/fourn/facture/card.php	763	Property CommonInvoice::$socid (int) does not accept array|string.
2024-01-20 21:27:24 +01:00
thibdrev
490d1f8cfa
qual: phsptan
htdocs/core/login/functions_openid.php	62	Function check_user_password_openid() should return string but returns false.
htdocs/core/login/functions_openid.php	64	Function check_user_password_openid() should return string but returns false.
htdocs/core/login/functions_openid.php	103	Function check_user_password_openid() should return string but returns false.
htdocs/core/login/functions_openid.php	107	Function check_user_password_openid() should return string but returns false.
htdocs/core/login/functions_openid.php	112	Function check_user_password_openid() should return string but returns false.
2024-01-20 21:18:52 +01:00
thibdrev
791f8c11dc
qual: phpstan
htdocs/core/class/translate.class.php	995	Method Translate::getLabelFromKey() should return string but returns int.
htdocs/core/class/translate.class.php	1032	Method Translate::getLabelFromKey() should return string but returns int.
2024-01-20 21:05:53 +01:00
Laurent Destailleur
18a6d9695c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-01-20 17:55:39 +01:00
Laurent Destailleur
9eaefcfdbf Fix missing header 2024-01-20 17:16:16 +01:00
Laurent Destailleur
6e6aa29ff3 Log 2024-01-20 16:48:39 +01:00
Christophe TREMBLAY-GUILLOUX
c1c45a171a Debug 2024-01-20 14:23:17 +01:00
Christophe TREMBLAY-GUILLOUX
2f32ac6fe3 Debug 2024-01-20 14:16:14 +01:00
Christophe TREMBLAY-GUILLOUX
0701d31325 Someone did a typo mistake 2024-01-20 14:03:56 +01:00
Christophe TREMBLAY-GUILLOUX
6e1a8f2942 Merge remote-tracking branch 'upstream/develop' into develop 2024-01-20 13:42:46 +01:00
Christophe TREMBLAY-GUILLOUX
2ac3b914cb CRON: fetchAll->lines will return list of Cronjob object instead of Cronjobline object 2024-01-20 13:42:39 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
Laurent Destailleur
02d520b5a7
Merge pull request #27604 from W1W1-M/fix-dolresource-phpstan-lvl3
Fix phpstan dolresource
2024-01-20 00:46:32 +01:00
Laurent Destailleur
72f2547422
Update dolresource.class.php 2024-01-20 00:46:02 +01:00
Laurent Destailleur
c78cd05818
Merge pull request #27638 from mdeweerd/qual/admin_lib
Qual: Cleanup method to ignore misspelled key
2024-01-20 00:42:41 +01:00
Laurent Destailleur
c6b99dbea8
Merge pull request #27635 from frederic34/patch-3
fix phpstan
2024-01-20 00:41:22 +01:00
Laurent Destailleur
1f13ec7e39
Merge pull request #27634 from frederic34/patch-8
fix phpstan
2024-01-20 00:41:07 +01:00
MDW
ee398214c2 Fix: Add missing argument to dol_print_error
# Fix: Add missing  argument to dol_print_error

Required  argument was missing.
2024-01-20 00:39:39 +01:00
Laurent Destailleur
72649eb9c6 Clean code 2024-01-20 00:39:13 +01:00
Laurent Destailleur
190d335f24
Merge pull request #27637 from mdeweerd/fix/dol_print_error
Fix: Add missing  argument to dol_print_error
2024-01-20 00:38:27 +01:00
Laurent Destailleur
5d5d996b4a
Merge pull request #27636 from frederic34/patch-5
clean code
2024-01-20 00:38:12 +01:00
Laurent Destailleur
f68dc61a73
Merge pull request #27686 from thibdrev/patch-12
qual: phpstan
2024-01-20 00:37:32 +01:00
Laurent Destailleur
76ae986a77
Merge pull request #27685 from thibdrev/patch-11
qual: phpstan
2024-01-20 00:37:07 +01:00
Laurent Destailleur
b8c5b9d3a0
Merge pull request #27684 from thibdrev/patch-10
qual: phpstan
2024-01-20 00:36:52 +01:00
Laurent Destailleur
b996bb1426
Merge pull request #27683 from thibdrev/patch-9
qual: phpstan
2024-01-20 00:36:36 +01:00
Laurent Destailleur
758404ce1c
Merge pull request #27682 from thibdrev/patch-8
qual: phpstan
2024-01-20 00:36:23 +01:00
Laurent Destailleur
de0ae0032f
Merge pull request #27678 from thibdrev/patch-3
qual: phpstan
2024-01-20 00:35:48 +01:00
Laurent Destailleur
f0373041af
Merge pull request #27681 from thibdrev/patch-7
qual: phpstan
2024-01-20 00:34:24 +01:00
Laurent Destailleur
0de4793bf8
Merge pull request #27640 from frederic34/date_lim_reglement
phpdoc
2024-01-19 22:29:28 +01:00
Laurent Destailleur
fc30521611
Merge pull request #27641 from mdeweerd/fix/missing_arg
Fix: Missing 'ref_supplier' argument
2024-01-19 22:28:15 +01:00
Laurent Destailleur
8c8fea88d2
Merge pull request #27642 from mdeweerd/fix/stripe_exceptions
Fix: Update Stripe Exception class references
2024-01-19 22:26:35 +01:00
thibdrev
1f7c183301
Update paymentloan.class.php - $numpayment is string (not int) 2024-01-19 21:16:08 +01:00
Laurent Destailleur
d3528306d8
Merge pull request #27644 from thibdrev/patch-1
qual: phpstan
2024-01-19 21:12:50 +01:00
Laurent Destailleur
a74014c101
Merge pull request #27645 from libremaster/develop
CLEANING: lines of code not usefull
2024-01-19 21:10:56 +01:00
thibdrev
f8c21d6ce3
Merge branch 'Dolibarr:develop' into patch-3 2024-01-19 21:07:50 +01:00
Laurent Destailleur
5d9b422ddd
Merge pull request #27680 from thibdrev/patch-6
qual: phpstan
2024-01-19 21:07:37 +01:00