# Qual: disable PHPCS action (now performed by pre-commit)
The php-cs analysis is now ensured by pre-commit which does analysis
on changed files in PR's and full analysis in the main branches.
It also provides better reports (PHPCS did not report all the issues
seen in travis).
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Qual: Introduce getDataToShowPhoto to prepare generic code
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix missing trans
* Fix langs
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Remove useless files in web templates
* Clean code
* Fix duplicate translation key
* Fix duplicate translation key
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix duplicate key
* Fix $object
* Debug v19
* WIP SMSing
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP EMAILINGS_SUPPORT_ALSO_SMS
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP SMSing
* Debug the "validate" feature
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Clean code
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Enhance rector to fix empty($user->rights->modulex->perm1)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Fix template to use v19 dev rules
* Fix use v19 dev rules
* Fix phpunit
* Debug v19
* Clean code
* Use rector to convert user->rights into user->hasRight
* Clean code
* Use rector to convert user->rights into user->hasRight
* Use rector to convert user->rights into user->hasRight
* Clean code
* Fix phpcs
* add editorconfig for sql files (#27999)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* add model_pdf field in llx_ticket-ticket.sql (#27996)
* add model_pdf field in llx_ticket-ticket.sql
* Update 19.0.0-20.0.0.sql
* Update 19.0.0-20.0.0.sql
* Improve wording in README (#27994)
* fix phpstan (#27989)
* fix phpstan
* Update UserRightsToFunction.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Fix spelling/working in datapolicy translations (#28006)
# Qual: Fix spelling/wording in datapolicy translations
Fixed some spelling and wording in datapolicy translations.
* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)
htdocs/ticket/class/ticketstats.class.php 98 Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix user with readonly perm on email template must be able to read.
* Fix doc
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Better message
* Add missing fields in merge of thirdparty
* Debug v19 selection of ticket printer per terminal
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Use constant
* NEW: Adding a recipient on emails sent, change status to sent partialy.
* fix travis (#28052)
* fix travis
* Update partnership.class.php
* fix php doc (#28047)
* fix undefined array key (#28048)
* Add region and departament for Cuba (#28046)
* Update llx_10_c_regions.sql
Add Cuba Regions (id_country=77)
* Update llx_20_c_departements.sql
Add Provinces Cuba (id country=77)
* Find the typo (#28050)
* Find the typo
* clean code
* add last_main_doc field to product (#28045)
* add las_main_doc field to product
* add field fetch
* NEW Add Categorie filter for ActionComm (#28041)
* New Add Categorie filter for ActionComm
New Add Categorie filter for ActionComm
* Fix space errors
Fix space errors
* Fix space errors 2
Fix space errors 2
* Update cunits.class.php (#28056)
FIX: error SQL when creating a Cunit
* Update codespell-lines-ignore.txt to avoid PR merge conflict
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: thibdrev <thibault.drevet@gmail.com>
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com>
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com>
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com>
* FIX: Bar code verification should be done by entity because generation does
* FIX: handle Entities shared tables
* FIX: Remove unused global
---------
Co-authored-by: Noé <noe@scopen.fr>
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 156 Property CommandeFournisseurDispatch::$fk_commande (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 159 Property CommandeFournisseurDispatch::$fk_product (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 162 Property CommandeFournisseurDispatch::$fk_commandefourndet (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 168 Property CommandeFournisseurDispatch::$fk_entrepot (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 171 Property CommandeFournisseurDispatch::$fk_user (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 177 Property CommandeFournisseurDispatch::$status (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 355 Property CommandeFournisseurDispatch::$fk_commande (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 358 Property CommandeFournisseurDispatch::$fk_product (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 361 Property CommandeFournisseurDispatch::$fk_commandefourndet (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 367 Property CommandeFournisseurDispatch::$fk_entrepot (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 370 Property CommandeFournisseurDispatch::$fk_user (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 376 Property CommandeFournisseurDispatch::$status (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 629 Property CommandeFournisseurDispatch::$fk_commande (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 630 Property CommandeFournisseurDispatch::$fk_product (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 631 Property CommandeFournisseurDispatch::$fk_commandefourndet (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 633 Property CommandeFournisseurDispatch::$fk_entrepot (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 634 Property CommandeFournisseurDispatch::$fk_user (int) does not accept string.
htdocs/fourn/class/fournisseur.commande.dispatch.class.php 637 Property CommandeFournisseurDispatch::$status (int) does not accept string.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
# Qual: Lower severity on php-cs messages that should not block
Some warning messages result in php-cs having an exit code of 2 and others
only have an exit ocde of 1. When the exit code is 2, the warnings are fixable
by php-cbf.
In order to be able to filter on the warnings in the github ci flow, but still
show them in the travis flow, I lower the level of the warnings that should not
be blocking to 4.
At the same time, the php-cs configuration in pre-commit now requires that the
severity is minimum 5 to show the message (level 5 is the default for all warnings
and errors).
So this will limit the warning messages to the ones that should result in a failing
ci action. If any new cases are discovered, they should also be lowered in the
php-cs configuration file.
* qual: phpstan for htdocs/core/lib/images.lib.php
htdocs/core/lib/images.lib.php 636 Function vignette() should return string but returns int.
* qual: phpstan for htdocs/core/lib/product.lib.php
htdocs/core/lib/product.lib.php 839 Function measuringUnitString() should return string but returns int.
* qual: phpstan for htdocs/core/lib/website.lib.php
htdocs/core/lib/website.lib.php 222 Function dolWebsiteReplacementOfLinks() should return bool but returns string.
* qual: phpstan for htdocs/core/lib/functions.lib.php
htdocs/core/lib/functions.lib.php 9576 Function dol_getIdFromCode() should return int but returns string.
* qual: phpstan for htdocs/core/modules/import/modules_import.php
htdocs/core/modules/import/modules_import.php 173 Method ModeleImports::getDriverId() should return int but returns string.
* qual: phpstan for htdocs/core/modules/mailings/thirdparties_services_expired.modules.php
htdocs/core/modules/mailings/thirdparties_services_expired.modules.php 100 Method mailing_thirdparties_services_expired::add_to_target() should return int but returns string.
* qual:phpstan for htdocs/loan/schedule.php
htdocs/loan/schedule.php 80 Property LoanSchedule::$datec (string) does not accept int.
* fix: auto generated user login 'undefined' appears on login input)[fix: auto generated user login 'undefined' appears on login input
When We enter a lastname then we enter a firstname the generated login looks fine
Example:
- lastname = Yacine
- firstname = Ahmaich
- login = yahmaich
But if we clear the firstname or the lastname we got
- lastname = Yacine
- firstname = // we clear the value of firstname
- login = yundefined
I fix the issue and also add a dot in the generated login because 'y.ahmaich' as login looks better than 'yahmaich'
* feat: add a configuration constant of separator char for generated login.
use constant **MAIN_USER_SEPARATOR_CHAR_FOR_GENERATED_LOGIN** to specify a separator for the auto generated login
* add import for events and more fields to export also
* update
* update to allowed mutli entity# Veuillez saisir le message de validation pour vos modifications. Les lignes
* update
* Update import_csv.modules.php
* update
* Update modAgenda.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
