Commit graph

133486 commits

Author SHA1 Message Date
lvessiller-opendsi
1e28f72057
NEW warning message when cloning a product whose status is not to sell (#28374) 2024-02-23 17:18:16 +01:00
lamrani abdelwadoud
71e59190aa
New method for calcule spent time in week passed (#28314)
* create method for calcule spent time in week

* Fix method for get first day of week and send email

* update method by sending mail with content and inserting in actioncom

* fix undeclared variables

* fix other variable undeclared
2024-02-23 17:15:40 +01:00
noec764
692e10ec94
FIX: Error When cloning fourn price no default value for tva_tx (#28368)
Co-authored-by: Noé <noe@scopen.fr>
2024-02-23 17:14:10 +01:00
thibdrev
d4faa5e2b5
qual: phpstan - Property CommonObjectLine::$fk_unit (int|null) does not accept string|null. (#28372)
* Update propal.class.php

htdocs/comm/propal/class/propal.class.php	746	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

htdocs/comm/propal/class/propal.class.php	963	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

* Update commande.class.php

htdocs/commande/class/commande.class.php	1692	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

htdocs/commande/class/commande.class.php	3273	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

* Update facture.class.php

htdocs/compta/facture/class/facture.class.php	3990	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

htdocs/compta/facture/class/facture.class.php	4243	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

* Update fournisseur.commande.class.php

htdocs/fourn/class/fournisseur.commande.class.php	2149	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

htdocs/fourn/class/fournisseur.commande.class.php	3031	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

* Update fournisseur.facture.class.php

htdocs/fourn/class/fournisseur.facture.class.php	2257	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.

htdocs/fourn/class/fournisseur.facture.class.php	2453	Property CommonObjectLine::$fk_unit (int|null) does not accept string|null.
2024-02-23 17:13:15 +01:00
Laurent Destailleur
9e6de237fe Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-23 17:09:54 +01:00
noec764
141d2d2aa9
FIX: Label must not be copied in desc (#28377)
Co-authored-by: Noé <noe@scopen.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-23 17:07:38 +01:00
Laurent Destailleur
00939477fb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-23 17:07:10 +01:00
Laurent Destailleur
3ef33e59a0 Doc 2024-02-23 17:06:56 +01:00
MDW
25617ab982
Fix: Protect from negative array index access (#28379)
# Fix: Protect from negative array index access

Negative array index access can happen when $i is 0.
While this raises a notice before PHP7.1 it would compare to the last
value in the string so it's invalid.

Detected with phan: PhanCompatibleNegativeStringOffset
2024-02-23 16:55:15 +01:00
MDW
a392ed0711
Qual: Suppress PhanPluginSuspiciousParamPosition for file (#28381) 2024-02-23 16:54:23 +01:00
Alban Durrheimer
36d364fb2d
Add sendEmailsRemindersOnSupplierInvoiceDueDate cron function (#28378)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-23 16:50:21 +01:00
Laurent Destailleur
85803c9dbf Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-23 16:45:19 +01:00
Laurent Destailleur
8ad9dc5b44 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-23 16:41:33 +01:00
Laurent Destailleur
d84a886e87 FIX #28369 2024-02-23 16:22:43 +01:00
Laurent Destailleur
1dbfd164bb Fix corrupted data 2024-02-23 15:27:00 +01:00
Laurent Destailleur
80f3bc6c1b Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-23 15:25:56 +01:00
Laurent Destailleur
f8c6d5a6a1 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-23 15:25:36 +01:00
Laurent Destailleur
7b1dc74b9e Fix corrupted data 2024-02-23 15:25:22 +01:00
Laurent Destailleur
2acfea2f0c Fix corrupted data 2024-02-23 15:24:47 +01:00
Laurent Destailleur
ad6fe34361 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-23 14:27:51 +01:00
AWeerWolf
be571fd372
#28334 (#28336)
Update lib_head.js.php concerning Date Format
Replace 1900 by 2000
2024-02-23 13:40:30 +01:00
thibdrev
db2fc174cd
qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28364)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array<int, float> of property Paiement::$multicurrency_tx is not covariant with PHPDoc type float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array<int, string> of property Paiement::$multicurrency_code is not covariant with PHPDoc type string of overridden property CommonObject::$multicurrency_code.
2024-02-23 13:40:22 +01:00
thibdrev
77ae6888ff
qual: phpstan for $user_valid (#28362)
* Update commande.class.php

htdocs/commande/class/commande.class.php	248	PHPDoc type int of property Commande::$user_valid is not covariant with PHPDoc type User of overridden property CommonObject::$user_valid.

* Update facture.class.php

htdocs/compta/facture/class/facture.class.php	129	PHPDoc type int of property Facture::$user_valid is not covariant with PHPDoc type User of overridden property CommonObject::$user_valid.
2024-02-23 13:39:49 +01:00
MDW
2cd1a1a303
Fix: Add parentheses to fix expression (#28365)
* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'

* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'

* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'
2024-02-23 13:39:17 +01:00
William Mead
70a061d0ce
Qual PHPStan Facture class (#28371)
* Fixed usage of deprecated $user_author

* Deleted unused properties

* Cleaned PHPDoc
2024-02-23 13:38:28 +01:00
Laurent Destailleur
dd9af54a6c Deprecate var 2024-02-23 13:37:58 +01:00
Laurent Destailleur
8aa3be1a82 Standardization 2024-02-23 13:28:17 +01:00
Laurent Destailleur
ad662c468f Fix sql with field name "desc" 2024-02-22 19:52:24 +01:00
Laurent Destailleur
f35e55030e Fix sql with field name "desc" 2024-02-22 19:49:43 +01:00
Laurent Destailleur
007b2bf758 Doygen 2024-02-22 19:29:31 +01:00
Laurent Destailleur
260505e2aa Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 19:27:03 +01:00
Laurent Destailleur
71dc610c25 Doc 2024-02-22 19:26:47 +01:00
thibdrev
132e98a4c7
qual: phpstan for CommonObject->origin (#28361)
htdocs/commande/class/commande.class.php	538	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/commande/class/commande.class.php	675	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/compta/facture/class/facture.class.php	2859	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3378	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3696	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	2326	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/expedition/class/expedition.class.php	2487	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/fourn/class/fournisseur.commande.class.php	1283	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.commande.class.php	2278	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1858	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1999	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/commande/dispatch.php	435	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	482	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	489	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/reception/class/reception.class.php	582	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1081	Property CommonObject::$origin (string) does not accept null.
htdocs/reception/class/reception.class.php	1674	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1833	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1967	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/takepos/invoice.php	332	Property CommonObject::$origin (string) does not accept Facture.
htdocs/takepos/invoice.php	336	Property CommonObject::$origin (string) does not accept Facture.
2024-02-22 19:25:01 +01:00
thibdrev
bb178dc8ab
qual: phpstan for htdocs/takepos/invoice.php (#28360)
htdocs/takepos/invoice.php	284	Property Paiement::$pos_change (float) does not accept string.
2024-02-22 19:18:00 +01:00
Can Arslan
2a03df95b4
FIX: duplicate with lines: 414-416 (#28358) 2024-02-22 19:17:38 +01:00
Laurent Destailleur
c99906db11 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 19:16:49 +01:00
Laurent Destailleur
8342b823c4 Fix $ventil warning 2024-02-22 19:16:32 +01:00
thibdrev
87a5ca7756
qual: phpstan for $fk_unit (#28359)
* Update bom.class.php

* Update commonobjectline.class.php

* Update product.class.php

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs
2024-02-22 19:14:31 +01:00
Laurent Destailleur
838c748fae Reduce variable parts into website template so risk of git conflict is
lower
2024-02-22 17:30:54 +01:00
Laurent Destailleur
82dd321662 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 13:28:40 +01:00
Laurent Destailleur
637ffa837f Clean code 2024-02-22 13:28:18 +01:00
thibdrev
999af4951b
qual: phpstan - various "$hidden (bool) does not accept string." (#28350)
* Update modWebsite.class.php

* Update DolibarrModules.class.php

* Update modCron.class.php

* Update modSocialNetworks.class.php

* qual: phpstan for htdocs/core/modules/modCollab.class.php

htdocs/core/modules/modCollab.class.php	68	Property DolibarrModules::$hidden (bool) does not accept string.
2024-02-22 13:27:04 +01:00
HENRY Florian
38095cf8b8
fix: enabled default wharehouse field on service if STOCK_SUPPORTS_SERVICES (#28354) 2024-02-22 13:24:18 +01:00
MDW
f1f516f54c
NEW: Global constant for deprecated module mapping (#28348)
* Qual: Add another deprecated module mapping

* NEW: Global constant for deprecated module mapping
2024-02-22 13:23:39 +01:00
thibdrev
2b4bc3b4bc
qual: phpstan for htdocs/resource/class/dolresource.class.php (#28352)
htdocs/resource/class/dolresource.class.php	723	Property Dolresource::$busy (int) does not accept string.

htdocs/resource/class/dolresource.class.php	726	Property Dolresource::$mandatory (int) does not accept string.
2024-02-22 13:22:24 +01:00
thibdrev
009a4856b3
qual: phpstan - various fixes (#28351)
* qual: phpstan for htdocs/compta/tva/class/paymentvat.class.php

htdocs/compta/tva/class/paymentvat.class.php	540	Property CommonObject::$tms (int) does not accept string.

* qual: phpstan - various "$enabled (int) does not accept bool."

htdocs/core/boxes/box_actions.php	54	Property box_actions::$enabled (int) does not accept bool.

htdocs/core/boxes/box_actions_future.php	54	Property box_actions_future::$enabled (int) does not accept bool.

htdocs/core/boxes/box_activity.php	53	Property box_activity::$enabled (int) does not accept string.

* qual: phpstan for htdocs/core/boxes/box_activity.php

htdocs/core/boxes/box_activity.php	53	Property box_activity::$enabled (int) does not accept string.

* qual: phpstan for htdocs/core/modules/modTakePos.class.php

htdocs/core/modules/modTakePos.class.php	284	Property Societe::$code_client (string) does not accept int.

htdocs/core/modules/modTakePos.class.php	285	Property Societe::$code_fournisseur (string) does not accept int.
2024-02-22 13:22:06 +01:00
Laurent Destailleur
757abcfaae Fix warning 2024-02-22 13:20:00 +01:00
Laurent Destailleur
8ba8b62180 Standardize field name 2024-02-22 13:11:32 +01:00
Laurent Destailleur
01e82a94b8 Fix phpstan 2024-02-22 12:46:57 +01:00
Laurent Destailleur
23492676b0 Removed definitely modelpdf (replaced with model_pdf) 2024-02-22 12:30:35 +01:00