Commit graph

133486 commits

Author SHA1 Message Date
MDW
6cce456b8c
Qual: Add fixers for price(ARG2), and urlencode((string)...) (#28701)
# Qual: Add fixers for price(ARG2), and urlencode((string)...)

Register the fixers used to fix phan messages by adjusting arguments and casts.
2024-03-08 12:18:22 +01:00
thibdrev
cc5366249a
qual: phpdoc for htdocs/core/db/mysqli.class.php (#28703)
PHPDoc update to reflect what the code does today.

This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php	243	Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
2024-03-08 12:10:09 +01:00
thibdrev
231703e5d1
qual: phpstan for htdocs/loan/class/paymentloan.class.php (#28704)
htdocs/loan/class/paymentloan.class.php	155	Property PaymentLoan::$num_payment (string) does not accept int.

htdocs/loan/class/paymentloan.class.php	317	Property PaymentLoan::$num_payment (string) does not accept int.
2024-03-08 12:09:49 +01:00
William Mead
3583c4aeea
NEW updated resource list for new fields (#28705)
* Added address, zip & town

* Added state & country

* Added phone, email, max_users & url

* Added link formatting. Cleaned code.

* Updated EN & FR localization

* Added country select list

* Cleaned code
2024-03-08 12:09:32 +01:00
John BOTELLA
d1c980b0be Factoring fetchObjectLinked 2024-03-08 11:57:07 +01:00
John BOTELLA
17a5bf1eab
Merge branch 'develop' into fix_element_type_part_04 2024-03-08 11:06:20 +01:00
Laurent Destailleur
a4faa488fd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-08 11:00:50 +01:00
Laurent Destailleur
fb16af02b4 Clean code. Move member type API in good file. 2024-03-08 11:00:19 +01:00
John BOTELLA
076a009554
Merge branch 'develop' into fix_element_type_part_03 2024-03-08 10:46:35 +01:00
Frédéric FRANCE
c537d8dd11
Merge branch 'develop' into patch-11 2024-03-08 09:26:29 +01:00
Eric Seigne
9f1904e8d2 todo is done 2024-03-08 00:15:45 +01:00
Eric Seigne
57e5599d82 Merge branch '18.0' into 18.0-ticket_code_review 2024-03-08 00:12:22 +01:00
Can Arslan
491e85037a
FIX: PHP Warning: Undefined variable $mode (#28697) 2024-03-07 23:09:54 +01:00
MDW
79adb60cf5
Qual: Add instanceof tests to help static typing analysis (#28696)
# Qual: Add instanceof tests to help static typing analysis

Added instanceof tests to help identify that properties exist.
2024-03-07 23:09:25 +01:00
Anthony Berton
ff03f86a50
NEW - See the documents of my subordinates (#28318)
* NEW - See the documents of my subordinates

* cop

* Rewriting

* up

* ok

* FIX - Restriction on sale representative

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 22:47:29 +01:00
Frédéric FRANCE
2a3ceb00dd
Merge branch 'develop' into patch-11 2024-03-07 22:17:10 +01:00
Frédéric FRANCE
3035a7bc7f
fix phpstan (#28695)
* fix phpstan

* fix typo

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-07 22:13:09 +01:00
Laurent Destailleur
7f277e9578 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 22:09:31 +01:00
Laurent Destailleur
ca297a751f Clean internal pahn warnings 2024-03-07 22:08:58 +01:00
Laurent Destailleur
970545b218 Doc 2024-03-07 21:49:45 +01:00
Frédéric FRANCE
c2379bfdf5
fix phpstan (#28694)
* fix phpstan

* fix typo

* fix phpstan
2024-03-07 21:39:29 +01:00
Laurent Destailleur
10aa278aca Fix add a type to allow sanitization of import rule='compute'. 2024-03-07 21:38:40 +01:00
Frédéric FRANCE
de5f6bcb93
Merge branch 'develop' into patch-11 2024-03-07 21:07:34 +01:00
Sébastien NASSIET
2636a64461
Set import_key in import when update record (#28657)
* Set import_key in import when update record

* Update import_xlsx.modules.php
2024-03-07 20:43:45 +01:00
Laurent Destailleur
a3b2682bbe
Merge branch 'develop' into fix_element_type_part_04 2024-03-07 20:33:24 +01:00
Laurent Destailleur
1d77e34daf
Merge branch 'develop' into fix_element_type_part_03 2024-03-07 20:33:17 +01:00
John BOTELLA
7b5982de5b
NEW : Factoring and Fix external module elementType limit - Part 02 (#28666)
* Fix element type size

* Factoring getElementType

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:32:41 +01:00
John BOTELLA
0dd7aad04b
Fix element type size (#28664) 2024-03-07 20:27:51 +01:00
Rikard Bosnjakovic
901fd65ad9
Fix #20209 (#28692)
When using multiple languages Dolibarr sometimes switches languages depending on settings. By not loading the "main" file, the proper date formats will not be used and this leads to inconsistency.
2024-03-07 20:24:37 +01:00
thibdrev
e2026a1c14
qual: phan for functions.lib.php (#28654)
6 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 5 ($objcon) is null of type null but \show_actions_messaging() takes \Contact|string (no real type) defined at htdocs/core/lib/functions.lib.php:13081
2024-03-07 20:23:45 +01:00
thibdrev
07b2850c27
qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28689)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array of property Paiement::$multicurrency_tx is not covariant with PHPDoc type array|float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array of property Paiement::$multicurrency_code is not covariant with PHPDoc type array|string of overridden property CommonObject::$multicurrency_code.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:22:51 +01:00
Florian Mortgat
7f10566d5e
FIX 17.0: $num doesn't take trigger-modified newref into account, leading to inconsistencies if BILL_SUPPLIER_VALIDATE changes the invoice's ref (#28684)
this is a follow-up of PR #27008
2024-03-07 20:21:41 +01:00
thibdrev
4b47868cea
qual: phpstan for htdocs/accountancy/class/accountingjournal.class.php (#28690)
htdocs/accountancy/class/accountingjournal.class.php	82	PHPDoc type array of property AccountingJournal::$lines is not covariant with PHPDoc type array of overridden property CommonObject::$lines.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:17:51 +01:00
MDW
63b2fff4a7
Qual: Ignore false positive for suspicious param positions (#28693)
* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
2024-03-07 20:16:48 +01:00
Frédéric FRANCE
01466b0056
Merge branch 'develop' into patch-11 2024-03-07 20:08:17 +01:00
Frédéric FRANCE
eb12fe6545
fix create from order (#28660) 2024-03-07 19:11:43 +01:00
Laurent Destailleur
b4b83c10b4 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 19:10:53 +01:00
Laurent Destailleur
6e2f1d350a Fix position of parameter 2024-03-07 19:10:27 +01:00
Laurent Destailleur
a63d7e0802 Fix regression 2024-03-07 19:06:08 +01:00
Jon Bendtsen
cbd331256d using note_public since note_private is not working (#28675)
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2024-03-07 19:02:08 +01:00
Jon Bendtsen
b55804841f
using note_public since note_private is not working (#28675)
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2024-03-07 19:01:38 +01:00
thibdrev
d79b3ba8ec
qual: phpstan for htdocs/expedition/class/expedition.class.php (#28686)
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (CommonObject|string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (CommonObject|string) does not accept null.
2024-03-07 18:57:38 +01:00
MDW
c6333c7782
Fix: Missing parameter (#28691)
# Fix: Missing parameter

dol_print_error was missing db parameter
2024-03-07 18:57:18 +01:00
Laurent Destailleur
a72e1f08c1 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

Conflicts:
	htdocs/fourn/class/fournisseur.commande.class.php
2024-03-07 18:54:59 +01:00
Laurent Destailleur
f396bf1218 Fix compatibility 2024-03-07 18:53:21 +01:00
Laurent Destailleur
5f7192f475 Fix signature of delete method 2024-03-07 18:51:20 +01:00
Frédéric FRANCE
9b59445e39
fix unknown $user (#28687)
* fix unknown $user

* fix @param

* fix @param

* fix @param

* fix @param
2024-03-07 18:48:50 +01:00
Laurent Destailleur
61e69b352b Doc 2024-03-07 18:44:55 +01:00
thibdrev
c66f7d6345
qual: phpstan for htdocs/comm/action/class/ical.class.php (#28685)
htdocs/comm/action/class/ical.class.php	146	Property ICal::$file_text (string) does not accept null.
htdocs/comm/action/class/ical.class.php	171	Property ICal::$file_text (string) does not accept array|false.
2024-03-07 18:20:18 +01:00
Frédéric FRANCE
33d3eb0949
Merge branch 'develop' into patch-11 2024-03-07 18:14:02 +01:00