Commit graph

133486 commits

Author SHA1 Message Date
MDW
101d56a2c1
Fix: Ob buffer cleanup on exception
# Fix: Ob buffer cleanup on exception

The OB buffer capture was incorrectly cleaned up on exception.
This fixes that.

Also modified the SecurityTest to enable running it standalone
2024-03-10 15:17:58 +01:00
Frédéric France
8cbd159d50 test 2024-03-10 08:58:09 +01:00
Frédéric France
5f30dffa59 test 2024-03-10 08:54:51 +01:00
MDW
c6fa4e4945
Qual: Enable reporting PhanTypeMismatchDimAssignment 2024-03-10 02:17:20 +01:00
Laurent Destailleur
1798283d96
Merge branch 'develop' into patch-11 2024-03-10 02:01:04 +01:00
MDW
4c442de1a2
Qual: Add phan stub files to phpstan configuration (#28730)
* Qual: Add phan stub files to phpstan configuration

* Provide log as artifact (for debug), improve CACHE_KEY
2024-03-10 02:00:41 +01:00
Laurent Destailleur
e5dc0f97d0 Fix cast 2024-03-10 01:59:42 +01:00
Laurent Destailleur
51807de4ff Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 01:56:45 +01:00
Charles
ce30ccb004
Update ticket.class.php #28721 - Default for Ticket fk_statut in "update" function (#28731)
Correcting the default value for Ticket fk_statut to zero(0) instead of null based on the prescription from the create function.
2024-03-10 01:56:36 +01:00
MDW
6d9e7b8144
Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal (#28732)
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal

* Qual: phan: suppress false positive on ssl_set

* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.

* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing

* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
2024-03-10 01:55:56 +01:00
MDW
d524e97137
Qual: Fix & enable PhanPluginRedundantAssignmentInLoop (#28733)
# Qual: Fix & enable PhanPluginRedundantAssignmentInLoop

Fixes the occurences that generated this notice & enable the report
for PhanPluginRedundantAssignmentInLoop
2024-03-10 01:54:34 +01:00
Laurent Destailleur
429476e293 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 01:53:32 +01:00
MDW
37afba949e
Fix most PhanTypeMismatchDimAssignment notices (#28739)
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice

* Fix: Initialise array for code in somme

* Qual: Update type hint for  argument in _Set_Format

* Qual: Update type hint for childtables

* Qual: Add typing to attributes

* Qual: Add typing for _msgContent

* Qual: Suppress PhanTypeMismatchDimAssignment

* Qual: Add typing for liste

* Qual: Add typing to fields

* Qual: Add typing hint for $objMod

* Qual: Modify assignment of array with bool keys for phan typing

Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
  [1] =>
  string(3) "yes"
  [0] =>
  string(2) "no"
}
```

* Qual: Add typing hint to indicate value is not null

* Force non-null type on $paramname

* Qual: Add typing hint to getCats()

* Update inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-10 01:53:04 +01:00
Laurent Destailleur
28df0ba1ab Fix doc 2024-03-10 01:49:56 +01:00
MDW
c95bab2818
Qual: Add check on addExtraField type argument (#28738)
* Qual: Add check on addExtraField type argument

# Qual: Add check on addExtraField type argument

Added a check on the type argument for addExtraField

* Qual: Update phan ignore with more specific name
2024-03-10 01:46:10 +01:00
Frédéric FRANCE
895aa5ee85
fix phpstan (#28735)
* fix phpstan

* fix phpstan

* fix phpstan
2024-03-10 01:44:08 +01:00
Laurent Destailleur
96ef01c5c7 Fix print $sql 2024-03-10 01:37:27 +01:00
Laurent Destailleur
279de64851 Fix regression 2024-03-10 01:21:50 +01:00
Laurent Destailleur
8ef22dc461 Fix css 2024-03-10 00:47:00 +01:00
Laurent Destailleur
cecd3bc1b6 FIX Picto in top menu 2024-03-09 23:47:28 +01:00
Laurent Destailleur
7e31aedf94 FIX Picto in top menu 2024-03-09 23:46:38 +01:00
Laurent Destailleur
983b22303a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-09 23:20:55 +01:00
Laurent Destailleur
e6a6ec737e Clean code to edit a menu entry 2024-03-09 23:20:43 +01:00
AWeerWolf
96eb651f95 White spaces is hell 2024-03-09 22:53:16 +01:00
AWeerWolf
8906d734db Still some White Spaces 2024-03-09 22:49:06 +01:00
AWeerWolf
ae0b7f6466 Merge branch 'develop' of https://github.com/AWeerWolf/dolibarr into develop 2024-03-09 22:44:47 +01:00
AWeerWolf
f1715a5209 Suppressing White soace at end of lines 2024-03-09 22:44:39 +01:00
Jon Bendtsen
668d2fa6e8 making param string cheque_number line up and conform better with previous code 2024-03-09 22:43:53 +01:00
AWeerWolf
39b8bc1729
Merge branch 'develop' into develop 2024-03-09 22:39:35 +01:00
Jon Bendtsen
95d644615c remove trailing whitespace 2024-03-09 22:14:02 +01:00
Jon Bendtsen
0c91e3fe06 attempt at fixing #28645 2024-03-09 22:01:30 +01:00
AWeerWolf
1c2f6533c2 Adding Hooks in bookkeeping card 2024-03-09 18:43:41 +01:00
Frédéric FRANCE
3a88c9f73e
Merge branch 'develop' into patch-11 2024-03-09 17:53:13 +01:00
MDW
4fa993fe8a
Fix: Ensure string type for urlencode() 2024-03-09 16:57:05 +01:00
MDW
1ce098d211
Fix: Ensure string type for urlencode() 2024-03-09 16:57:04 +01:00
MDW
7d84a5ecf3
Fix: Ensure string type for urlencode() 2024-03-09 16:57:03 +01:00
MDW
ed507b7df2
Fix: Ensure string type for urlencode() 2024-03-09 16:57:02 +01:00
MDW
be80a14b47
Fix: Ensure string type for urlencode() 2024-03-09 16:57:01 +01:00
MDW
08424f1347
Fix: Ensure string type for urlencode() 2024-03-09 16:57:00 +01:00
MDW
41a82fe7da
Fix: Ensure string type for urlencode() 2024-03-09 16:56:59 +01:00
MDW
7fd69459df
Fix: Ensure string type for urlencode() 2024-03-09 16:56:58 +01:00
MDW
a7c5b01ec3
Fix: Ensure string type for urlencode() 2024-03-09 16:56:57 +01:00
MDW
8bd13a17db
Fix: Ensure string type for urlencode() 2024-03-09 16:56:56 +01:00
MDW
a00e69f96f
Fix: Ensure string type for urlencode() 2024-03-09 16:56:55 +01:00
MDW
14843e808a
Fix: Ensure string type for urlencode() 2024-03-09 16:56:54 +01:00
MDW
6f7e11126b
Fix: Ensure string type for urlencode() 2024-03-09 16:56:53 +01:00
MDW
68ab7bac14
Fix: Ensure string type for urlencode() 2024-03-09 16:56:53 +01:00
MDW
5f025a87e1
Fix: Ensure string type for urlencode() 2024-03-09 16:56:52 +01:00
MDW
7293151d82
Fix: Ensure string type for urlencode() 2024-03-09 16:56:51 +01:00
MDW
837749d471
Fix: Ensure string type for urlencode() 2024-03-09 16:56:50 +01:00