# Qual: Ignore most shellcheck annotations, fix some
Most shellcheck annotations are ignored - this is to make sure that ci
can work for existing scripts.
Some fixes were applied.
pre-commit script was beautyfied by temporarily suppressing the IFS= expression on 2 lines.
* qual: Move the function checking Spanish Tax Identification Numbers from societe.class.php to profid.lib.php
Create the function isValidTinForES($str)
* qual: Update societe.class.php using function isValidTinForES($str) from profid.lib.php
* phpcs
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Mostly comments, one variable changed from misspelling to .
Also changed CNAT to C.N.A.T in comment to avoid fix from CNAT to CAN'T.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
# Qual: Fix spelling htdocs/p[b-z]*
Highlight:
Probably fixes a bug:
htdocs/product/stock/replenish.php: empty(->variants->eabled) corrected to ...enabled.
'eabled' could not be found elsewhere in the codebase.
# Qual: Fix trailing whitespace in yaml file.
Yaml check tools complain about trailing whitespace, so I fix them.
pre-commit (#27392) has rules to fix them automatically (locally).
* qual: Update profid.lib.php - move functions checking profid from societe.class.php
- One function checking the Tax Identification Number for PT (called NIF)
- One function checking the Tax Identification Number for DZ (called NIF)
- One function checking the Tax Identification Number for BE (called NN)
* qual: Update societe.class.php - use the isValidTinXX() functions from profid.lib.php
isValidTinForPT($this->idprof1)
isValidTinForDZ($this->idprof1)
isValidTinForBE($this->idprof1)
* typo
# Qual: Fix spelling htdocs/[q-z]*
Probably fixes a bug:
- htdocs/webservices/server_thirdparty.php
No other occurence of adress found.
-'adress'=>->adress,- +'address'=>->address,+
* Qual: Spelling outside htdocs
# Qual: Fix spelling of files not in the htdocs subdirectory.
Highlight:
- Change in email test from unvalid to invalid that should give the same test result.
* Update Dolibarr-soapui-project.xml
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>