Commit graph

133486 commits

Author SHA1 Message Date
Laurent Destailleur
569d9426d7 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-12 21:40:51 +01:00
Laurent Destailleur
11d6b891fa FIX SQL error 2024-01-12 21:37:19 +01:00
Laurent Destailleur
014c9a1739 FIX SQL error 2024-01-12 21:36:29 +01:00
Laurent Destailleur
523279f028 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-12 21:35:15 +01:00
Laurent Destailleur
f1fc1d5d69 Qual: methods CRUD must have $user as first parameter 2024-01-12 21:34:21 +01:00
MDW
c885c6917e
Qual: Ignore most shellcheck annotations, fix some (#27452)
# Qual: Ignore most shellcheck annotations, fix some

Most shellcheck annotations are ignored - this is to make sure that ci
can work for existing scripts.

Some fixes were applied.

pre-commit script was beautyfied by temporarily suppressing the IFS= expression on 2 lines.
2024-01-12 21:03:08 +01:00
thibdrev
96383a10a5
qual: move the function checking the syntax of Spanish Tax Identification Numbers (CIF, NIF, NIE) to profid.lib.php (#27472)
* qual: Move the function checking Spanish Tax Identification Numbers from societe.class.php to profid.lib.php

Create the function isValidTinForES($str)

* qual: Update societe.class.php using function isValidTinForES($str) from profid.lib.php

* phpcs

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 20:59:42 +01:00
MDW
85ad4ecdf8
Qual: Spelling for htdocs/[a-b]* (#27422)
Mostly comments, one variable changed from misspelling to .
Also changed CNAT to C.N.A.T in comment to avoid fix from CNAT to CAN'T.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 20:58:09 +01:00
Laurent Destailleur
00903a7672 Fix phpstan 2024-01-12 20:55:40 +01:00
Laurent Destailleur
cb2ebb1d56 Fix phpcs 2024-01-12 20:51:10 +01:00
Laurent Destailleur
b2926952a8 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-12 20:46:39 +01:00
Laurent Destailleur
d9c72fa9a4 Fix phpcs 2024-01-12 20:46:16 +01:00
Frédéric FRANCE
8aa4a515dd
add hook getBuyPrice (#27420) 2024-01-12 20:43:00 +01:00
Frédéric FRANCE
0d3e0c8ec4
fix incorrect case and remove exclude check (#27449) 2024-01-12 20:40:34 +01:00
Laurent Destailleur
7c5a782593 Fix method undef 2024-01-12 20:31:52 +01:00
Mohamed DAOUD
1e01321294
NEW: add position column in category table (#27425)
* add position column in category table

* Update 19.0.0-20.0.0.sql

* Update llx_categorie.sql

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 19:55:23 +01:00
Lucas Marcouiller
43e82eff70
Fix funnel of prospection to have a minimum value (#27426)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-01-12 19:54:30 +01:00
Frédéric FRANCE
591568e34a
clean code (#27421) 2024-01-12 19:53:55 +01:00
Frédéric FRANCE
a2aac4bd6c
fix phpdoc (#27429) 2024-01-12 19:53:13 +01:00
Laurent Destailleur
f201692001 Fix phpstan 2024-01-12 19:50:22 +01:00
Laurent Destailleur
ad6c4c2deb Fix phpcs 2024-01-12 18:18:20 +01:00
MDW
591306d7b1
Qual: Spelling htdocs/[l-o]* & htdocs/pa* (#27435)
# Qual: Fix spelling htdocs/[l-o]* & htdocs/pa*

Mostly comments, some local variables changed and translations to avoid
automatic fixes.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 18:06:50 +01:00
HENRY Florian
13ddcb9552
fix: filter on date lost on sort (#27467) 2024-01-12 18:04:00 +01:00
Frédéric FRANCE
85b7dfbf73
add info in service tooltip (#27423) 2024-01-12 18:03:24 +01:00
Frédéric FRANCE
ae194e2d3e
fix phpdoc (#27428) 2024-01-12 18:02:42 +01:00
Frédéric FRANCE
b7846ac9d1
fix phpdoc (#27430) 2024-01-12 18:02:28 +01:00
Frédéric FRANCE
356a1a882f
fix phpdoc (#27431) 2024-01-12 18:02:05 +01:00
Frédéric FRANCE
662a55ece8
fix phpdoc (#27432) 2024-01-12 18:01:50 +01:00
Frédéric FRANCE
0a9657ac60
fix phpdoc (#27433) 2024-01-12 18:01:36 +01:00
lamrani abdelwadoud
c70b5a2e11
Fix nb of evaluation and display speciale char (#27434)
* Fix nb of evaluation and display speciale char

* Update hrm_evaluation.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 18:00:07 +01:00
MDW
0395718521
Qual: Spelling htdocs/p[b-z]* (#27436)
# Qual: Fix spelling htdocs/p[b-z]*

Highlight:

Probably fixes a bug:
htdocs/product/stock/replenish.php: empty(->variants->eabled) corrected to ...enabled.
'eabled' could not be found elsewhere in the codebase.
2024-01-12 17:55:52 +01:00
Frédéric FRANCE
3160cab8b3
remove unused code (#27437) 2024-01-12 17:55:02 +01:00
MDW
c094fba538
Qual: Fix trailing whitespace in yaml file. (#27466)
# Qual: Fix trailing whitespace in yaml file.

Yaml check tools complain about trailing whitespace, so I fix them.
pre-commit (#27392) has rules to fix them automatically (locally).
2024-01-12 17:54:14 +01:00
thibdrev
dd2a3c05d9
qual: move into profid.lib.php the code checking the idprof1 syntax for BE, DZ and PT (#27443)
* qual: Update profid.lib.php - move functions checking profid from societe.class.php

- One function checking the Tax Identification Number for PT (called NIF)
- One function checking the Tax Identification Number for DZ (called NIF)
- One function checking the Tax Identification Number for BE (called NN)

* qual: Update societe.class.php - use the isValidTinXX() functions from profid.lib.php

isValidTinForPT($this->idprof1)
isValidTinForDZ($this->idprof1)
isValidTinForBE($this->idprof1)

* typo
2024-01-12 17:53:29 +01:00
William Mead
4ef13a2196
Fixed method filter argument type. Cleaned code. Added contributor details. (#27464)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 17:52:49 +01:00
nat
f721b7a2de
FIX Error creating a thirdparty (#27438)
The mod_codeclient_* constructors now expect an argument.
See #27373
2024-01-12 17:50:00 +01:00
Laurent Destailleur
c406d9a002 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-12 17:49:00 +01:00
Laurent Destailleur
618a364064 FIX #27439 but using the opposite direction. int is bette as we can evolve to add a third value in a future. 2024-01-12 17:47:54 +01:00
MDW
342ab85195
Qual: Spelling htdocs/[q-z]* (#27447)
# Qual: Fix spelling htdocs/[q-z]*

Probably fixes a bug:

- htdocs/webservices/server_thirdparty.php
  No other occurence of adress found.
  -'adress'=>->adress,- +'address'=>->address,+
2024-01-12 17:18:52 +01:00
Frédéric FRANCE
5d6d6a92cf
fix phpstan (#27441) 2024-01-12 17:16:53 +01:00
Frédéric FRANCE
d8ffc4aed0
fix phpstan (#27442)
* fix phpstan

* Update api_products.class.php
2024-01-12 17:16:28 +01:00
Frédéric FRANCE
45d47d1dc9
fix phpstan (#27444) 2024-01-12 17:15:39 +01:00
Frédéric FRANCE
74aa353079
try to run action on push to have always valid cache (#27445) 2024-01-12 17:15:16 +01:00
MDW
42a0d05b63
Qual: Spelling outside htdocs (#27448)
* Qual: Spelling outside htdocs

# Qual: Fix spelling of files not in the htdocs subdirectory.

Highlight:
- Change in email test from unvalid to invalid that should give the same test result.

* Update Dolibarr-soapui-project.xml

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 17:14:13 +01:00
Frédéric FRANCE
4cf62b9711
clean code and fix (#27446)
* clean code and fix

* clean code and fix
2024-01-12 17:11:08 +01:00
MDW
417726f7b1
Fix: Disable execute bit in git + correct shebangs (#27450)
# Fix: Execute bits in git and shebangs

Some files had the execute bit improperly set to enabled.
Some scripts did not have a correct shebang.
2024-01-12 17:10:16 +01:00
Frédéric FRANCE
8608a075fb
fix Undefined variable $mode (#27451) 2024-01-12 17:07:43 +01:00
Frédéric FRANCE
c9a0957920
fix phpstan (#27440) 2024-01-12 17:07:22 +01:00
Laurent Destailleur
1c86073a9e Fix phpcs 2024-01-12 17:06:22 +01:00
John BOTELLA
58cf5609ca
FIX php 8.2 warning (#27465)
* fix php 8.2 warning

* Fix warning
2024-01-12 17:03:57 +01:00