Commit graph

151292 commits

Author SHA1 Message Date
MDW
3b57795895
Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0) (#28718)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* New: Fixer for selectDate '' arguments h, m and empty

* Qual: Update codespell exceptions
2024-03-09 01:04:15 +01:00
MDW
d13d661754
Fix: PhanPossiblyUnsetPropertyOfThis - variable is unset (#28714)
# Fix: PhanPossiblyUnsetPropertyOfThis - variable is unset

Because the variable is unset to force recomputation, the Phan message
is valid and the if condition is always true.

Hence, the if condition was commented.

Also added an initialisation to an empty array before assigning array fields.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-09 01:02:45 +01:00
Laurent Destailleur
bb6cf2c6ed Fix warning 2024-03-08 23:00:55 +01:00
Laurent Destailleur
5e84632d61 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-08 22:58:33 +01:00
Laurent Destailleur
c44f102518 Try to remove phan error 2024-03-08 22:58:15 +01:00
JeromeBARBOTIN
5371db3c0b
FIX: Verification of variables (#28623)
* Verifcation of variables

Modification of the variable setting before its use.

* To check if the property exists

* Modification as per @frederic34 suggestion

* Update propal.class.php

* Application of coding rules

Modification of the called function.

* Verification of variables

* Verification of variable

* Typo error

* Update actions_sendmails.inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 22:50:15 +01:00
Laurent Destailleur
cb58ad2e60
Merge branch 'develop' into fix_element_type_part_04 2024-03-08 22:06:53 +01:00
Laurent Destailleur
defc98f471
Merge branch 'develop' into fix_element_type_part_03 2024-03-08 22:04:51 +01:00
Laurent Destailleur
6f38f4030a Trans 2024-03-08 21:55:26 +01:00
Laurent Destailleur
9a839a1c08
Merge branch 'develop' into fix_element_type_part_05 2024-03-08 21:40:34 +01:00
MDW
d93fd1839c
Fix typing for showOutputFieldForObject (#28709)
# Fix typing for showOutputFieldForObject

Type hint that $value can also be a list of strings.
Also updated the "else-if" sequence so that a static tool checker can
still appropriately detect when $value is a string and when it is
a list of strings so that it provides correct feedback.
Added an error message to the syslog in case we got an array but not
"array" as the value for "$type"
2024-03-08 21:40:18 +01:00
MDW
7bf8f489f6
Fix: $addInputLabel is at position 8 (#28711)
# Fix: $addInputLabel is at position 8

PhanPluginSuspiciousParamPosition: The position of the argument was incorrect
2024-03-08 21:35:32 +01:00
MDW
3d0a85608b
Qual: Fix and enable alias deprecation detection (#28716)
* Qual: Ignore some false positives for deprecated functions

# Qual: Ignore some false positives for deprecated functions

The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that

* Qual: Enable detection and fixing of internal deprecations

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Update codespell lines ignore list after format

# Qual: Update codespell lines ignore list after forma

Done using latest library, so also adds some exceptions that are needed
in the future;

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:34:18 +01:00
MDW
f309d1634c
Qual: Better hint for index value for phan (#28712)
# Qual: Better hint for index value for phan.

($i - 1) must be >= 0, so update test from $i>0 to $i>=1 .
This helps static analysis.
2024-03-08 21:30:46 +01:00
MDW
d846044e38
Fix: $form argument to price() must be int (#28699)
* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0
2024-03-08 21:30:04 +01:00
MDW
9cc3476765
Fix: PHPDoc annotations in unappropriate comment (#28713)
* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Update dolreceiptprinter.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:27:09 +01:00
MDW
826d72d04b
Qual: Reduce phan baseline (thanks to 'fixes') (#28715)
# Qual: Reduce phan baseline (thanks to 'fixes')

The number of phan exceptions has been reduced, the baseline is updated
accordingly.
2024-03-08 21:25:15 +01:00
Laurent Destailleur
9a281ed264 Fix undefined property 2024-03-08 21:21:27 +01:00
Laurent Destailleur
65899433fe Qual: remove $_GET use. 2024-03-08 19:47:05 +01:00
Laurent Destailleur
a9cae438a6 Fix regression 2024-03-08 19:43:57 +01:00
Laurent Destailleur
4f5c400870 Fix missing search_all 2024-03-08 19:39:33 +01:00
Laurent Destailleur
4ca754205c Fix serch_all 2024-03-08 19:37:00 +01:00
Laurent Destailleur
7ab339e97f Fix regression 2024-03-08 17:54:32 +01:00
John BOTELLA
c4cb7c0a98 Add cache feature on fetchObjectByElement 2024-03-08 16:55:53 +01:00
Laurent Destailleur
6df4a5eded Use a better name for thirdparties site account 2024-03-08 16:42:49 +01:00
Laurent Destailleur
c9243e2c80 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-08 16:33:14 +01:00
Laurent Destailleur
afd49868d5 Fix bad route 2024-03-08 16:32:44 +01:00
John BOTELLA
f03557a06f
Merge branch 'develop' into fix_element_type_part_05 2024-03-08 14:46:26 +01:00
John BOTELLA
8d26140908
Merge branch 'develop' into fix_element_type_part_03 2024-03-08 14:45:35 +01:00
kkhelifa-opendsi
bcf6d7a2aa
FIX: Fix create shipping with product who have negative stocks on warehouse but the negative stock transfert is allowed (#26217) 2024-03-08 12:36:31 +01:00
MDW
7fd606b336
Qual: Ignore/workaround SuspiciousParamOrder detection (#28688)
* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)
2024-03-08 12:34:25 +01:00
Can Arslan
e74e638b26
FIX: skip adding tab if user doesn't have permission (#28698)
verifCond function checks whether user has right and we should skip adding it if user doesn't have right
2024-03-08 12:28:31 +01:00
MDW
6cce456b8c
Qual: Add fixers for price(ARG2), and urlencode((string)...) (#28701)
# Qual: Add fixers for price(ARG2), and urlencode((string)...)

Register the fixers used to fix phan messages by adjusting arguments and casts.
2024-03-08 12:18:22 +01:00
thibdrev
cc5366249a
qual: phpdoc for htdocs/core/db/mysqli.class.php (#28703)
PHPDoc update to reflect what the code does today.

This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php	243	Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
2024-03-08 12:10:09 +01:00
thibdrev
231703e5d1
qual: phpstan for htdocs/loan/class/paymentloan.class.php (#28704)
htdocs/loan/class/paymentloan.class.php	155	Property PaymentLoan::$num_payment (string) does not accept int.

htdocs/loan/class/paymentloan.class.php	317	Property PaymentLoan::$num_payment (string) does not accept int.
2024-03-08 12:09:49 +01:00
William Mead
3583c4aeea
NEW updated resource list for new fields (#28705)
* Added address, zip & town

* Added state & country

* Added phone, email, max_users & url

* Added link formatting. Cleaned code.

* Updated EN & FR localization

* Added country select list

* Cleaned code
2024-03-08 12:09:32 +01:00
John BOTELLA
d1c980b0be Factoring fetchObjectLinked 2024-03-08 11:57:07 +01:00
John BOTELLA
17a5bf1eab
Merge branch 'develop' into fix_element_type_part_04 2024-03-08 11:06:20 +01:00
Laurent Destailleur
a4faa488fd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-08 11:00:50 +01:00
Laurent Destailleur
fb16af02b4 Clean code. Move member type API in good file. 2024-03-08 11:00:19 +01:00
John BOTELLA
076a009554
Merge branch 'develop' into fix_element_type_part_03 2024-03-08 10:46:35 +01:00
Frédéric FRANCE
c537d8dd11
Merge branch 'develop' into patch-11 2024-03-08 09:26:29 +01:00
Eric Seigne
9f1904e8d2 todo is done 2024-03-08 00:15:45 +01:00
Eric Seigne
57e5599d82 Merge branch '18.0' into 18.0-ticket_code_review 2024-03-08 00:12:22 +01:00
Can Arslan
491e85037a
FIX: PHP Warning: Undefined variable $mode (#28697) 2024-03-07 23:09:54 +01:00
MDW
79adb60cf5
Qual: Add instanceof tests to help static typing analysis (#28696)
# Qual: Add instanceof tests to help static typing analysis

Added instanceof tests to help identify that properties exist.
2024-03-07 23:09:25 +01:00
Anthony Berton
ff03f86a50
NEW - See the documents of my subordinates (#28318)
* NEW - See the documents of my subordinates

* cop

* Rewriting

* up

* ok

* FIX - Restriction on sale representative

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 22:47:29 +01:00
Frédéric FRANCE
2a3ceb00dd
Merge branch 'develop' into patch-11 2024-03-07 22:17:10 +01:00
Frédéric FRANCE
3035a7bc7f
fix phpstan (#28695)
* fix phpstan

* fix typo

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-07 22:13:09 +01:00
Laurent Destailleur
7f277e9578 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 22:09:31 +01:00