ldestailleur
cf8beb8505
Fix error return
2025-06-21 14:39:53 +02:00
Alexandre Janniaux
1a3430f40a
commonobject: updateLineDown: use early return on query failure ( #34598 )
...
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.
It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-21 14:36:07 +02:00
Marc
52c827c2bb
FIX #34541 ( #34597 )
2025-06-21 14:35:20 +02:00
Alexandre Janniaux
1113ae6dc1
Qual: Commonobject reverse happy path ( #34599 )
...
* commonobject: getRangOfLine: reverse happy and error path
* commonobject: getIdOfLine: reverse error and happy path
2025-06-21 14:35:01 +02:00
github-actions[bot]
5ea28763e5
PHPStan > Update baseline ( #34601 )
...
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-06-21 14:34:28 +02:00
William Mead
e35e1d76e1
QUAL Updated agenda events API PHPDoc ( #34558 )
...
* Fixed mandatory fields
* Updated PHPDoc. Added contributor details.
* Updated PHPDoc
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-20 20:13:10 +02:00
ldestailleur
9b7fee42e3
Clean code
2025-06-20 16:45:49 +02:00
ldestailleur
b8de0358c0
Fix use of distinct.
2025-06-20 16:42:22 +02:00
HENRY Florian
7384959f38
FIX: filter agenda on user and ressource SQL error ( #34580 )
2025-06-20 16:25:00 +02:00
ldestailleur
3a04ba15c7
Fix trans
2025-06-20 16:21:08 +02:00
Marc
32051ee77d
FIX #34564 ( #34590 )
2025-06-20 16:19:17 +02:00
ldestailleur
955fc158ee
Fix CI
2025-06-20 16:17:54 +02:00
ldestailleur
7ed2cddd4b
Fix CI
2025-06-20 16:16:04 +02:00
Frédéric FRANCE
7c0604047e
fix missing translation ( #34587 )
...
* fix missing translation
* fix missing translation
2025-06-20 15:48:58 +02:00
Marc de Lima Lucio
96eddc1729
NEW: dev tools: add github webhook handler to auto-assign pull requests ( #34579 )
...
* NEW: dev tools: add github webhook handle to auto-assign pull requests
* FIX: ci
* FIX: comment
* FIX: ci
* FIX: forgotten param + ci
* FIX: ci
* FIX: ci
2025-06-20 15:45:31 +02:00
Günter Lukas
603f46a173
Fix #34593 ( #34594 )
...
* Fix #34593
* Fix whitespace
* Fix phpstan error
* undi fix in dolibarrtriggers.class.php
* Fix #34593
2025-06-20 15:43:39 +02:00
ldestailleur
446efdc432
Clean dead code
2025-06-20 14:00:29 +02:00
ldestailleur
2a85b73fa2
Add MULTICURRENCY_SHOW_ALSO_MAIN_CURRENCY_ON_PDF for legal requirement
...
that need both currencies on PDF
2025-06-20 14:00:14 +02:00
ldestailleur
81bd0f3389
Debug v22
2025-06-20 12:56:16 +02:00
ldestailleur
703d4358a5
Debug v22
2025-06-20 12:34:10 +02:00
ldestailleur
a23580f785
Fix code of event
2025-06-20 12:23:53 +02:00
ldestailleur
351b3b4dd3
Debug v22
2025-06-20 11:56:10 +02:00
ldestailleur
e6ff3280f6
Debug v22
2025-06-20 11:55:14 +02:00
ldestailleur
739cbe063b
Fix missing
2025-06-19 16:47:12 +02:00
ldestailleur
bbd091d7df
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-19 15:58:33 +02:00
ldestailleur
2cfa986ad5
Doc
2025-06-19 15:58:23 +02:00
ldestailleur
ec8a87a3cb
Doc
2025-06-19 15:49:26 +02:00
github-actions[bot]
b2b3100ed3
PHPStan > Update baseline ( #34584 )
...
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-06-19 14:59:26 +02:00
lvessiller-opendsi
c263fccb5f
Prepare 18.0.7 ( #34575 )
...
* Prepare 18.0.7
* Changelog for 18.0.7 LTS
2025-06-19 14:58:38 +02:00
ldestailleur
8c99c91015
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-19 12:51:00 +02:00
ldestailleur
b8695702dd
Fix DOC
2025-06-19 12:50:49 +02:00
ldestailleur
62abfe7cb0
Clean code
2025-06-19 12:50:41 +02:00
Frédéric FRANCE
a089aa2409
fix missing translation ( #34578 )
2025-06-19 12:41:29 +02:00
ldestailleur
9c2da8b9b6
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-19 11:31:44 +02:00
ldestailleur
a78e63dbf0
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-06-19 11:13:59 +02:00
ldestailleur
ec098b2632
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2025-06-19 10:59:07 +02:00
ldestailleur
c3f11fd0a7
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2025-06-19 10:52:07 +02:00
ldestailleur
719de0aef3
Disable not working github actions
2025-06-19 10:51:51 +02:00
ldestailleur
8a00ba81d0
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2025-06-19 10:49:00 +02:00
ldestailleur
0da1e6b464
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2025-06-19 10:48:18 +02:00
ldestailleur
4cc3be24d3
Doc
2025-06-19 10:46:15 +02:00
Eric - CAP-REL
b1109f6803
add env var for non-origin repository ( #34577 )
2025-06-19 10:44:18 +02:00
HENRY Florian
68a33a8759
fix: SubTotal module version for 22 is still experimental (even if actually it's working like a charm on the customer scope) ( #34573 )
2025-06-19 10:40:06 +02:00
ldestailleur
247847cd14
Fix warnings
2025-06-19 10:39:19 +02:00
Alexandre Janniaux
0770e79749
commonobject: updateLineUp: use early return on query failure ( #34570 )
...
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.
It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-19 10:12:55 +02:00
Alexandre Janniaux
1da9aab8d4
commonobject: updateRangOfLine: de-indent happy path ( #34569 )
...
There's no need for the else{} block when the if block early returns,
and it helps highlighting the happy path. Note that this kind of change
only make sense when one of the block is an error, not a choice between
two possibilities.
2025-06-19 10:11:12 +02:00
Frédéric FRANCE
bf2d6f1f1e
fix CI ( #34553 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-19 10:10:42 +02:00
ldestailleur
0a0f96bda6
Fix CI
2025-06-18 19:13:53 +02:00
ldestailleur
01b630a221
Fix CI
2025-06-18 18:21:57 +02:00
ldestailleur
0ae1f2fb9d
Fix CI
2025-06-18 16:53:20 +02:00