Commit graph

349 commits

Author SHA1 Message Date
Laurent Destailleur
cdb7694041 Fix autocomplete 2026-07-31 01:04:47 +02:00
MDW
1693f8a8a4
Qual: Fix 'SqlInjection' notices (#39216)
* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices

* Qual: Enhance SQL injection prevention in CodingPhpTest.php

Improved the SQL injection prevention mechanism in the CodingPhpTest.php file by adding a check for integer and float casts in the IN clause of SQL queries to avoid false positives.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-07-23 19:06:39 +02:00
Frédéric FRANCE
282e7dac6a
don't take care of some french comments and fix false positive (#39007)
* don't take care of some french comments

* Update LanguageOfCommentsSniff.php

* test a file

* Update doc_generic_asset_odt.modules.php

* Update auxaccount.php

* FIX: Translate French code comments to English in societe module

* fix phan

* fix phan
2026-06-29 19:28:28 +02:00
Laurent Destailleur
1839b99264 Fix BIC mandatory when WITHDRAWAL_WITHOUT_BIC is off 2026-06-27 15:56:46 +02:00
MDW
c5d2bd0179
Qual: Fix PHPStan notices (#38064)
* Qual: Fix PHPStan notices

# Qual: Fix PHPStan notices

Fix variable.undefined notices

* Qual: Fix fixed 'job' value

* Qual: Fix Phan & PHPStan notices

* Qual: Ignore PHPStan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-05-11 01:26:15 +02:00
Laurent Destailleur
9e7043d39b Debug v24 2026-04-30 12:06:28 +02:00
Jon Bendtsen
9b6b33747e
NEW Thirdparty bank account asks for bank country, state, currency and status (#38031)
* NEW Thirdparty bank account asks for bank country, state, currency and status

* edit thirdparty bank account will update the changes, but not read from object before showing

* Modification of bank account is now possible, but state selection is a multi step process

* at least show a nice dropdown with some statusses when edit bank account

* bank account status is now preserved during edit

* Pre-commit fix

* phpstan fixes

* PHAN variable order fix

* making sure the SQL variable is defined

---------

Co-authored-by: Jon Bendtsen <jonbendtsen@jonb.dk>
2026-04-28 14:28:16 +02:00
Laurent Destailleur
c2db7a3220 Clean code 2026-04-14 18:40:54 +02:00
Laurent Destailleur
ec2c637a90 spellcheck war 2026-03-19 12:52:27 +01:00
Laurent Destailleur
8a8ba06698 Fix CI 2026-02-08 15:28:19 +01:00
Laurent Destailleur
169b74b7bd Debug v23 2025-12-29 02:42:50 +01:00
Laurent Destailleur
33acfc6963 Debug v23 2025-12-23 12:02:10 +01:00
Laurent Destailleur
96583a11fc Debug v23 2025-12-23 11:48:56 +01:00
Laurent Destailleur
e96db77fda Look and feel Debug v23 2025-11-18 02:49:47 +01:00
ldestailleur
ad830a346e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-09-23 16:50:17 +02:00
ldestailleur
6ead2839d0 Fix missing several test on permission on actions 2025-09-23 16:41:53 +02:00
Frédéric FRANCE
0e1478206a
clean code (#35229)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-09-08 01:48:52 +02:00
ldestailleur
9a66d14c80 Fix remove non expected column 2025-08-08 01:28:02 +02:00
ldestailleur
556959e824 Fix remove non expected column 2025-08-08 01:27:28 +02:00
ldestailleur
6bc3036b18 Removed option forcesandbox 2025-07-10 19:47:58 +02:00
Norbert Penel
84f293ebe7
FIX right name (#34163)
right name have changed
OLD BUG !!!
report it on dol20 branch also, please
2025-05-15 18:11:36 +02:00
Josep Lluís
dfe997fa07
Update paymentmodes.php (#34044)
Fix multicompany signatures on sepamandate
2025-05-02 22:42:15 +02:00
ThomasNgr-OpenDSI
149bb14202
NEW Move right from advance to normal for thirdparty information payment page (#33885)d
Co-authored-by: Alexandre SPANGARO <aspangaro.dolibarr@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-04-26 21:23:08 +02:00
MDW
5035580e56
Qual: Fix phan notices (societe) 2025-02-17 09:44:12 +01:00
Laurent Destailleur (aka Eldy)
c631d66751 CSS 2025-01-27 18:26:56 +01:00
Laurent Destailleur (aka Eldy)
3b6f36f2ae Missing br 2025-01-27 18:25:14 +01:00
Laurent Destailleur (aka Eldy)
6dcaaf9276 Better look of feel of bank page 2025-01-27 18:22:49 +01:00
Laurent Destailleur (aka Eldy)
b9f10cbc33 Fix css 2025-01-27 18:17:36 +01:00
Laurent Destailleur (aka Eldy)
440c08346f Fix responsive 2025-01-27 18:13:25 +01:00
Laurent Destailleur (aka Eldy)
58e42656c0 Fix regression after a fix 2025-01-09 13:54:25 +01:00
Frédéric FRANCE
1b6ee9e654
fix phpdoc (#32097)
* fix phpdoc

* Update accountancycategory.class.php

* fix phpstan

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-28 11:15:56 +01:00
Frédéric FRANCE
13b8f5feff
keep only commonobject property oldcopy (#32123)
* clean properties

* clean properties

* clean properties

* clean properties

* clean phpcs

* clean phan

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-27 21:59:41 +01:00
Laurent Destailleur
64540fe5f4 Fix regression 2024-11-26 19:34:05 +01:00
Laurent Destailleur
7a12b15376 Fix regression 2024-11-26 19:25:05 +01:00
Laurent Destailleur
63ac936652 Fix add an order to have same behavior in using stripe customer account
event if data are corrupted with duplicate record.
2024-11-25 14:46:22 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
8abfcf71a9 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-24 13:54:13 +02:00
Laurent Destailleur
830029dd05 NEW Iban is saved encrypted 2024-10-24 13:03:52 +02:00
Laurent Destailleur
3bc1d35236 QUAL The property ->domiciliation and ->propio on bank accounts has been
deprecated and replaced with property ->address and ->owner_name
2024-10-24 12:38:41 +02:00
MDW
fb3972b702
Qual: Fix phan notices in some payment/strip related classes (#31453)
* fix concat

* fix overwrite

* Clean code

* Do not analyze custom

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class

* Qual: Fix companybankaccount.class

* Fix phan/phpstan notices

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic.france@free.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-20 00:32:01 +02:00
Laurent Destailleur
0cb9fbc39a CSS 2024-10-01 01:06:53 +02:00
Frédéric FRANCE
ecf5f41110
fix phpstan (#31020)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-20 01:46:07 +02:00
atm-thomasb
fdca7b691a
FIX: BIC requirement is now checked separately from IBAN (#30994) 2024-09-18 01:30:56 +02:00
MDW
f89245b354
Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
d6ede5c890 Debug v20 2024-09-10 11:03:13 +02:00
Laurent Destailleur
62f7e219d1 Debug css v20 2024-09-10 10:55:47 +02:00
Frédéric FRANCE
d12fd8d175
fix phpstan (#30869)
* fix phpstan

* fix phpstan
2024-09-06 13:50:27 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
84ce31b8f8 Fix missing test on permissions 2024-09-01 14:04:10 +02:00