Commit graph

461 commits

Author SHA1 Message Date
MDW
1693f8a8a4
Qual: Fix 'SqlInjection' notices (#39216)
* Qual: Fix 'SqlInjection' notices

# Qual: Fix 'SqlInjection' notices

Batch of 25 files with changes to fix 'SqlInjection' Notices

* Qual: Enhance SQL injection prevention in CodingPhpTest.php

Improved the SQL injection prevention mechanism in the CodingPhpTest.php file by adding a check for integer and float casts in the IN clause of SQL queries to avoid false positives.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-07-23 19:06:39 +02:00
VIAL-GOUTEYRON Quentin
d67ac89a65
FIX : ModuleBuilder list page derives email trackid from object name (#38906)
The generated list page set $trackid = 'xxxx'.$object->id, where 'xxxx'
is not a NamingContract substitution token. It leaked verbatim into every
generated module and made the mass-emailing trackid collide across modules.

Align it with the card page (myobject_card.php) and core list pages
(comm/propal/list.php => 'pro', societe/list.php => 'thi') by using the
substitutable 'myobject' token, so the trackid derives from the object name.

Addresses #32460 (item 14, email/trackid handling).

Next: push to remote quentin, open upstream PR on Dolibarr/dolibarr:develop
Next: linking #32460 item 14

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-21 23:27:34 +02:00
Lucas Marcouiller
85a1770fca
New add drag and drop for fields (#37462)
* New add drag and drop for fields in object list

* Enable it on new module in module builder

* Fix some missing lines

* Fix Ci

* fix CI

* Move script out of th

* fix Ci

* fix Ci

* try fix CI

* try fix CI

* fix ci

* fix Ci phan

* fix license

* fix Ci

* fix Ci

* fix Ci

* Change way to drag and drop column

* undo changes

* Fix CI

---------

Co-authored-by: Lucas Marcouiller <lmarcouiller@dolicloud.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-06-13 16:19:14 +02:00
Frédéric FRANCE
80184f0bd3
fix phpstan (#38038)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* clean

* clean code

* clean code

* clean code

* Update bom_agenda.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2026-05-11 01:19:35 +02:00
Frédéric FRANCE
331af2c22d
clean code (#38077)
* clean code

* clean code
2026-05-04 12:54:54 +02:00
Laurent Destailleur
1e6492c17a Work on stats page in template module 2026-04-27 04:55:29 +02:00
Laurent Destailleur
166cef8bc2 Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into develop 2026-04-26 20:36:20 +02:00
Laurent Destailleur
8a38e805e3 Fix missing hook 2026-04-26 20:35:24 +02:00
MDW
43a958b925
Qual: Fix CI notices after changes to fields type (#37934)
* Qual: CI notices after changes to fields type

# Qual: CI notices after changes to fields type

The phpstan regexes to ignore notices no longer matched because of the type change.
Update the code to fix the notices.

* Qual: Ignore false positive (Phan)
2026-04-20 12:38:14 +02:00
Laurent Destailleur
2a0da2cb4e WIP Work on stats 2026-04-04 13:10:12 +02:00
Laurent Destailleur
b8627e312a WIP Graph/stats view 2026-04-04 12:54:03 +02:00
Laurent Destailleur
99b88e876f css 2026-01-11 14:26:55 +01:00
Lucas Marcouiller
3f406a994f Fix path traversal with $_SERVER["CONTEXT_DOCUMENT_ROOT"] variable for new modulebuilder modules 2025-12-09 13:36:20 +01:00
Laurent Destailleur
1abc87ff03 Clean code 2025-11-17 19:35:10 +01:00
Alexandre SPANGARO
b4a88253eb
UIUX - More intuitive select table - Module builder (#35490)
Module builder

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-09-27 12:10:48 +02:00
ldestailleur
75925aee71 Debug v23 2025-09-24 12:05:30 +02:00
ldestailleur
20875dead9 Use fields into the list of events 2025-09-24 12:01:52 +02:00
ldestailleur
7506fd006e Fix CI 2025-08-09 14:24:59 +02:00
ldestailleur
1390c34a23 Fix CI 2025-08-09 14:02:49 +02:00
ldestailleur
3abad41f87 Clean code 2025-08-07 23:50:05 +02:00
ldestailleur
80999ed6fd QUAL: Clean/Standardize hook response of hook printFieldListHaving 2025-08-04 14:57:44 +02:00
Laurent Destailleur
602b9c26ae Fix case of ismultientitymanaged that is key@table 2025-08-01 18:37:20 +02:00
Laurent Destailleur
82098594a6 Fix warning 2025-07-31 22:13:45 +02:00
ldestailleur
e8b2664921 Debug v22 2025-07-17 19:26:24 +02:00
ldestailleur
9e5769b8b7 Make the feature "Kanban Grouped By" on opportunities visible by default 2025-06-05 15:49:53 +02:00
ldestailleur
cab064083c Debug v22 2025-06-05 14:35:52 +02:00
Jyhere
9b770c8fe9
FIX: list filter for boolean field when using modulebuilder (#33977)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-04-26 01:59:23 +02:00
ldestailleur
c689cffae3 FIX Position of dropdonw with checkbox column on left 2025-03-29 15:20:09 +01:00
ldestailleur
4ba3f0d90e Clean and standardize code for Categories 2025-03-29 15:03:36 +01:00
MDW
f05bc70b2e
Qual: Fix phan notices (modulebuilder) 2025-02-07 12:31:19 +01:00
Laurent Destailleur (aka Eldy)
efeeab4108 Debug v22 2025-02-04 23:58:14 +01:00
Laurent Destailleur
15658c56d5 CI 2026-02-04 21:33:07 +01:00
Quentin VIAL--GOUTEYRON
01be602fb1 FIX Issue 32460 db prefix module builder 2025-01-15 08:42:14 +01:00
Laurent Destailleur (aka Eldy)
2c988d28c9 Debug v21 - fix multiselect 2024-12-11 14:05:28 +01:00
Frédéric FRANCE
1b6ee9e654
fix phpdoc (#32097)
* fix phpdoc

* Update accountancycategory.class.php

* fix phpstan

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-28 11:15:56 +01:00
Laurent Destailleur
be1a658285 Look and feel v21 2024-11-05 15:22:55 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
1739acf715 CSS 2024-10-25 16:37:24 +02:00
Laurent Destailleur
4ae96d296d Debug v21 2024-10-15 10:57:35 +02:00
Laurent Destailleur
10c58950bb Look and feel v21 2024-10-15 10:16:48 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
e8c45ace3b Clean code 2024-09-25 19:30:37 +02:00
Laurent Destailleur
6f30d2f187 Missing param 2024-09-25 14:04:24 +02:00
Laurent Destailleur
8f54f06e12 FIX #31076 Bad position of hooks 2024-09-23 02:26:19 +02:00
Laurent Destailleur
74ad35dcac FIX #31076 Bad position of hooks 2024-09-23 02:24:43 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
bc21b973ca Debug v20 2024-08-31 11:45:42 +02:00
MDW
b0087aaf61
Qual: Enable phan on modulebuilder (#30652)
* Allow null for buyer, and force '' for  in printObjectLine(s)

* Allow null for Contact in show_actions_done

* Qual: Enable phan on modulebuilder

# Qual: Enable phan on modulebuilder

Most files of the modulebuilder template can be checked as regular files.
It will help improve the template

* Update baseline (enable modulebuilder notices)

* Add properties that are expected to exist on modules_boxes

* Qual: Ignore false positive (phan)

* Set phpdoc type to include null on formAddObjectLine

* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)

* Fix phpcs for intracom

* Make ModeleBoxes:showBox() signature match child class's

* Fix *box::showBox() phpdoc types

* Update index.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 18:16:08 +02:00
Laurent Destailleur
72b37a2369 Fix phan 2024-08-18 00:01:45 +02:00
Laurent Destailleur
7ea04ab0af Clean code 2024-08-17 23:59:08 +02:00