Since v21 the wysiwyg editor in comm/mailing/card.php was created with
$uselocalbrowser=-1, which DolEditor maps to the hidden constant
WYSIWYG_ALLOW_UPLOAD_MEDIA_FILES (default 0). The local image browser
that was available before v21 disappears for any installation that
does not explicitly set that constant.
The email templates editor at admin/mails_templates.php solves this
with the dedicated helper acceptLocalLinktoMedia() (also gated on
MAIN_DISALLOW_MEDIAS_IN_EMAIL_TEMPLATES, plus an IP allowlist for
private networks). The two editors are intended to behave the same way
(maintainer comment on the issue thread).
Mirror that pattern in the mailing page: compute
$acceptlocallinktomedia once near the top and pass it as the
$uselocalbrowser argument to all five DolEditor instances. The
default-deny behavior for installs exposed to the internet is preserved
through acceptLocalLinktoMedia()'s own checks, and an existing local
install on a private network gets the image browser back without
having to set the hidden WYSIWYG_ALLOW_UPLOAD_MEDIA_FILES flag.
Signed-off-by: Dolicraft <contact@dolicraft.com>
Co-authored-by: Dolicraft <contact@dolicraft.com>
* Fix perms
* Fix CI
* UX Accountancy - Ledger - Add icon for more comprehension
* Fix phpunit
* Debug v23
* Debug v23
* Fix CI
* Qual: Update PHP-CS-Fixer configuration and DolibarrModules class
- Update PHP-CS-Fixer configuration to replace deprecated 'visibility_required' rule with 'modifier_keywords'
- Update DolibarrModules class to use const instead of public const for PHP 7.0 compatibility (revert recent change)
* fix warning in upgrade2.php
* Debug v23
* add modulepart for direct print capabilities
* add project
* add project
* add more
* add ficheuinter
* qual: Update phpstan-baseline.neon to remove unresolvable type issues
Removed multiple entries related to unresolvable types in dol_sort_array function calls and property assignments.
* FIX#36447 Email Collector subject/body exclusion filters not working
The '!' prefix was removed at line 1369-1373 before being tested
at lines 1398 and 1406, causing exclusion filters to never work.
This fix uses the $not variable (already set correctly) instead of
re-testing for '!' on the modified rulevalue.
* Qual: Improve type hinting for phpstan in dol_sort_array()
#Qual: Improve type hinting for phpstan in dol_sort_array()
- Improve phpdoc for phpstan in dol_sort_array()
* qual: Add type hint for $arraydata in select_juridicalstatus method
This change adds a type hint for the $arraydata variable in the select_juridicalstatus method for phpstan
* Qual: Change array assignment for phpstan type deduction
* Qual: Change array assignment for phpstan type deduction
* Qual: Cast properties to string in get_full_arbo method
* Qual: Type casting in select_country and loadCacheInputReason methods
* fix: Improve type casting and array initialization in user.class.php
- Added explicit type casting for array values
- Improved array initialization syntax for better readability and maintainability
* qual: Add type hint for group_list array
Add a type hint for the $group_list array for phpstan.
* qual: Update type hints and casting in select_juridicalstatus method
- Changed type hint for $arraydata
- Added explicit casting for `code` and `country_code` in the array assignment
* Qual: Cast label to string to ensure type consistency (phpstan)
* Qual: Add types for $workflow and $workflowcodes.
* Update upgrade2.php
* Debug v23
* Doc
* CSS
* Doc
* Fix prevent use of TRACE method in waf
* FIX: reinstate shipment with origin
* add another
* implem
* fix space
* add another
* fix space
* CSS
* Fix webhook history record save on error
* fix CI
* fix missing migration
* fix missing migration
* add more
* add more
* add more
* add more
* add more
* add more
* add more
* PHPStan > Update baseline
* FIX: ticket module - use random_int() for secure ID generation instead of microtime
* ENH: Accessibility on modulebuilder setup page
Add label for input fields
* Clarify supported versions for security reports
* Update supported versions for security reports
* Add default supplier type handling in card.php in creation mode
Hi
By default supplier is a professional in creation mode.
* Add default supplier type handling in card.php in creation mode
* CSS
* Add new phpunit tests
* Comment
* Debug v23
* Comment
* Update ticket.lib.php
* Fix: Do not transform [__XXX__] string when
MAIN_RESTRICTHTML_ONLY_VALID_HTML is on.
* Update card.php
* Fix formatting and add new line in card.php
* CSS
* Modification of the family VARCHAR field to VARCHAR(64), causing the failure of module re-activation.
* FIX must not allow deletion of invoice if printed or sent by email.
* Debug v23
* clean code
* Trans
* FIX: now there are two values for INVOICE_USE_SITUATION (1 = legacy, 2 = new), leading to two interpretations of situation_percent; in some algorithms, only the old algorithm was applied even when the new mode was on
* FIX: now there are two values for INVOICE_USE_SITUATION (1 = legacy, 2 = new), leading to two interpretations of situation_percent; in some algorithms, only the old algorithm was applied even when the new mode was on
* WIP Loi finance
* Fix yearly events and duplicate recurring events
* Debug v23
* Fix LNE
* Update addTimeSpent api method to use default progress
with null parameters, swagger validator fail
* Fix permission check from 'lire' to 'read'
* FIX: use suspended status in FactureFournisseurRec::updateline()
- The method checks `$this->status == self::STATUS_SUSPENDED`.
- For recurring **supplier** invoices, `$this->status` is not populated (it is always `null`).
- The real field used to store the suspended flag of the template is `$this->suspended`.
* Fix replace DISTINCT
* Fix progress assignment in addTimeSpent method
* FIX: INVOICE_USE_SITUATION (1 = legacy, 2 = new): some functions still use only the legacy algorithm
* FIX wrong indentation
* WIP LNE
* FIX missing space before cast
* FIX bad ratio calculation
* phpdoc: wrong return type
* WIP LNE
* Fix setup margin
* CSS
* Update blockedlog.php
* new: defaut to True show unit price on title and sub total
* Debug v23 - Navigation in timespent and style
* Trans
* Fix detection of security commit
* Fix detection of security commit
* Fix warning
* Fix webportal css
* Debug v23
* CSS
* Fix warning
* Fix warning
* Fixed shipping and availability updating. Updated contributor details.
* FIX#36407 BUG: API POST contact to a non-existing socid gives DB error
* Update blockedlog.php
* Fix CI
* Fix CI
* Better compatibility
* Fix CI
* Fix CI
* CSS
* Fix dialog for iframe
* restaure times
* Fix isset usage
* Fix isset usage
* Allow to define if data is user input or not into GETPOSTFLOAT.
* Typo
* Update holiday api methods from setValidate/setApproved to validate/approve
* CSS
* Doc
* Debug v23
* Fix some phan warnings
* remove var_dump
* Fix for #36550
there are \n and other characters that need to get handled here, otherwise they will get replaced with space character later.
* CSS
* Translation
* Debug v23
* Debug v23
* Debug v23
* Fix var_dump
* Debug v23 - fix link social networks
* Debug v23 - hide field with unknown meaning.
* fix modal css and display
* Fix CI
* Update odf.php
* Added postLine method to expense report API. Added mandatory expense report line fields check.
* Added deleteLine method. Updated contributor details.
* Added getLines method
* Added setToDraft method
* Cleaned code
* Updated PHPDoc
* Updated PHPDoc
* Updated PHPDoc
* Added cancel exepense report method
* Added return object
* CSS
* CSS
* Fix CI
* Fix CI
* CSS
* CSS
* CSS
* CSS
* Debug v23. Bad balance ul/li in menu.
* Debug v23
* FIX Add missing addMoreActionsButtons hook in mailing card actions
Add missing call to addMoreActionsButtons hook in mailing card.php to allow external modules to inject custom action buttons, ensuring consistency with other modules.
---------
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Alexandre SPANGARO <alexandre.spangaro@gmail.com>
Co-authored-by: MDW <mdeweerd@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic.france@free.fr>
Co-authored-by: Steph501 <stmallet@gmail.com>
Co-authored-by: Lucas Marcouiller <lmarcouiller@dolicloud.com>
Co-authored-by: Mélina JOUM <melina.joum@altairis.fr>
Co-authored-by: Rémi Champlon <r.champlon@vold.lu>
Co-authored-by: Lucas Marcouiller <45882981+Hystepik@users.noreply.github.com>
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
Co-authored-by: atm-jonathan <jonathan.lescaut@atm-consulting.fr>
Co-authored-by: Benjamin Falière <benjamin.faliere@altairis.fr>
Co-authored-by: Francis <162715304+le-reparateur@users.noreply.github.com>
Co-authored-by: atm-nicolasV <nicolas.vidal@atm-consulting.fr>
Co-authored-by: atm-florian <florian.mortgat@atm-consulting.fr>
Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com>
Co-authored-by: lelex86 <75493227+lelex86@users.noreply.github.com>
Co-authored-by: Florian HENRY <florian.henry@open-concept.pro>
Co-authored-by: John BOTELLA <68917336+thersane-john@users.noreply.github.com>
Co-authored-by: William Mead <william@m34d.com>
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Joachim Kueter <priojk@users.noreply.github.com>
* Add mass mailing tab - with counts to project tabs
* Separate mailing tab from event tab so they can be active independently + correcter link to mass mailings
* Now loads the project head ontop of all the mass mailings
* Make the project tab for mass mailings use the correct translation files
* If you supply a project ID, it will overwrite the search_refproject variable
* Making the mass mailing list search for project id directly
* Just typecast integers
* make it possible to add another mass mailing with prefilled project from the list of mass mailings in a project
* change indent to make pre_commit check happy
* Trying to make phan happy by declaring the variable in both situations
* when on mailing card, click project link, show projects mass mailings
* declaring variable so phan does not complain
* Still working on making phan happy about
* Working on and phan
* Change the UX so the project links goes to project and there is an other link to other mass mailings in this project + when editing we open in a new window
* Correct mailing tab condition syntax
Fix syntax error in condition for mailing tab display.
* Fix syntax error in mailing tab condition
---------
Co-authored-by: Jon Bendtsen <jonbendtsen@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* New: Adding linked project to mass mailing card
* modify project on mailing card
* mailing card load fk_project pre commit fix
* only fetch projects with id>0
* fix PHPstan errors regarding mesg
* projects related to mass mailings does not have a soc or socid
* remove last trace of soc and socid
* checking if mesg is set before using it
* just loading all projects, because maybe you have a mailing list with workers for a thirdparty? think company party
* showing the project during edit
* given that action is already something else, it will never not be classify
* making PHPstan happy
* Adding project column to list of mass mailings. Search, order and click able
* pasted the wrong place
* no need to check for filtermail
* x now also clears project search
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* NEW : Change the path for the mailing files because if you have more than 100 mailing you have the files of the previous mailing show in the newest.
Only activate if the global MAILING_USE_NEW_PATH_FOR_FILES is set to 1.
Add a script for move files to new path.
* Place migration script into repair.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: tnegre <tnegre@open-dsi.fr>
