Commit graph

24 commits

Author SHA1 Message Date
MDW
138056be91
Qual: Fix PHPStan notices (#37977)
* Qual: Fix PHPStan notices

# Qual: Fix PHPStan notices

* Qual: Fix Phan notices

* Qual: Fix PHPStan notices

* Qual: Fix nb field type hint

* Qual: Fix stats return type hints
2026-04-23 15:26:53 +02:00
MDW
e23059184f
Qual: Phan/fix for notices seen in #37875 & ci (#37876)
* Qual: Fix phan notice

Fix PhanTypeMismatchArgumentNullable: Argument 1 ($stringtosanitize) is $origin of type ?\CommonObject|?\CommonTrigger|?\DolDeprecationHandler|?array{}|?non-empty-array<mixed,mixed>|?non-empty-string|?string but \DoliDB::sanitize() takes string defined at htdocs/core/db/DoliDB.class.php:187 (expected type to be non-nullable)

* Qual: Fix PhanPluginSuspiciousParamPosition

# Qual: Fix PhanPluginSuspiciousParamPosition

Fix notices by using intermediate variable name that matches the parameter of the called function
where the original parameter name matches the name of a parameter in another position

* Qual: Fix PhanTypeMismatchArgument

# Qual: Fix PhanTypeMismatchArgument

Fix PhanTypeMismatchArgument: Argument 1 ($stringtosanitize) is $local of type int but \DoliDB::sanitize() takes string
in get_localtax_by_third($local) where local is an int already.
So use cast to (int) instead.
Also limit typehint of local to 1 and 2 which are the only allowed values

* Qual: Fix PhanTypeMismatchArgument in cloneCategories()

# Qual: Fix PhanTypeMismatchArgument in cloneCategories()

The argument $toId which is already an integer was passed to DoliDB::sanitize() which expects a string.
So casting to (int) instead to fix this.

* Qual: Ignore complex PhanUndeclaredStaticProperty

# Qual: Ignore complex PhanUndeclaredStaticProperty

Accessing static property provided by a trait on some classes - ignore the phan notice

* Qual: Phan ignore PhanUndeclaredMethod for getPossibleLevels

* Qual: Add typing hints for phan

* Qual: Add typehint for phan

* Qual: Remove redundant semicolon in objectonoff.php

# Qual: Remove redundant semicolon in objectonoff.php

Removed an unnecessary semicolon in the error handling loop of objectonoff.php.

* Qual: Fix PhanPossiblyUndeclaredGlobalVariable

* Qual: Ignore PhanPossiblyUndeclaredGlobalVariable
2026-04-15 17:59:06 +02:00
Laurent Destailleur
795e799815 Fix duplicate picto 2026-04-15 14:36:52 +02:00
John BOTELLA
559454e4d4
Fix : fontawesome icon list in doc (#37481)
* Fix fontawesome icon list

* Label

* remove useless test

* Fix doc php stan

* Fix doc php stan

* Fix doc php stan
2026-03-15 14:54:59 +01:00
ldestailleur
5aee279f5a Clean code 2025-10-10 14:47:31 +02:00
ldestailleur
77d7d17d4c Removed function getImgPictoNameList from functions.lib.php (useless) 2025-10-10 14:45:07 +02:00
Laurent Destailleur
c3ae90f191 Fix warning 2025-07-31 21:12:01 +02:00
John BOTELLA
308bed0742
fix link icon display mode (#34506)
Co-authored-by: John BOTELLA <29435477+john-botella@users.noreply.github.com>
2025-06-14 15:06:01 +02:00
Laurent Destailleur
f27d5a1be9 Sync transifex 2025-06-12 16:11:49 +02:00
ldestailleur
40d53621c3 NEW Add/enhance the popup for preview of icons 2025-05-05 14:54:35 +02:00
ldestailleur
9728c3f10a Make popup with picto simplest from modulebuiler or menu editor 2025-04-24 16:22:51 +02:00
ldestailleur
ccec9286e2 Better explanation 2025-04-22 19:12:25 +02:00
ldestailleur
6a76f55ae3 Clean font awesome picto 2025-03-27 17:33:56 +01:00
John BOTELLA
b16b462520
New js search filter in icons doc (#33580)
* New js search filter in icons doc

* Fix code wysiwyg editor in Doc and add search input doc

* Fix code wysiwyg editor in Doc and add search input doc

* Fix autofocus

* fix js count

* comment

* comment

* fix php stan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-03-25 10:57:15 +01:00
John BOTELLA
c54a7a965c
Add link to doc and fix doc (#33470) 2025-03-15 15:44:40 +01:00
Laurent Destailleur
fccbab9a10
Merge pull request #32809 from frederic34/patch-10
fix phpstan
2025-01-27 14:41:19 +01:00
Laurent Destailleur (aka Eldy)
10982b208f Fix warnings 2025-01-27 14:37:00 +01:00
Frédéric FRANCE
ca619914c2
Update icons.php 2025-01-27 11:49:39 +01:00
Frédéric FRANCE
73e3a260cf
Update icons.php 2025-01-27 11:49:01 +01:00
Frédéric FRANCE
16f8de0f4d
Update icons.php 2025-01-27 11:27:34 +01:00
Frédéric FRANCE
3a19a7d277
fix phpstan 2025-01-27 11:22:10 +01:00
John BOTELLA
c642396dca Add List of usable icons with img_picto function 2024-11-23 18:26:40 +01:00
John BOTELLA
469baa0b5b remove double 2024-11-23 17:53:12 +01:00
John BOTELLA
0cb35d5b03 New doc for icon list 2024-11-23 09:15:34 +01:00