From f309d1634cd4ff4765a8db6bbbfe0182b4f5ace8 Mon Sep 17 00:00:00 2001 From: MDW Date: Fri, 8 Mar 2024 21:30:46 +0100 Subject: [PATCH] Qual: Better hint for index value for phan (#28712) # Qual: Better hint for index value for phan. ($i - 1) must be >= 0, so update test from $i>0 to $i>=1 . This helps static analysis. --- htdocs/core/lib/json.lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/lib/json.lib.php b/htdocs/core/lib/json.lib.php index b5a53c7f888..15f54b75f97 100644 --- a/htdocs/core/lib/json.lib.php +++ b/htdocs/core/lib/json.lib.php @@ -267,7 +267,7 @@ function dol_json_decode($json, $assoc = false) } else { $out .= $json[$i]; } - if ($i > 0 && $json[$i] == '"' && $json[($i - 1)] != "\\") { + if ($i >= 1 && $json[$i] == '"' && $json[$i - 1] != "\\") { $comment = !$comment; } }